Review Request 111927: remove K_EXPORT_PLUGIN macro
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111927/ --- Review request for KDE Frameworks. Description --- Remove K_EXPORT_PLUGIN throughout. The recent changes to the K_PLUGIN_FACTORY macro make this unnecessary. The macro is in fact already a no-op. I have this branch split out in patches per module. Diffs - interfaces/kmediaplayer/kfileaudiopreview/kfileaudiopreview.cpp b5b0f7b kfile/kfilemodule.cpp 1c51d16 kio/kssl/kcm/kcmssl.cpp 6dd19e4 kio/misc/kpac/proxyscout.cpp 6451c04 kioslave/http/kcookiejar/kcookieserver.cpp 5432859 kparts/tests/notepad.cpp 5eb9fcf kparts/tests/plugin_spellcheck.cpp 15509d8 kutils/kcmodulecontainer.h db6e435 kutils/ksettings/README.dox 7f2210d kutils/ksettings/pluginpage.h ded17e7 staging/kconfigwidgets/src/kcmodule.h 74333c1 staging/kde4support/autotests/klibloadertest4_module.cpp 7c1eec2 staging/kemoticons/src/providers/adium/adium_emoticons.cpp 35414e9 staging/kemoticons/src/providers/kde/kde_emoticons.cpp 570afb3 staging/kemoticons/src/providers/pidgin/pidgin_emoticons.cpp d24792f staging/kemoticons/src/providers/xmpp/xmpp_emoticons.cpp 12ee96a staging/kio/src/kssld/kssld.cpp 52bc7b6 staging/kio/src/widgets/kabstractfileitemactionplugin.h 19b872b staging/kservice/src/plugin/kpluginloader.h 7562ee4 tier1/kconfig/src/core/kconfigbackend.h bce9fd1 Diff: http://git.reviewboard.kde.org/r/111927/diff/ Testing --- No regressions observed in tests. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111927: remove K_EXPORT_PLUGIN macro
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111927/#review37285 --- Ship it! Ship It! - David Faure On Aug. 7, 2013, 12:37 a.m., Sebastian Kügler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111927/ > --- > > (Updated Aug. 7, 2013, 12:37 a.m.) > > > Review request for KDE Frameworks. > > > Description > --- > > Remove K_EXPORT_PLUGIN throughout. > > The recent changes to the K_PLUGIN_FACTORY macro make this unnecessary. The > macro is in fact already a no-op. I have this branch split out in patches per > module. > > > Diffs > - > > interfaces/kmediaplayer/kfileaudiopreview/kfileaudiopreview.cpp b5b0f7b > kfile/kfilemodule.cpp 1c51d16 > kio/kssl/kcm/kcmssl.cpp 6dd19e4 > kio/misc/kpac/proxyscout.cpp 6451c04 > kioslave/http/kcookiejar/kcookieserver.cpp 5432859 > kparts/tests/notepad.cpp 5eb9fcf > kparts/tests/plugin_spellcheck.cpp 15509d8 > kutils/kcmodulecontainer.h db6e435 > kutils/ksettings/README.dox 7f2210d > kutils/ksettings/pluginpage.h ded17e7 > staging/kconfigwidgets/src/kcmodule.h 74333c1 > staging/kde4support/autotests/klibloadertest4_module.cpp 7c1eec2 > staging/kemoticons/src/providers/adium/adium_emoticons.cpp 35414e9 > staging/kemoticons/src/providers/kde/kde_emoticons.cpp 570afb3 > staging/kemoticons/src/providers/pidgin/pidgin_emoticons.cpp d24792f > staging/kemoticons/src/providers/xmpp/xmpp_emoticons.cpp 12ee96a > staging/kio/src/kssld/kssld.cpp 52bc7b6 > staging/kio/src/widgets/kabstractfileitemactionplugin.h 19b872b > staging/kservice/src/plugin/kpluginloader.h 7562ee4 > tier1/kconfig/src/core/kconfigbackend.h bce9fd1 > > Diff: http://git.reviewboard.kde.org/r/111927/diff/ > > > Testing > --- > > No regressions observed in tests. > > > Thanks, > > Sebastian Kügler > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111927: remove K_EXPORT_PLUGIN macro
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111927/ --- (Updated Aug. 7, 2013, 5:20 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Description --- Remove K_EXPORT_PLUGIN throughout. The recent changes to the K_PLUGIN_FACTORY macro make this unnecessary. The macro is in fact already a no-op. I have this branch split out in patches per module. Diffs - interfaces/kmediaplayer/kfileaudiopreview/kfileaudiopreview.cpp b5b0f7b kfile/kfilemodule.cpp 1c51d16 kio/kssl/kcm/kcmssl.cpp 6dd19e4 kio/misc/kpac/proxyscout.cpp 6451c04 kioslave/http/kcookiejar/kcookieserver.cpp 5432859 kparts/tests/notepad.cpp 5eb9fcf kparts/tests/plugin_spellcheck.cpp 15509d8 kutils/kcmodulecontainer.h db6e435 kutils/ksettings/README.dox 7f2210d kutils/ksettings/pluginpage.h ded17e7 staging/kconfigwidgets/src/kcmodule.h 74333c1 staging/kde4support/autotests/klibloadertest4_module.cpp 7c1eec2 staging/kemoticons/src/providers/adium/adium_emoticons.cpp 35414e9 staging/kemoticons/src/providers/kde/kde_emoticons.cpp 570afb3 staging/kemoticons/src/providers/pidgin/pidgin_emoticons.cpp d24792f staging/kemoticons/src/providers/xmpp/xmpp_emoticons.cpp 12ee96a staging/kio/src/kssld/kssld.cpp 52bc7b6 staging/kio/src/widgets/kabstractfileitemactionplugin.h 19b872b staging/kservice/src/plugin/kpluginloader.h 7562ee4 tier1/kconfig/src/core/kconfigbackend.h bce9fd1 Diff: http://git.reviewboard.kde.org/r/111927/diff/ Testing --- No regressions observed in tests. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111927: remove K_EXPORT_PLUGIN macro
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111927/#review37299 --- This review has been submitted with commit 3d00e4b21a89eb19dd2e2101e1a8141604f2b2c2 by Sebastian Kügler to branch frameworks. - Commit Hook On Aug. 7, 2013, 12:37 a.m., Sebastian Kügler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111927/ > --- > > (Updated Aug. 7, 2013, 12:37 a.m.) > > > Review request for KDE Frameworks. > > > Description > --- > > Remove K_EXPORT_PLUGIN throughout. > > The recent changes to the K_PLUGIN_FACTORY macro make this unnecessary. The > macro is in fact already a no-op. I have this branch split out in patches per > module. > > > Diffs > - > > interfaces/kmediaplayer/kfileaudiopreview/kfileaudiopreview.cpp b5b0f7b > kfile/kfilemodule.cpp 1c51d16 > kio/kssl/kcm/kcmssl.cpp 6dd19e4 > kio/misc/kpac/proxyscout.cpp 6451c04 > kioslave/http/kcookiejar/kcookieserver.cpp 5432859 > kparts/tests/notepad.cpp 5eb9fcf > kparts/tests/plugin_spellcheck.cpp 15509d8 > kutils/kcmodulecontainer.h db6e435 > kutils/ksettings/README.dox 7f2210d > kutils/ksettings/pluginpage.h ded17e7 > staging/kconfigwidgets/src/kcmodule.h 74333c1 > staging/kde4support/autotests/klibloadertest4_module.cpp 7c1eec2 > staging/kemoticons/src/providers/adium/adium_emoticons.cpp 35414e9 > staging/kemoticons/src/providers/kde/kde_emoticons.cpp 570afb3 > staging/kemoticons/src/providers/pidgin/pidgin_emoticons.cpp d24792f > staging/kemoticons/src/providers/xmpp/xmpp_emoticons.cpp 12ee96a > staging/kio/src/kssld/kssld.cpp 52bc7b6 > staging/kio/src/widgets/kabstractfileitemactionplugin.h 19b872b > staging/kservice/src/plugin/kpluginloader.h 7562ee4 > tier1/kconfig/src/core/kconfigbackend.h bce9fd1 > > Diff: http://git.reviewboard.kde.org/r/111927/diff/ > > > Testing > --- > > No regressions observed in tests. > > > Thanks, > > Sebastian Kügler > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel