Review Request 112463: Port SMB kioslave to KF5/Qt5

[Mark Gaiser]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112463/
---

Review request for KDE Runtime and KDE Frameworks.


Description
---

This is the initial port! I added two TODO lines in the diff for parts where 
i'm not sure if I've ported them correctly.
Also, i needed a change in FindSamba.cmake to even get the samba detection 
working. That reviewrequest is waiting here: 
https://git.reviewboard.kde.org/r/112448/ you're probably OK if you still use 
samba 3.x

Once i know that this is actually working then i will comment some qDebug lines.


Diffs
-

  kioslave/CMakeLists.txt ff66ab6 
  kioslave/smb/CMakeLists.txt a3a2265 
  kioslave/smb/kio_smb.h 55efb44 
  kioslave/smb/kio_smb.cpp 2c2523a 
  kioslave/smb/kio_smb_auth.cpp 4d236b4 
  kioslave/smb/kio_smb_browse.cpp fec6449 
  kioslave/smb/kio_smb_config.cpp 81ce29c 
  kioslave/smb/kio_smb_dir.cpp 5573266 
  kioslave/smb/kio_smb_file.cpp 827a519 
  kioslave/smb/kio_smb_internal.h b895b81 
  kioslave/smb/kio_smb_internal.cpp 3c35583 
  kioslave/smb/kio_smb_mount.cpp a5a7e8e 

Diff: http://git.reviewboard.kde.org/r/112463/diff/


Testing
---

It compiles and gets loaded just fine. I tried testing this on an actual samba 
share, but i kept getting a 111 error (connection refused) from kio_smb so i'm 
hoping that is a local issue here. If someone else could try this out and 
verify that it's either working or broken.


Thanks,

Mark Gaiser

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112463/#review44515
---


It's been stalled for almost three months now, any chance to see progress or 
should it be discarded?

- Kevin Ottens


On Sept. 2, 2013, 7:16 p.m., Mark Gaiser wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112463/
> ---
> 
> (Updated Sept. 2, 2013, 7:16 p.m.)
> 
> 
> Review request for KDE Runtime and KDE Frameworks.
> 
> 
> Repository: kde-runtime
> 
> 
> Description
> ---
> 
> This is the initial port! I added two TODO lines in the diff for parts where 
> i'm not sure if I've ported them correctly.
> Also, i needed a change in FindSamba.cmake to even get the samba detection 
> working. That reviewrequest is waiting here: 
> https://git.reviewboard.kde.org/r/112448/ you're probably OK if you still use 
> samba 3.x
> 
> Once i know that this is actually working then i will comment some qDebug 
> lines.
> 
> 
> Diffs
> -
> 
>   kioslave/CMakeLists.txt ff66ab6 
>   kioslave/smb/CMakeLists.txt a3a2265 
>   kioslave/smb/kio_smb.h 55efb44 
>   kioslave/smb/kio_smb.cpp 2c2523a 
>   kioslave/smb/kio_smb_auth.cpp 4d236b4 
>   kioslave/smb/kio_smb_browse.cpp fec6449 
>   kioslave/smb/kio_smb_config.cpp 81ce29c 
>   kioslave/smb/kio_smb_dir.cpp 5573266 
>   kioslave/smb/kio_smb_file.cpp 827a519 
>   kioslave/smb/kio_smb_internal.h b895b81 
>   kioslave/smb/kio_smb_internal.cpp 3c35583 
>   kioslave/smb/kio_smb_mount.cpp a5a7e8e 
> 
> Diff: http://git.reviewboard.kde.org/r/112463/diff/
> 
> 
> Testing
> ---
> 
> It compiles and gets loaded just fine. I tried testing this on an actual 
> samba share, but i kept getting a 111 error (connection refused) from kio_smb 
> so i'm hoping that is a local issue here. If someone else could try this out 
> and verify that it's either working or broken.
> 
> 
> Thanks,
> 
> Mark Gaiser
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

[Mark Gaiser]

> On Nov. 26, 2013, 5:12 p.m., Kevin Ottens wrote:
> > It's been stalled for almost three months now, any chance to see progress 
> > or should it be discarded?

No, it should most certainly not be disgarded. It was even working when i 
posted this post up for review.

Dawit, how are you doing in the SMB improvements that you had in mind?


- Mark


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112463/#review44515
---


On Sept. 2, 2013, 7:16 p.m., Mark Gaiser wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112463/
> ---
> 
> (Updated Sept. 2, 2013, 7:16 p.m.)
> 
> 
> Review request for KDE Runtime and KDE Frameworks.
> 
> 
> Repository: kde-runtime
> 
> 
> Description
> ---
> 
> This is the initial port! I added two TODO lines in the diff for parts where 
> i'm not sure if I've ported them correctly.
> Also, i needed a change in FindSamba.cmake to even get the samba detection 
> working. That reviewrequest is waiting here: 
> https://git.reviewboard.kde.org/r/112448/ you're probably OK if you still use 
> samba 3.x
> 
> Once i know that this is actually working then i will comment some qDebug 
> lines.
> 
> 
> Diffs
> -
> 
>   kioslave/CMakeLists.txt ff66ab6 
>   kioslave/smb/CMakeLists.txt a3a2265 
>   kioslave/smb/kio_smb.h 55efb44 
>   kioslave/smb/kio_smb.cpp 2c2523a 
>   kioslave/smb/kio_smb_auth.cpp 4d236b4 
>   kioslave/smb/kio_smb_browse.cpp fec6449 
>   kioslave/smb/kio_smb_config.cpp 81ce29c 
>   kioslave/smb/kio_smb_dir.cpp 5573266 
>   kioslave/smb/kio_smb_file.cpp 827a519 
>   kioslave/smb/kio_smb_internal.h b895b81 
>   kioslave/smb/kio_smb_internal.cpp 3c35583 
>   kioslave/smb/kio_smb_mount.cpp a5a7e8e 
> 
> Diff: http://git.reviewboard.kde.org/r/112463/diff/
> 
> 
> Testing
> ---
> 
> It compiles and gets loaded just fine. I tried testing this on an actual 
> samba share, but i kept getting a 111 error (connection refused) from kio_smb 
> so i'm hoping that is a local issue here. If someone else could try this out 
> and verify that it's either working or broken.
> 
> 
> Thanks,
> 
> Mark Gaiser
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

[Dawit Alemayehu]

> On Nov. 26, 2013, 5:12 p.m., Kevin Ottens wrote:
> > It's been stalled for almost three months now, any chance to see progress 
> > or should it be discarded?
> 
> Mark Gaiser wrote:
> No, it should most certainly not be disgarded. It was even working when i 
> posted this post up for review.
> 
> Dawit, how are you doing in the SMB improvements that you had in mind?

Sorry, I forgot to inform you. I have already merged my changes into 4.12 and 
master branches.


- Dawit


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112463/#review44515
---


On Sept. 2, 2013, 7:16 p.m., Mark Gaiser wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112463/
> ---
> 
> (Updated Sept. 2, 2013, 7:16 p.m.)
> 
> 
> Review request for KDE Runtime and KDE Frameworks.
> 
> 
> Repository: kde-runtime
> 
> 
> Description
> ---
> 
> This is the initial port! I added two TODO lines in the diff for parts where 
> i'm not sure if I've ported them correctly.
> Also, i needed a change in FindSamba.cmake to even get the samba detection 
> working. That reviewrequest is waiting here: 
> https://git.reviewboard.kde.org/r/112448/ you're probably OK if you still use 
> samba 3.x
> 
> Once i know that this is actually working then i will comment some qDebug 
> lines.
> 
> 
> Diffs
> -
> 
>   kioslave/CMakeLists.txt ff66ab6 
>   kioslave/smb/CMakeLists.txt a3a2265 
>   kioslave/smb/kio_smb.h 55efb44 
>   kioslave/smb/kio_smb.cpp 2c2523a 
>   kioslave/smb/kio_smb_auth.cpp 4d236b4 
>   kioslave/smb/kio_smb_browse.cpp fec6449 
>   kioslave/smb/kio_smb_config.cpp 81ce29c 
>   kioslave/smb/kio_smb_dir.cpp 5573266 
>   kioslave/smb/kio_smb_file.cpp 827a519 
>   kioslave/smb/kio_smb_internal.h b895b81 
>   kioslave/smb/kio_smb_internal.cpp 3c35583 
>   kioslave/smb/kio_smb_mount.cpp a5a7e8e 
> 
> Diff: http://git.reviewboard.kde.org/r/112463/diff/
> 
> 
> Testing
> ---
> 
> It compiles and gets loaded just fine. I tried testing this on an actual 
> samba share, but i kept getting a 111 error (connection refused) from kio_smb 
> so i'm hoping that is a local issue here. If someone else could try this out 
> and verify that it's either working or broken.
> 
> 
> Thanks,
> 
> Mark Gaiser
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

[Mark Gaiser]

> On Nov. 26, 2013, 5:12 p.m., Kevin Ottens wrote:
> > It's been stalled for almost three months now, any chance to see progress 
> > or should it be discarded?
> 
> Mark Gaiser wrote:
> No, it should most certainly not be disgarded. It was even working when i 
> posted this post up for review.
> 
> Dawit, how are you doing in the SMB improvements that you had in mind?
> 
> Dawit Alemayehu wrote:
> Sorry, I forgot to inform you. I have already merged my changes into 4.12 
> and master branches.

Awesome! Then i will update this review asap with an up to date patch.


- Mark


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112463/#review44515
---


On Sept. 2, 2013, 7:16 p.m., Mark Gaiser wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112463/
> ---
> 
> (Updated Sept. 2, 2013, 7:16 p.m.)
> 
> 
> Review request for KDE Runtime and KDE Frameworks.
> 
> 
> Repository: kde-runtime
> 
> 
> Description
> ---
> 
> This is the initial port! I added two TODO lines in the diff for parts where 
> i'm not sure if I've ported them correctly.
> Also, i needed a change in FindSamba.cmake to even get the samba detection 
> working. That reviewrequest is waiting here: 
> https://git.reviewboard.kde.org/r/112448/ you're probably OK if you still use 
> samba 3.x
> 
> Once i know that this is actually working then i will comment some qDebug 
> lines.
> 
> 
> Diffs
> -
> 
>   kioslave/CMakeLists.txt ff66ab6 
>   kioslave/smb/CMakeLists.txt a3a2265 
>   kioslave/smb/kio_smb.h 55efb44 
>   kioslave/smb/kio_smb.cpp 2c2523a 
>   kioslave/smb/kio_smb_auth.cpp 4d236b4 
>   kioslave/smb/kio_smb_browse.cpp fec6449 
>   kioslave/smb/kio_smb_config.cpp 81ce29c 
>   kioslave/smb/kio_smb_dir.cpp 5573266 
>   kioslave/smb/kio_smb_file.cpp 827a519 
>   kioslave/smb/kio_smb_internal.h b895b81 
>   kioslave/smb/kio_smb_internal.cpp 3c35583 
>   kioslave/smb/kio_smb_mount.cpp a5a7e8e 
> 
> Diff: http://git.reviewboard.kde.org/r/112463/diff/
> 
> 
> Testing
> ---
> 
> It compiles and gets loaded just fine. I tried testing this on an actual 
> samba share, but i kept getting a 111 error (connection refused) from kio_smb 
> so i'm hoping that is a local issue here. If someone else could try this out 
> and verify that it's either working or broken.
> 
> 
> Thanks,
> 
> Mark Gaiser
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

[Mark Gaiser]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112463/
---

(Updated Dec. 1, 2013, 9:32 p.m.)


Review request for KDE Runtime and KDE Frameworks.


Changes
---

Updated diff since Dawit is done with his patches.
I tried to be as thorough as possible with this porting. You won't see any new 
notices or warning coming from this patch. I at least didn't saw any in my test 
compiles.

As for testing this. I did manage to test it and got file listings back. So 
that makes me think that it's ported properly and working. But i have to say 
that testing this is very tricky! The applications that one would normally use 
to verify if everything is OK (aka, dolphin) is not possible because dolphin 
isn't ported. Testing it in my new app "Accretion" is possible, but not 
reliable since that is in heavy development. If something doesn't show up there 
it doesn't mean the slave is broken :)

So this patch is partly based on guess work. It looks like it's working fine.
On the other hand, if it isn't i'm likely the one finding it out anyway since 
i'm digging around a lot in this area lately.


Repository: kde-runtime


Description
---

This is the initial port! I added two TODO lines in the diff for parts where 
i'm not sure if I've ported them correctly.
Also, i needed a change in FindSamba.cmake to even get the samba detection 
working. That reviewrequest is waiting here: 
https://git.reviewboard.kde.org/r/112448/ you're probably OK if you still use 
samba 3.x

Once i know that this is actually working then i will comment some qDebug lines.


Diffs (updated)
-

  kioslave/CMakeLists.txt fc594e4 
  kioslave/smb/CMakeLists.txt a3a2265 
  kioslave/smb/kio_smb.h c2229ab 
  kioslave/smb/kio_smb.cpp 2c2523a 
  kioslave/smb/kio_smb_auth.cpp 4d236b4 
  kioslave/smb/kio_smb_browse.cpp 5253be9 
  kioslave/smb/kio_smb_dir.cpp ba80c86 
  kioslave/smb/kio_smb_file.cpp 206526a 
  kioslave/smb/kio_smb_internal.h 4b946c1 
  kioslave/smb/kio_smb_internal.cpp e943844 
  kioslave/smb/kio_smb_mount.cpp a5a7e8e 
  kioslave/smb/kio_smb_win.h f1dcb6f 
  kioslave/smb/kio_smb_win.cpp 14dd797 

Diff: http://git.reviewboard.kde.org/r/112463/diff/


Testing
---

It compiles and gets loaded just fine. I tried testing this on an actual samba 
share, but i kept getting a 111 error (connection refused) from kio_smb so i'm 
hoping that is a local issue here. If someone else could try this out and 
verify that it's either working or broken.


Thanks,

Mark Gaiser

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

[Mark Gaiser]

Bump.

Can anyone look at this?


On Sun, Dec 1, 2013 at 10:32 PM, Mark Gaiser  wrote:

>This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112463/
>   Review request for KDE Runtime and KDE Frameworks.
> By Mark Gaiser.
>
> *Updated Dec. 1, 2013, 9:32 p.m.*
> Changes
>
> Updated diff since Dawit is done with his patches.
> I tried to be as thorough as possible with this porting. You won't see any 
> new notices or warning coming from this patch. I at least didn't saw any in 
> my test compiles.
>
> As for testing this. I did manage to test it and got file listings back. So 
> that makes me think that it's ported properly and working. But i have to say 
> that testing this is very tricky! The applications that one would normally 
> use to verify if everything is OK (aka, dolphin) is not possible because 
> dolphin isn't ported. Testing it in my new app "Accretion" is possible, but 
> not reliable since that is in heavy development. If something doesn't show up 
> there it doesn't mean the slave is broken :)
>
> So this patch is partly based on guess work. It looks like it's working fine.
> On the other hand, if it isn't i'm likely the one finding it out anyway since 
> i'm digging around a lot in this area lately.
>
>   *Repository: * kde-runtime
> Description
>
> This is the initial port! I added two TODO lines in the diff for parts where 
> i'm not sure if I've ported them correctly.
> Also, i needed a change in FindSamba.cmake to even get the samba detection 
> working. That reviewrequest is waiting here: 
> https://git.reviewboard.kde.org/r/112448/ you're probably OK if you still use 
> samba 3.x
>
> Once i know that this is actually working then i will comment some qDebug 
> lines.
>
>   Testing
>
> It compiles and gets loaded just fine. I tried testing this on an actual 
> samba share, but i kept getting a 111 error (connection refused) from kio_smb 
> so i'm hoping that is a local issue here. If someone else could try this out 
> and verify that it's either working or broken.
>
>   Diffs (updated)
>
>- kioslave/CMakeLists.txt (fc594e4)
>- kioslave/smb/CMakeLists.txt (a3a2265)
>- kioslave/smb/kio_smb.h (c2229ab)
>- kioslave/smb/kio_smb.cpp (2c2523a)
>- kioslave/smb/kio_smb_auth.cpp (4d236b4)
>- kioslave/smb/kio_smb_browse.cpp (5253be9)
>- kioslave/smb/kio_smb_dir.cpp (ba80c86)
>- kioslave/smb/kio_smb_file.cpp (206526a)
>- kioslave/smb/kio_smb_internal.h (4b946c1)
>- kioslave/smb/kio_smb_internal.cpp (e943844)
>- kioslave/smb/kio_smb_mount.cpp (a5a7e8e)
>- kioslave/smb/kio_smb_win.h (f1dcb6f)
>- kioslave/smb/kio_smb_win.cpp (14dd797)
>
> View Diff 
>
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112463/#review45140
---



kioslave/smb/kio_smb.cpp


Can be removed



kioslave/smb/kio_smb_internal.h


Spurious space



kioslave/smb/kio_smb_internal.cpp


Could be the mode compact toString(QUrl::PrettyDecoded).toUtf8()

Avoids a temporary in the process.


- Kevin Ottens


On Dec. 1, 2013, 9:32 p.m., Mark Gaiser wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112463/
> ---
> 
> (Updated Dec. 1, 2013, 9:32 p.m.)
> 
> 
> Review request for KDE Runtime and KDE Frameworks.
> 
> 
> Repository: kde-runtime
> 
> 
> Description
> ---
> 
> This is the initial port! I added two TODO lines in the diff for parts where 
> i'm not sure if I've ported them correctly.
> Also, i needed a change in FindSamba.cmake to even get the samba detection 
> working. That reviewrequest is waiting here: 
> https://git.reviewboard.kde.org/r/112448/ you're probably OK if you still use 
> samba 3.x
> 
> Once i know that this is actually working then i will comment some qDebug 
> lines.
> 
> 
> Diffs
> -
> 
>   kioslave/CMakeLists.txt fc594e4 
>   kioslave/smb/CMakeLists.txt a3a2265 
>   kioslave/smb/kio_smb.h c2229ab 
>   kioslave/smb/kio_smb.cpp 2c2523a 
>   kioslave/smb/kio_smb_auth.cpp 4d236b4 
>   kioslave/smb/kio_smb_browse.cpp 5253be9 
>   kioslave/smb/kio_smb_dir.cpp ba80c86 
>   kioslave/smb/kio_smb_file.cpp 206526a 
>   kioslave/smb/kio_smb_internal.h 4b946c1 
>   kioslave/smb/kio_smb_internal.cpp e943844 
>   kioslave/smb/kio_smb_mount.cpp a5a7e8e 
>   kioslave/smb/kio_smb_win.h f1dcb6f 
>   kioslave/smb/kio_smb_win.cpp 14dd797 
> 
> Diff: http://git.reviewboard.kde.org/r/112463/diff/
> 
> 
> Testing
> ---
> 
> It compiles and gets loaded just fine. I tried testing this on an actual 
> samba share, but i kept getting a 111 error (connection refused) from kio_smb 
> so i'm hoping that is a local issue here. If someone else could try this out 
> and verify that it's either working or broken.
> 
> 
> Thanks,
> 
> Mark Gaiser
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

[Mark Gaiser]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112463/
---

(Updated Dec. 5, 2013, 11:44 p.m.)


Review request for KDE Runtime and KDE Frameworks.


Changes
---

Updated with suggestions from Kevin.
Replaced KDE::utime (deprecated warning) by just utime(QFile::enc..., ...)


Repository: kde-runtime


Description
---

This is the initial port! I added two TODO lines in the diff for parts where 
i'm not sure if I've ported them correctly.
Also, i needed a change in FindSamba.cmake to even get the samba detection 
working. That reviewrequest is waiting here: 
https://git.reviewboard.kde.org/r/112448/ you're probably OK if you still use 
samba 3.x

Once i know that this is actually working then i will comment some qDebug lines.


Diffs (updated)
-

  kioslave/CMakeLists.txt fc594e4 
  kioslave/smb/CMakeLists.txt a3a2265 
  kioslave/smb/kio_smb.h c2229ab 
  kioslave/smb/kio_smb.cpp 2c2523a 
  kioslave/smb/kio_smb_auth.cpp 4d236b4 
  kioslave/smb/kio_smb_browse.cpp 5253be9 
  kioslave/smb/kio_smb_dir.cpp ba80c86 
  kioslave/smb/kio_smb_file.cpp 206526a 
  kioslave/smb/kio_smb_internal.h 4b946c1 
  kioslave/smb/kio_smb_internal.cpp e943844 
  kioslave/smb/kio_smb_mount.cpp a5a7e8e 
  kioslave/smb/kio_smb_win.h f1dcb6f 
  kioslave/smb/kio_smb_win.cpp 14dd797 

Diff: http://git.reviewboard.kde.org/r/112463/diff/


Testing
---

It compiles and gets loaded just fine. I tried testing this on an actual samba 
share, but i kept getting a 111 error (connection refused) from kio_smb so i'm 
hoping that is a local issue here. If someone else could try this out and 
verify that it's either working or broken.


Thanks,

Mark Gaiser

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

[Mark Gaiser]

Bump.. Ok to push it?


On Fri, Dec 6, 2013 at 12:44 AM, Mark Gaiser  wrote:

>This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112463/
>   Review request for KDE Runtime and KDE Frameworks.
> By Mark Gaiser.
>
> *Updated Dec. 5, 2013, 11:44 p.m.*
> Changes
>
> Updated with suggestions from Kevin.
> Replaced KDE::utime (deprecated warning) by just utime(QFile::enc..., ...)
>
>   *Repository: * kde-runtime
> Description
>
> This is the initial port! I added two TODO lines in the diff for parts where 
> i'm not sure if I've ported them correctly.
> Also, i needed a change in FindSamba.cmake to even get the samba detection 
> working. That reviewrequest is waiting here: 
> https://git.reviewboard.kde.org/r/112448/ you're probably OK if you still use 
> samba 3.x
>
> Once i know that this is actually working then i will comment some qDebug 
> lines.
>
>   Testing
>
> It compiles and gets loaded just fine. I tried testing this on an actual 
> samba share, but i kept getting a 111 error (connection refused) from kio_smb 
> so i'm hoping that is a local issue here. If someone else could try this out 
> and verify that it's either working or broken.
>
>   Diffs (updated)
>
>- kioslave/CMakeLists.txt (fc594e4)
>- kioslave/smb/CMakeLists.txt (a3a2265)
>- kioslave/smb/kio_smb.h (c2229ab)
>- kioslave/smb/kio_smb.cpp (2c2523a)
>- kioslave/smb/kio_smb_auth.cpp (4d236b4)
>- kioslave/smb/kio_smb_browse.cpp (5253be9)
>- kioslave/smb/kio_smb_dir.cpp (ba80c86)
>- kioslave/smb/kio_smb_file.cpp (206526a)
>- kioslave/smb/kio_smb_internal.h (4b946c1)
>- kioslave/smb/kio_smb_internal.cpp (e943844)
>- kioslave/smb/kio_smb_mount.cpp (a5a7e8e)
>- kioslave/smb/kio_smb_win.h (f1dcb6f)
>- kioslave/smb/kio_smb_win.cpp (14dd797)
>
> View Diff 
>
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

[Mark Gaiser]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112463/#review45467
---


If there are further objections/feedback, please share them. If there still is 
nothing by next friday (13th dec.) then i will go ahead and push.

- Mark Gaiser


On Dec. 5, 2013, 11:44 p.m., Mark Gaiser wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112463/
> ---
> 
> (Updated Dec. 5, 2013, 11:44 p.m.)
> 
> 
> Review request for KDE Runtime and KDE Frameworks.
> 
> 
> Repository: kde-runtime
> 
> 
> Description
> ---
> 
> This is the initial port! I added two TODO lines in the diff for parts where 
> i'm not sure if I've ported them correctly.
> Also, i needed a change in FindSamba.cmake to even get the samba detection 
> working. That reviewrequest is waiting here: 
> https://git.reviewboard.kde.org/r/112448/ you're probably OK if you still use 
> samba 3.x
> 
> Once i know that this is actually working then i will comment some qDebug 
> lines.
> 
> 
> Diffs
> -
> 
>   kioslave/CMakeLists.txt fc594e4 
>   kioslave/smb/CMakeLists.txt a3a2265 
>   kioslave/smb/kio_smb.h c2229ab 
>   kioslave/smb/kio_smb.cpp 2c2523a 
>   kioslave/smb/kio_smb_auth.cpp 4d236b4 
>   kioslave/smb/kio_smb_browse.cpp 5253be9 
>   kioslave/smb/kio_smb_dir.cpp ba80c86 
>   kioslave/smb/kio_smb_file.cpp 206526a 
>   kioslave/smb/kio_smb_internal.h 4b946c1 
>   kioslave/smb/kio_smb_internal.cpp e943844 
>   kioslave/smb/kio_smb_mount.cpp a5a7e8e 
>   kioslave/smb/kio_smb_win.h f1dcb6f 
>   kioslave/smb/kio_smb_win.cpp 14dd797 
> 
> Diff: http://git.reviewboard.kde.org/r/112463/diff/
> 
> 
> Testing
> ---
> 
> It compiles and gets loaded just fine. I tried testing this on an actual 
> samba share, but i kept getting a 111 error (connection refused) from kio_smb 
> so i'm hoping that is a local issue here. If someone else could try this out 
> and verify that it's either working or broken.
> 
> 
> Thanks,
> 
> Mark Gaiser
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112463/#review45466
---



kioslave/smb/CMakeLists.txt


this should be:
add_library(kio_smb MODULE {kio_smb_PART_SRCS})



kioslave/smb/CMakeLists.txt


also add_library.



kioslave/smb/kio_smb.h


do you need klocale? it's deprecated.



kioslave/smb/kio_smb_auth.cpp


A

xD
Maybe we can just remove this one?



kioslave/smb/kio_smb_internal.h


it might be a good moment to remove this comment-



kioslave/smb/kio_smb_internal.cpp


Does it really need QDir::separator()? It seems to me like everything 
should be '/'.


- Aleix Pol Gonzalez


On Dec. 5, 2013, 11:44 p.m., Mark Gaiser wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112463/
> ---
> 
> (Updated Dec. 5, 2013, 11:44 p.m.)
> 
> 
> Review request for KDE Runtime and KDE Frameworks.
> 
> 
> Repository: kde-runtime
> 
> 
> Description
> ---
> 
> This is the initial port! I added two TODO lines in the diff for parts where 
> i'm not sure if I've ported them correctly.
> Also, i needed a change in FindSamba.cmake to even get the samba detection 
> working. That reviewrequest is waiting here: 
> https://git.reviewboard.kde.org/r/112448/ you're probably OK if you still use 
> samba 3.x
> 
> Once i know that this is actually working then i will comment some qDebug 
> lines.
> 
> 
> Diffs
> -
> 
>   kioslave/CMakeLists.txt fc594e4 
>   kioslave/smb/CMakeLists.txt a3a2265 
>   kioslave/smb/kio_smb.h c2229ab 
>   kioslave/smb/kio_smb.cpp 2c2523a 
>   kioslave/smb/kio_smb_auth.cpp 4d236b4 
>   kioslave/smb/kio_smb_browse.cpp 5253be9 
>   kioslave/smb/kio_smb_dir.cpp ba80c86 
>   kioslave/smb/kio_smb_file.cpp 206526a 
>   kioslave/smb/kio_smb_internal.h 4b946c1 
>   kioslave/smb/kio_smb_internal.cpp e943844 
>   kioslave/smb/kio_smb_mount.cpp a5a7e8e 
>   kioslave/smb/kio_smb_win.h f1dcb6f 
>   kioslave/smb/kio_smb_win.cpp 14dd797 
> 
> Diff: http://git.reviewboard.kde.org/r/112463/diff/
> 
> 
> Testing
> ---
> 
> It compiles and gets loaded just fine. I tried testing this on an actual 
> samba share, but i kept getting a 111 error (connection refused) from kio_smb 
> so i'm hoping that is a local issue here. If someone else could try this out 
> and verify that it's either working or broken.
> 
> 
> Thanks,
> 
> Mark Gaiser
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

[Mark Gaiser]

> On Dec. 10, 2013, 3:54 p.m., Aleix Pol Gonzalez wrote:
> > kioslave/smb/kio_smb_internal.cpp, line 68
> > 
> >
> > Does it really need QDir::separator()? It seems to me like everything 
> > should be '/'.

"could" be, but i'm not quite sure. The path() function doesn't add a trailing 
slash if there is none.
So that probably leaves the question: "Does the current path always have a 
trailing slash?". I don't know. I'm better safe then sorry and just leave the 
QDir::separator() unless you are 100% sure i can manage without it?


> On Dec. 10, 2013, 3:54 p.m., Aleix Pol Gonzalez wrote:
> > kioslave/smb/kio_smb_internal.h, line 35
> > 
> >
> > it might be a good moment to remove this comment-

:) will do


> On Dec. 10, 2013, 3:54 p.m., Aleix Pol Gonzalez wrote:
> > kioslave/smb/kio_smb_auth.cpp, line 76
> > 
> >
> > A
> > 
> > xD
> > Maybe we can just remove this one?

Just the "A" i suppose? So the rest can stay?


> On Dec. 10, 2013, 3:54 p.m., Aleix Pol Gonzalez wrote:
> > kioslave/smb/kio_smb.h, line 48
> > 
> >
> > do you need klocale? it's deprecated.

Interesting! I'm not getting any deprecated notices from locale based function 
so i wonder if any functions from that include are used at all. Will take a 
look at it and remove it if possible.


- Mark


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112463/#review45466
---


On Dec. 5, 2013, 11:44 p.m., Mark Gaiser wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112463/
> ---
> 
> (Updated Dec. 5, 2013, 11:44 p.m.)
> 
> 
> Review request for KDE Runtime and KDE Frameworks.
> 
> 
> Repository: kde-runtime
> 
> 
> Description
> ---
> 
> This is the initial port! I added two TODO lines in the diff for parts where 
> i'm not sure if I've ported them correctly.
> Also, i needed a change in FindSamba.cmake to even get the samba detection 
> working. That reviewrequest is waiting here: 
> https://git.reviewboard.kde.org/r/112448/ you're probably OK if you still use 
> samba 3.x
> 
> Once i know that this is actually working then i will comment some qDebug 
> lines.
> 
> 
> Diffs
> -
> 
>   kioslave/CMakeLists.txt fc594e4 
>   kioslave/smb/CMakeLists.txt a3a2265 
>   kioslave/smb/kio_smb.h c2229ab 
>   kioslave/smb/kio_smb.cpp 2c2523a 
>   kioslave/smb/kio_smb_auth.cpp 4d236b4 
>   kioslave/smb/kio_smb_browse.cpp 5253be9 
>   kioslave/smb/kio_smb_dir.cpp ba80c86 
>   kioslave/smb/kio_smb_file.cpp 206526a 
>   kioslave/smb/kio_smb_internal.h 4b946c1 
>   kioslave/smb/kio_smb_internal.cpp e943844 
>   kioslave/smb/kio_smb_mount.cpp a5a7e8e 
>   kioslave/smb/kio_smb_win.h f1dcb6f 
>   kioslave/smb/kio_smb_win.cpp 14dd797 
> 
> Diff: http://git.reviewboard.kde.org/r/112463/diff/
> 
> 
> Testing
> ---
> 
> It compiles and gets loaded just fine. I tried testing this on an actual 
> samba share, but i kept getting a 111 error (connection refused) from kio_smb 
> so i'm hoping that is a local issue here. If someone else could try this out 
> and verify that it's either working or broken.
> 
> 
> Thanks,
> 
> Mark Gaiser
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

[Aleix Pol Gonzalez]

> On Dec. 10, 2013, 3:54 p.m., Aleix Pol Gonzalez wrote:
> > kioslave/smb/kio_smb_auth.cpp, line 76
> > 
> >
> > A
> > 
> > xD
> > Maybe we can just remove this one?
> 
> Mark Gaiser wrote:
> Just the "A" i suppose? So the rest can stay?

Your decision. :D


> On Dec. 10, 2013, 3:54 p.m., Aleix Pol Gonzalez wrote:
> > kioslave/smb/kio_smb_internal.cpp, line 68
> > 
> >
> > Does it really need QDir::separator()? It seems to me like everything 
> > should be '/'.
> 
> Mark Gaiser wrote:
> "could" be, but i'm not quite sure. The path() function doesn't add a 
> trailing slash if there is none.
> So that probably leaves the question: "Does the current path always have 
> a trailing slash?". I don't know. I'm better safe then sorry and just leave 
> the QDir::separator() unless you are 100% sure i can manage without it?

No, that's not what I was saying. I was proposing to change it to:
QUrl::setPath(path() + QLatin1Char('/') + filedir);


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112463/#review45466
---


On Dec. 5, 2013, 11:44 p.m., Mark Gaiser wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112463/
> ---
> 
> (Updated Dec. 5, 2013, 11:44 p.m.)
> 
> 
> Review request for KDE Runtime and KDE Frameworks.
> 
> 
> Repository: kde-runtime
> 
> 
> Description
> ---
> 
> This is the initial port! I added two TODO lines in the diff for parts where 
> i'm not sure if I've ported them correctly.
> Also, i needed a change in FindSamba.cmake to even get the samba detection 
> working. That reviewrequest is waiting here: 
> https://git.reviewboard.kde.org/r/112448/ you're probably OK if you still use 
> samba 3.x
> 
> Once i know that this is actually working then i will comment some qDebug 
> lines.
> 
> 
> Diffs
> -
> 
>   kioslave/CMakeLists.txt fc594e4 
>   kioslave/smb/CMakeLists.txt a3a2265 
>   kioslave/smb/kio_smb.h c2229ab 
>   kioslave/smb/kio_smb.cpp 2c2523a 
>   kioslave/smb/kio_smb_auth.cpp 4d236b4 
>   kioslave/smb/kio_smb_browse.cpp 5253be9 
>   kioslave/smb/kio_smb_dir.cpp ba80c86 
>   kioslave/smb/kio_smb_file.cpp 206526a 
>   kioslave/smb/kio_smb_internal.h 4b946c1 
>   kioslave/smb/kio_smb_internal.cpp e943844 
>   kioslave/smb/kio_smb_mount.cpp a5a7e8e 
>   kioslave/smb/kio_smb_win.h f1dcb6f 
>   kioslave/smb/kio_smb_win.cpp 14dd797 
> 
> Diff: http://git.reviewboard.kde.org/r/112463/diff/
> 
> 
> Testing
> ---
> 
> It compiles and gets loaded just fine. I tried testing this on an actual 
> samba share, but i kept getting a 111 error (connection refused) from kio_smb 
> so i'm hoping that is a local issue here. If someone else could try this out 
> and verify that it's either working or broken.
> 
> 
> Thanks,
> 
> Mark Gaiser
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

[Mark Gaiser]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112463/
---

(Updated Dec. 10, 2013, 6:51 p.m.)


Review request for KDE Runtime and KDE Frameworks.


Changes
---

Updated according to feedback.


Repository: kde-runtime


Description
---

This is the initial port! I added two TODO lines in the diff for parts where 
i'm not sure if I've ported them correctly.
Also, i needed a change in FindSamba.cmake to even get the samba detection 
working. That reviewrequest is waiting here: 
https://git.reviewboard.kde.org/r/112448/ you're probably OK if you still use 
samba 3.x

Once i know that this is actually working then i will comment some qDebug lines.


Diffs (updated)
-

  kioslave/CMakeLists.txt fc594e4 
  kioslave/smb/CMakeLists.txt a3a2265 
  kioslave/smb/kio_smb.h c2229ab 
  kioslave/smb/kio_smb.cpp 2c2523a 
  kioslave/smb/kio_smb_auth.cpp 4d236b4 
  kioslave/smb/kio_smb_browse.cpp 5253be9 
  kioslave/smb/kio_smb_dir.cpp ba80c86 
  kioslave/smb/kio_smb_file.cpp 206526a 
  kioslave/smb/kio_smb_internal.h 4b946c1 
  kioslave/smb/kio_smb_internal.cpp e943844 
  kioslave/smb/kio_smb_mount.cpp a5a7e8e 
  kioslave/smb/kio_smb_win.h f1dcb6f 
  kioslave/smb/kio_smb_win.cpp 14dd797 

Diff: http://git.reviewboard.kde.org/r/112463/diff/


Testing
---

It compiles and gets loaded just fine. I tried testing this on an actual samba 
share, but i kept getting a 111 error (connection refused) from kio_smb so i'm 
hoping that is a local issue here. If someone else could try this out and 
verify that it's either working or broken.


Thanks,

Mark Gaiser

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112463/#review45520
---

Ship it!


- Aleix Pol Gonzalez


On Dec. 10, 2013, 6:51 p.m., Mark Gaiser wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112463/
> ---
> 
> (Updated Dec. 10, 2013, 6:51 p.m.)
> 
> 
> Review request for KDE Runtime and KDE Frameworks.
> 
> 
> Repository: kde-runtime
> 
> 
> Description
> ---
> 
> This is the initial port! I added two TODO lines in the diff for parts where 
> i'm not sure if I've ported them correctly.
> Also, i needed a change in FindSamba.cmake to even get the samba detection 
> working. That reviewrequest is waiting here: 
> https://git.reviewboard.kde.org/r/112448/ you're probably OK if you still use 
> samba 3.x
> 
> Once i know that this is actually working then i will comment some qDebug 
> lines.
> 
> 
> Diffs
> -
> 
>   kioslave/CMakeLists.txt fc594e4 
>   kioslave/smb/CMakeLists.txt a3a2265 
>   kioslave/smb/kio_smb.h c2229ab 
>   kioslave/smb/kio_smb.cpp 2c2523a 
>   kioslave/smb/kio_smb_auth.cpp 4d236b4 
>   kioslave/smb/kio_smb_browse.cpp 5253be9 
>   kioslave/smb/kio_smb_dir.cpp ba80c86 
>   kioslave/smb/kio_smb_file.cpp 206526a 
>   kioslave/smb/kio_smb_internal.h 4b946c1 
>   kioslave/smb/kio_smb_internal.cpp e943844 
>   kioslave/smb/kio_smb_mount.cpp a5a7e8e 
>   kioslave/smb/kio_smb_win.h f1dcb6f 
>   kioslave/smb/kio_smb_win.cpp 14dd797 
> 
> Diff: http://git.reviewboard.kde.org/r/112463/diff/
> 
> 
> Testing
> ---
> 
> It compiles and gets loaded just fine. I tried testing this on an actual 
> samba share, but i kept getting a 111 error (connection refused) from kio_smb 
> so i'm hoping that is a local issue here. If someone else could try this out 
> and verify that it's either working or broken.
> 
> 
> Thanks,
> 
> Mark Gaiser
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112463/#review45522
---


This review has been submitted with commit 
728309ac2a80cab8feba4ef28f33725c59411bcf by Mark Gaiser to branch frameworks.

- Commit Hook


On Dec. 10, 2013, 6:51 p.m., Mark Gaiser wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112463/
> ---
> 
> (Updated Dec. 10, 2013, 6:51 p.m.)
> 
> 
> Review request for KDE Runtime and KDE Frameworks.
> 
> 
> Repository: kde-runtime
> 
> 
> Description
> ---
> 
> This is the initial port! I added two TODO lines in the diff for parts where 
> i'm not sure if I've ported them correctly.
> Also, i needed a change in FindSamba.cmake to even get the samba detection 
> working. That reviewrequest is waiting here: 
> https://git.reviewboard.kde.org/r/112448/ you're probably OK if you still use 
> samba 3.x
> 
> Once i know that this is actually working then i will comment some qDebug 
> lines.
> 
> 
> Diffs
> -
> 
>   kioslave/CMakeLists.txt fc594e4 
>   kioslave/smb/CMakeLists.txt a3a2265 
>   kioslave/smb/kio_smb.h c2229ab 
>   kioslave/smb/kio_smb.cpp 2c2523a 
>   kioslave/smb/kio_smb_auth.cpp 4d236b4 
>   kioslave/smb/kio_smb_browse.cpp 5253be9 
>   kioslave/smb/kio_smb_dir.cpp ba80c86 
>   kioslave/smb/kio_smb_file.cpp 206526a 
>   kioslave/smb/kio_smb_internal.h 4b946c1 
>   kioslave/smb/kio_smb_internal.cpp e943844 
>   kioslave/smb/kio_smb_mount.cpp a5a7e8e 
>   kioslave/smb/kio_smb_win.h f1dcb6f 
>   kioslave/smb/kio_smb_win.cpp 14dd797 
> 
> Diff: http://git.reviewboard.kde.org/r/112463/diff/
> 
> 
> Testing
> ---
> 
> It compiles and gets loaded just fine. I tried testing this on an actual 
> samba share, but i kept getting a 111 error (connection refused) from kio_smb 
> so i'm hoping that is a local issue here. If someone else could try this out 
> and verify that it's either working or broken.
> 
> 
> Thanks,
> 
> Mark Gaiser
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

[Mark Gaiser]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112463/
---

(Updated Dec. 11, 2013, 1:45 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Runtime and KDE Frameworks.


Repository: kde-runtime


Description
---

This is the initial port! I added two TODO lines in the diff for parts where 
i'm not sure if I've ported them correctly.
Also, i needed a change in FindSamba.cmake to even get the samba detection 
working. That reviewrequest is waiting here: 
https://git.reviewboard.kde.org/r/112448/ you're probably OK if you still use 
samba 3.x

Once i know that this is actually working then i will comment some qDebug lines.


Diffs
-

  kioslave/CMakeLists.txt fc594e4 
  kioslave/smb/CMakeLists.txt a3a2265 
  kioslave/smb/kio_smb.h c2229ab 
  kioslave/smb/kio_smb.cpp 2c2523a 
  kioslave/smb/kio_smb_auth.cpp 4d236b4 
  kioslave/smb/kio_smb_browse.cpp 5253be9 
  kioslave/smb/kio_smb_dir.cpp ba80c86 
  kioslave/smb/kio_smb_file.cpp 206526a 
  kioslave/smb/kio_smb_internal.h 4b946c1 
  kioslave/smb/kio_smb_internal.cpp e943844 
  kioslave/smb/kio_smb_mount.cpp a5a7e8e 
  kioslave/smb/kio_smb_win.h f1dcb6f 
  kioslave/smb/kio_smb_win.cpp 14dd797 

Diff: http://git.reviewboard.kde.org/r/112463/diff/


Testing
---

It compiles and gets loaded just fine. I tried testing this on an actual samba 
share, but i kept getting a 111 error (connection refused) from kio_smb so i'm 
hoping that is a local issue here. If someone else could try this out and 
verify that it's either working or broken.


Thanks,

Mark Gaiser

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

[Mark Gaiser]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112463/#review39205
---



kioslave/CMakeLists.txt


This will obviously go once i commit.


- Mark Gaiser


On Sept. 2, 2013, 7:16 p.m., Mark Gaiser wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112463/
> ---
> 
> (Updated Sept. 2, 2013, 7:16 p.m.)
> 
> 
> Review request for KDE Runtime and KDE Frameworks.
> 
> 
> Description
> ---
> 
> This is the initial port! I added two TODO lines in the diff for parts where 
> i'm not sure if I've ported them correctly.
> Also, i needed a change in FindSamba.cmake to even get the samba detection 
> working. That reviewrequest is waiting here: 
> https://git.reviewboard.kde.org/r/112448/ you're probably OK if you still use 
> samba 3.x
> 
> Once i know that this is actually working then i will comment some qDebug 
> lines.
> 
> 
> Diffs
> -
> 
>   kioslave/CMakeLists.txt ff66ab6 
>   kioslave/smb/CMakeLists.txt a3a2265 
>   kioslave/smb/kio_smb.h 55efb44 
>   kioslave/smb/kio_smb.cpp 2c2523a 
>   kioslave/smb/kio_smb_auth.cpp 4d236b4 
>   kioslave/smb/kio_smb_browse.cpp fec6449 
>   kioslave/smb/kio_smb_config.cpp 81ce29c 
>   kioslave/smb/kio_smb_dir.cpp 5573266 
>   kioslave/smb/kio_smb_file.cpp 827a519 
>   kioslave/smb/kio_smb_internal.h b895b81 
>   kioslave/smb/kio_smb_internal.cpp 3c35583 
>   kioslave/smb/kio_smb_mount.cpp a5a7e8e 
> 
> Diff: http://git.reviewboard.kde.org/r/112463/diff/
> 
> 
> Testing
> ---
> 
> It compiles and gets loaded just fine. I tried testing this on an actual 
> samba share, but i kept getting a 111 error (connection refused) from kio_smb 
> so i'm hoping that is a local issue here. If someone else could try this out 
> and verify that it's either working or broken.
> 
> 
> Thanks,
> 
> Mark Gaiser
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

[Dawit Alemayehu]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112463/#review39463
---


I have several changes coming to this ioslave. Mainly I am going to implement 
the copyFrom and copyTo optimizations like I did for the sftp ioslave and add 
support for upload/download resumptions. The changes are going to come in parts 
because they are not small and should be done in the next week or two. 

If you feel that it would be easier to merge those changes after your port, 
then feel free to ship this, otherwise would it be possible for you to hold off 
on this port? For the record I am not the maintainer of this code base. I am 
just trying to improve as many of these ioslaves as I can when I get the chance.

- Dawit Alemayehu


On Sept. 2, 2013, 7:16 p.m., Mark Gaiser wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112463/
> ---
> 
> (Updated Sept. 2, 2013, 7:16 p.m.)
> 
> 
> Review request for KDE Runtime and KDE Frameworks.
> 
> 
> Description
> ---
> 
> This is the initial port! I added two TODO lines in the diff for parts where 
> i'm not sure if I've ported them correctly.
> Also, i needed a change in FindSamba.cmake to even get the samba detection 
> working. That reviewrequest is waiting here: 
> https://git.reviewboard.kde.org/r/112448/ you're probably OK if you still use 
> samba 3.x
> 
> Once i know that this is actually working then i will comment some qDebug 
> lines.
> 
> 
> Diffs
> -
> 
>   kioslave/CMakeLists.txt ff66ab6 
>   kioslave/smb/CMakeLists.txt a3a2265 
>   kioslave/smb/kio_smb.h 55efb44 
>   kioslave/smb/kio_smb.cpp 2c2523a 
>   kioslave/smb/kio_smb_auth.cpp 4d236b4 
>   kioslave/smb/kio_smb_browse.cpp fec6449 
>   kioslave/smb/kio_smb_config.cpp 81ce29c 
>   kioslave/smb/kio_smb_dir.cpp 5573266 
>   kioslave/smb/kio_smb_file.cpp 827a519 
>   kioslave/smb/kio_smb_internal.h b895b81 
>   kioslave/smb/kio_smb_internal.cpp 3c35583 
>   kioslave/smb/kio_smb_mount.cpp a5a7e8e 
> 
> Diff: http://git.reviewboard.kde.org/r/112463/diff/
> 
> 
> Testing
> ---
> 
> It compiles and gets loaded just fine. I tried testing this on an actual 
> samba share, but i kept getting a 111 error (connection refused) from kio_smb 
> so i'm hoping that is a local issue here. If someone else could try this out 
> and verify that it's either working or broken.
> 
> 
> Thanks,
> 
> Mark Gaiser
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

[Mark Gaiser]

> On Sept. 6, 2013, 1:10 p.m., Dawit Alemayehu wrote:
> > I have several changes coming to this ioslave. Mainly I am going to 
> > implement the copyFrom and copyTo optimizations like I did for the sftp 
> > ioslave and add support for upload/download resumptions. The changes are 
> > going to come in parts because they are not small and should be done in the 
> > next week or two. 
> > 
> > If you feel that it would be easier to merge those changes after your port, 
> > then feel free to ship this, otherwise would it be possible for you to hold 
> > off on this port? For the record I am not the maintainer of this code base. 
> > I am just trying to improve as many of these ioslaves as I can when I get 
> > the chance.

Question though: did you test this port and did it work for you?

As for the porting and your changes. You seem to be making those changes in 
KDE/4.11, not in frameworks-scratch, so i would prefer if you make the changes 
you want to make. Once those are in i will have to rebase my changes against it 
and request a "ship it" again :)


- Mark


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112463/#review39463
---


On Sept. 2, 2013, 7:16 p.m., Mark Gaiser wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112463/
> ---
> 
> (Updated Sept. 2, 2013, 7:16 p.m.)
> 
> 
> Review request for KDE Runtime and KDE Frameworks.
> 
> 
> Description
> ---
> 
> This is the initial port! I added two TODO lines in the diff for parts where 
> i'm not sure if I've ported them correctly.
> Also, i needed a change in FindSamba.cmake to even get the samba detection 
> working. That reviewrequest is waiting here: 
> https://git.reviewboard.kde.org/r/112448/ you're probably OK if you still use 
> samba 3.x
> 
> Once i know that this is actually working then i will comment some qDebug 
> lines.
> 
> 
> Diffs
> -
> 
>   kioslave/CMakeLists.txt ff66ab6 
>   kioslave/smb/CMakeLists.txt a3a2265 
>   kioslave/smb/kio_smb.h 55efb44 
>   kioslave/smb/kio_smb.cpp 2c2523a 
>   kioslave/smb/kio_smb_auth.cpp 4d236b4 
>   kioslave/smb/kio_smb_browse.cpp fec6449 
>   kioslave/smb/kio_smb_config.cpp 81ce29c 
>   kioslave/smb/kio_smb_dir.cpp 5573266 
>   kioslave/smb/kio_smb_file.cpp 827a519 
>   kioslave/smb/kio_smb_internal.h b895b81 
>   kioslave/smb/kio_smb_internal.cpp 3c35583 
>   kioslave/smb/kio_smb_mount.cpp a5a7e8e 
> 
> Diff: http://git.reviewboard.kde.org/r/112463/diff/
> 
> 
> Testing
> ---
> 
> It compiles and gets loaded just fine. I tried testing this on an actual 
> samba share, but i kept getting a 111 error (connection refused) from kio_smb 
> so i'm hoping that is a local issue here. If someone else could try this out 
> and verify that it's either working or broken.
> 
> 
> Thanks,
> 
> Mark Gaiser
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

[Dawit Alemayehu]

> On Sept. 6, 2013, 1:10 p.m., Dawit Alemayehu wrote:
> > I have several changes coming to this ioslave. Mainly I am going to 
> > implement the copyFrom and copyTo optimizations like I did for the sftp 
> > ioslave and add support for upload/download resumptions. The changes are 
> > going to come in parts because they are not small and should be done in the 
> > next week or two. 
> > 
> > If you feel that it would be easier to merge those changes after your port, 
> > then feel free to ship this, otherwise would it be possible for you to hold 
> > off on this port? For the record I am not the maintainer of this code base. 
> > I am just trying to improve as many of these ioslaves as I can when I get 
> > the chance.
> 
> Mark Gaiser wrote:
> Question though: did you test this port and did it work for you?
> 
> As for the porting and your changes. You seem to be making those changes 
> in KDE/4.11, not in frameworks-scratch, so i would prefer if you make the 
> changes you want to make. Once those are in i will have to rebase my changes 
> against it and request a "ship it" again :)

I cannot test it because I am not setup for KF5. I just went through the code.


- Dawit


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112463/#review39463
---


On Sept. 2, 2013, 7:16 p.m., Mark Gaiser wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112463/
> ---
> 
> (Updated Sept. 2, 2013, 7:16 p.m.)
> 
> 
> Review request for KDE Runtime and KDE Frameworks.
> 
> 
> Description
> ---
> 
> This is the initial port! I added two TODO lines in the diff for parts where 
> i'm not sure if I've ported them correctly.
> Also, i needed a change in FindSamba.cmake to even get the samba detection 
> working. That reviewrequest is waiting here: 
> https://git.reviewboard.kde.org/r/112448/ you're probably OK if you still use 
> samba 3.x
> 
> Once i know that this is actually working then i will comment some qDebug 
> lines.
> 
> 
> Diffs
> -
> 
>   kioslave/CMakeLists.txt ff66ab6 
>   kioslave/smb/CMakeLists.txt a3a2265 
>   kioslave/smb/kio_smb.h 55efb44 
>   kioslave/smb/kio_smb.cpp 2c2523a 
>   kioslave/smb/kio_smb_auth.cpp 4d236b4 
>   kioslave/smb/kio_smb_browse.cpp fec6449 
>   kioslave/smb/kio_smb_config.cpp 81ce29c 
>   kioslave/smb/kio_smb_dir.cpp 5573266 
>   kioslave/smb/kio_smb_file.cpp 827a519 
>   kioslave/smb/kio_smb_internal.h b895b81 
>   kioslave/smb/kio_smb_internal.cpp 3c35583 
>   kioslave/smb/kio_smb_mount.cpp a5a7e8e 
> 
> Diff: http://git.reviewboard.kde.org/r/112463/diff/
> 
> 
> Testing
> ---
> 
> It compiles and gets loaded just fine. I tried testing this on an actual 
> samba share, but i kept getting a 111 error (connection refused) from kio_smb 
> so i'm hoping that is a local issue here. If someone else could try this out 
> and verify that it's either working or broken.
> 
> 
> Thanks,
> 
> Mark Gaiser
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel