Re: Review Request 112919: Prepare KParts for the move

2013-09-25 Thread David Edmundson

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112919/#review40740
---

Ship it!


One thing to fix


kparts/CMakeLists.txt
http://git.reviewboard.kde.org/r/112919/#comment29973

nope.
KPARTS



- David Edmundson


On Sept. 24, 2013, 5:21 p.m., Aleix Pol Gonzalez wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/112919/
 ---
 
 (Updated Sept. 24, 2013, 5:21 p.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Description
 ---
 
 Moved all sources to src.
 Installs a KPartsConfig.cmake file.
 Documented dependencies.
 
 
 Diffs
 -
 
   kparts/CMakeLists.txt cae8539 
   kparts/KPartsConfig.cmake.in PRE-CREATION 
   kparts/browserextension.h  
   kparts/browserextension.cpp  
   kparts/browserinterface.h  
   kparts/browserinterface.cpp  
   kparts/browseropenorsavequestion.h  
   kparts/browseropenorsavequestion.cpp  
   kparts/browserrun.h  
   kparts/browserrun.cpp  
   kparts/browserrun_p.h  
   kparts/browserview.desktop  
   kparts/event.h  
   kparts/event.cpp  
   kparts/fileinfoextension.h  
   kparts/fileinfoextension.cpp  
   kparts/historyprovider.h  
   kparts/historyprovider.cpp  
   kparts/htmlextension.h  
   kparts/htmlextension.cpp  
   kparts/kpart.desktop  
   kparts/krop.desktop  
   kparts/krwp.desktop  
   kparts/listingextension.h  
   kparts/listingextension.cpp  
   kparts/mainwindow.h  
   kparts/mainwindow.cpp  
   kparts/part.h 3a8a56d 
   kparts/part.cpp  
   kparts/partmanager.h  
   kparts/partmanager.cpp  
   kparts/plugin.h  
   kparts/plugin.cpp  
   kparts/scriptableextension.h  
   kparts/scriptableextension.cpp  
   kparts/scriptableextension_p.h  
   kparts/src/CMakeLists.txt PRE-CREATION 
   kparts/statusbarextension.h  
   kparts/statusbarextension.cpp  
   kparts/textextension.h  
   kparts/textextension.cpp  
   staging/kde4support/src/CMakeLists.txt 5dc206d 
 
 Diff: http://git.reviewboard.kde.org/r/112919/diff/
 
 
 Testing
 ---
 
 builds, tests pass.
 
 
 Thanks,
 
 Aleix Pol Gonzalez
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 112919: Prepare KParts for the move

2013-09-25 Thread Commit Hook

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112919/#review40768
---


This review has been submitted with commit 
9697ef3985110aa6ae7dca32f84c248b1605f5cd by Aleix Pol to branch frameworks.

- Commit Hook


On Sept. 24, 2013, 5:21 p.m., Aleix Pol Gonzalez wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/112919/
 ---
 
 (Updated Sept. 24, 2013, 5:21 p.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Description
 ---
 
 Moved all sources to src.
 Installs a KPartsConfig.cmake file.
 Documented dependencies.
 
 
 Diffs
 -
 
   kparts/CMakeLists.txt cae8539 
   kparts/KPartsConfig.cmake.in PRE-CREATION 
   kparts/browserextension.h  
   kparts/browserextension.cpp  
   kparts/browserinterface.h  
   kparts/browserinterface.cpp  
   kparts/browseropenorsavequestion.h  
   kparts/browseropenorsavequestion.cpp  
   kparts/browserrun.h  
   kparts/browserrun.cpp  
   kparts/browserrun_p.h  
   kparts/browserview.desktop  
   kparts/event.h  
   kparts/event.cpp  
   kparts/fileinfoextension.h  
   kparts/fileinfoextension.cpp  
   kparts/historyprovider.h  
   kparts/historyprovider.cpp  
   kparts/htmlextension.h  
   kparts/htmlextension.cpp  
   kparts/kpart.desktop  
   kparts/krop.desktop  
   kparts/krwp.desktop  
   kparts/listingextension.h  
   kparts/listingextension.cpp  
   kparts/mainwindow.h  
   kparts/mainwindow.cpp  
   kparts/part.h 3a8a56d 
   kparts/part.cpp  
   kparts/partmanager.h  
   kparts/partmanager.cpp  
   kparts/plugin.h  
   kparts/plugin.cpp  
   kparts/scriptableextension.h  
   kparts/scriptableextension.cpp  
   kparts/scriptableextension_p.h  
   kparts/src/CMakeLists.txt PRE-CREATION 
   kparts/statusbarextension.h  
   kparts/statusbarextension.cpp  
   kparts/textextension.h  
   kparts/textextension.cpp  
   staging/kde4support/src/CMakeLists.txt 5dc206d 
 
 Diff: http://git.reviewboard.kde.org/r/112919/diff/
 
 
 Testing
 ---
 
 builds, tests pass.
 
 
 Thanks,
 
 Aleix Pol Gonzalez
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 112919: Prepare KParts for the move

2013-09-25 Thread Commit Hook

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112919/
---

(Updated Sept. 25, 2013, 3:11 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Description
---

Moved all sources to src.
Installs a KPartsConfig.cmake file.
Documented dependencies.


Diffs
-

  kparts/CMakeLists.txt cae8539 
  kparts/KPartsConfig.cmake.in PRE-CREATION 
  kparts/browserextension.h  
  kparts/browserextension.cpp  
  kparts/browserinterface.h  
  kparts/browserinterface.cpp  
  kparts/browseropenorsavequestion.h  
  kparts/browseropenorsavequestion.cpp  
  kparts/browserrun.h  
  kparts/browserrun.cpp  
  kparts/browserrun_p.h  
  kparts/browserview.desktop  
  kparts/event.h  
  kparts/event.cpp  
  kparts/fileinfoextension.h  
  kparts/fileinfoextension.cpp  
  kparts/historyprovider.h  
  kparts/historyprovider.cpp  
  kparts/htmlextension.h  
  kparts/htmlextension.cpp  
  kparts/kpart.desktop  
  kparts/krop.desktop  
  kparts/krwp.desktop  
  kparts/listingextension.h  
  kparts/listingextension.cpp  
  kparts/mainwindow.h  
  kparts/mainwindow.cpp  
  kparts/part.h 3a8a56d 
  kparts/part.cpp  
  kparts/partmanager.h  
  kparts/partmanager.cpp  
  kparts/plugin.h  
  kparts/plugin.cpp  
  kparts/scriptableextension.h  
  kparts/scriptableextension.cpp  
  kparts/scriptableextension_p.h  
  kparts/src/CMakeLists.txt PRE-CREATION 
  kparts/statusbarextension.h  
  kparts/statusbarextension.cpp  
  kparts/textextension.h  
  kparts/textextension.cpp  
  staging/kde4support/src/CMakeLists.txt 5dc206d 

Diff: http://git.reviewboard.kde.org/r/112919/diff/


Testing
---

builds, tests pass.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Review Request 112919: Prepare KParts for the move

2013-09-24 Thread Aleix Pol Gonzalez

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112919/
---

Review request for KDE Frameworks.


Description
---

Moved all sources to src.
Installs a KPartsConfig.cmake file.
Documented dependencies.


Diffs
-

  kparts/CMakeLists.txt cae8539 
  kparts/KPartsConfig.cmake.in PRE-CREATION 
  kparts/browserextension.h  
  kparts/browserextension.cpp  
  kparts/browserinterface.h  
  kparts/browserinterface.cpp  
  kparts/browseropenorsavequestion.h  
  kparts/browseropenorsavequestion.cpp  
  kparts/browserrun.h  
  kparts/browserrun.cpp  
  kparts/browserrun_p.h  
  kparts/browserview.desktop  
  kparts/event.h  
  kparts/event.cpp  
  kparts/fileinfoextension.h  
  kparts/fileinfoextension.cpp  
  kparts/historyprovider.h  
  kparts/historyprovider.cpp  
  kparts/htmlextension.h  
  kparts/htmlextension.cpp  
  kparts/kpart.desktop  
  kparts/krop.desktop  
  kparts/krwp.desktop  
  kparts/listingextension.h  
  kparts/listingextension.cpp  
  kparts/mainwindow.h  
  kparts/mainwindow.cpp  
  kparts/part.h 3a8a56d 
  kparts/part.cpp  
  kparts/partmanager.h  
  kparts/partmanager.cpp  
  kparts/plugin.h  
  kparts/plugin.cpp  
  kparts/scriptableextension.h  
  kparts/scriptableextension.cpp  
  kparts/scriptableextension_p.h  
  kparts/src/CMakeLists.txt PRE-CREATION 
  kparts/statusbarextension.h  
  kparts/statusbarextension.cpp  
  kparts/textextension.h  
  kparts/textextension.cpp  
  staging/kde4support/src/CMakeLists.txt 5dc206d 

Diff: http://git.reviewboard.kde.org/r/112919/diff/


Testing
---

builds, tests pass.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel