Re: Review Request 113155: Port all kde4_add_unit_test uses

2013-10-29 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113155/
---

(Updated Oct. 29, 2013, 8:46 a.m.)


Status
--

This change has been discarded.


Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Stop using kde4_add_unit_test.

One step less towards no kde4_* uses.


Diffs
-

  kded/tests/CMakeLists.txt ca392d2 
  kfile/tests/CMakeLists.txt d28d642 
  khtml/tests/CMakeLists.txt 59a0a56 
  kio/tests/CMakeLists.txt a60eac0 
  kioslave/http/kcookiejar/tests/CMakeLists.txt cb67f26 
  kioslave/http/tests/CMakeLists.txt 000c488 

Diff: http://git.reviewboard.kde.org/r/113155/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113155: Port all kde4_add_unit_test uses

2013-10-29 Thread Kevin Ottens 


> On Oct. 21, 2013, 11:23 a.m., Kevin Ottens wrote:
> > Any chance to see Alexander comments addressed?

Any news? Is it abandoned?


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113155/#review42070
---


On Oct. 10, 2013, 6:08 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113155/
> ---
> 
> (Updated Oct. 10, 2013, 6:08 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Stop using kde4_add_unit_test.
> 
> One step less towards no kde4_* uses.
> 
> 
> Diffs
> -
> 
>   kded/tests/CMakeLists.txt ca392d2 
>   kfile/tests/CMakeLists.txt d28d642 
>   khtml/tests/CMakeLists.txt 59a0a56 
>   kio/tests/CMakeLists.txt a60eac0 
>   kioslave/http/kcookiejar/tests/CMakeLists.txt cb67f26 
>   kioslave/http/tests/CMakeLists.txt 000c488 
> 
> Diff: http://git.reviewboard.kde.org/r/113155/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113155: Port all kde4_add_unit_test uses

2013-10-21 Thread Kevin Ottens 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113155/#review42070
---


Any chance to see Alexander comments addressed?

- Kevin Ottens


On Oct. 10, 2013, 6:08 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113155/
> ---
> 
> (Updated Oct. 10, 2013, 6:08 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Stop using kde4_add_unit_test.
> 
> One step less towards no kde4_* uses.
> 
> 
> Diffs
> -
> 
>   kded/tests/CMakeLists.txt ca392d2 
>   kfile/tests/CMakeLists.txt d28d642 
>   khtml/tests/CMakeLists.txt 59a0a56 
>   kio/tests/CMakeLists.txt a60eac0 
>   kioslave/http/kcookiejar/tests/CMakeLists.txt cb67f26 
>   kioslave/http/tests/CMakeLists.txt 000c488 
> 
> Diff: http://git.reviewboard.kde.org/r/113155/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113155: Port all kde4_add_unit_test uses

2013-10-10 Thread Alexander Richardson 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113155/#review41535
---



kfile/tests/CMakeLists.txt


ecm_add_tests expects the source file to be passed (i.e. 
kurlnavigatortest.cpp)



kio/tests/CMakeLists.txt


same here



kioslave/http/tests/CMakeLists.txt


same


- Alexander Richardson


On Oct. 10, 2013, 8:08 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113155/
> ---
> 
> (Updated Oct. 10, 2013, 8:08 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Stop using kde4_add_unit_test.
> 
> One step less towards no kde4_* uses.
> 
> 
> Diffs
> -
> 
>   kded/tests/CMakeLists.txt ca392d2 
>   kfile/tests/CMakeLists.txt d28d642 
>   khtml/tests/CMakeLists.txt 59a0a56 
>   kio/tests/CMakeLists.txt a60eac0 
>   kioslave/http/kcookiejar/tests/CMakeLists.txt cb67f26 
>   kioslave/http/tests/CMakeLists.txt 000c488 
> 
> Diff: http://git.reviewboard.kde.org/r/113155/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113155: Port all kde4_add_unit_test uses

2013-10-10 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113155/
---

(Updated Oct. 10, 2013, 6:08 p.m.)


Review request for KDE Frameworks.


Changes
---

Ping!

Rebase to frameworks branch.


Repository: kdelibs


Description
---

Stop using kde4_add_unit_test.

One step less towards no kde4_* uses.


Diffs (updated)
-

  kded/tests/CMakeLists.txt ca392d2 
  kfile/tests/CMakeLists.txt d28d642 
  khtml/tests/CMakeLists.txt 59a0a56 
  kio/tests/CMakeLists.txt a60eac0 
  kioslave/http/kcookiejar/tests/CMakeLists.txt cb67f26 
  kioslave/http/tests/CMakeLists.txt 000c488 

Diff: http://git.reviewboard.kde.org/r/113155/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113155: Port all kde4_add_unit_test uses

2013-10-07 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113155/
---

Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Stop using kde4_add_unit_test.

One step less towards no kde4_* uses.


Diffs
-

  kded/tests/CMakeLists.txt ca392d2 
  kfile/tests/CMakeLists.txt d28d642 
  khtml/tests/CMakeLists.txt 0a404d5 
  kio/tests/CMakeLists.txt a60eac0 
  kioslave/http/kcookiejar/tests/CMakeLists.txt cb67f26 
  kioslave/http/tests/CMakeLists.txt 000c488 

Diff: http://git.reviewboard.kde.org/r/113155/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel