Review Request 113160: Move KDeclarative to tier3
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113160/ --- Review request for KDE Frameworks. Repository: kdelibs Description --- Moves KDeclarative to tier3 Also trim down the test so that it uses the module but it doesn't use something from upstream (such as plasma components) Diffs - tier3/CMakeLists.txt 11be8e4 staging/kdeclarative/tests/testobject_p.h staging/kdeclarative/tests/test.qml 060c265 staging/kdeclarative/tests/kdeclarativetest.cpp d5b9f96 staging/kdeclarative/tests/CMakeLists.txt ad4a7db staging/kdeclarative/src/qmlobject_p.h staging/kdeclarative/src/qmlobject.cpp staging/kdeclarative/src/qmlobject.h staging/kdeclarative/src/private/rootcontext_p.h staging/kdeclarative/src/private/rootcontext.cpp staging/kdeclarative/src/private/kiconprovider_p.h staging/kdeclarative/src/private/kiconprovider.cpp staging/kdeclarative/src/private/kdeclarative_p.h staging/kdeclarative/src/kdeclarative.cpp staging/kdeclarative/src/kdeclarative.h staging/kdeclarative/src/configpropertymap.cpp staging/kdeclarative/src/configpropertymap.h staging/kdeclarative/src/bindings/url.cpp staging/kdeclarative/src/bindings/qscriptnonguibookkeeping.cpp staging/kdeclarative/src/bindings/icon.cpp staging/kdeclarative/src/bindings/i18n_p.h staging/kdeclarative/src/bindings/i18n.cpp staging/kdeclarative/src/bindings/backportglobal.h staging/kdeclarative/src/CMakeLists.txt staging/kdeclarative/KDeclarativeConfig.cmake.in staging/kdeclarative/CMakeLists.txt eefa756 staging/CMakeLists.txt 4f64e8a tier3/kdeclarative/tests/CMakeLists.txt PRE-CREATION tier3/kdeclarative/tests/test.qml PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113160/diff/ Testing --- the test starts and seems to work. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113160: Move KDeclarative to tier3
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113160/#review41440 --- Ship it! Code looks fine. reviewboard-am doesn't apply cleanly (possibly as it moves a file). Check it all builds from a clean slate - remember to update ECM too. - David Edmundson On Oct. 7, 2013, 6:18 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113160/ > --- > > (Updated Oct. 7, 2013, 6:18 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > --- > > Moves KDeclarative to tier3 > > Also trim down the test so that it uses the module but it doesn't use > something from upstream (such as plasma components) > > > Diffs > - > > tier3/CMakeLists.txt 11be8e4 > staging/kdeclarative/tests/testobject_p.h > staging/kdeclarative/tests/test.qml 060c265 > staging/kdeclarative/tests/kdeclarativetest.cpp d5b9f96 > staging/kdeclarative/tests/CMakeLists.txt ad4a7db > staging/kdeclarative/src/qmlobject_p.h > staging/kdeclarative/src/qmlobject.cpp > staging/kdeclarative/src/qmlobject.h > staging/kdeclarative/src/private/rootcontext_p.h > staging/kdeclarative/src/private/rootcontext.cpp > staging/kdeclarative/src/private/kiconprovider_p.h > staging/kdeclarative/src/private/kiconprovider.cpp > staging/kdeclarative/src/private/kdeclarative_p.h > staging/kdeclarative/src/kdeclarative.cpp > staging/kdeclarative/src/kdeclarative.h > staging/kdeclarative/src/configpropertymap.cpp > staging/kdeclarative/src/configpropertymap.h > staging/kdeclarative/src/bindings/url.cpp > staging/kdeclarative/src/bindings/qscriptnonguibookkeeping.cpp > staging/kdeclarative/src/bindings/icon.cpp > staging/kdeclarative/src/bindings/i18n_p.h > staging/kdeclarative/src/bindings/i18n.cpp > staging/kdeclarative/src/bindings/backportglobal.h > staging/kdeclarative/src/CMakeLists.txt > staging/kdeclarative/KDeclarativeConfig.cmake.in > staging/kdeclarative/CMakeLists.txt eefa756 > staging/CMakeLists.txt 4f64e8a > tier3/kdeclarative/tests/CMakeLists.txt PRE-CREATION > tier3/kdeclarative/tests/test.qml PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/113160/diff/ > > > Testing > --- > > the test starts and seems to work. > > > Thanks, > > Aleix Pol Gonzalez > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113160: Move KDeclarative to tier3
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113160/#review41465 --- This review has been submitted with commit b986e512054c3a9423226bb26863911a69aafc98 by Aleix Pol to branch frameworks. - Commit Hook On Oct. 7, 2013, 6:18 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113160/ > --- > > (Updated Oct. 7, 2013, 6:18 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > --- > > Moves KDeclarative to tier3 > > Also trim down the test so that it uses the module but it doesn't use > something from upstream (such as plasma components) > > > Diffs > - > > tier3/CMakeLists.txt 11be8e4 > staging/kdeclarative/tests/testobject_p.h > staging/kdeclarative/tests/test.qml 060c265 > staging/kdeclarative/tests/kdeclarativetest.cpp d5b9f96 > staging/kdeclarative/tests/CMakeLists.txt ad4a7db > staging/kdeclarative/src/qmlobject_p.h > staging/kdeclarative/src/qmlobject.cpp > staging/kdeclarative/src/qmlobject.h > staging/kdeclarative/src/private/rootcontext_p.h > staging/kdeclarative/src/private/rootcontext.cpp > staging/kdeclarative/src/private/kiconprovider_p.h > staging/kdeclarative/src/private/kiconprovider.cpp > staging/kdeclarative/src/private/kdeclarative_p.h > staging/kdeclarative/src/kdeclarative.cpp > staging/kdeclarative/src/kdeclarative.h > staging/kdeclarative/src/configpropertymap.cpp > staging/kdeclarative/src/configpropertymap.h > staging/kdeclarative/src/bindings/url.cpp > staging/kdeclarative/src/bindings/qscriptnonguibookkeeping.cpp > staging/kdeclarative/src/bindings/icon.cpp > staging/kdeclarative/src/bindings/i18n_p.h > staging/kdeclarative/src/bindings/i18n.cpp > staging/kdeclarative/src/bindings/backportglobal.h > staging/kdeclarative/src/CMakeLists.txt > staging/kdeclarative/KDeclarativeConfig.cmake.in > staging/kdeclarative/CMakeLists.txt eefa756 > staging/CMakeLists.txt 4f64e8a > tier3/kdeclarative/tests/CMakeLists.txt PRE-CREATION > tier3/kdeclarative/tests/test.qml PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/113160/diff/ > > > Testing > --- > > the test starts and seems to work. > > > Thanks, > > Aleix Pol Gonzalez > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113160: Move KDeclarative to tier3
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113160/ --- (Updated Oct. 9, 2013, 6:30 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- Moves KDeclarative to tier3 Also trim down the test so that it uses the module but it doesn't use something from upstream (such as plasma components) Diffs - tier3/CMakeLists.txt 11be8e4 staging/kdeclarative/tests/testobject_p.h staging/kdeclarative/tests/test.qml 060c265 staging/kdeclarative/tests/kdeclarativetest.cpp d5b9f96 staging/kdeclarative/tests/CMakeLists.txt ad4a7db staging/kdeclarative/src/qmlobject_p.h staging/kdeclarative/src/qmlobject.cpp staging/kdeclarative/src/qmlobject.h staging/kdeclarative/src/private/rootcontext_p.h staging/kdeclarative/src/private/rootcontext.cpp staging/kdeclarative/src/private/kiconprovider_p.h staging/kdeclarative/src/private/kiconprovider.cpp staging/kdeclarative/src/private/kdeclarative_p.h staging/kdeclarative/src/kdeclarative.cpp staging/kdeclarative/src/kdeclarative.h staging/kdeclarative/src/configpropertymap.cpp staging/kdeclarative/src/configpropertymap.h staging/kdeclarative/src/bindings/url.cpp staging/kdeclarative/src/bindings/qscriptnonguibookkeeping.cpp staging/kdeclarative/src/bindings/icon.cpp staging/kdeclarative/src/bindings/i18n_p.h staging/kdeclarative/src/bindings/i18n.cpp staging/kdeclarative/src/bindings/backportglobal.h staging/kdeclarative/src/CMakeLists.txt staging/kdeclarative/KDeclarativeConfig.cmake.in staging/kdeclarative/CMakeLists.txt eefa756 staging/CMakeLists.txt 4f64e8a tier3/kdeclarative/tests/CMakeLists.txt PRE-CREATION tier3/kdeclarative/tests/test.qml PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113160/diff/ Testing --- the test starts and seems to work. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
