Review Request 113206: Make KIconLoader a bit less fragile

2013-10-11 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113206/
---

Review request for KDE Frameworks.


Repository: kdelibs


Description
---

KIconLoaderPrivate::_k_refreshIcons was calling KIconLoader::reconfigure that 
would delete the d-pointer.

This patch makes it so instead of deleting it, it will clear the values and 
initialize them again instead.


Diffs
-

  tier3/kiconthemes/src/kiconloader.cpp bf3899a 

Diff: http://git.reviewboard.kde.org/r/113206/diff/


Testing
---

Makes ktoolbartest pass (and valgrind-proof)


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113206: Make KIconLoader a bit less fragile

2013-10-11 Thread Àlex Fiestas 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113206/#review41569
---

Ship it!


When I touched this code I was tempted of doing exactly this, but I applied the 
"If it works don't touch it".

Since apparently it does NOT work, it seems that this change is required after 
all :p.


tier3/kiconthemes/src/kiconloader.cpp


Trailing space


- Àlex Fiestas


On Oct. 11, 2013, 5:54 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113206/
> ---
> 
> (Updated Oct. 11, 2013, 5:54 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> KIconLoaderPrivate::_k_refreshIcons was calling KIconLoader::reconfigure that 
> would delete the d-pointer.
> 
> This patch makes it so instead of deleting it, it will clear the values and 
> initialize them again instead.
> 
> 
> Diffs
> -
> 
>   tier3/kiconthemes/src/kiconloader.cpp bf3899a 
> 
> Diff: http://git.reviewboard.kde.org/r/113206/diff/
> 
> 
> Testing
> ---
> 
> Makes ktoolbartest pass (and valgrind-proof)
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113206: Make KIconLoader a bit less fragile

2013-10-11 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113206/
---

(Updated Oct. 11, 2013, 6:07 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kdelibs


Description
---

KIconLoaderPrivate::_k_refreshIcons was calling KIconLoader::reconfigure that 
would delete the d-pointer.

This patch makes it so instead of deleting it, it will clear the values and 
initialize them again instead.


Diffs
-

  tier3/kiconthemes/src/kiconloader.cpp bf3899a 

Diff: http://git.reviewboard.kde.org/r/113206/diff/


Testing
---

Makes ktoolbartest pass (and valgrind-proof)


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel