Review Request 113237: Move KInit to tier3

2013-10-14 Thread Aleix Pol Gonzalez

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113237/
---

Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Moves KInit to tier3


Diffs
-

  CMakeLists.txt 17c3090 
  staging/CMakeLists.txt a3bfaab 
  staging/kinit/CMakeLists.txt  
  staging/kinit/ConfigureChecks.cmake  
  staging/kinit/Info.plist.template  
  staging/kinit/KInitConfig.cmake  
  staging/kinit/KInitMacros.cmake 67d24dd 
  staging/kinit/Mainpage.dox  
  staging/kinit/README  
  staging/kinit/README.autostart  
  staging/kinit/README.wrapper  
  staging/kinit/kde5init_dummy.cpp.in  
  staging/kinit/kde5init_win32lib_dummy.cpp.in  
  staging/kinit/src/CMakeLists.txt 12d1590 
  staging/kinit/src/config-kdeinit.h.cmake  
  staging/kinit/src/kdeinit/CMakeLists.txt  
  staging/kinit/src/kdeinit/kinit.cpp  
  staging/kinit/src/kdeinit/kinit_win.cpp  
  staging/kinit/src/kdeinit/proctitle.h  
  staging/kinit/src/kdeinit/proctitle.cpp  
  staging/kinit/src/kioslave/CMakeLists.txt  
  staging/kinit/src/kioslave/kioslave.cpp  
  staging/kinit/src/klauncher/CMakeLists.txt  
  staging/kinit/src/klauncher/autostart.h  
  staging/kinit/src/klauncher/autostart.cpp  
  staging/kinit/src/klauncher/klauncher.h  
  staging/kinit/src/klauncher/klauncher.cpp  
  staging/kinit/src/klauncher/klauncher_adaptor.h  
  staging/kinit/src/klauncher/klauncher_adaptor.cpp  
  staging/kinit/src/klauncher/klauncher_main.cpp  
  staging/kinit/src/klauncher_cmds.h  
  staging/kinit/src/klauncher_cmds.cpp  
  staging/kinit/src/kshell/CMakeLists.txt  
  staging/kinit/src/kshell/shell.cpp  
  staging/kinit/src/kwrapper/CMakeLists.txt  
  staging/kinit/src/kwrapper/kwrapper.cpp  
  staging/kinit/src/kwrapper/kwrapper_win.cpp  
  staging/kinit/src/start_kdeinit/CMakeLists.txt  
  staging/kinit/src/start_kdeinit/start_kdeinit.c  
  staging/kinit/src/start_kdeinit/start_kdeinit_wrapper.c  
  staging/kinit/src/wrapper.cpp  
  tier3/CMakeLists.txt 4f5c1c8 

Diff: http://git.reviewboard.kde.org/r/113237/diff/


Testing
---

Builds, tests pass.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 113237: Move KInit to tier3

2013-10-14 Thread Àlex Fiestas

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113237/#review41736
---

Ship it!


No test is breaking because of the patch, it looks good so please ship it.

- Àlex Fiestas


On Oct. 14, 2013, 11:12 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113237/
> ---
> 
> (Updated Oct. 14, 2013, 11:12 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Moves KInit to tier3
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 17c3090 
>   staging/CMakeLists.txt a3bfaab 
>   staging/kinit/CMakeLists.txt  
>   staging/kinit/ConfigureChecks.cmake  
>   staging/kinit/Info.plist.template  
>   staging/kinit/KInitConfig.cmake  
>   staging/kinit/KInitMacros.cmake 67d24dd 
>   staging/kinit/Mainpage.dox  
>   staging/kinit/README  
>   staging/kinit/README.autostart  
>   staging/kinit/README.wrapper  
>   staging/kinit/kde5init_dummy.cpp.in  
>   staging/kinit/kde5init_win32lib_dummy.cpp.in  
>   staging/kinit/src/CMakeLists.txt 12d1590 
>   staging/kinit/src/config-kdeinit.h.cmake  
>   staging/kinit/src/kdeinit/CMakeLists.txt  
>   staging/kinit/src/kdeinit/kinit.cpp  
>   staging/kinit/src/kdeinit/kinit_win.cpp  
>   staging/kinit/src/kdeinit/proctitle.h  
>   staging/kinit/src/kdeinit/proctitle.cpp  
>   staging/kinit/src/kioslave/CMakeLists.txt  
>   staging/kinit/src/kioslave/kioslave.cpp  
>   staging/kinit/src/klauncher/CMakeLists.txt  
>   staging/kinit/src/klauncher/autostart.h  
>   staging/kinit/src/klauncher/autostart.cpp  
>   staging/kinit/src/klauncher/klauncher.h  
>   staging/kinit/src/klauncher/klauncher.cpp  
>   staging/kinit/src/klauncher/klauncher_adaptor.h  
>   staging/kinit/src/klauncher/klauncher_adaptor.cpp  
>   staging/kinit/src/klauncher/klauncher_main.cpp  
>   staging/kinit/src/klauncher_cmds.h  
>   staging/kinit/src/klauncher_cmds.cpp  
>   staging/kinit/src/kshell/CMakeLists.txt  
>   staging/kinit/src/kshell/shell.cpp  
>   staging/kinit/src/kwrapper/CMakeLists.txt  
>   staging/kinit/src/kwrapper/kwrapper.cpp  
>   staging/kinit/src/kwrapper/kwrapper_win.cpp  
>   staging/kinit/src/start_kdeinit/CMakeLists.txt  
>   staging/kinit/src/start_kdeinit/start_kdeinit.c  
>   staging/kinit/src/start_kdeinit/start_kdeinit_wrapper.c  
>   staging/kinit/src/wrapper.cpp  
>   tier3/CMakeLists.txt 4f5c1c8 
> 
> Diff: http://git.reviewboard.kde.org/r/113237/diff/
> 
> 
> Testing
> ---
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 113237: Move KInit to tier3

2013-10-14 Thread Commit Hook

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113237/#review41740
---


This review has been submitted with commit 
bc43c8b20d21d6c06c61bea999a36b8c4e31ba7c by Aleix Pol to branch frameworks.

- Commit Hook


On Oct. 14, 2013, 11:12 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113237/
> ---
> 
> (Updated Oct. 14, 2013, 11:12 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Moves KInit to tier3
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 17c3090 
>   staging/CMakeLists.txt a3bfaab 
>   staging/kinit/CMakeLists.txt  
>   staging/kinit/ConfigureChecks.cmake  
>   staging/kinit/Info.plist.template  
>   staging/kinit/KInitConfig.cmake  
>   staging/kinit/KInitMacros.cmake 67d24dd 
>   staging/kinit/Mainpage.dox  
>   staging/kinit/README  
>   staging/kinit/README.autostart  
>   staging/kinit/README.wrapper  
>   staging/kinit/kde5init_dummy.cpp.in  
>   staging/kinit/kde5init_win32lib_dummy.cpp.in  
>   staging/kinit/src/CMakeLists.txt 12d1590 
>   staging/kinit/src/config-kdeinit.h.cmake  
>   staging/kinit/src/kdeinit/CMakeLists.txt  
>   staging/kinit/src/kdeinit/kinit.cpp  
>   staging/kinit/src/kdeinit/kinit_win.cpp  
>   staging/kinit/src/kdeinit/proctitle.h  
>   staging/kinit/src/kdeinit/proctitle.cpp  
>   staging/kinit/src/kioslave/CMakeLists.txt  
>   staging/kinit/src/kioslave/kioslave.cpp  
>   staging/kinit/src/klauncher/CMakeLists.txt  
>   staging/kinit/src/klauncher/autostart.h  
>   staging/kinit/src/klauncher/autostart.cpp  
>   staging/kinit/src/klauncher/klauncher.h  
>   staging/kinit/src/klauncher/klauncher.cpp  
>   staging/kinit/src/klauncher/klauncher_adaptor.h  
>   staging/kinit/src/klauncher/klauncher_adaptor.cpp  
>   staging/kinit/src/klauncher/klauncher_main.cpp  
>   staging/kinit/src/klauncher_cmds.h  
>   staging/kinit/src/klauncher_cmds.cpp  
>   staging/kinit/src/kshell/CMakeLists.txt  
>   staging/kinit/src/kshell/shell.cpp  
>   staging/kinit/src/kwrapper/CMakeLists.txt  
>   staging/kinit/src/kwrapper/kwrapper.cpp  
>   staging/kinit/src/kwrapper/kwrapper_win.cpp  
>   staging/kinit/src/start_kdeinit/CMakeLists.txt  
>   staging/kinit/src/start_kdeinit/start_kdeinit.c  
>   staging/kinit/src/start_kdeinit/start_kdeinit_wrapper.c  
>   staging/kinit/src/wrapper.cpp  
>   tier3/CMakeLists.txt 4f5c1c8 
> 
> Diff: http://git.reviewboard.kde.org/r/113237/diff/
> 
> 
> Testing
> ---
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 113237: Move KInit to tier3

2013-10-14 Thread Aleix Pol Gonzalez

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113237/
---

(Updated Oct. 14, 2013, 4:15 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Moves KInit to tier3


Diffs
-

  CMakeLists.txt 17c3090 
  staging/CMakeLists.txt a3bfaab 
  staging/kinit/CMakeLists.txt  
  staging/kinit/ConfigureChecks.cmake  
  staging/kinit/Info.plist.template  
  staging/kinit/KInitConfig.cmake  
  staging/kinit/KInitMacros.cmake 67d24dd 
  staging/kinit/Mainpage.dox  
  staging/kinit/README  
  staging/kinit/README.autostart  
  staging/kinit/README.wrapper  
  staging/kinit/kde5init_dummy.cpp.in  
  staging/kinit/kde5init_win32lib_dummy.cpp.in  
  staging/kinit/src/CMakeLists.txt 12d1590 
  staging/kinit/src/config-kdeinit.h.cmake  
  staging/kinit/src/kdeinit/CMakeLists.txt  
  staging/kinit/src/kdeinit/kinit.cpp  
  staging/kinit/src/kdeinit/kinit_win.cpp  
  staging/kinit/src/kdeinit/proctitle.h  
  staging/kinit/src/kdeinit/proctitle.cpp  
  staging/kinit/src/kioslave/CMakeLists.txt  
  staging/kinit/src/kioslave/kioslave.cpp  
  staging/kinit/src/klauncher/CMakeLists.txt  
  staging/kinit/src/klauncher/autostart.h  
  staging/kinit/src/klauncher/autostart.cpp  
  staging/kinit/src/klauncher/klauncher.h  
  staging/kinit/src/klauncher/klauncher.cpp  
  staging/kinit/src/klauncher/klauncher_adaptor.h  
  staging/kinit/src/klauncher/klauncher_adaptor.cpp  
  staging/kinit/src/klauncher/klauncher_main.cpp  
  staging/kinit/src/klauncher_cmds.h  
  staging/kinit/src/klauncher_cmds.cpp  
  staging/kinit/src/kshell/CMakeLists.txt  
  staging/kinit/src/kshell/shell.cpp  
  staging/kinit/src/kwrapper/CMakeLists.txt  
  staging/kinit/src/kwrapper/kwrapper.cpp  
  staging/kinit/src/kwrapper/kwrapper_win.cpp  
  staging/kinit/src/start_kdeinit/CMakeLists.txt  
  staging/kinit/src/start_kdeinit/start_kdeinit.c  
  staging/kinit/src/start_kdeinit/start_kdeinit_wrapper.c  
  staging/kinit/src/wrapper.cpp  
  tier3/CMakeLists.txt 4f5c1c8 

Diff: http://git.reviewboard.kde.org/r/113237/diff/


Testing
---

Builds, tests pass.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel