Re: Review Request 113423: Fix KConfigCompiler_Test::testRunning() on Windows

2013-10-28 Thread Alexander Richardson 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113423/
---

(Updated Oct. 28, 2013, 8:32 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Fix KConfigCompiler_Test::testRunning() on Windows

The test expects that the executables to find have no suffix


Diffs
-

  tier1/kconfig/autotests/kconfig_compiler/kconfigcompiler_test.cpp 
7f2697ad94ac6d433d18fb16a99ed1435433547d 

Diff: http://git.reviewboard.kde.org/r/113423/diff/


Testing
---

Test passes.

Although IMO it might make sense to drop this test, it takes ages due to 
spawning all those programs that do nothing useful.
Compiling these generated files to see that they contain no errors is enough.


Thanks,

Alexander Richardson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113423: Fix KConfigCompiler_Test::testRunning() on Windows

2013-10-28 Thread Commit Hook 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113423/#review42556
---


This review has been submitted with commit 
0d44382caa78e3e17db0f917f50cc3a9159bf422 by Alex Richardson to branch 
frameworks.

- Commit Hook


On Oct. 24, 2013, 3:59 p.m., Alexander Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113423/
> ---
> 
> (Updated Oct. 24, 2013, 3:59 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Fix KConfigCompiler_Test::testRunning() on Windows
> 
> The test expects that the executables to find have no suffix
> 
> 
> Diffs
> -
> 
>   tier1/kconfig/autotests/kconfig_compiler/kconfigcompiler_test.cpp 
> 7f2697ad94ac6d433d18fb16a99ed1435433547d 
> 
> Diff: http://git.reviewboard.kde.org/r/113423/diff/
> 
> 
> Testing
> ---
> 
> Test passes.
> 
> Although IMO it might make sense to drop this test, it takes ages due to 
> spawning all those programs that do nothing useful.
> Compiling these generated files to see that they contain no errors is enough.
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113423: Fix KConfigCompiler_Test::testRunning() on Windows

2013-10-24 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113423/#review42298
---

Ship it!


Ship It!


tier1/kconfig/autotests/kconfig_compiler/kconfigcompiler_test.cpp


You can pass CMAKE_EXECUTABLE_SUFFIX from cmake.


- Aleix Pol Gonzalez


On Oct. 24, 2013, 3:59 p.m., Alexander Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113423/
> ---
> 
> (Updated Oct. 24, 2013, 3:59 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Fix KConfigCompiler_Test::testRunning() on Windows
> 
> The test expects that the executables to find have no suffix
> 
> 
> Diffs
> -
> 
>   tier1/kconfig/autotests/kconfig_compiler/kconfigcompiler_test.cpp 
> 7f2697ad94ac6d433d18fb16a99ed1435433547d 
> 
> Diff: http://git.reviewboard.kde.org/r/113423/diff/
> 
> 
> Testing
> ---
> 
> Test passes.
> 
> Although IMO it might make sense to drop this test, it takes ages due to 
> spawning all those programs that do nothing useful.
> Compiling these generated files to see that they contain no errors is enough.
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113423: Fix KConfigCompiler_Test::testRunning() on Windows

2013-10-24 Thread Alexander Richardson 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113423/
---

Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Fix KConfigCompiler_Test::testRunning() on Windows

The test expects that the executables to find have no suffix


Diffs
-

  tier1/kconfig/autotests/kconfig_compiler/kconfigcompiler_test.cpp 
7f2697ad94ac6d433d18fb16a99ed1435433547d 

Diff: http://git.reviewboard.kde.org/r/113423/diff/


Testing
---

Test passes.

Although IMO it might make sense to drop this test, it takes ages due to 
spawning all those programs that do nothing useful.
Compiling these generated files to see that they contain no errors is enough.


Thanks,

Alexander Richardson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel