Re: Review Request 113625: Prepare KHTML for moving into tier4.

2013-11-05 Thread Commit Hook 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113625/#review43064
---


This review has been submitted with commit 
62c3ce73fc99fe588f0e604775d60299959dd479 by David Edmundson to branch 
frameworks.

- Commit Hook


On Nov. 5, 2013, 11:52 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113625/
> ---
> 
> (Updated Nov. 5, 2013, 11:52 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Tidy target_link for KHTML.
> 
> 
> Diffs
> -
> 
>   khtml/src/CMakeLists.txt ed113f5 
>   khtml/src/java/CMakeLists.txt 3dd2d88 
> 
> Diff: http://git.reviewboard.kde.org/r/113625/diff/
> 
> 
> Testing
> ---
> 
> Builds.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113625: Prepare KHTML for moving into tier4.

2013-11-05 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113625/
---

(Updated Nov. 5, 2013, 2:28 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Tidy target_link for KHTML.


Diffs
-

  khtml/src/CMakeLists.txt ed113f5 
  khtml/src/java/CMakeLists.txt 3dd2d88 

Diff: http://git.reviewboard.kde.org/r/113625/diff/


Testing
---

Builds.


Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113625: Prepare KHTML for moving into tier4.

2013-11-05 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113625/#review43050
---

Ship it!


Looks good to me

- Aleix Pol Gonzalez


On Nov. 5, 2013, 11:52 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113625/
> ---
> 
> (Updated Nov. 5, 2013, 11:52 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Tidy target_link for KHTML.
> 
> 
> Diffs
> -
> 
>   khtml/src/CMakeLists.txt ed113f5 
>   khtml/src/java/CMakeLists.txt 3dd2d88 
> 
> Diff: http://git.reviewboard.kde.org/r/113625/diff/
> 
> 
> Testing
> ---
> 
> Builds.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113625: Prepare KHTML for moving into tier4.

2013-11-05 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113625/
---

(Updated Nov. 5, 2013, 11:52 a.m.)


Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Tidy target_link for KHTML.


Diffs (updated)
-

  khtml/src/CMakeLists.txt ed113f5 
  khtml/src/java/CMakeLists.txt 3dd2d88 

Diff: http://git.reviewboard.kde.org/r/113625/diff/


Testing
---

Builds.


Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113625: Prepare KHTML for moving into tier4.

2013-11-04 Thread Martin Klapetek 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113625/#review42979
---



khtml/src/CMakeLists.txt


Super-small-nitpick - this could be merged with the target_link_libraries 
above (the big one) as is the case with other frameworks, makes it more 
readable imho


- Martin Klapetek


On Nov. 4, 2013, 6:13 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113625/
> ---
> 
> (Updated Nov. 4, 2013, 6:13 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Tidy target_link for KHTML.
> 
> 
> Diffs
> -
> 
>   khtml/src/CMakeLists.txt ed113f5 
>   khtml/src/java/CMakeLists.txt 3dd2d88 
> 
> Diff: http://git.reviewboard.kde.org/r/113625/diff/
> 
> 
> Testing
> ---
> 
> Builds.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113625: Prepare KHTML for moving into tier4.

2013-11-04 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113625/
---

Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Tidy target_link for KHTML.


Diffs
-

  khtml/src/CMakeLists.txt ed113f5 
  khtml/src/java/CMakeLists.txt 3dd2d88 

Diff: http://git.reviewboard.kde.org/r/113625/diff/


Testing
---

Builds.


Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel