Re: Review Request 113643: Fix Standalone Configuration for KJobWidgets

[David Narváez]

> On Nov. 5, 2013, 1:54 p.m., Aurélien Gâteau wrote:
> > tier2/kjobwidgets/src/CMakeLists.txt, line 17
> > 
> >
> > You should replace this line with:
> > 
> > if("${CMAKE_BINARY_DIR}" STREQUAL "${CMAKE_CURRENT_BINARY_DIR}")
> > 
> > This is more future-proof in case the top-level project gets renamed.
> 
> David Narváez wrote:
> Mmm, I understand your point but note that
> 
> CMAKE_BINARY_DIR /usr/local/src/kf5-standalone/kjobwidgets
> CMAKE_CURRENT_BINARY_DIR /usr/local/src/kf5-standalone/kjobwidgets/src
>
> 
> Aleix Pol Gonzalez wrote:
> You should always do the find_package() from the root CMakeLists.txt of 
> the module.

Right, my bad, I'm uploading the fixed version of the patch.


- David


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113643/#review43058
---


On Nov. 5, 2013, 1:53 p.m., David Narváez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113643/
> ---
> 
> (Updated Nov. 5, 2013, 1:53 p.m.)
> 
> 
> Review request for KDE Frameworks and Aurélien Gâteau.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Specify required find_packages when not in kdelib's source dir. This does not 
> fix the standalone build itself.
> 
> 
> Diffs
> -
> 
>   tier2/kjobwidgets/src/CMakeLists.txt 032df16 
> 
> Diff: http://git.reviewboard.kde.org/r/113643/diff/
> 
> 
> Testing
> ---
> 
> 1. Configure a standalone build
> 
> Before this patch the configuration would complain of missing find_packages 
> for KCore
> 
> 
> Thanks,
> 
> David Narváez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113643: Fix Standalone Configuration for KJobWidgets

[Aleix Pol Gonzalez]

> On Nov. 5, 2013, 1:54 p.m., Aurélien Gâteau wrote:
> > tier2/kjobwidgets/src/CMakeLists.txt, line 17
> > 
> >
> > You should replace this line with:
> > 
> > if("${CMAKE_BINARY_DIR}" STREQUAL "${CMAKE_CURRENT_BINARY_DIR}")
> > 
> > This is more future-proof in case the top-level project gets renamed.
> 
> David Narváez wrote:
> Mmm, I understand your point but note that
> 
> CMAKE_BINARY_DIR /usr/local/src/kf5-standalone/kjobwidgets
> CMAKE_CURRENT_BINARY_DIR /usr/local/src/kf5-standalone/kjobwidgets/src
>

You should always do the find_package() from the root CMakeLists.txt of the 
module.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113643/#review43058
---


On Nov. 5, 2013, 1:53 p.m., David Narváez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113643/
> ---
> 
> (Updated Nov. 5, 2013, 1:53 p.m.)
> 
> 
> Review request for KDE Frameworks and Aurélien Gâteau.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Specify required find_packages when not in kdelib's source dir. This does not 
> fix the standalone build itself.
> 
> 
> Diffs
> -
> 
>   tier2/kjobwidgets/src/CMakeLists.txt 032df16 
> 
> Diff: http://git.reviewboard.kde.org/r/113643/diff/
> 
> 
> Testing
> ---
> 
> 1. Configure a standalone build
> 
> Before this patch the configuration would complain of missing find_packages 
> for KCore
> 
> 
> Thanks,
> 
> David Narváez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113643: Fix Standalone Configuration for KJobWidgets

[David Narváez]

> On Nov. 5, 2013, 1:54 p.m., Aurélien Gâteau wrote:
> > tier2/kjobwidgets/src/CMakeLists.txt, line 17
> > 
> >
> > You should replace this line with:
> > 
> > if("${CMAKE_BINARY_DIR}" STREQUAL "${CMAKE_CURRENT_BINARY_DIR}")
> > 
> > This is more future-proof in case the top-level project gets renamed.

Mmm, I understand your point but note that

CMAKE_BINARY_DIR /usr/local/src/kf5-standalone/kjobwidgets
CMAKE_CURRENT_BINARY_DIR /usr/local/src/kf5-standalone/kjobwidgets/src


- David


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113643/#review43058
---


On Nov. 5, 2013, 1:53 p.m., David Narváez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113643/
> ---
> 
> (Updated Nov. 5, 2013, 1:53 p.m.)
> 
> 
> Review request for KDE Frameworks and Aurélien Gâteau.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Specify required find_packages when not in kdelib's source dir. This does not 
> fix the standalone build itself.
> 
> 
> Diffs
> -
> 
>   tier2/kjobwidgets/src/CMakeLists.txt 032df16 
> 
> Diff: http://git.reviewboard.kde.org/r/113643/diff/
> 
> 
> Testing
> ---
> 
> 1. Configure a standalone build
> 
> Before this patch the configuration would complain of missing find_packages 
> for KCore
> 
> 
> Thanks,
> 
> David Narváez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113643: Fix Standalone Configuration for KJobWidgets

[Aurélien Gâteau]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113643/#review43058
---



tier2/kjobwidgets/src/CMakeLists.txt


You should replace this line with:

if("${CMAKE_BINARY_DIR}" STREQUAL "${CMAKE_CURRENT_BINARY_DIR}")

This is more future-proof in case the top-level project gets renamed.


- Aurélien Gâteau


On Nov. 5, 2013, 2:53 p.m., David Narváez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113643/
> ---
> 
> (Updated Nov. 5, 2013, 2:53 p.m.)
> 
> 
> Review request for KDE Frameworks and Aurélien Gâteau.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Specify required find_packages when not in kdelib's source dir. This does not 
> fix the standalone build itself.
> 
> 
> Diffs
> -
> 
>   tier2/kjobwidgets/src/CMakeLists.txt 032df16 
> 
> Diff: http://git.reviewboard.kde.org/r/113643/diff/
> 
> 
> Testing
> ---
> 
> 1. Configure a standalone build
> 
> Before this patch the configuration would complain of missing find_packages 
> for KCore
> 
> 
> Thanks,
> 
> David Narváez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113643: Fix Standalone Configuration for KJobWidgets

[David Narváez]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113643/
---

(Updated Nov. 5, 2013, 1:53 p.m.)


Review request for KDE Frameworks and Aurélien Gâteau.


Changes
---

Fixing group


Repository: kdelibs


Description
---

Specify required find_packages when not in kdelib's source dir. This does not 
fix the standalone build itself.


Diffs
-

  tier2/kjobwidgets/src/CMakeLists.txt 032df16 

Diff: http://git.reviewboard.kde.org/r/113643/diff/


Testing
---

1. Configure a standalone build

Before this patch the configuration would complain of missing find_packages for 
KCore


Thanks,

David Narváez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel