Review Request 113686: Fix KParts standalone build
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113686/ --- Review request for KDE Frameworks. Repository: kdelibs Description --- Adds all the dependencies so it can be compiled. Diffs - staging/kio/src/core/kprotocolmanager.h af8c8a8 tier3/kparts/CMakeLists.txt 77557bf tier3/kparts/autotests/CMakeLists.txt d47a821 tier3/kparts/src/browserrun.h 9038fd4 tier3/kparts/tests/CMakeLists.txt 1e675f0 Diff: http://git.reviewboard.kde.org/r/113686/diff/ Testing --- Builds, installs, tests still pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113686: Fix KParts standalone build
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113686/#review43205 --- works fine, but please add kparts to superbuild/CMakeLists.txt. - Aurélien Gâteau On Nov. 6, 2013, 6:02 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113686/ > --- > > (Updated Nov. 6, 2013, 6:02 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > --- > > Adds all the dependencies so it can be compiled. > > > Diffs > - > > staging/kio/src/core/kprotocolmanager.h af8c8a8 > tier3/kparts/CMakeLists.txt 77557bf > tier3/kparts/autotests/CMakeLists.txt d47a821 > tier3/kparts/src/browserrun.h 9038fd4 > tier3/kparts/tests/CMakeLists.txt 1e675f0 > > Diff: http://git.reviewboard.kde.org/r/113686/diff/ > > > Testing > --- > > Builds, installs, tests still pass. > > > Thanks, > > Aleix Pol Gonzalez > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113686: Fix KParts standalone build
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113686/ --- (Updated Nov. 7, 2013, 1:04 p.m.) Review request for KDE Frameworks. Changes --- add superbuild... Repository: kdelibs Description --- Adds all the dependencies so it can be compiled. Diffs (updated) - staging/kio/src/core/kprotocolmanager.h af8c8a8 superbuild/CMakeLists.txt e965cc8 tier3/kparts/CMakeLists.txt 77557bf tier3/kparts/autotests/CMakeLists.txt d47a821 tier3/kparts/src/browserrun.h 9038fd4 tier3/kparts/tests/CMakeLists.txt 1e675f0 Diff: http://git.reviewboard.kde.org/r/113686/diff/ Testing --- Builds, installs, tests still pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113686: Fix KParts standalone build
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113686/#review43252 --- Ship it! Tested, it builds both independently and with the whole repo. - Àlex Fiestas On Nov. 7, 2013, 1:04 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113686/ > --- > > (Updated Nov. 7, 2013, 1:04 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > --- > > Adds all the dependencies so it can be compiled. > > > Diffs > - > > staging/kio/src/core/kprotocolmanager.h af8c8a8 > superbuild/CMakeLists.txt e965cc8 > tier3/kparts/CMakeLists.txt 77557bf > tier3/kparts/autotests/CMakeLists.txt d47a821 > tier3/kparts/src/browserrun.h 9038fd4 > tier3/kparts/tests/CMakeLists.txt 1e675f0 > > Diff: http://git.reviewboard.kde.org/r/113686/diff/ > > > Testing > --- > > Builds, installs, tests still pass. > > > Thanks, > > Aleix Pol Gonzalez > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113686: Fix KParts standalone build
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113686/#review43359 --- Ship it! Ship It! - Kevin Ottens On Nov. 7, 2013, 1:04 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113686/ > --- > > (Updated Nov. 7, 2013, 1:04 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > --- > > Adds all the dependencies so it can be compiled. > > > Diffs > - > > staging/kio/src/core/kprotocolmanager.h af8c8a8 > superbuild/CMakeLists.txt e965cc8 > tier3/kparts/CMakeLists.txt 77557bf > tier3/kparts/autotests/CMakeLists.txt d47a821 > tier3/kparts/src/browserrun.h 9038fd4 > tier3/kparts/tests/CMakeLists.txt 1e675f0 > > Diff: http://git.reviewboard.kde.org/r/113686/diff/ > > > Testing > --- > > Builds, installs, tests still pass. > > > Thanks, > > Aleix Pol Gonzalez > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113686: Fix KParts standalone build
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113686/#review43434 --- This review has been submitted with commit d691d3fac78fcebdcb94956227a7aa2109303b18 by Aleix Pol to branch frameworks. - Commit Hook On Nov. 7, 2013, 1:04 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113686/ > --- > > (Updated Nov. 7, 2013, 1:04 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > --- > > Adds all the dependencies so it can be compiled. > > > Diffs > - > > staging/kio/src/core/kprotocolmanager.h af8c8a8 > superbuild/CMakeLists.txt e965cc8 > tier3/kparts/CMakeLists.txt 77557bf > tier3/kparts/autotests/CMakeLists.txt d47a821 > tier3/kparts/src/browserrun.h 9038fd4 > tier3/kparts/tests/CMakeLists.txt 1e675f0 > > Diff: http://git.reviewboard.kde.org/r/113686/diff/ > > > Testing > --- > > Builds, installs, tests still pass. > > > Thanks, > > Aleix Pol Gonzalez > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113686: Fix KParts standalone build
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113686/ --- (Updated Nov. 11, 2013, 2:31 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- Adds all the dependencies so it can be compiled. Diffs - staging/kio/src/core/kprotocolmanager.h af8c8a8 superbuild/CMakeLists.txt e965cc8 tier3/kparts/CMakeLists.txt 77557bf tier3/kparts/autotests/CMakeLists.txt d47a821 tier3/kparts/src/browserrun.h 9038fd4 tier3/kparts/tests/CMakeLists.txt 1e675f0 Diff: http://git.reviewboard.kde.org/r/113686/diff/ Testing --- Builds, installs, tests still pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
