Re: Review Request 113693: Fix KNotifyConfig standalone build

2013-11-11 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113693/
---

(Updated Nov. 11, 2013, 2:31 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Add the dependencies of dependencies.
Small fixes.


Diffs
-

  superbuild/CMakeLists.txt 90688f6 
  tier3/knotifyconfig/CMakeLists.txt 8be2ceb 
  tier3/knotifyconfig/tests/CMakeLists.txt 385ff70 

Diff: http://git.reviewboard.kde.org/r/113693/diff/


Testing
---

Builds, installs, the test seems to work.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113693: Fix KNotifyConfig standalone build

2013-11-11 Thread Commit Hook 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113693/#review43436
---


This review has been submitted with commit 
25e6882a52b9e564a0773e53ddf0700342e16307 by Aleix Pol to branch frameworks.

- Commit Hook


On Nov. 7, 2013, 1:07 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113693/
> ---
> 
> (Updated Nov. 7, 2013, 1:07 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Add the dependencies of dependencies.
> Small fixes.
> 
> 
> Diffs
> -
> 
>   superbuild/CMakeLists.txt 90688f6 
>   tier3/knotifyconfig/CMakeLists.txt 8be2ceb 
>   tier3/knotifyconfig/tests/CMakeLists.txt 385ff70 
> 
> Diff: http://git.reviewboard.kde.org/r/113693/diff/
> 
> 
> Testing
> ---
> 
> Builds, installs, the test seems to work.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113693: Fix KNotifyConfig standalone build

2013-11-10 Thread Kevin Ottens 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113693/#review43361
---

Ship it!


After adjusting the comment it can go in indeed.

- Kevin Ottens


On Nov. 7, 2013, 1:07 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113693/
> ---
> 
> (Updated Nov. 7, 2013, 1:07 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Add the dependencies of dependencies.
> Small fixes.
> 
> 
> Diffs
> -
> 
>   superbuild/CMakeLists.txt 90688f6 
>   tier3/knotifyconfig/CMakeLists.txt 8be2ceb 
>   tier3/knotifyconfig/tests/CMakeLists.txt 385ff70 
> 
> Diff: http://git.reviewboard.kde.org/r/113693/diff/
> 
> 
> Testing
> ---
> 
> Builds, installs, the test seems to work.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113693: Fix KNotifyConfig standalone build

2013-11-08 Thread Àlex Fiestas 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113693/#review43254
---

Ship it!


I think this can go in once the comment is changed.

- Àlex Fiestas


On Nov. 7, 2013, 1:07 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113693/
> ---
> 
> (Updated Nov. 7, 2013, 1:07 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Add the dependencies of dependencies.
> Small fixes.
> 
> 
> Diffs
> -
> 
>   superbuild/CMakeLists.txt 90688f6 
>   tier3/knotifyconfig/CMakeLists.txt 8be2ceb 
>   tier3/knotifyconfig/tests/CMakeLists.txt 385ff70 
> 
> Diff: http://git.reviewboard.kde.org/r/113693/diff/
> 
> 
> Testing
> ---
> 
> Builds, installs, the test seems to work.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113693: Fix KNotifyConfig standalone build

2013-11-07 Thread Alex Merry 


> On Nov. 7, 2013, 2:16 p.m., Alex Merry wrote:
> > tier3/knotifyconfig/CMakeLists.txt, lines 20-35
> > 
> >
> > Did I miss something?  Why is CMake 3 relevant to these?  KIO wasn't 
> > exporting its dependencies to KIOConfig.cmake properly until recently, but 
> > it should be doing so now.
> 
> Aleix Pol Gonzalez wrote:
> That error you get it just by trying to find KIO. It's because the 
> private dependencies are looked up as well and the reason we have to list the 
> private dependencies.
> 
> CMake Error at /home/kde-devel/kde5/lib64/cmake/KIO/KIOConfig.cmake:31 
> (find_package):
>   Found package configuration file:
> 
> /home/kde-devel/kde5/lib64/cmake/KJobWidgets/KJobWidgetsConfig.cmake
> 
>   but it set KJobWidgets_FOUND to FALSE so package "KJobWidgets" is
>   considered to be NOT FOUND.  Reason given by package:
> 
>   The following imported targets are referenced, but are missing:
>   KF5::KWidgetsAddons
>

Fair enough.  A more descriptive comment would be good, then, like
# Due to a CMake bug, we need to explicitly find private dependencies of our 
dependencies
# Remove when we depend on CMake 3.0.0 (which should fix this)


- Alex


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113693/#review43226
---


On Nov. 7, 2013, 1:07 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113693/
> ---
> 
> (Updated Nov. 7, 2013, 1:07 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Add the dependencies of dependencies.
> Small fixes.
> 
> 
> Diffs
> -
> 
>   superbuild/CMakeLists.txt 90688f6 
>   tier3/knotifyconfig/CMakeLists.txt 8be2ceb 
>   tier3/knotifyconfig/tests/CMakeLists.txt 385ff70 
> 
> Diff: http://git.reviewboard.kde.org/r/113693/diff/
> 
> 
> Testing
> ---
> 
> Builds, installs, the test seems to work.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113693: Fix KNotifyConfig standalone build

2013-11-07 Thread Aleix Pol Gonzalez 


> On Nov. 7, 2013, 2:16 p.m., Alex Merry wrote:
> > tier3/knotifyconfig/CMakeLists.txt, lines 20-35
> > 
> >
> > Did I miss something?  Why is CMake 3 relevant to these?  KIO wasn't 
> > exporting its dependencies to KIOConfig.cmake properly until recently, but 
> > it should be doing so now.

That error you get it just by trying to find KIO. It's because the private 
dependencies are looked up as well and the reason we have to list the private 
dependencies.

CMake Error at /home/kde-devel/kde5/lib64/cmake/KIO/KIOConfig.cmake:31 
(find_package):
  Found package configuration file:

/home/kde-devel/kde5/lib64/cmake/KJobWidgets/KJobWidgetsConfig.cmake

  but it set KJobWidgets_FOUND to FALSE so package "KJobWidgets" is
  considered to be NOT FOUND.  Reason given by package:

  The following imported targets are referenced, but are missing:
  KF5::KWidgetsAddons


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113693/#review43226
---


On Nov. 7, 2013, 1:07 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113693/
> ---
> 
> (Updated Nov. 7, 2013, 1:07 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Add the dependencies of dependencies.
> Small fixes.
> 
> 
> Diffs
> -
> 
>   superbuild/CMakeLists.txt 90688f6 
>   tier3/knotifyconfig/CMakeLists.txt 8be2ceb 
>   tier3/knotifyconfig/tests/CMakeLists.txt 385ff70 
> 
> Diff: http://git.reviewboard.kde.org/r/113693/diff/
> 
> 
> Testing
> ---
> 
> Builds, installs, the test seems to work.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113693: Fix KNotifyConfig standalone build

2013-11-07 Thread Alex Merry 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113693/#review43226
---



tier3/knotifyconfig/CMakeLists.txt


Did I miss something?  Why is CMake 3 relevant to these?  KIO wasn't 
exporting its dependencies to KIOConfig.cmake properly until recently, but it 
should be doing so now.


- Alex Merry


On Nov. 7, 2013, 1:07 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113693/
> ---
> 
> (Updated Nov. 7, 2013, 1:07 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Add the dependencies of dependencies.
> Small fixes.
> 
> 
> Diffs
> -
> 
>   superbuild/CMakeLists.txt 90688f6 
>   tier3/knotifyconfig/CMakeLists.txt 8be2ceb 
>   tier3/knotifyconfig/tests/CMakeLists.txt 385ff70 
> 
> Diff: http://git.reviewboard.kde.org/r/113693/diff/
> 
> 
> Testing
> ---
> 
> Builds, installs, the test seems to work.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113693: Fix KNotifyConfig standalone build

2013-11-07 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113693/
---

(Updated Nov. 7, 2013, 1:07 p.m.)


Review request for KDE Frameworks.


Changes
---

add superbuild


Repository: kdelibs


Description
---

Add the dependencies of dependencies.
Small fixes.


Diffs (updated)
-

  superbuild/CMakeLists.txt 90688f6 
  tier3/knotifyconfig/CMakeLists.txt 8be2ceb 
  tier3/knotifyconfig/tests/CMakeLists.txt 385ff70 

Diff: http://git.reviewboard.kde.org/r/113693/diff/


Testing
---

Builds, installs, the test seems to work.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113693: Fix KNotifyConfig standalone build

2013-11-06 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113693/
---

Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Add the dependencies of dependencies.
Small fixes.


Diffs
-

  tier3/knotifyconfig/CMakeLists.txt 8be2ceb 
  tier3/knotifyconfig/tests/CMakeLists.txt 385ff70 

Diff: http://git.reviewboard.kde.org/r/113693/diff/


Testing
---

Builds, installs, the test seems to work.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel