Review Request 113702: Fix KEmoticons standalone build

2013-11-07 Thread Maarten De Meyer 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113702/
---

Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Make KEmoticons build standalone.


Diffs
-

  superbuild/CMakeLists.txt 90688f6 
  tier3/kemoticons/CMakeLists.txt bc2812b 
  tier3/kemoticons/autotests/CMakeLists.txt c88a288 
  tier3/kemoticons/src/core/CMakeLists.txt 556d9bb 

Diff: http://git.reviewboard.kde.org/r/113702/diff/


Testing
---

Builds.
KCoreAddons is pulled in by KService


Thanks,

Maarten De Meyer

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113702: Fix KEmoticons standalone build

2013-11-07 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113702/#review43211
---

Ship it!


Ship It!

- Aleix Pol Gonzalez


On Nov. 7, 2013, 10:47 a.m., Maarten De Meyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113702/
> ---
> 
> (Updated Nov. 7, 2013, 10:47 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Make KEmoticons build standalone.
> 
> 
> Diffs
> -
> 
>   superbuild/CMakeLists.txt 90688f6 
>   tier3/kemoticons/CMakeLists.txt bc2812b 
>   tier3/kemoticons/autotests/CMakeLists.txt c88a288 
>   tier3/kemoticons/src/core/CMakeLists.txt 556d9bb 
> 
> Diff: http://git.reviewboard.kde.org/r/113702/diff/
> 
> 
> Testing
> ---
> 
> Builds.
> KCoreAddons is pulled in by KService
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113702: Fix KEmoticons standalone build

2013-11-07 Thread Aurélien Gâteau 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113702/#review43216
---



superbuild/CMakeLists.txt


kemoticons should be listed after kservice, otherwise superbuild won't pick 
up the standalone version of it.

/me goes documenting this


- Aurélien Gâteau


On Nov. 7, 2013, 11:47 a.m., Maarten De Meyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113702/
> ---
> 
> (Updated Nov. 7, 2013, 11:47 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Make KEmoticons build standalone.
> 
> 
> Diffs
> -
> 
>   superbuild/CMakeLists.txt 90688f6 
>   tier3/kemoticons/CMakeLists.txt bc2812b 
>   tier3/kemoticons/autotests/CMakeLists.txt c88a288 
>   tier3/kemoticons/src/core/CMakeLists.txt 556d9bb 
> 
> Diff: http://git.reviewboard.kde.org/r/113702/diff/
> 
> 
> Testing
> ---
> 
> Builds.
> KCoreAddons is pulled in by KService
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113702: Fix KEmoticons standalone build

2013-11-07 Thread Maarten De Meyer 


> On Nov. 7, 2013, 12:47 p.m., Aurélien Gâteau wrote:
> > superbuild/CMakeLists.txt, line 34
> > 
> >
> > kemoticons should be listed after kservice, otherwise superbuild won't 
> > pick up the standalone version of it.
> > 
> > /me goes documenting this

Yes. I noticed when making superbuild. Already fixed here.
Do you want me to upload a new diff?


- Maarten


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113702/#review43216
---


On Nov. 7, 2013, 10:47 a.m., Maarten De Meyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113702/
> ---
> 
> (Updated Nov. 7, 2013, 10:47 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Make KEmoticons build standalone.
> 
> 
> Diffs
> -
> 
>   superbuild/CMakeLists.txt 90688f6 
>   tier3/kemoticons/CMakeLists.txt bc2812b 
>   tier3/kemoticons/autotests/CMakeLists.txt c88a288 
>   tier3/kemoticons/src/core/CMakeLists.txt 556d9bb 
> 
> Diff: http://git.reviewboard.kde.org/r/113702/diff/
> 
> 
> Testing
> ---
> 
> Builds.
> KCoreAddons is pulled in by KService
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113702: Fix KEmoticons standalone build

2013-11-08 Thread Aurélien Gâteau 


> On Nov. 7, 2013, 1:47 p.m., Aurélien Gâteau wrote:
> > superbuild/CMakeLists.txt, line 34
> > 
> >
> > kemoticons should be listed after kservice, otherwise superbuild won't 
> > pick up the standalone version of it.
> > 
> > /me goes documenting this
> 
> Maarten De Meyer wrote:
> Yes. I noticed when making superbuild. Already fixed here.
> Do you want me to upload a new diff?

No it's OK, I trust you.


- Aurélien


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113702/#review43216
---


On Nov. 7, 2013, 11:47 a.m., Maarten De Meyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113702/
> ---
> 
> (Updated Nov. 7, 2013, 11:47 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Make KEmoticons build standalone.
> 
> 
> Diffs
> -
> 
>   superbuild/CMakeLists.txt 90688f6 
>   tier3/kemoticons/CMakeLists.txt bc2812b 
>   tier3/kemoticons/autotests/CMakeLists.txt c88a288 
>   tier3/kemoticons/src/core/CMakeLists.txt 556d9bb 
> 
> Diff: http://git.reviewboard.kde.org/r/113702/diff/
> 
> 
> Testing
> ---
> 
> Builds.
> KCoreAddons is pulled in by KService
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113702: Fix KEmoticons standalone build

2013-11-08 Thread Aurélien Gâteau 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113702/#review43260
---

Ship it!


Ship It!

- Aurélien Gâteau


On Nov. 7, 2013, 11:47 a.m., Maarten De Meyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113702/
> ---
> 
> (Updated Nov. 7, 2013, 11:47 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Make KEmoticons build standalone.
> 
> 
> Diffs
> -
> 
>   superbuild/CMakeLists.txt 90688f6 
>   tier3/kemoticons/CMakeLists.txt bc2812b 
>   tier3/kemoticons/autotests/CMakeLists.txt c88a288 
>   tier3/kemoticons/src/core/CMakeLists.txt 556d9bb 
> 
> Diff: http://git.reviewboard.kde.org/r/113702/diff/
> 
> 
> Testing
> ---
> 
> Builds.
> KCoreAddons is pulled in by KService
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113702: Fix KEmoticons standalone build

2013-11-08 Thread Commit Hook 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113702/#review43278
---


This review has been submitted with commit 
62fb092823ca5c7ca38010d2146ee1af489036b2 by Maarten De Meyer to branch 
frameworks.

- Commit Hook


On Nov. 7, 2013, 10:47 a.m., Maarten De Meyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113702/
> ---
> 
> (Updated Nov. 7, 2013, 10:47 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Make KEmoticons build standalone.
> 
> 
> Diffs
> -
> 
>   superbuild/CMakeLists.txt 90688f6 
>   tier3/kemoticons/CMakeLists.txt bc2812b 
>   tier3/kemoticons/autotests/CMakeLists.txt c88a288 
>   tier3/kemoticons/src/core/CMakeLists.txt 556d9bb 
> 
> Diff: http://git.reviewboard.kde.org/r/113702/diff/
> 
> 
> Testing
> ---
> 
> Builds.
> KCoreAddons is pulled in by KService
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113702: Fix KEmoticons standalone build

2013-11-08 Thread Maarten De Meyer 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113702/
---

(Updated Nov. 8, 2013, 7:41 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Make KEmoticons build standalone.


Diffs
-

  superbuild/CMakeLists.txt 90688f6 
  tier3/kemoticons/CMakeLists.txt bc2812b 
  tier3/kemoticons/autotests/CMakeLists.txt c88a288 
  tier3/kemoticons/src/core/CMakeLists.txt 556d9bb 

Diff: http://git.reviewboard.kde.org/r/113702/diff/


Testing
---

Builds.
KCoreAddons is pulled in by KService


Thanks,

Maarten De Meyer

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel