Re: Review Request 113703: Fix KRoss standalone build

2013-11-08 Thread Maarten De Meyer 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113703/
---

(Updated Nov. 8, 2013, 8:16 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Make kross build standalone.


Diffs
-

  tier3/kross/CMakeLists.txt 440edf2 
  tier3/kross/src/modules/CMakeLists.txt 198cb04 

Diff: http://git.reviewboard.kde.org/r/113703/diff/


Testing
---

Builds.
Not added to superbuild.


Thanks,

Maarten De Meyer

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113703: Fix KRoss standalone build

2013-11-08 Thread Commit Hook 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113703/#review43280
---


This review has been submitted with commit 
1bab5c4c483aed3e863b25f5a81b52f501be63fc by Maarten De Meyer to branch 
frameworks.

- Commit Hook


On Nov. 7, 2013, 1:45 p.m., Maarten De Meyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113703/
> ---
> 
> (Updated Nov. 7, 2013, 1:45 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Make kross build standalone.
> 
> 
> Diffs
> -
> 
>   tier3/kross/CMakeLists.txt 440edf2 
>   tier3/kross/src/modules/CMakeLists.txt 198cb04 
> 
> Diff: http://git.reviewboard.kde.org/r/113703/diff/
> 
> 
> Testing
> ---
> 
> Builds.
> Not added to superbuild.
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113703: Fix KRoss standalone build

2013-11-07 Thread Alex Merry 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113703/#review43222
---

Ship it!


Ship It!

- Alex Merry


On Nov. 7, 2013, 1:45 p.m., Maarten De Meyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113703/
> ---
> 
> (Updated Nov. 7, 2013, 1:45 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Make kross build standalone.
> 
> 
> Diffs
> -
> 
>   tier3/kross/CMakeLists.txt 440edf2 
>   tier3/kross/src/modules/CMakeLists.txt 198cb04 
> 
> Diff: http://git.reviewboard.kde.org/r/113703/diff/
> 
> 
> Testing
> ---
> 
> Builds.
> Not added to superbuild.
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113703: Fix KRoss standalone build

2013-11-07 Thread Maarten De Meyer 


> On Nov. 7, 2013, 11:50 a.m., Alex Merry wrote:
> > tier3/kross/CMakeLists.txt, lines 29-31
> > 
> >
> > These shouldn't be needed; we should fix how KIO is generating 
> > KIOConfig.cmake first (it's not listing its dependencies properly).
> 
> Aurélien Gâteau wrote:
> I think I fixed this yesterday in commit 
> fd4771d7f11b847cc9ea9dbe1590f92893d16a12. Can you check you still need the 
> find_package() calls?

With a fresh build they are no longer needed. Thanks.


- Maarten


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113703/#review43213
---


On Nov. 7, 2013, 1:45 p.m., Maarten De Meyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113703/
> ---
> 
> (Updated Nov. 7, 2013, 1:45 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Make kross build standalone.
> 
> 
> Diffs
> -
> 
>   tier3/kross/CMakeLists.txt 440edf2 
>   tier3/kross/src/modules/CMakeLists.txt 198cb04 
> 
> Diff: http://git.reviewboard.kde.org/r/113703/diff/
> 
> 
> Testing
> ---
> 
> Builds.
> Not added to superbuild.
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113703: Fix KRoss standalone build

2013-11-07 Thread Maarten De Meyer 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113703/
---

(Updated Nov. 7, 2013, 1:45 p.m.)


Review request for KDE Frameworks.


Changes
---

Remove unneeded dependencies.


Repository: kdelibs


Description
---

Make kross build standalone.


Diffs (updated)
-

  tier3/kross/CMakeLists.txt 440edf2 
  tier3/kross/src/modules/CMakeLists.txt 198cb04 

Diff: http://git.reviewboard.kde.org/r/113703/diff/


Testing
---

Builds.
Not added to superbuild.


Thanks,

Maarten De Meyer

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113703: Fix KRoss standalone build

2013-11-07 Thread Aurélien Gâteau 


> On Nov. 7, 2013, 12:50 p.m., Alex Merry wrote:
> > tier3/kross/CMakeLists.txt, lines 29-31
> > 
> >
> > These shouldn't be needed; we should fix how KIO is generating 
> > KIOConfig.cmake first (it's not listing its dependencies properly).

I think I fixed this yesterday in commit 
fd4771d7f11b847cc9ea9dbe1590f92893d16a12. Can you check you still need the 
find_package() calls?


- Aurélien


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113703/#review43213
---


On Nov. 7, 2013, 12:23 p.m., Maarten De Meyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113703/
> ---
> 
> (Updated Nov. 7, 2013, 12:23 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Make kross build standalone.
> 
> 
> Diffs
> -
> 
>   tier3/kross/src/modules/CMakeLists.txt 
> 198cb047131702fc60b046ec30c86e342d4a79fc 
>   tier3/kross/CMakeLists.txt 440edf23308f4b6fa57e66d592a01ba6024ec22d 
> 
> Diff: http://git.reviewboard.kde.org/r/113703/diff/
> 
> 
> Testing
> ---
> 
> Builds.
> Not added to superbuild.
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113703: Fix KRoss standalone build

2013-11-07 Thread Alex Merry 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113703/#review43213
---



tier3/kross/CMakeLists.txt


These shouldn't be needed; we should fix how KIO is generating 
KIOConfig.cmake first (it's not listing its dependencies properly).


- Alex Merry


On Nov. 7, 2013, 11:23 a.m., Maarten De Meyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113703/
> ---
> 
> (Updated Nov. 7, 2013, 11:23 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Make kross build standalone.
> 
> 
> Diffs
> -
> 
>   tier3/kross/src/modules/CMakeLists.txt 
> 198cb047131702fc60b046ec30c86e342d4a79fc 
>   tier3/kross/CMakeLists.txt 440edf23308f4b6fa57e66d592a01ba6024ec22d 
> 
> Diff: http://git.reviewboard.kde.org/r/113703/diff/
> 
> 
> Testing
> ---
> 
> Builds.
> Not added to superbuild.
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113703: Fix KRoss standalone build

2013-11-07 Thread Maarten De Meyer 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113703/
---

Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Make kross build standalone.


Diffs
-

  tier3/kross/src/modules/CMakeLists.txt 
198cb047131702fc60b046ec30c86e342d4a79fc 
  tier3/kross/CMakeLists.txt 440edf23308f4b6fa57e66d592a01ba6024ec22d 

Diff: http://git.reviewboard.kde.org/r/113703/diff/


Testing
---

Builds.
Not added to superbuild.


Thanks,

Maarten De Meyer

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel