Re: Review Request 115207: Improve integration QCommandLineParser <-> KAboutData

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115207/
---

(Updated March 5, 2014, 11:55 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kcoreaddons


Description
---

Let the KAboutData set information to QApplication. This way we don't have to 
duplicate information by passing it to the KAboutData _and_ the QApplication.


Diffs
-

  src/lib/kaboutdata.h c9e 
  src/lib/kaboutdata.cpp c347521 

Diff: https://git.reviewboard.kde.org/r/115207/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115207: Improve integration QCommandLineParser <-> KAboutData

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115207/#review52059
---


This review has been submitted with commit 
71febbb162847ddf1bae1a2dfd39da49aff2df83 by Aleix Pol to branch master.

- Commit Hook


On March 4, 2014, 11:11 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115207/
> ---
> 
> (Updated March 4, 2014, 11:11 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Let the KAboutData set information to QApplication. This way we don't have to 
> duplicate information by passing it to the KAboutData _and_ the QApplication.
> 
> 
> Diffs
> -
> 
>   src/lib/kaboutdata.h c9e 
>   src/lib/kaboutdata.cpp c347521 
> 
> Diff: https://git.reviewboard.kde.org/r/115207/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115207: Improve integration QCommandLineParser <-> KAboutData

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115207/#review52010
---

Ship it!


Ship It!

- David Faure


On March 4, 2014, 11:11 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115207/
> ---
> 
> (Updated March 4, 2014, 11:11 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Let the KAboutData set information to QApplication. This way we don't have to 
> duplicate information by passing it to the KAboutData _and_ the QApplication.
> 
> 
> Diffs
> -
> 
>   src/lib/kaboutdata.h c9e 
>   src/lib/kaboutdata.cpp c347521 
> 
> Diff: https://git.reviewboard.kde.org/r/115207/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115207: Improve integration QCommandLineParser <-> KAboutData

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115207/#review52006
---

Ship it!


Ship It!

- Kevin Ottens


On March 4, 2014, 11:11 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115207/
> ---
> 
> (Updated March 4, 2014, 11:11 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Let the KAboutData set information to QApplication. This way we don't have to 
> duplicate information by passing it to the KAboutData _and_ the QApplication.
> 
> 
> Diffs
> -
> 
>   src/lib/kaboutdata.h c9e 
>   src/lib/kaboutdata.cpp c347521 
> 
> Diff: https://git.reviewboard.kde.org/r/115207/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115207: Improve integration QCommandLineParser <-> KAboutData

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115207/
---

(Updated March 4, 2014, 11:11 p.m.)


Review request for KDE Frameworks.


Changes
---

Address David's remarks.

I'm a noob. >.<


Repository: kcoreaddons


Description
---

Let the KAboutData set information to QApplication. This way we don't have to 
duplicate information by passing it to the KAboutData _and_ the QApplication.


Diffs (updated)
-

  src/lib/kaboutdata.h c9e 
  src/lib/kaboutdata.cpp c347521 

Diff: https://git.reviewboard.kde.org/r/115207/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115207: Improve integration QCommandLineParser <-> KAboutData

[Kevin Ottens]

> On Feb. 22, 2014, 9:09 a.m., David Faure wrote:
> > src/lib/kaboutdata.cpp, line 919
> > 
> >
> > A unittest would have shown you the bug in this line...
> > (you're modifying a copy -> no effect).
> > 
> > Use setProperty, just like the existing line for applicationIconName 
> > does.
> > 
> > And then I would remove the inherits() call. It will become a dynamic 
> > property if the app isn't a QGuiApplication, no big deal.
> >

Please address David's comments it's been more than a week.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115207/#review50501
---


On Feb. 21, 2014, 2:03 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115207/
> ---
> 
> (Updated Feb. 21, 2014, 2:03 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Let the KAboutData set information to QApplication. This way we don't have to 
> duplicate information by passing it to the KAboutData _and_ the QApplication.
> 
> 
> Diffs
> -
> 
>   src/lib/kaboutdata.h c9e 
>   src/lib/kaboutdata.cpp c347521 
> 
> Diff: https://git.reviewboard.kde.org/r/115207/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115207: Improve integration QCommandLineParser <-> KAboutData

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115207/#review50501
---



src/lib/kaboutdata.cpp


A unittest would have shown you the bug in this line...
(you're modifying a copy -> no effect).

Use setProperty, just like the existing line for applicationIconName does.

And then I would remove the inherits() call. It will become a dynamic 
property if the app isn't a QGuiApplication, no big deal.



- David Faure


On Feb. 21, 2014, 2:03 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115207/
> ---
> 
> (Updated Feb. 21, 2014, 2:03 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Let the KAboutData set information to QApplication. This way we don't have to 
> duplicate information by passing it to the KAboutData _and_ the QApplication.
> 
> 
> Diffs
> -
> 
>   src/lib/kaboutdata.h c9e 
>   src/lib/kaboutdata.cpp c347521 
> 
> Diff: https://git.reviewboard.kde.org/r/115207/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115207: Improve integration QCommandLineParser <-> KAboutData

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115207/
---

(Updated Feb. 21, 2014, 2:03 p.m.)


Review request for KDE Frameworks.


Changes
---

Address issues pointed out by Alex Merry.


Repository: kcoreaddons


Description
---

Let the KAboutData set information to QApplication. This way we don't have to 
duplicate information by passing it to the KAboutData _and_ the QApplication.


Diffs (updated)
-

  src/lib/kaboutdata.h c9e 
  src/lib/kaboutdata.cpp c347521 

Diff: https://git.reviewboard.kde.org/r/115207/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115207: Improve integration QCommandLineParser <-> KAboutData

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115207/#review50466
---



src/lib/kaboutdata.h


"chosen"

I would actually rephrase this as "In addition to changing the result of 
applicationData(), this initializes the relevant properties of QCoreApplication 
(and its subclasses) with information from @p aboutData."



src/lib/kaboutdata.cpp


No point changing this


- Alex Merry


On Feb. 21, 2014, 12:26 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115207/
> ---
> 
> (Updated Feb. 21, 2014, 12:26 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Let the KAboutData set information to QApplication. This way we don't have to 
> duplicate information by passing it to the KAboutData _and_ the QApplication.
> 
> 
> Diffs
> -
> 
>   src/lib/kaboutdata.h c9e 
>   src/lib/kaboutdata.cpp c347521 
> 
> Diff: https://git.reviewboard.kde.org/r/115207/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115207: Improve integration QCommandLineParser <-> KAboutData

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115207/
---

(Updated Feb. 21, 2014, 12:26 p.m.)


Review request for KDE Frameworks.


Changes
---

Move the QApplication initialization to setApplicationData() instead of in 
setupCommandLine().

It makes more sense, the previous API looked a bit hacky.


Repository: kcoreaddons


Description
---

Let the KAboutData set information to QApplication. This way we don't have to 
duplicate information by passing it to the KAboutData _and_ the QApplication.


Diffs (updated)
-

  src/lib/kaboutdata.h c9e 
  src/lib/kaboutdata.cpp c347521 

Diff: https://git.reviewboard.kde.org/r/115207/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115207: Improve integration QCommandLineParser <-> KAboutData

[Kevin Ottens]

> On Jan. 27, 2014, 7:45 a.m., Kevin Ottens wrote:
> > src/lib/kaboutdata.cpp, line 941
> > 
> >
> > Not really my type of thing. It's acting on an object behind our back 
> > without knowing... what happens to code where setApplication* was called 
> > before? Information would be lost and it's not obvious to the user. Looks 
> > dangerous to me.
> > 
> > If we want to factorize the qApp call, and I see the need for that 
> > indeed, then that block should be provided by a separate method 
> > (setupApplication(QCoreApplication *)?).
> 
> Aleix Pol Gonzalez wrote:
> I agree, I only did it this way to avoid the required set up.
> 
> An alternative would be to make KAboutData to pass the information to 
> Q*Application when it's initialized (and if it's an application 
> KAboutData...).
> 
> Alex Merry wrote:
> Any progress on this?

In that case, wouldn't putting that in setApplicationData better? I see it 
already attaches properties to the application pointer. Or is that unrelated to 
what you had in mind?


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115207/#review48347
---


On Jan. 21, 2014, 11:36 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115207/
> ---
> 
> (Updated Jan. 21, 2014, 11:36 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Let the KAboutData set information to QApplication. This way we don't have to 
> duplicate information by passing it to the KAboutData _and_ the QApplication.
> 
> 
> Diffs
> -
> 
>   src/lib/kaboutdata.h c9e 
>   src/lib/kaboutdata.cpp f24006b 
> 
> Diff: https://git.reviewboard.kde.org/r/115207/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115207: Improve integration QCommandLineParser <-> KAboutData

[Alex Merry]

> On Jan. 27, 2014, 7:45 a.m., Kevin Ottens wrote:
> > src/lib/kaboutdata.cpp, line 941
> > 
> >
> > Not really my type of thing. It's acting on an object behind our back 
> > without knowing... what happens to code where setApplication* was called 
> > before? Information would be lost and it's not obvious to the user. Looks 
> > dangerous to me.
> > 
> > If we want to factorize the qApp call, and I see the need for that 
> > indeed, then that block should be provided by a separate method 
> > (setupApplication(QCoreApplication *)?).
> 
> Aleix Pol Gonzalez wrote:
> I agree, I only did it this way to avoid the required set up.
> 
> An alternative would be to make KAboutData to pass the information to 
> Q*Application when it's initialized (and if it's an application 
> KAboutData...).

Any progress on this?


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115207/#review48347
---


On Jan. 21, 2014, 11:36 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115207/
> ---
> 
> (Updated Jan. 21, 2014, 11:36 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Let the KAboutData set information to QApplication. This way we don't have to 
> duplicate information by passing it to the KAboutData _and_ the QApplication.
> 
> 
> Diffs
> -
> 
>   src/lib/kaboutdata.h c9e 
>   src/lib/kaboutdata.cpp f24006b 
> 
> Diff: https://git.reviewboard.kde.org/r/115207/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115207: Improve integration QCommandLineParser <-> KAboutData

[Aleix Pol Gonzalez]

> On Jan. 27, 2014, 7:45 a.m., Kevin Ottens wrote:
> > src/lib/kaboutdata.cpp, line 941
> > 
> >
> > Not really my type of thing. It's acting on an object behind our back 
> > without knowing... what happens to code where setApplication* was called 
> > before? Information would be lost and it's not obvious to the user. Looks 
> > dangerous to me.
> > 
> > If we want to factorize the qApp call, and I see the need for that 
> > indeed, then that block should be provided by a separate method 
> > (setupApplication(QCoreApplication *)?).

I agree, I only did it this way to avoid the required set up.

An alternative would be to make KAboutData to pass the information to 
Q*Application when it's initialized (and if it's an application KAboutData...).


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115207/#review48347
---


On Jan. 21, 2014, 11:36 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115207/
> ---
> 
> (Updated Jan. 21, 2014, 11:36 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Let the KAboutData set information to QApplication. This way we don't have to 
> duplicate information by passing it to the KAboutData _and_ the QApplication.
> 
> 
> Diffs
> -
> 
>   src/lib/kaboutdata.h c9e 
>   src/lib/kaboutdata.cpp f24006b 
> 
> Diff: https://git.reviewboard.kde.org/r/115207/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115207: Improve integration QCommandLineParser <-> KAboutData

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115207/#review48455
---


I agree with Kévin: this doesn't match what the function name says it does. 
Better make it a separate function.

- David Faure


On Jan. 21, 2014, 11:36 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115207/
> ---
> 
> (Updated Jan. 21, 2014, 11:36 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Let the KAboutData set information to QApplication. This way we don't have to 
> duplicate information by passing it to the KAboutData _and_ the QApplication.
> 
> 
> Diffs
> -
> 
>   src/lib/kaboutdata.h c9e 
>   src/lib/kaboutdata.cpp f24006b 
> 
> Diff: https://git.reviewboard.kde.org/r/115207/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115207: Improve integration QCommandLineParser <-> KAboutData

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115207/#review48347
---



src/lib/kaboutdata.cpp


Not really my type of thing. It's acting on an object behind our back 
without knowing... what happens to code where setApplication* was called 
before? Information would be lost and it's not obvious to the user. Looks 
dangerous to me.

If we want to factorize the qApp call, and I see the need for that indeed, 
then that block should be provided by a separate method 
(setupApplication(QCoreApplication *)?).


- Kevin Ottens


On Jan. 21, 2014, 11:36 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115207/
> ---
> 
> (Updated Jan. 21, 2014, 11:36 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Let the KAboutData set information to QApplication. This way we don't have to 
> duplicate information by passing it to the KAboutData _and_ the QApplication.
> 
> 
> Diffs
> -
> 
>   src/lib/kaboutdata.h c9e 
>   src/lib/kaboutdata.cpp f24006b 
> 
> Diff: https://git.reviewboard.kde.org/r/115207/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115207: Improve integration QCommandLineParser <-> KAboutData

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115207/#review47964
---


Looks like a good idea to me.

- Alex Merry


On Jan. 21, 2014, 11:36 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115207/
> ---
> 
> (Updated Jan. 21, 2014, 11:36 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Let the KAboutData set information to QApplication. This way we don't have to 
> duplicate information by passing it to the KAboutData _and_ the QApplication.
> 
> 
> Diffs
> -
> 
>   src/lib/kaboutdata.h c9e 
>   src/lib/kaboutdata.cpp f24006b 
> 
> Diff: https://git.reviewboard.kde.org/r/115207/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115207: Improve integration QCommandLineParser <-> KAboutData

[Christoph Cullmann]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115207/#review47962
---


Think that will make porting easier and avoids boiler plate code

- Christoph Cullmann


On Jan. 21, 2014, 11:36 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115207/
> ---
> 
> (Updated Jan. 21, 2014, 11:36 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Let the KAboutData set information to QApplication. This way we don't have to 
> duplicate information by passing it to the KAboutData _and_ the QApplication.
> 
> 
> Diffs
> -
> 
>   src/lib/kaboutdata.h c9e 
>   src/lib/kaboutdata.cpp f24006b 
> 
> Diff: https://git.reviewboard.kde.org/r/115207/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115207: Improve integration QCommandLineParser <-> KAboutData

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115207/
---

Review request for KDE Frameworks.


Repository: kcoreaddons


Description
---

Let the KAboutData set information to QApplication. This way we don't have to 
duplicate information by passing it to the KAboutData _and_ the QApplication.


Diffs
-

  src/lib/kaboutdata.h c9e 
  src/lib/kaboutdata.cpp f24006b 

Diff: https://git.reviewboard.kde.org/r/115207/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel