Re: Review Request 115752: Change DATA_INSTALL_DIR on Mac OS X

2014-04-21 Thread Allen Winter
On Friday, February 14, 2014 06:49:43 PM Harald Fernengel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115752/
> ---
> 
> Review request for Build System, Extra Cmake Modules and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> ---
> 
> Let it point to "~/Library/Application Support" as that is what 
> QStandardPaths expects
> 
> This is actually a tricky one - I'd rather have $HOMEBREW_PREFIX/share as 
> data path, but Qt only reports ~/Library/Application\ Support
> 
> So - do we add some magic to Qt to allow user-configurable extra data dirs 
> (juck), implement our own magic (juck), or just change the DATA_INSTALL_DIR 
> to ~/Library/Application\ Support?
> 
> 

Maybe I'm biased to the Unix-way of thinking, but I'm not following why
the person who installed KDE gets to have all the app data under their user.
Or I missing something.  Please enlighten me.

Seems to me the correct solution is $HOMEBREW_PREFIX/share and we need
to adjust QStandardPaths results somehow.  Is KStandardDirs gone in frameworks?

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 115752: Change DATA_INSTALL_DIR on Mac OS X

2014-04-21 Thread Allen Winter
On Friday, February 14, 2014 06:49:43 PM Harald Fernengel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115752/
> ---
> 
> Review request for Build System, Extra Cmake Modules and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> ---
> 
> Let it point to "~/Library/Application Support" as that is what 
> QStandardPaths expects
> 
> This is actually a tricky one - I'd rather have $HOMEBREW_PREFIX/share as 
> data path, but Qt only reports ~/Library/Application\ Support
> 
> So - do we add some magic to Qt to allow user-configurable extra data dirs 
> (juck), implement our own magic (juck), or just change the DATA_INSTALL_DIR 
> to ~/Library/Application\ Support?
> 
> 

Maybe I'm biased to the Unix-way of thinking, but I'm not following why
the person who installed KDE gets to have all the app data under their user.
Or I missing something.  Please enlighten me.

Seems to me the correct solution is $HOMEBREW_PREFIX/share and we need
to adjust QStandardPaths results somehow.  Is KStandardDirs gone in frameworks?
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 115752: Change DATA_INSTALL_DIR on Mac OS X

2014-03-04 Thread Harald Fernengel

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115752/
---

(Updated March 4, 2014, 8:09 p.m.)


Status
--

This change has been discarded.


Review request for Build System, Extra Cmake Modules and KDE Frameworks.


Repository: extra-cmake-modules


Description
---

Let it point to "~/Library/Application Support" as that is what QStandardPaths 
expects

This is actually a tricky one - I'd rather have $HOMEBREW_PREFIX/share as data 
path, but Qt only reports ~/Library/Application\ Support

So - do we add some magic to Qt to allow user-configurable extra data dirs 
(juck), implement our own magic (juck), or just change the DATA_INSTALL_DIR to 
~/Library/Application\ Support?


Diffs
-

  kde-modules/KDEInstallDirs.cmake 9ff23540f00a2794b1ebd842656c3d61b047a500 

Diff: https://git.reviewboard.kde.org/r/115752/diff/


Testing
---

Tested with homebrew tap at https://github.com/haraldF/homebrew-kf5


Thanks,

Harald Fernengel

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 115752: Change DATA_INSTALL_DIR on Mac OS X

2014-02-20 Thread Kevin Ottens


> On Feb. 15, 2014, 3:51 p.m., Alexander Richardson wrote:
> > Same Problem on Windows: https://git.reviewboard.kde.org/r/115210/
> > Further discussion needed I guess

I'd propose the discussion to be started on list then. Once the discussion is 
started this patch can be discarded until we reach a consensus and implement it.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115752/#review49837
---


On Feb. 14, 2014, 6:49 p.m., Harald Fernengel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115752/
> ---
> 
> (Updated Feb. 14, 2014, 6:49 p.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> ---
> 
> Let it point to "~/Library/Application Support" as that is what 
> QStandardPaths expects
> 
> This is actually a tricky one - I'd rather have $HOMEBREW_PREFIX/share as 
> data path, but Qt only reports ~/Library/Application\ Support
> 
> So - do we add some magic to Qt to allow user-configurable extra data dirs 
> (juck), implement our own magic (juck), or just change the DATA_INSTALL_DIR 
> to ~/Library/Application\ Support?
> 
> 
> Diffs
> -
> 
>   kde-modules/KDEInstallDirs.cmake 9ff23540f00a2794b1ebd842656c3d61b047a500 
> 
> Diff: https://git.reviewboard.kde.org/r/115752/diff/
> 
> 
> Testing
> ---
> 
> Tested with homebrew tap at https://github.com/haraldF/homebrew-kf5
> 
> 
> Thanks,
> 
> Harald Fernengel
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 115752: Change DATA_INSTALL_DIR on Mac OS X

2014-02-15 Thread Alexander Richardson

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115752/#review49837
---


Same Problem on Windows: https://git.reviewboard.kde.org/r/115210/
Further discussion needed I guess

- Alexander Richardson


On Feb. 14, 2014, 7:49 p.m., Harald Fernengel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115752/
> ---
> 
> (Updated Feb. 14, 2014, 7:49 p.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> ---
> 
> Let it point to "~/Library/Application Support" as that is what 
> QStandardPaths expects
> 
> This is actually a tricky one - I'd rather have $HOMEBREW_PREFIX/share as 
> data path, but Qt only reports ~/Library/Application\ Support
> 
> So - do we add some magic to Qt to allow user-configurable extra data dirs 
> (juck), implement our own magic (juck), or just change the DATA_INSTALL_DIR 
> to ~/Library/Application\ Support?
> 
> 
> Diffs
> -
> 
>   kde-modules/KDEInstallDirs.cmake 9ff23540f00a2794b1ebd842656c3d61b047a500 
> 
> Diff: https://git.reviewboard.kde.org/r/115752/diff/
> 
> 
> Testing
> ---
> 
> Tested with homebrew tap at https://github.com/haraldF/homebrew-kf5
> 
> 
> Thanks,
> 
> Harald Fernengel
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Review Request 115752: Change DATA_INSTALL_DIR on Mac OS X

2014-02-14 Thread Harald Fernengel

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115752/
---

Review request for Build System, Extra Cmake Modules and KDE Frameworks.


Repository: extra-cmake-modules


Description
---

Let it point to "~/Library/Application Support" as that is what QStandardPaths 
expects

This is actually a tricky one - I'd rather have $HOMEBREW_PREFIX/share as data 
path, but Qt only reports ~/Library/Application\ Support

So - do we add some magic to Qt to allow user-configurable extra data dirs 
(juck), implement our own magic (juck), or just change the DATA_INSTALL_DIR to 
~/Library/Application\ Support?


Diffs
-

  kde-modules/KDEInstallDirs.cmake 9ff23540f00a2794b1ebd842656c3d61b047a500 

Diff: https://git.reviewboard.kde.org/r/115752/diff/


Testing
---

Tested with homebrew tap at https://github.com/haraldF/homebrew-kf5


Thanks,

Harald Fernengel

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel