Re: Review Request 115918: Fix kservice_desktop_to_json for Visual Studio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115918/ --- (Updated March 18, 2014, 12:17 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Stephen Kelly. Repository: kservice Description --- Fix kservice_desktop_to_json for Visual Studio The CMake generator for Visual Studio cannot handle the new build-time kservice_desktop_to_json macro -> fall back to configure-time generation Diffs - KF5ServiceMacros.cmake 55fba4288dd16a97bf388f77c5c923c6136fab81 Diff: https://git.reviewboard.kde.org/r/115918/diff/ Testing --- ktexteditor fails to build before this patch (because moc can't find the .json file), with the patch it compiles Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115918: Fix kservice_desktop_to_json for Visual Studio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115918/#review53313 --- This review has been submitted with commit c1b5bb1298390a2e8a843f710212c193e0d25d50 by Alex Richardson to branch master. - Commit Hook On March 15, 2014, 3:37 p.m., Alexander Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115918/ > --- > > (Updated March 15, 2014, 3:37 p.m.) > > > Review request for KDE Frameworks and Stephen Kelly. > > > Repository: kservice > > > Description > --- > > Fix kservice_desktop_to_json for Visual Studio > > The CMake generator for Visual Studio cannot handle the new build-time > kservice_desktop_to_json macro -> fall back to configure-time generation > > > Diffs > - > > KF5ServiceMacros.cmake 55fba4288dd16a97bf388f77c5c923c6136fab81 > > Diff: https://git.reviewboard.kde.org/r/115918/diff/ > > > Testing > --- > > ktexteditor fails to build before this patch (because moc can't find the > .json file), with the patch it compiles > > > Thanks, > > Alexander Richardson > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115918: Fix kservice_desktop_to_json for Visual Studio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115918/#review53190 --- Ship it! Ship It! - Kevin Ottens On March 15, 2014, 3:37 p.m., Alexander Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115918/ > --- > > (Updated March 15, 2014, 3:37 p.m.) > > > Review request for KDE Frameworks and Stephen Kelly. > > > Repository: kservice > > > Description > --- > > Fix kservice_desktop_to_json for Visual Studio > > The CMake generator for Visual Studio cannot handle the new build-time > kservice_desktop_to_json macro -> fall back to configure-time generation > > > Diffs > - > > KF5ServiceMacros.cmake 55fba4288dd16a97bf388f77c5c923c6136fab81 > > Diff: https://git.reviewboard.kde.org/r/115918/diff/ > > > Testing > --- > > ktexteditor fails to build before this patch (because moc can't find the > .json file), with the patch it compiles > > > Thanks, > > Alexander Richardson > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115918: Fix kservice_desktop_to_json for Visual Studio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115918/ --- (Updated March 15, 2014, 4:37 p.m.) Review request for KDE Frameworks and Stephen Kelly. Repository: kservice Description --- Fix kservice_desktop_to_json for Visual Studio The CMake generator for Visual Studio cannot handle the new build-time kservice_desktop_to_json macro -> fall back to configure-time generation Diffs (updated) - KF5ServiceMacros.cmake 55fba4288dd16a97bf388f77c5c923c6136fab81 Diff: https://git.reviewboard.kde.org/r/115918/diff/ Testing --- ktexteditor fails to build before this patch (because moc can't find the .json file), with the patch it compiles Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115918: Fix kservice_desktop_to_json for Visual Studio
> On March 4, 2014, 8:45 p.m., Kevin Ottens wrote: > > And I agree with Aurélien, a bug should be filed and Stephen involved in > > that issue. > > Stephen Kelly wrote: > Please provide a minimal testcase. The feature is unit tested in cmake. > If it's broken, it needs to be fixed soon (before the final 3.0 release). > > Alexander Richardson wrote: > I'll try to reproduce it with a minimal test case, however I am away > until Sunday, so it will be a while. > > Stephen Kelly wrote: > I've pushed a fix to the cmake next branch. Please test it instead of > committing this patch. > > Another point of note is that you shouldn't read the LOCATION property > from the target. You get a policy warning about that. Use the target name > directly instead. > > Alexander Richardson wrote: > I can confirm that using cmake next branch fixes the issue. > How do I check that the currently used CMake version contains that fix? > > Kevin Ottens wrote: > No idea, anyone? Maybe you want 'NOT VERSION_LESS 3.0'. - Stephen --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115918/#review51946 --- On March 4, 2014, 8:45 p.m., Alexander Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115918/ > --- > > (Updated March 4, 2014, 8:45 p.m.) > > > Review request for KDE Frameworks and Stephen Kelly. > > > Repository: kservice > > > Description > --- > > Fix kservice_desktop_to_json for Visual Studio > > The CMake generator for Visual Studio cannot handle the new build-time > kservice_desktop_to_json macro -> fall back to configure-time generation > > > Diffs > - > > KF5ServiceMacros.cmake f70a185f4cd48293cb9f1e2ca4cf13defaf2aec3 > > Diff: https://git.reviewboard.kde.org/r/115918/diff/ > > > Testing > --- > > ktexteditor fails to build before this patch (because moc can't find the > .json file), with the patch it compiles > > > Thanks, > > Alexander Richardson > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115918: Fix kservice_desktop_to_json for Visual Studio
> On March 4, 2014, 8:45 p.m., Kevin Ottens wrote: > > And I agree with Aurélien, a bug should be filed and Stephen involved in > > that issue. > > Stephen Kelly wrote: > Please provide a minimal testcase. The feature is unit tested in cmake. > If it's broken, it needs to be fixed soon (before the final 3.0 release). > > Alexander Richardson wrote: > I'll try to reproduce it with a minimal test case, however I am away > until Sunday, so it will be a while. > > Stephen Kelly wrote: > I've pushed a fix to the cmake next branch. Please test it instead of > committing this patch. > > Another point of note is that you shouldn't read the LOCATION property > from the target. You get a policy warning about that. Use the target name > directly instead. > > Alexander Richardson wrote: > I can confirm that using cmake next branch fixes the issue. > How do I check that the currently used CMake version contains that fix? No idea, anyone? - Kevin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115918/#review51946 --- On March 4, 2014, 8:45 p.m., Alexander Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115918/ > --- > > (Updated March 4, 2014, 8:45 p.m.) > > > Review request for KDE Frameworks and Stephen Kelly. > > > Repository: kservice > > > Description > --- > > Fix kservice_desktop_to_json for Visual Studio > > The CMake generator for Visual Studio cannot handle the new build-time > kservice_desktop_to_json macro -> fall back to configure-time generation > > > Diffs > - > > KF5ServiceMacros.cmake f70a185f4cd48293cb9f1e2ca4cf13defaf2aec3 > > Diff: https://git.reviewboard.kde.org/r/115918/diff/ > > > Testing > --- > > ktexteditor fails to build before this patch (because moc can't find the > .json file), with the patch it compiles > > > Thanks, > > Alexander Richardson > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115918: Fix kservice_desktop_to_json for Visual Studio
> On March 4, 2014, 9:45 p.m., Kevin Ottens wrote: > > And I agree with Aurélien, a bug should be filed and Stephen involved in > > that issue. > > Stephen Kelly wrote: > Please provide a minimal testcase. The feature is unit tested in cmake. > If it's broken, it needs to be fixed soon (before the final 3.0 release). > > Alexander Richardson wrote: > I'll try to reproduce it with a minimal test case, however I am away > until Sunday, so it will be a while. > > Stephen Kelly wrote: > I've pushed a fix to the cmake next branch. Please test it instead of > committing this patch. > > Another point of note is that you shouldn't read the LOCATION property > from the target. You get a policy warning about that. Use the target name > directly instead. I can confirm that using cmake next branch fixes the issue. How do I check that the currently used CMake version contains that fix? - Alexander --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115918/#review51946 --- On March 4, 2014, 9:45 p.m., Alexander Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115918/ > --- > > (Updated March 4, 2014, 9:45 p.m.) > > > Review request for KDE Frameworks and Stephen Kelly. > > > Repository: kservice > > > Description > --- > > Fix kservice_desktop_to_json for Visual Studio > > The CMake generator for Visual Studio cannot handle the new build-time > kservice_desktop_to_json macro -> fall back to configure-time generation > > > Diffs > - > > KF5ServiceMacros.cmake f70a185f4cd48293cb9f1e2ca4cf13defaf2aec3 > > Diff: https://git.reviewboard.kde.org/r/115918/diff/ > > > Testing > --- > > ktexteditor fails to build before this patch (because moc can't find the > .json file), with the patch it compiles > > > Thanks, > > Alexander Richardson > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115918: Fix kservice_desktop_to_json for Visual Studio
> On March 4, 2014, 8:45 p.m., Kevin Ottens wrote: > > And I agree with Aurélien, a bug should be filed and Stephen involved in > > that issue. > > Stephen Kelly wrote: > Please provide a minimal testcase. The feature is unit tested in cmake. > If it's broken, it needs to be fixed soon (before the final 3.0 release). > > Alexander Richardson wrote: > I'll try to reproduce it with a minimal test case, however I am away > until Sunday, so it will be a while. I've pushed a fix to the cmake next branch. Please test it instead of committing this patch. Another point of note is that you shouldn't read the LOCATION property from the target. You get a policy warning about that. Use the target name directly instead. - Stephen --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115918/#review51946 --- On March 4, 2014, 8:45 p.m., Alexander Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115918/ > --- > > (Updated March 4, 2014, 8:45 p.m.) > > > Review request for KDE Frameworks and Stephen Kelly. > > > Repository: kservice > > > Description > --- > > Fix kservice_desktop_to_json for Visual Studio > > The CMake generator for Visual Studio cannot handle the new build-time > kservice_desktop_to_json macro -> fall back to configure-time generation > > > Diffs > - > > KF5ServiceMacros.cmake f70a185f4cd48293cb9f1e2ca4cf13defaf2aec3 > > Diff: https://git.reviewboard.kde.org/r/115918/diff/ > > > Testing > --- > > ktexteditor fails to build before this patch (because moc can't find the > .json file), with the patch it compiles > > > Thanks, > > Alexander Richardson > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115918: Fix kservice_desktop_to_json for Visual Studio
> On March 4, 2014, 9:45 p.m., Kevin Ottens wrote: > > And I agree with Aurélien, a bug should be filed and Stephen involved in > > that issue. > > Stephen Kelly wrote: > Please provide a minimal testcase. The feature is unit tested in cmake. > If it's broken, it needs to be fixed soon (before the final 3.0 release). I'll try to reproduce it with a minimal test case, however I am away until Sunday, so it will be a while. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115918/#review51946 --- On March 4, 2014, 9:45 p.m., Alexander Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115918/ > --- > > (Updated March 4, 2014, 9:45 p.m.) > > > Review request for KDE Frameworks and Stephen Kelly. > > > Repository: kservice > > > Description > --- > > Fix kservice_desktop_to_json for Visual Studio > > The CMake generator for Visual Studio cannot handle the new build-time > kservice_desktop_to_json macro -> fall back to configure-time generation > > > Diffs > - > > KF5ServiceMacros.cmake f70a185f4cd48293cb9f1e2ca4cf13defaf2aec3 > > Diff: https://git.reviewboard.kde.org/r/115918/diff/ > > > Testing > --- > > ktexteditor fails to build before this patch (because moc can't find the > .json file), with the patch it compiles > > > Thanks, > > Alexander Richardson > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115918: Fix kservice_desktop_to_json for Visual Studio
> On March 4, 2014, 8:45 p.m., Kevin Ottens wrote: > > And I agree with Aurélien, a bug should be filed and Stephen involved in > > that issue. Please provide a minimal testcase. The feature is unit tested in cmake. If it's broken, it needs to be fixed soon (before the final 3.0 release). - Stephen --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115918/#review51946 --- On March 4, 2014, 8:45 p.m., Alexander Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115918/ > --- > > (Updated March 4, 2014, 8:45 p.m.) > > > Review request for KDE Frameworks and Stephen Kelly. > > > Repository: kservice > > > Description > --- > > Fix kservice_desktop_to_json for Visual Studio > > The CMake generator for Visual Studio cannot handle the new build-time > kservice_desktop_to_json macro -> fall back to configure-time generation > > > Diffs > - > > KF5ServiceMacros.cmake f70a185f4cd48293cb9f1e2ca4cf13defaf2aec3 > > Diff: https://git.reviewboard.kde.org/r/115918/diff/ > > > Testing > --- > > ktexteditor fails to build before this patch (because moc can't find the > .json file), with the patch it compiles > > > Thanks, > > Alexander Richardson > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115918: Fix kservice_desktop_to_json for Visual Studio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115918/#review51946 --- Ship it! And I agree with Aurélien, a bug should be filed and Stephen involved in that issue. - Kevin Ottens On March 4, 2014, 8:45 p.m., Alexander Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115918/ > --- > > (Updated March 4, 2014, 8:45 p.m.) > > > Review request for KDE Frameworks and Stephen Kelly. > > > Repository: kservice > > > Description > --- > > Fix kservice_desktop_to_json for Visual Studio > > The CMake generator for Visual Studio cannot handle the new build-time > kservice_desktop_to_json macro -> fall back to configure-time generation > > > Diffs > - > > KF5ServiceMacros.cmake f70a185f4cd48293cb9f1e2ca4cf13defaf2aec3 > > Diff: https://git.reviewboard.kde.org/r/115918/diff/ > > > Testing > --- > > ktexteditor fails to build before this patch (because moc can't find the > .json file), with the patch it compiles > > > Thanks, > > Alexander Richardson > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115918: Fix kservice_desktop_to_json for Visual Studio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115918/ --- (Updated March 4, 2014, 8:45 p.m.) Review request for KDE Frameworks and Stephen Kelly. Repository: kservice Description --- Fix kservice_desktop_to_json for Visual Studio The CMake generator for Visual Studio cannot handle the new build-time kservice_desktop_to_json macro -> fall back to configure-time generation Diffs - KF5ServiceMacros.cmake f70a185f4cd48293cb9f1e2ca4cf13defaf2aec3 Diff: https://git.reviewboard.kde.org/r/115918/diff/ Testing --- ktexteditor fails to build before this patch (because moc can't find the .json file), with the patch it compiles Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115918: Fix kservice_desktop_to_json for Visual Studio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115918/#review51043 --- While this fix would certainly work, I think it would be good to file a bug on CMake bug tracker for that issue (and add the bug id as a comment there). Maybe also ping Stephen Kelly about it, since he wrote the code in CMake which makes it possible to define a command to run before moc. - Aurélien Gâteau On Feb. 20, 2014, 5:58 p.m., Alexander Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115918/ > --- > > (Updated Feb. 20, 2014, 5:58 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kservice > > > Description > --- > > Fix kservice_desktop_to_json for Visual Studio > > The CMake generator for Visual Studio cannot handle the new build-time > kservice_desktop_to_json macro -> fall back to configure-time generation > > > Diffs > - > > KF5ServiceMacros.cmake f70a185f4cd48293cb9f1e2ca4cf13defaf2aec3 > > Diff: https://git.reviewboard.kde.org/r/115918/diff/ > > > Testing > --- > > ktexteditor fails to build before this patch (because moc can't find the > .json file), with the patch it compiles > > > Thanks, > > Alexander Richardson > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115918: Fix kservice_desktop_to_json for Visual Studio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115918/ --- Review request for KDE Frameworks. Repository: kservice Description --- Fix kservice_desktop_to_json for Visual Studio The CMake generator for Visual Studio cannot handle the new build-time kservice_desktop_to_json macro -> fall back to configure-time generation Diffs - KF5ServiceMacros.cmake f70a185f4cd48293cb9f1e2ca4cf13defaf2aec3 Diff: https://git.reviewboard.kde.org/r/115918/diff/ Testing --- ktexteditor fails to build before this patch (because moc can't find the .json file), with the patch it compiles Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
