Re: Review Request 115960: Add sharedConfig() accessor, to avoid manipulating a raw KConfig * as returned by config().
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115960/#review51123 --- This review has been submitted with commit eb604bc60bcc5cd94328de725ac357e728eae624 by David Faure to branch master. - Commit Hook On Feb. 23, 2014, 11:15 a.m., David Faure wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115960/ --- (Updated Feb. 23, 2014, 11:15 a.m.) Review request for KDE Frameworks and Matthew John Dawson. Repository: kconfig Description --- Add sharedConfig() accessor, to avoid manipulating a raw KConfig * as returned by config(). This is useful when using kconfigxt and some other code to read from the same config file (e.g. KColorScheme::contrastF(config)) - no need to call KSharedConfig::openConfig twice, just grab the KSharedConfig from the generated class. Diffs - src/core/kcoreconfigskeleton.h 9cd079941fa6f870a19bdbdb945aafe858b4c51a src/core/kcoreconfigskeleton.cpp 98d9cdccec3cf3925bb68e2d0cff1b5a1276c56a Diff: https://git.reviewboard.kde.org/r/115960/diff/ Testing --- About to use it in kde-workspace. Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115960: Add sharedConfig() accessor, to avoid manipulating a raw KConfig * as returned by config().
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115960/#review50833 --- Ship it! Ship It! - Matthew John Dawson On Feb. 23, 2014, 6:15 a.m., David Faure wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115960/ --- (Updated Feb. 23, 2014, 6:15 a.m.) Review request for KDE Frameworks and Matthew John Dawson. Repository: kconfig Description --- Add sharedConfig() accessor, to avoid manipulating a raw KConfig * as returned by config(). This is useful when using kconfigxt and some other code to read from the same config file (e.g. KColorScheme::contrastF(config)) - no need to call KSharedConfig::openConfig twice, just grab the KSharedConfig from the generated class. Diffs - src/core/kcoreconfigskeleton.h 9cd079941fa6f870a19bdbdb945aafe858b4c51a src/core/kcoreconfigskeleton.cpp 98d9cdccec3cf3925bb68e2d0cff1b5a1276c56a Diff: https://git.reviewboard.kde.org/r/115960/diff/ Testing --- About to use it in kde-workspace. Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115960: Add sharedConfig() accessor, to avoid manipulating a raw KConfig * as returned by config().
On February 23, 2014 11:15:47 AM David Faure wrote: Add sharedConfig() accessor, to avoid manipulating a raw KConfig * as returned by config(). I had thought that when dealing with smart pointers, one should in general always pass around the smart pointer and not the raw pointer behind it. While you can reconstruct the smart pointer from the raw pointer here, there is still a point in time where you may lose access to the pointer if it goes out of scope elsewhere. Thus I'd like to deprecate/get rid of the raw pointer version of that function. However, I understand the frameworks are seeking to maintain source compatibility as much as possible. I looked around on Techbase for some guidance, but I wasn't able to find any. If such documentation exists, could someone point me to it please? Otherwise, could some one outline it? -- Matthew smime.p7s Description: S/MIME cryptographic signature ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115960: Add sharedConfig() accessor, to avoid manipulating a raw KConfig * as returned by config().
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115960/ --- Review request for KDE Frameworks and Matthew John Dawson. Repository: kconfig Description --- Add sharedConfig() accessor, to avoid manipulating a raw KConfig * as returned by config(). This is useful when using kconfigxt and some other code to read from the same config file (e.g. KColorScheme::contrastF(config)) - no need to call KSharedConfig::openConfig twice, just grab the KSharedConfig from the generated class. Diffs - src/core/kcoreconfigskeleton.h 9cd079941fa6f870a19bdbdb945aafe858b4c51a src/core/kcoreconfigskeleton.cpp 98d9cdccec3cf3925bb68e2d0cff1b5a1276c56a Diff: https://git.reviewboard.kde.org/r/115960/diff/ Testing --- About to use it in kde-workspace. Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
