Re: Review Request 116545: Fix KHTML compilation when using clang.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116545/
---
(Updated March 5, 2014, 9:26 a.m.)
Status
--
This change has been marked as submitted.
Review request for KDE Frameworks and David Faure.
Repository: kjs
Description
---
Fix KHTML compilation when using clang.
In file included from src/ecma/kjs_traversal.cpp:21:
src/kjs_traversal.lut.h:49:18: error: constant expression
evaluates to 4294967295 which cannot be narrowed to type 'int'
[-Wc++11-narrowing]
{ "SHOW_ALL", DOM::NodeFilter::SHOW_ALL,
KJS::DontDelete|KJS::ReadOnly, 0, 0 } ,
src/kjs_traversal.lut.h:49:18: note: override this message by
inserting an explicit cast
{ "SHOW_ALL", DOM::NodeFilter::SHOW_ALL,
^
static_cast()
Diffs
-
src/kjs/create_hash_table 94f3e4358a6d78fc7c658369d65b0e75ca131bc8
Diff: https://git.reviewboard.kde.org/r/116545/diff/
Testing
---
Thanks,
Milian Wolff
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116545: Fix KHTML compilation when using clang.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116545/#review52035
---
This review has been submitted with commit
dadacaf995170f44e6d392fce2c3f6c7e4967989 by Milian Wolff to branch master.
- Commit Hook
On March 2, 2014, 9:11 p.m., Milian Wolff wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116545/
> ---
>
> (Updated March 2, 2014, 9:11 p.m.)
>
>
> Review request for KDE Frameworks and David Faure.
>
>
> Repository: kjs
>
>
> Description
> ---
>
> Fix KHTML compilation when using clang.
>
> In file included from src/ecma/kjs_traversal.cpp:21:
> src/kjs_traversal.lut.h:49:18: error: constant expression
> evaluates to 4294967295 which cannot be narrowed to type 'int'
> [-Wc++11-narrowing]
>{ "SHOW_ALL", DOM::NodeFilter::SHOW_ALL,
> KJS::DontDelete|KJS::ReadOnly, 0, 0 } ,
>
> src/kjs_traversal.lut.h:49:18: note: override this message by
> inserting an explicit cast
>{ "SHOW_ALL", DOM::NodeFilter::SHOW_ALL,
> ^
> static_cast()
>
>
> Diffs
> -
>
> src/kjs/create_hash_table 94f3e4358a6d78fc7c658369d65b0e75ca131bc8
>
> Diff: https://git.reviewboard.kde.org/r/116545/diff/
>
>
> Testing
> ---
>
>
> Thanks,
>
> Milian Wolff
>
>
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116545: Fix KHTML compilation when using clang.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116545/#review51953
---
Ship it!
Ship It!
- Kevin Ottens
On March 2, 2014, 9:11 p.m., Milian Wolff wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116545/
> ---
>
> (Updated March 2, 2014, 9:11 p.m.)
>
>
> Review request for KDE Frameworks and David Faure.
>
>
> Repository: kjs
>
>
> Description
> ---
>
> Fix KHTML compilation when using clang.
>
> In file included from src/ecma/kjs_traversal.cpp:21:
> src/kjs_traversal.lut.h:49:18: error: constant expression
> evaluates to 4294967295 which cannot be narrowed to type 'int'
> [-Wc++11-narrowing]
>{ "SHOW_ALL", DOM::NodeFilter::SHOW_ALL,
> KJS::DontDelete|KJS::ReadOnly, 0, 0 } ,
>
> src/kjs_traversal.lut.h:49:18: note: override this message by
> inserting an explicit cast
>{ "SHOW_ALL", DOM::NodeFilter::SHOW_ALL,
> ^
> static_cast()
>
>
> Diffs
> -
>
> src/kjs/create_hash_table 94f3e4358a6d78fc7c658369d65b0e75ca131bc8
>
> Diff: https://git.reviewboard.kde.org/r/116545/diff/
>
>
> Testing
> ---
>
>
> Thanks,
>
> Milian Wolff
>
>
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 116545: Fix KHTML compilation when using clang.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116545/
---
Review request for KDE Frameworks and David Faure.
Repository: kjs
Description
---
Fix KHTML compilation when using clang.
In file included from src/ecma/kjs_traversal.cpp:21:
src/kjs_traversal.lut.h:49:18: error: constant expression
evaluates to 4294967295 which cannot be narrowed to type 'int'
[-Wc++11-narrowing]
{ "SHOW_ALL", DOM::NodeFilter::SHOW_ALL,
KJS::DontDelete|KJS::ReadOnly, 0, 0 } ,
src/kjs_traversal.lut.h:49:18: note: override this message by
inserting an explicit cast
{ "SHOW_ALL", DOM::NodeFilter::SHOW_ALL,
^
static_cast()
Diffs
-
src/kjs/create_hash_table 94f3e4358a6d78fc7c658369d65b0e75ca131bc8
Diff: https://git.reviewboard.kde.org/r/116545/diff/
Testing
---
Thanks,
Milian Wolff
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
