Re: Review Request 116603: Expose the QDialogButtonBox in KPasswordDialog
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116603/ --- (Updated March 5, 2014, 11:49 a.m.) Review request for KDE Frameworks. Changes --- Add documentation, makes the method protected, just in case. Repository: kwidgetsaddons Description --- KPasswordDialog used to be a KDialog. There, users could interact with the buttons setup (like sudlg.cpp in kde-runtime/kdesu). The fact that it was re-based to QDialog, we lost the ability of editing the buttons at all. This change exposes the buttonBox(), so the user re-gains this feature, through QDialogButtonBox. Diffs (updated) - src/kpassworddialog.h 069e301 src/kpassworddialog.cpp cacf31a Diff: https://git.reviewboard.kde.org/r/116603/diff/ Testing --- Ported sudlg.cpp to it, they need it because it requires an Ignore button over there. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116603: Expose the QDialogButtonBox in KPasswordDialog
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116603/ --- (Updated March 5, 2014, 12:04 p.m.) Status -- This change has been discarded. Review request for KDE Frameworks. Repository: kwidgetsaddons Description --- KPasswordDialog used to be a KDialog. There, users could interact with the buttons setup (like sudlg.cpp in kde-runtime/kdesu). The fact that it was re-based to QDialog, we lost the ability of editing the buttons at all. This change exposes the buttonBox(), so the user re-gains this feature, through QDialogButtonBox. Diffs - src/kpassworddialog.h 069e301 src/kpassworddialog.cpp cacf31a Diff: https://git.reviewboard.kde.org/r/116603/diff/ Testing --- Ported sudlg.cpp to it, they need it because it requires an Ignore button over there. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 116603: Expose the QDialogButtonBox in KPasswordDialog
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116603/ --- Review request for KDE Frameworks. Repository: kwidgetsaddons Description --- KPasswordDialog used to be a KDialog. There, users could interact with the buttons setup (like sudlg.cpp in kde-runtime/kdesu). The fact that it was re-based to QDialog, we lost the ability of editing the buttons at all. This change exposes the buttonBox(), so the user re-gains this feature, through QDialogButtonBox. Diffs - src/kpassworddialog.h 069e301 src/kpassworddialog.cpp cacf31a Diff: https://git.reviewboard.kde.org/r/116603/diff/ Testing --- Ported sudlg.cpp to it, they need it because it requires an Ignore button over there. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116603: Expose the QDialogButtonBox in KPasswordDialog
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116603/#review51992 --- Ship it! Should this remain internal API? If yes, please mark it as such. If not, please add some documentation. - Christoph Feck On March 4, 2014, 11:05 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116603/ --- (Updated March 4, 2014, 11:05 p.m.) Review request for KDE Frameworks. Repository: kwidgetsaddons Description --- KPasswordDialog used to be a KDialog. There, users could interact with the buttons setup (like sudlg.cpp in kde-runtime/kdesu). The fact that it was re-based to QDialog, we lost the ability of editing the buttons at all. This change exposes the buttonBox(), so the user re-gains this feature, through QDialogButtonBox. Diffs - src/kpassworddialog.h 069e301 src/kpassworddialog.cpp cacf31a Diff: https://git.reviewboard.kde.org/r/116603/diff/ Testing --- Ported sudlg.cpp to it, they need it because it requires an Ignore button over there. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116603: Expose the QDialogButtonBox in KPasswordDialog
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116603/#review51995 --- src/kpassworddialog.h https://git.reviewboard.kde.org/r/116603/#comment36946 Maybe move this below bool checkPassword() so that it is protected? I don't think it needs to be a public function, being able to customize it in subclasses is fine IMO - Alexander Richardson On March 5, 2014, 12:05 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116603/ --- (Updated March 5, 2014, 12:05 a.m.) Review request for KDE Frameworks. Repository: kwidgetsaddons Description --- KPasswordDialog used to be a KDialog. There, users could interact with the buttons setup (like sudlg.cpp in kde-runtime/kdesu). The fact that it was re-based to QDialog, we lost the ability of editing the buttons at all. This change exposes the buttonBox(), so the user re-gains this feature, through QDialogButtonBox. Diffs - src/kpassworddialog.h 069e301 src/kpassworddialog.cpp cacf31a Diff: https://git.reviewboard.kde.org/r/116603/diff/ Testing --- Ported sudlg.cpp to it, they need it because it requires an Ignore button over there. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
