Review Request 116628: Avoid multiple warnings caused by CMake Policy 0026
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116628/ --- Review request for Build System and KDE Frameworks. Repository: kde4support Description --- I don't think there is a way to make this code CMP0026-compliant. Since it is supposed to not be used in the long run, disable the policy temporarily should be OK. Diffs - cmake/modules/KDE4Macros.cmake 192094b Diff: https://git.reviewboard.kde.org/r/116628/diff/ Testing --- Rebuilt kde-workspace with the change. CMake output is easier to read now. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116628: Avoid multiple warnings caused by CMake Policy 0026
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116628/#review52236 --- Ship it! - Aleix Pol Gonzalez On March 6, 2014, 10:11 a.m., Aurélien Gâteau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116628/ > --- > > (Updated March 6, 2014, 10:11 a.m.) > > > Review request for Build System and KDE Frameworks. > > > Repository: kde4support > > > Description > --- > > I don't think there is a way to make this code CMP0026-compliant. Since it is > supposed to not be used in the long run, disable the policy temporarily > should be OK. > > > Diffs > - > > cmake/modules/KDE4Macros.cmake 192094b > > Diff: https://git.reviewboard.kde.org/r/116628/diff/ > > > Testing > --- > > Rebuilt kde-workspace with the change. CMake output is easier to read now. > > > Thanks, > > Aurélien Gâteau > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116628: Avoid multiple warnings caused by CMake Policy 0026
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116628/#review52246 --- Ship it! Ship It! - Alex Merry On March 6, 2014, 10:11 a.m., Aurélien Gâteau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116628/ > --- > > (Updated March 6, 2014, 10:11 a.m.) > > > Review request for Build System and KDE Frameworks. > > > Repository: kde4support > > > Description > --- > > I don't think there is a way to make this code CMP0026-compliant. Since it is > supposed to not be used in the long run, disable the policy temporarily > should be OK. > > > Diffs > - > > cmake/modules/KDE4Macros.cmake 192094b > > Diff: https://git.reviewboard.kde.org/r/116628/diff/ > > > Testing > --- > > Rebuilt kde-workspace with the change. CMake output is easier to read now. > > > Thanks, > > Aurélien Gâteau > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116628: Avoid multiple warnings caused by CMake Policy 0026
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116628/ --- (Updated March 6, 2014, 4:30 p.m.) Status -- This change has been discarded. Review request for Build System and KDE Frameworks. Repository: kde4support Description --- I don't think there is a way to make this code CMP0026-compliant. Since it is supposed to not be used in the long run, disable the policy temporarily should be OK. Diffs - cmake/modules/KDE4Macros.cmake 192094b Diff: https://git.reviewboard.kde.org/r/116628/diff/ Testing --- Rebuilt kde-workspace with the change. CMake output is easier to read now. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
