Review Request 117017: Remove forward headers for KTextEditor
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117017/ --- Review request for KDE Frameworks and Dominik Haumann. Repository: kde4support Description --- Remove forward headers for KTextEditor Some of the headers have actually been removed already. Keeping broken forward headers actually makes it *more* difficult to port. Diffs - src/includes/KTextEditor/CommandExtension 4187c61882a83cab906fa87cd16bd18229b6efb5 src/includes/KTextEditor/Command 4187c61882a83cab906fa87cd16bd18229b6efb5 src/includes/KTextEditor/CodeCompletionModelControllerInterface a92ceb40a0d0afbf42d8b3302492b8e52a7f8505 src/includes/KTextEditor/CodeCompletionModel 3511d00b212e5c56613bf4f06fedc5a5d76cb3bc src/includes/CMakeLists.txt bc7d00f85012ec436937fd3d402e9c08e28f6b74 src/includes/KTextEditor/Attribute 6420e896e93532188d08894853176842c7d8ccae src/includes/KTextEditor/CodeCompletionInterface 41341c38dd92e7c1533b0ba74eceb735408a1d3f src/includes/KTextEditor/Document 858d360f8ae751c16b03d350d7e415bea400906d src/includes/KTextEditor/Cursor 2811cda0f69b3c263ac8b2dd210b50f6239f7ff2 src/includes/KTextEditor/ConfigPage b3904bee10ffc0245bca1a928389237813850ec3 src/includes/KTextEditor/ConfigInterface 0617835fc7621c4c26a2d50ca95d12d8870fffc2 src/includes/KTextEditor/CommandInterface 4187c61882a83cab906fa87cd16bd18229b6efb5 src/includes/KTextEditor/ModificationInterface 50df2902648156dc5cd4630f587add36d320a43a src/includes/KTextEditor/MessageInterface 41d9aa45a8edb7b9b50e0b82c7b113b6e07bcb32 src/includes/KTextEditor/Editor 76d55675c78248875996b0284288a34af303e8c7 src/includes/KTextEditor/HighlightInterface 8c8c94ec679877be7e3965eba86498f06b67a883 src/includes/KTextEditor/MarkInterface 87adf561b38045bdd65fc3f64f24311aa901d8ee src/includes/KTextEditor/Message 41d9aa45a8edb7b9b50e0b82c7b113b6e07bcb32 src/includes/KTextEditor/ParameterizedSessionConfigInterface 8c26b7d418e81072df4e7dffe0038d7fdc1e3010 src/includes/KTextEditor/MovingRange 89f68605ffa863862476831cfb836660a70e4931 src/includes/KTextEditor/MovingInterface bde16eaca7d68517ce7c2068186eb641daf6eab1 src/includes/KTextEditor/MovingCursor 7c9eb3074e4feace09cca78962caf1ff27bd6394 src/includes/KTextEditor/View 411c995972b47e7a2ad4a385a6924e3a67f8c892 src/includes/KTextEditor/VariableInterface 126a93691700fab3134400907d0ba93a4e275f0d src/includes/KTextEditor/TextHintInterface 6b05d9a4a45ac8807294599e04c7dc15db076cf0 src/includes/KTextEditor/TemplateInterface2 de9d9451796710756287bfc2a627f7ae43a006b1 src/includes/KTextEditor/TemplateInterface 0142d17815fabb9136836effa61114aaa1994635 src/includes/KTextEditor/SessionConfigInterface 8c26b7d418e81072df4e7dffe0038d7fdc1e3010 src/includes/KTextEditor/Range 15aad643ee6f1f95b96f579bc66cc84f4873d006 src/includes/KTextEditor/SearchInterface f7dffc91739e82cceffea35de0632cb19e92ab0a src/includes/KTextEditor/Plugin 1016b2e5c5f930afcceb1110b00468ee1158cf7e Diff: https://git.reviewboard.kde.org/r/117017/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117017: Remove forward headers for KTextEditor
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117017/#review53937 --- There's a slight difference, and the reason we haven't been doing this for most headers. From KDE4Support you can include headers prefixing KDE/ (such as KDE/KTextEditor/MovingRange). If you remove these that won't be possible anymore thus making porting slightly harder. Arguably people won't be doing KDE/KTextEditor, but then I don't know why people added the KDE/ at all... - Aleix Pol Gonzalez On March 24, 2014, 10:48 a.m., Kevin Funk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117017/ > --- > > (Updated March 24, 2014, 10:48 a.m.) > > > Review request for KDE Frameworks and Dominik Haumann. > > > Repository: kde4support > > > Description > --- > > Remove forward headers for KTextEditor > > Some of the headers have actually been removed already. Keeping broken > forward headers actually makes it *more* difficult to port. > > > Diffs > - > > src/includes/KTextEditor/CommandExtension > 4187c61882a83cab906fa87cd16bd18229b6efb5 > src/includes/KTextEditor/Command 4187c61882a83cab906fa87cd16bd18229b6efb5 > src/includes/KTextEditor/CodeCompletionModelControllerInterface > a92ceb40a0d0afbf42d8b3302492b8e52a7f8505 > src/includes/KTextEditor/CodeCompletionModel > 3511d00b212e5c56613bf4f06fedc5a5d76cb3bc > src/includes/CMakeLists.txt bc7d00f85012ec436937fd3d402e9c08e28f6b74 > src/includes/KTextEditor/Attribute 6420e896e93532188d08894853176842c7d8ccae > src/includes/KTextEditor/CodeCompletionInterface > 41341c38dd92e7c1533b0ba74eceb735408a1d3f > src/includes/KTextEditor/Document 858d360f8ae751c16b03d350d7e415bea400906d > src/includes/KTextEditor/Cursor 2811cda0f69b3c263ac8b2dd210b50f6239f7ff2 > src/includes/KTextEditor/ConfigPage > b3904bee10ffc0245bca1a928389237813850ec3 > src/includes/KTextEditor/ConfigInterface > 0617835fc7621c4c26a2d50ca95d12d8870fffc2 > src/includes/KTextEditor/CommandInterface > 4187c61882a83cab906fa87cd16bd18229b6efb5 > src/includes/KTextEditor/ModificationInterface > 50df2902648156dc5cd4630f587add36d320a43a > src/includes/KTextEditor/MessageInterface > 41d9aa45a8edb7b9b50e0b82c7b113b6e07bcb32 > src/includes/KTextEditor/Editor 76d55675c78248875996b0284288a34af303e8c7 > src/includes/KTextEditor/HighlightInterface > 8c8c94ec679877be7e3965eba86498f06b67a883 > src/includes/KTextEditor/MarkInterface > 87adf561b38045bdd65fc3f64f24311aa901d8ee > src/includes/KTextEditor/Message 41d9aa45a8edb7b9b50e0b82c7b113b6e07bcb32 > src/includes/KTextEditor/ParameterizedSessionConfigInterface > 8c26b7d418e81072df4e7dffe0038d7fdc1e3010 > src/includes/KTextEditor/MovingRange > 89f68605ffa863862476831cfb836660a70e4931 > src/includes/KTextEditor/MovingInterface > bde16eaca7d68517ce7c2068186eb641daf6eab1 > src/includes/KTextEditor/MovingCursor > 7c9eb3074e4feace09cca78962caf1ff27bd6394 > src/includes/KTextEditor/View 411c995972b47e7a2ad4a385a6924e3a67f8c892 > src/includes/KTextEditor/VariableInterface > 126a93691700fab3134400907d0ba93a4e275f0d > src/includes/KTextEditor/TextHintInterface > 6b05d9a4a45ac8807294599e04c7dc15db076cf0 > src/includes/KTextEditor/TemplateInterface2 > de9d9451796710756287bfc2a627f7ae43a006b1 > src/includes/KTextEditor/TemplateInterface > 0142d17815fabb9136836effa61114aaa1994635 > src/includes/KTextEditor/SessionConfigInterface > 8c26b7d418e81072df4e7dffe0038d7fdc1e3010 > src/includes/KTextEditor/Range 15aad643ee6f1f95b96f579bc66cc84f4873d006 > src/includes/KTextEditor/SearchInterface > f7dffc91739e82cceffea35de0632cb19e92ab0a > src/includes/KTextEditor/Plugin 1016b2e5c5f930afcceb1110b00468ee1158cf7e > > Diff: https://git.reviewboard.kde.org/r/117017/diff/ > > > Testing > --- > > > Thanks, > > Kevin Funk > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117017: Remove forward headers for KTextEditor
> On March 24, 2014, 10:57 a.m., Aleix Pol Gonzalez wrote: > > There's a slight difference, and the reason we haven't been doing this for > > most headers. From KDE4Support you can include headers prefixing KDE/ (such > > as KDE/KTextEditor/MovingRange). If you remove these that won't be possible > > anymore thus making porting slightly harder. Arguably people won't be doing > > KDE/KTextEditor, but then I don't know why people added the KDE/ at all... Yep. I'm just fixing this up in KDevelop (where I hit that problem), replacing occurences of 'KDE/'. The problem with the KTE forward headers are that some of them are already broken (TemplateInterface*, HighlightInterface, and others). This makes it harder than easier to port, because you get compile errors in the middle of the build process. Arguably, I'd rather force people to get rid off the 'KDE/' prefix (which is easy to script) than to compile again and again to make your code work. - Kevin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117017/#review53937 --- On March 24, 2014, 10:48 a.m., Kevin Funk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117017/ > --- > > (Updated March 24, 2014, 10:48 a.m.) > > > Review request for KDE Frameworks and Dominik Haumann. > > > Repository: kde4support > > > Description > --- > > Remove forward headers for KTextEditor > > Some of the headers have actually been removed already. Keeping broken > forward headers actually makes it *more* difficult to port. > > > Diffs > - > > src/includes/KTextEditor/CommandExtension > 4187c61882a83cab906fa87cd16bd18229b6efb5 > src/includes/KTextEditor/Command 4187c61882a83cab906fa87cd16bd18229b6efb5 > src/includes/KTextEditor/CodeCompletionModelControllerInterface > a92ceb40a0d0afbf42d8b3302492b8e52a7f8505 > src/includes/KTextEditor/CodeCompletionModel > 3511d00b212e5c56613bf4f06fedc5a5d76cb3bc > src/includes/CMakeLists.txt bc7d00f85012ec436937fd3d402e9c08e28f6b74 > src/includes/KTextEditor/Attribute 6420e896e93532188d08894853176842c7d8ccae > src/includes/KTextEditor/CodeCompletionInterface > 41341c38dd92e7c1533b0ba74eceb735408a1d3f > src/includes/KTextEditor/Document 858d360f8ae751c16b03d350d7e415bea400906d > src/includes/KTextEditor/Cursor 2811cda0f69b3c263ac8b2dd210b50f6239f7ff2 > src/includes/KTextEditor/ConfigPage > b3904bee10ffc0245bca1a928389237813850ec3 > src/includes/KTextEditor/ConfigInterface > 0617835fc7621c4c26a2d50ca95d12d8870fffc2 > src/includes/KTextEditor/CommandInterface > 4187c61882a83cab906fa87cd16bd18229b6efb5 > src/includes/KTextEditor/ModificationInterface > 50df2902648156dc5cd4630f587add36d320a43a > src/includes/KTextEditor/MessageInterface > 41d9aa45a8edb7b9b50e0b82c7b113b6e07bcb32 > src/includes/KTextEditor/Editor 76d55675c78248875996b0284288a34af303e8c7 > src/includes/KTextEditor/HighlightInterface > 8c8c94ec679877be7e3965eba86498f06b67a883 > src/includes/KTextEditor/MarkInterface > 87adf561b38045bdd65fc3f64f24311aa901d8ee > src/includes/KTextEditor/Message 41d9aa45a8edb7b9b50e0b82c7b113b6e07bcb32 > src/includes/KTextEditor/ParameterizedSessionConfigInterface > 8c26b7d418e81072df4e7dffe0038d7fdc1e3010 > src/includes/KTextEditor/MovingRange > 89f68605ffa863862476831cfb836660a70e4931 > src/includes/KTextEditor/MovingInterface > bde16eaca7d68517ce7c2068186eb641daf6eab1 > src/includes/KTextEditor/MovingCursor > 7c9eb3074e4feace09cca78962caf1ff27bd6394 > src/includes/KTextEditor/View 411c995972b47e7a2ad4a385a6924e3a67f8c892 > src/includes/KTextEditor/VariableInterface > 126a93691700fab3134400907d0ba93a4e275f0d > src/includes/KTextEditor/TextHintInterface > 6b05d9a4a45ac8807294599e04c7dc15db076cf0 > src/includes/KTextEditor/TemplateInterface2 > de9d9451796710756287bfc2a627f7ae43a006b1 > src/includes/KTextEditor/TemplateInterface > 0142d17815fabb9136836effa61114aaa1994635 > src/includes/KTextEditor/SessionConfigInterface > 8c26b7d418e81072df4e7dffe0038d7fdc1e3010 > src/includes/KTextEditor/Range 15aad643ee6f1f95b96f579bc66cc84f4873d006 > src/includes/KTextEditor/SearchInterface > f7dffc91739e82cceffea35de0632cb19e92ab0a > src/includes/KTextEditor/Plugin 1016b2e5c5f930afcceb1110b00468ee1158cf7e > > Diff: https://git.reviewboard.kde.org/r/117017/diff/ > > > Testing > --- > > > Thanks, > > Kevin Funk > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117017: Remove forward headers for KTextEditor
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117017/#review53970 --- Ship it! Ship It! - Christoph Cullmann On March 24, 2014, 10:48 a.m., Kevin Funk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117017/ > --- > > (Updated March 24, 2014, 10:48 a.m.) > > > Review request for KDE Frameworks and Dominik Haumann. > > > Repository: kde4support > > > Description > --- > > Remove forward headers for KTextEditor > > Some of the headers have actually been removed already. Keeping broken > forward headers actually makes it *more* difficult to port. > > > Diffs > - > > src/includes/KTextEditor/CommandExtension > 4187c61882a83cab906fa87cd16bd18229b6efb5 > src/includes/KTextEditor/Command 4187c61882a83cab906fa87cd16bd18229b6efb5 > src/includes/KTextEditor/CodeCompletionModelControllerInterface > a92ceb40a0d0afbf42d8b3302492b8e52a7f8505 > src/includes/KTextEditor/CodeCompletionModel > 3511d00b212e5c56613bf4f06fedc5a5d76cb3bc > src/includes/CMakeLists.txt bc7d00f85012ec436937fd3d402e9c08e28f6b74 > src/includes/KTextEditor/Attribute 6420e896e93532188d08894853176842c7d8ccae > src/includes/KTextEditor/CodeCompletionInterface > 41341c38dd92e7c1533b0ba74eceb735408a1d3f > src/includes/KTextEditor/Document 858d360f8ae751c16b03d350d7e415bea400906d > src/includes/KTextEditor/Cursor 2811cda0f69b3c263ac8b2dd210b50f6239f7ff2 > src/includes/KTextEditor/ConfigPage > b3904bee10ffc0245bca1a928389237813850ec3 > src/includes/KTextEditor/ConfigInterface > 0617835fc7621c4c26a2d50ca95d12d8870fffc2 > src/includes/KTextEditor/CommandInterface > 4187c61882a83cab906fa87cd16bd18229b6efb5 > src/includes/KTextEditor/ModificationInterface > 50df2902648156dc5cd4630f587add36d320a43a > src/includes/KTextEditor/MessageInterface > 41d9aa45a8edb7b9b50e0b82c7b113b6e07bcb32 > src/includes/KTextEditor/Editor 76d55675c78248875996b0284288a34af303e8c7 > src/includes/KTextEditor/HighlightInterface > 8c8c94ec679877be7e3965eba86498f06b67a883 > src/includes/KTextEditor/MarkInterface > 87adf561b38045bdd65fc3f64f24311aa901d8ee > src/includes/KTextEditor/Message 41d9aa45a8edb7b9b50e0b82c7b113b6e07bcb32 > src/includes/KTextEditor/ParameterizedSessionConfigInterface > 8c26b7d418e81072df4e7dffe0038d7fdc1e3010 > src/includes/KTextEditor/MovingRange > 89f68605ffa863862476831cfb836660a70e4931 > src/includes/KTextEditor/MovingInterface > bde16eaca7d68517ce7c2068186eb641daf6eab1 > src/includes/KTextEditor/MovingCursor > 7c9eb3074e4feace09cca78962caf1ff27bd6394 > src/includes/KTextEditor/View 411c995972b47e7a2ad4a385a6924e3a67f8c892 > src/includes/KTextEditor/VariableInterface > 126a93691700fab3134400907d0ba93a4e275f0d > src/includes/KTextEditor/TextHintInterface > 6b05d9a4a45ac8807294599e04c7dc15db076cf0 > src/includes/KTextEditor/TemplateInterface2 > de9d9451796710756287bfc2a627f7ae43a006b1 > src/includes/KTextEditor/TemplateInterface > 0142d17815fabb9136836effa61114aaa1994635 > src/includes/KTextEditor/SessionConfigInterface > 8c26b7d418e81072df4e7dffe0038d7fdc1e3010 > src/includes/KTextEditor/Range 15aad643ee6f1f95b96f579bc66cc84f4873d006 > src/includes/KTextEditor/SearchInterface > f7dffc91739e82cceffea35de0632cb19e92ab0a > src/includes/KTextEditor/Plugin 1016b2e5c5f930afcceb1110b00468ee1158cf7e > > Diff: https://git.reviewboard.kde.org/r/117017/diff/ > > > Testing > --- > > > Thanks, > > Kevin Funk > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117017: Remove forward headers for KTextEditor
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117017/#review53981 --- This review has been submitted with commit a2f6dfd6814f75c18dd4e91a6a28932db6cef5bf by Kevin Funk to branch master. - Commit Hook On March 24, 2014, 10:48 a.m., Kevin Funk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117017/ > --- > > (Updated March 24, 2014, 10:48 a.m.) > > > Review request for KDE Frameworks and Dominik Haumann. > > > Repository: kde4support > > > Description > --- > > Remove forward headers for KTextEditor > > Some of the headers have actually been removed already. Keeping broken > forward headers actually makes it *more* difficult to port. > > > Diffs > - > > src/includes/KTextEditor/CommandExtension > 4187c61882a83cab906fa87cd16bd18229b6efb5 > src/includes/KTextEditor/Command 4187c61882a83cab906fa87cd16bd18229b6efb5 > src/includes/KTextEditor/CodeCompletionModelControllerInterface > a92ceb40a0d0afbf42d8b3302492b8e52a7f8505 > src/includes/KTextEditor/CodeCompletionModel > 3511d00b212e5c56613bf4f06fedc5a5d76cb3bc > src/includes/CMakeLists.txt bc7d00f85012ec436937fd3d402e9c08e28f6b74 > src/includes/KTextEditor/Attribute 6420e896e93532188d08894853176842c7d8ccae > src/includes/KTextEditor/CodeCompletionInterface > 41341c38dd92e7c1533b0ba74eceb735408a1d3f > src/includes/KTextEditor/Document 858d360f8ae751c16b03d350d7e415bea400906d > src/includes/KTextEditor/Cursor 2811cda0f69b3c263ac8b2dd210b50f6239f7ff2 > src/includes/KTextEditor/ConfigPage > b3904bee10ffc0245bca1a928389237813850ec3 > src/includes/KTextEditor/ConfigInterface > 0617835fc7621c4c26a2d50ca95d12d8870fffc2 > src/includes/KTextEditor/CommandInterface > 4187c61882a83cab906fa87cd16bd18229b6efb5 > src/includes/KTextEditor/ModificationInterface > 50df2902648156dc5cd4630f587add36d320a43a > src/includes/KTextEditor/MessageInterface > 41d9aa45a8edb7b9b50e0b82c7b113b6e07bcb32 > src/includes/KTextEditor/Editor 76d55675c78248875996b0284288a34af303e8c7 > src/includes/KTextEditor/HighlightInterface > 8c8c94ec679877be7e3965eba86498f06b67a883 > src/includes/KTextEditor/MarkInterface > 87adf561b38045bdd65fc3f64f24311aa901d8ee > src/includes/KTextEditor/Message 41d9aa45a8edb7b9b50e0b82c7b113b6e07bcb32 > src/includes/KTextEditor/ParameterizedSessionConfigInterface > 8c26b7d418e81072df4e7dffe0038d7fdc1e3010 > src/includes/KTextEditor/MovingRange > 89f68605ffa863862476831cfb836660a70e4931 > src/includes/KTextEditor/MovingInterface > bde16eaca7d68517ce7c2068186eb641daf6eab1 > src/includes/KTextEditor/MovingCursor > 7c9eb3074e4feace09cca78962caf1ff27bd6394 > src/includes/KTextEditor/View 411c995972b47e7a2ad4a385a6924e3a67f8c892 > src/includes/KTextEditor/VariableInterface > 126a93691700fab3134400907d0ba93a4e275f0d > src/includes/KTextEditor/TextHintInterface > 6b05d9a4a45ac8807294599e04c7dc15db076cf0 > src/includes/KTextEditor/TemplateInterface2 > de9d9451796710756287bfc2a627f7ae43a006b1 > src/includes/KTextEditor/TemplateInterface > 0142d17815fabb9136836effa61114aaa1994635 > src/includes/KTextEditor/SessionConfigInterface > 8c26b7d418e81072df4e7dffe0038d7fdc1e3010 > src/includes/KTextEditor/Range 15aad643ee6f1f95b96f579bc66cc84f4873d006 > src/includes/KTextEditor/SearchInterface > f7dffc91739e82cceffea35de0632cb19e92ab0a > src/includes/KTextEditor/Plugin 1016b2e5c5f930afcceb1110b00468ee1158cf7e > > Diff: https://git.reviewboard.kde.org/r/117017/diff/ > > > Testing > --- > > > Thanks, > > Kevin Funk > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117017: Remove forward headers for KTextEditor
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117017/ --- (Updated March 24, 2014, 2:58 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Dominik Haumann. Repository: kde4support Description --- Remove forward headers for KTextEditor Some of the headers have actually been removed already. Keeping broken forward headers actually makes it *more* difficult to port. Diffs - src/includes/KTextEditor/CommandExtension 4187c61882a83cab906fa87cd16bd18229b6efb5 src/includes/KTextEditor/Command 4187c61882a83cab906fa87cd16bd18229b6efb5 src/includes/KTextEditor/CodeCompletionModelControllerInterface a92ceb40a0d0afbf42d8b3302492b8e52a7f8505 src/includes/KTextEditor/CodeCompletionModel 3511d00b212e5c56613bf4f06fedc5a5d76cb3bc src/includes/CMakeLists.txt bc7d00f85012ec436937fd3d402e9c08e28f6b74 src/includes/KTextEditor/Attribute 6420e896e93532188d08894853176842c7d8ccae src/includes/KTextEditor/CodeCompletionInterface 41341c38dd92e7c1533b0ba74eceb735408a1d3f src/includes/KTextEditor/Document 858d360f8ae751c16b03d350d7e415bea400906d src/includes/KTextEditor/Cursor 2811cda0f69b3c263ac8b2dd210b50f6239f7ff2 src/includes/KTextEditor/ConfigPage b3904bee10ffc0245bca1a928389237813850ec3 src/includes/KTextEditor/ConfigInterface 0617835fc7621c4c26a2d50ca95d12d8870fffc2 src/includes/KTextEditor/CommandInterface 4187c61882a83cab906fa87cd16bd18229b6efb5 src/includes/KTextEditor/ModificationInterface 50df2902648156dc5cd4630f587add36d320a43a src/includes/KTextEditor/MessageInterface 41d9aa45a8edb7b9b50e0b82c7b113b6e07bcb32 src/includes/KTextEditor/Editor 76d55675c78248875996b0284288a34af303e8c7 src/includes/KTextEditor/HighlightInterface 8c8c94ec679877be7e3965eba86498f06b67a883 src/includes/KTextEditor/MarkInterface 87adf561b38045bdd65fc3f64f24311aa901d8ee src/includes/KTextEditor/Message 41d9aa45a8edb7b9b50e0b82c7b113b6e07bcb32 src/includes/KTextEditor/ParameterizedSessionConfigInterface 8c26b7d418e81072df4e7dffe0038d7fdc1e3010 src/includes/KTextEditor/MovingRange 89f68605ffa863862476831cfb836660a70e4931 src/includes/KTextEditor/MovingInterface bde16eaca7d68517ce7c2068186eb641daf6eab1 src/includes/KTextEditor/MovingCursor 7c9eb3074e4feace09cca78962caf1ff27bd6394 src/includes/KTextEditor/View 411c995972b47e7a2ad4a385a6924e3a67f8c892 src/includes/KTextEditor/VariableInterface 126a93691700fab3134400907d0ba93a4e275f0d src/includes/KTextEditor/TextHintInterface 6b05d9a4a45ac8807294599e04c7dc15db076cf0 src/includes/KTextEditor/TemplateInterface2 de9d9451796710756287bfc2a627f7ae43a006b1 src/includes/KTextEditor/TemplateInterface 0142d17815fabb9136836effa61114aaa1994635 src/includes/KTextEditor/SessionConfigInterface 8c26b7d418e81072df4e7dffe0038d7fdc1e3010 src/includes/KTextEditor/Range 15aad643ee6f1f95b96f579bc66cc84f4873d006 src/includes/KTextEditor/SearchInterface f7dffc91739e82cceffea35de0632cb19e92ab0a src/includes/KTextEditor/Plugin 1016b2e5c5f930afcceb1110b00468ee1158cf7e Diff: https://git.reviewboard.kde.org/r/117017/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel