Review Request 117952: Fix KIO::suggestName() for the case of leading dots, and no other dot.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117952/ --- Review request for KDE Frameworks and Kevin Funk. Repository: kio Description --- Fix KIO::suggestName() for the case of leading dots, and no other dot. We don't want to change the extension in that case. With a unittest for that method, finally. Diffs - autotests/globaltest.h b955329cf7d5841d9f9c1230e41d1261a268420e autotests/globaltest.cpp 4367e53b44e077c566316081e21f429ac15b74a0 src/core/global.cpp b6f523d66ef5b9308f615c485d6dcf3069b26ace Diff: https://git.reviewboard.kde.org/r/117952/diff/ Testing --- Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117952: Fix KIO::suggestName() for the case of leading dots, and no other dot.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117952/#review57150 --- Ship it! LGTM - Kevin Funk On May 2, 2014, 4:12 p.m., David Faure wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117952/ --- (Updated May 2, 2014, 4:12 p.m.) Review request for KDE Frameworks and Kevin Funk. Repository: kio Description --- Fix KIO::suggestName() for the case of leading dots, and no other dot. We don't want to change the extension in that case. With a unittest for that method, finally. Diffs - autotests/globaltest.h b955329cf7d5841d9f9c1230e41d1261a268420e autotests/globaltest.cpp 4367e53b44e077c566316081e21f429ac15b74a0 src/core/global.cpp b6f523d66ef5b9308f615c485d6dcf3069b26ace Diff: https://git.reviewboard.kde.org/r/117952/diff/ Testing --- Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117952: Fix KIO::suggestName() for the case of leading dots, and no other dot.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117952/ --- (Updated May 2, 2014, 4:30 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Kevin Funk. Repository: kio Description --- Fix KIO::suggestName() for the case of leading dots, and no other dot. We don't want to change the extension in that case. With a unittest for that method, finally. Diffs - autotests/globaltest.h b955329cf7d5841d9f9c1230e41d1261a268420e autotests/globaltest.cpp 4367e53b44e077c566316081e21f429ac15b74a0 src/core/global.cpp b6f523d66ef5b9308f615c485d6dcf3069b26ace Diff: https://git.reviewboard.kde.org/r/117952/diff/ Testing --- Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
