Re: Review Request 121160: Add libgit2 compile-time check for threads support

2014-11-17 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121160/#review70555
---



src/utils/kateglobal.cpp


#if defined(HAVE_GIT2) && defined(HAVE_GIT2_THREADS)


- Aleix Pol Gonzalez


On Nov. 17, 2014, 10:45 p.m., Kevin Funk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121160/
> ---
> 
> (Updated Nov. 17, 2014, 10:45 p.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Cullmann.
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> ---
> 
> Add libgit2 compile-time check for threads support
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 5cace5fead7c80ede9fa82643426ab5a5e5a4035 
>   src/test_libgit2_threads.c PRE-CREATION 
>   src/utils/kateglobal.cpp 6e3362802c213c914430a4775ab15e3515729474 
> 
> Diff: https://git.reviewboard.kde.org/r/121160/diff/
> 
> 
> Testing
> ---
> 
> Should fix the CI failure. Compiles fine for me (with threads support)
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121160: Add libgit2 compile-time check for threads support

2014-11-17 Thread Kevin Funk 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121160/
---

(Updated Nov. 17, 2014, 10:45 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Christoph Cullmann.


Repository: ktexteditor


Description
---

Add libgit2 compile-time check for threads support


Diffs
-

  CMakeLists.txt 5cace5fead7c80ede9fa82643426ab5a5e5a4035 
  src/test_libgit2_threads.c PRE-CREATION 
  src/utils/kateglobal.cpp 6e3362802c213c914430a4775ab15e3515729474 

Diff: https://git.reviewboard.kde.org/r/121160/diff/


Testing
---

Should fix the CI failure. Compiles fine for me (with threads support)


Thanks,

Kevin Funk

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121160: Add libgit2 compile-time check for threads support

2014-11-17 Thread Christoph Cullmann 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121160/#review70541
---

Ship it!


Ship It!

- Christoph Cullmann


On Nov. 17, 2014, 8:11 p.m., Kevin Funk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121160/
> ---
> 
> (Updated Nov. 17, 2014, 8:11 p.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Cullmann.
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> ---
> 
> Add libgit2 compile-time check for threads support
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 5cace5fead7c80ede9fa82643426ab5a5e5a4035 
>   src/test_libgit2_threads.c PRE-CREATION 
>   src/utils/kateglobal.cpp 6e3362802c213c914430a4775ab15e3515729474 
> 
> Diff: https://git.reviewboard.kde.org/r/121160/diff/
> 
> 
> Testing
> ---
> 
> Should fix the CI failure. Compiles fine for me (with threads support)
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121160: Add libgit2 compile-time check for threads support

2014-11-17 Thread Marko Käning 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121160/#review70538
---

Ship it!


This does indeed work on OSX/CI.

- Marko Käning


On Nov. 17, 2014, 9:11 p.m., Kevin Funk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121160/
> ---
> 
> (Updated Nov. 17, 2014, 9:11 p.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Cullmann.
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> ---
> 
> Add libgit2 compile-time check for threads support
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 5cace5fead7c80ede9fa82643426ab5a5e5a4035 
>   src/test_libgit2_threads.c PRE-CREATION 
>   src/utils/kateglobal.cpp 6e3362802c213c914430a4775ab15e3515729474 
> 
> Diff: https://git.reviewboard.kde.org/r/121160/diff/
> 
> 
> Testing
> ---
> 
> Should fix the CI failure. Compiles fine for me (with threads support)
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 121160: Add libgit2 compile-time check for threads support

2014-11-17 Thread Kevin Funk 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121160/
---

Review request for KDE Frameworks and Christoph Cullmann.


Repository: ktexteditor


Description
---

Add libgit2 compile-time check for threads support


Diffs
-

  CMakeLists.txt 5cace5fead7c80ede9fa82643426ab5a5e5a4035 
  src/test_libgit2_threads.c PRE-CREATION 
  src/utils/kateglobal.cpp 6e3362802c213c914430a4775ab15e3515729474 

Diff: https://git.reviewboard.kde.org/r/121160/diff/


Testing
---

Should fix the CI failure. Compiles fine for me (with threads support)


Thanks,

Kevin Funk

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel