Re: Review Request 122613: Do not add an extra slash if item does not have a host (KUrlComboBoxPrivate::textForItem)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122613/ --- (Updated March 22, 2015, 5:18 p.m.) Review request for KDE Frameworks. Changes --- Change code as suggested by David, also added test. Repository: kio Description --- The rest of kio internally is doing this correctly apparently it was only a problem in the GUI part of it. Diffs (updated) - autotests/kurlcomboboxtest.h PRE-CREATION autotests/kurlcomboboxtest.cpp PRE-CREATION src/widgets/kurlcombobox.cpp ed5b8a2 Diff: https://git.reviewboard.kde.org/r/122613/diff/ Testing --- Besides the added unit tests, I have used this patch while running a few ups, everything seems to work great. Thanks, Àlex Fiestas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122613: Do not add an extra slash if item does not have a host (KUrlComboBoxPrivate::textForItem)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122613/ --- (Updated March 22, 2015, 5:25 p.m.) Review request for KDE Frameworks. Repository: kio Description --- The rest of kio internally is doing this correctly apparently it was only a problem in the GUI part of it. Diffs (updated) - autotests/CMakeLists.txt 69c8957 autotests/kurlcomboboxtest.h PRE-CREATION autotests/kurlcomboboxtest.cpp PRE-CREATION src/widgets/kurlcombobox.cpp ed5b8a2 Diff: https://git.reviewboard.kde.org/r/122613/diff/ Testing --- Besides the added unit tests, I have used this patch while running a few ups, everything seems to work great. Thanks, Àlex Fiestas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122613: Do not add an extra slash if item does not have a host (KUrlComboBoxPrivate::textForItem)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122613/#review77921 --- Ship it! Ship It! - David Faure On March 22, 2015, 5:25 p.m., Àlex Fiestas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122613/ --- (Updated March 22, 2015, 5:25 p.m.) Review request for KDE Frameworks. Repository: kio Description --- The rest of kio internally is doing this correctly apparently it was only a problem in the GUI part of it. Diffs - autotests/CMakeLists.txt 69c8957 autotests/kurlcomboboxtest.h PRE-CREATION autotests/kurlcomboboxtest.cpp PRE-CREATION src/widgets/kurlcombobox.cpp ed5b8a2 Diff: https://git.reviewboard.kde.org/r/122613/diff/ Testing --- Besides the added unit tests, I have used this patch while running a few ups, everything seems to work great. Thanks, Àlex Fiestas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122613: Do not add an extra slash if item does not have a host (KUrlComboBoxPrivate::textForItem)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122613/ --- (Updated March 23, 2015, 12:34 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit f00990e3a5b7178d75278429c426fc9d953d49de by Àlex Fiestas to branch master. Repository: kio Description --- The rest of kio internally is doing this correctly apparently it was only a problem in the GUI part of it. Diffs - autotests/CMakeLists.txt 69c8957 autotests/kurlcomboboxtest.h PRE-CREATION autotests/kurlcomboboxtest.cpp PRE-CREATION src/widgets/kurlcombobox.cpp ed5b8a2 Diff: https://git.reviewboard.kde.org/r/122613/diff/ Testing --- Besides the added unit tests, I have used this patch while running a few ups, everything seems to work great. Thanks, Àlex Fiestas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122613: Do not add an extra slash if item does not have a host (KUrlComboBoxPrivate::textForItem)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122613/#review77148 --- src/widgets/kurlcombobox.cpp https://git.reviewboard.kde.org/r/122613/#comment53006 A better check would be if (!url.path().isEmpty() ...) The reasoning being that empty path isn't the same as / (e.g. for FTP, empty path means $HOME on the ftp server, while / is the root). i.e. add this testcase: ftp://u...@example.com This should not turn into ftp://u...@example.com/ - David Faure On Feb. 18, 2015, 8:46 p.m., Àlex Fiestas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122613/ --- (Updated Feb. 18, 2015, 8:46 p.m.) Review request for KDE Frameworks. Repository: kio Description --- The rest of kio internally is doing this correctly apparently it was only a problem in the GUI part of it. Diffs - autotests/CMakeLists.txt f613c1a autotests/kurlcomboboxtest.h PRE-CREATION autotests/kurlcomboboxtest.cpp PRE-CREATION src/widgets/kurlcombobox.cpp ed5b8a2 Diff: https://git.reviewboard.kde.org/r/122613/diff/ Testing --- Besides the added unit tests, I have used this patch while running a few ups, everything seems to work great. Thanks, Àlex Fiestas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122613: Do not add an extra slash if item does not have a host (KUrlComboBoxPrivate::textForItem)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122613/#review76712 --- Hey, anybody can review it? - Àlex Fiestas On feb. 18, 2015, 8:46 p.m., Àlex Fiestas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122613/ --- (Updated feb. 18, 2015, 8:46 p.m.) Review request for KDE Frameworks. Repository: kio Description --- The rest of kio internally is doing this correctly apparently it was only a problem in the GUI part of it. Diffs - autotests/CMakeLists.txt f613c1a autotests/kurlcomboboxtest.h PRE-CREATION autotests/kurlcomboboxtest.cpp PRE-CREATION src/widgets/kurlcombobox.cpp ed5b8a2 Diff: https://git.reviewboard.kde.org/r/122613/diff/ Testing --- Besides the added unit tests, I have used this patch while running a few ups, everything seems to work great. Thanks, Àlex Fiestas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122613: Do not add an extra slash if item does not have a host (KUrlComboBoxPrivate::textForItem)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122613/#review76245 --- autotests/kurlcomboboxtest.cpp https://git.reviewboard.kde.org/r/122613/#comment52571 Name? :) autotests/kurlcomboboxtest.cpp https://git.reviewboard.kde.org/r/122613/#comment52569 Never used autotests/kurlcomboboxtest.cpp https://git.reviewboard.kde.org/r/122613/#comment52570 Never used autotests/kurlcomboboxtest.cpp https://git.reviewboard.kde.org/r/122613/#comment52572 Just create on the stack? - Kevin Funk On Feb. 17, 2015, 10:29 p.m., Àlex Fiestas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122613/ --- (Updated Feb. 17, 2015, 10:29 p.m.) Review request for KDE Frameworks. Repository: kio Description --- The rest of kio internally is doing this correctly apparently it was only a problem in the GUI part of it. Diffs - autotests/CMakeLists.txt f613c1a autotests/kurlcomboboxtest.h PRE-CREATION autotests/kurlcomboboxtest.cpp PRE-CREATION src/widgets/kurlcombobox.cpp ed5b8a2 Diff: https://git.reviewboard.kde.org/r/122613/diff/ Testing --- Besides the added unit tests, I have used this patch while running a few ups, everything seems to work great. Thanks, Àlex Fiestas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122613: Do not add an extra slash if item does not have a host (KUrlComboBoxPrivate::textForItem)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122613/ --- (Updated feb. 18, 2015, 8:46 p.m.) Review request for KDE Frameworks. Changes --- Fixed all the issues. Repository: kio Description --- The rest of kio internally is doing this correctly apparently it was only a problem in the GUI part of it. Diffs (updated) - autotests/CMakeLists.txt f613c1a autotests/kurlcomboboxtest.h PRE-CREATION autotests/kurlcomboboxtest.cpp PRE-CREATION src/widgets/kurlcombobox.cpp ed5b8a2 Diff: https://git.reviewboard.kde.org/r/122613/diff/ Testing --- Besides the added unit tests, I have used this patch while running a few ups, everything seems to work great. Thanks, Àlex Fiestas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 122613: Do not add an extra slash if item does not have a host (KUrlComboBoxPrivate::textForItem)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122613/ --- Review request for KDE Frameworks. Repository: kio Description --- The rest of kio internally is doing this correctly apparently it was only a problem in the GUI part of it. Diffs - autotests/CMakeLists.txt f613c1a autotests/kurlcomboboxtest.h PRE-CREATION autotests/kurlcomboboxtest.cpp PRE-CREATION src/widgets/kurlcombobox.cpp ed5b8a2 Diff: https://git.reviewboard.kde.org/r/122613/diff/ Testing --- Besides the added unit tests, I have used this patch while running a few ups, everything seems to work great. Thanks, Àlex Fiestas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
