---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124165/#review81738
---
Preserving the executable flag sounds like a good idea indeed, but I wouldn't
want extracted files to be readonly just because the person who made the
archive decided it to be so. Just like we don't preserve ownership either, it
wouldn't make sense, across systems.
I think this patch should be reduced to making executable if it was
executable.
- David Faure
On June 24, 2015, 5 p.m., Romário Rios wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124165/
---
(Updated June 24, 2015, 5 p.m.)
Review request for KDE Frameworks.
Repository: karchive
Description
---
The KArchiveFile::copyTo() wasn't setting the permissions of the files it
copied -- it just copied the data. So, for instance, if an archive contained
an executable, it was extracted from the archive as a non-executable. This
patch makes it apply the permission information found in the KArchiveFile to
the QFile being copied.
Diffs
-
src/karchive.cpp 344cba8
Diff: https://git.reviewboard.kde.org/r/124165/diff/
Testing
---
Seems to work for all files (tested with xz and zip files containing
executables, directories, text, etc.).
Thanks,
Romário Rios
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
