Review Request 125115: kcmshell5 cookies: fix DBus names for kded5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125115/ --- Review request for KDE Frameworks. Repository: kio Description --- When starting this module, from the command line or similar, the error message is shown: Unable to start the cookie handler service. You will not be able to manage the cookies that are stored on your computer. and similarly for any operation attempted from the resulting dialogue. The reason for this appears to be that the module is connecting to the DBus name 'org.kde.kded', which should now be 'org.kde.kded5' (verified with qdbusviewer and in kded/src/org.kde.kded5.service.in). The patch here corrects these names throughout. Diffs - src/kcms/kio/kcookiesmain.cpp c4e36ac src/kcms/kio/kcookiesmanagement.cpp c041fc2 src/kcms/kio/kcookiespolicies.cpp 7470616 src/kcms/kio/ksaveioconfig.cpp 82ca6d9 Diff: https://git.reviewboard.kde.org/r/125115/diff/ Testing --- Built kio with these changes, cookie dialogue and management operates correctly. Thanks, Jonathan Marten ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125115: kcmshell5 cookies: fix DBus names for kded5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125115/#review85063 --- Ship it! Yes, clearly. I have plans to turn that kded module into library code (multiple processes sharing a file rather than a daemon), so we don't need a better solution for kded6 anyway ;) - David Faure On Sept. 9, 2015, 1:20 p.m., Jonathan Marten wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125115/ > --- > > (Updated Sept. 9, 2015, 1:20 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kio > > > Description > --- > > When starting this module, from the command line or similar, the error > message is shown: > > Unable to start the cookie handler service. > You will not be able to manage the cookies that > are stored on your computer. > > and similarly for any operation attempted from the resulting dialogue. > > The reason for this appears to be that the module is connecting to the DBus > name 'org.kde.kded', which should now be 'org.kde.kded5' (verified with > qdbusviewer and in kded/src/org.kde.kded5.service.in). The patch here > corrects these names throughout. > > > Diffs > - > > src/kcms/kio/kcookiesmain.cpp c4e36ac > src/kcms/kio/kcookiesmanagement.cpp c041fc2 > src/kcms/kio/kcookiespolicies.cpp 7470616 > src/kcms/kio/ksaveioconfig.cpp 82ca6d9 > > Diff: https://git.reviewboard.kde.org/r/125115/diff/ > > > Testing > --- > > Built kio with these changes, cookie dialogue and management operates > correctly. > > > Thanks, > > Jonathan Marten > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125115: kcmshell5 cookies: fix DBus names for kded5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125115/ --- (Updated Sept. 9, 2015, 7:55 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 3bdd02a2fbcac6d7bc6a188ce2396160c4f22ed7 by Jonathan Marten to branch master. Repository: kio Description --- When starting this module, from the command line or similar, the error message is shown: Unable to start the cookie handler service. You will not be able to manage the cookies that are stored on your computer. and similarly for any operation attempted from the resulting dialogue. The reason for this appears to be that the module is connecting to the DBus name 'org.kde.kded', which should now be 'org.kde.kded5' (verified with qdbusviewer and in kded/src/org.kde.kded5.service.in). The patch here corrects these names throughout. Diffs - src/kcms/kio/kcookiesmain.cpp c4e36ac src/kcms/kio/kcookiesmanagement.cpp c041fc2 src/kcms/kio/kcookiespolicies.cpp 7470616 src/kcms/kio/ksaveioconfig.cpp 82ca6d9 Diff: https://git.reviewboard.kde.org/r/125115/diff/ Testing --- Built kio with these changes, cookie dialogue and management operates correctly. Thanks, Jonathan Marten ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
