subject:"Review Request 125325\: New widget KCollapsibleGroupBox"

Re: Review Request 125325: New widget KCollapsibleGroupBox

2015-10-26 Thread David Edmundson

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125325/
---

(Updated Oct. 26, 2015, 12:16 p.m.)

Status
--

This change has been marked as submitted.

Review request for KDE Frameworks and Christoph Feck.

Changes
---

Submitted with commit 2d9efde46e638a11b0d706cbedde34153957080d by David
Edmundson to branch master.

Repository: kwidgetsaddons

Description
---

A groupbox featuring a clickable header and arrow indicator that can be
expanded and collapsed to reveal the box content

Widget features a close and collapse animation and works as expected in
QtDesigner.

--
Screenshot explains what I mean better than the description above.

I've been given at least 3 mockups from the VDG mockup which feature using this
widget, clearly there's a demand for it.

It's a bit like QToolBox, except no-one uses it because QToolbox has a weird
way of only expanding one at a time, and looks a bit weird so no-one uses it.

Diffs
-

src/CMakeLists.txt cc32508aff5452ec95f666d1a6545fd2dd1294f8
src/kcollapsiblegroupbox.h PRE-CREATION
src/kcollapsiblegroupbox.cpp PRE-CREATION
tests/CMakeLists.txt 180b0ef1f8900247da59112612ee87dd3164c8af
tests/kcollapsiblegroupboxtest.cpp PRE-CREATION

Diff: https://git.reviewboard.kde.org/r/125325/diff/

Testing
---

Made little test app (see screenshot)

Wrote QtDesigner plugin, and played with it there.

File Attachments

kcollapsiblegroupbox.png

https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/f9758e22-0043-4876-b462-364c3b2854dc__kcollapsiblegroupbox.png

Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125325: New widget KCollapsibleGroupBox

2015-10-22 Thread David Faure


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125325/#review87241
---

Ship it!


Ship It!

- David Faure


On Oct. 20, 2015, 9:20 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125325/
> ---
> 
> (Updated Oct. 20, 2015, 9:20 p.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> A groupbox featuring a clickable header and arrow indicator that can be
> expanded and collapsed to reveal the box content
> 
> Widget features a close and collapse animation and works as expected in
> QtDesigner.
> 
> --
> Screenshot explains what I mean better than the description above.
> 
> I've been given at least 3 mockups from the VDG mockup which feature using 
> this widget, clearly there's a demand for it. 
> 
> It's a bit like QToolBox, except no-one uses it because QToolbox has a weird 
> way of only expanding one at a time, and looks a bit weird so no-one uses it.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt cc32508aff5452ec95f666d1a6545fd2dd1294f8 
>   src/kcollapsiblegroupbox.h PRE-CREATION 
>   src/kcollapsiblegroupbox.cpp PRE-CREATION 
>   tests/CMakeLists.txt 180b0ef1f8900247da59112612ee87dd3164c8af 
>   tests/kcollapsiblegroupboxtest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125325/diff/
> 
> 
> Testing
> ---
> 
> Made little test app (see screenshot)
> 
> Wrote QtDesigner plugin, and played with it there.
> 
> 
> File Attachments
> 
> 
> kcollapsiblegroupbox.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/f9758e22-0043-4876-b462-364c3b2854dc__kcollapsiblegroupbox.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125325: New widget KCollapsibleGroupBox

2015-10-20 Thread David Edmundson

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125325/
---

(Updated Oct. 20, 2015, 9:20 p.m.)

Review request for KDE Frameworks and Christoph Feck.

Repository: kwidgetsaddons

Description
---

A groupbox featuring a clickable header and arrow indicator that can be
expanded and collapsed to reveal the box content

Widget features a close and collapse animation and works as expected in
QtDesigner.

--
Screenshot explains what I mean better than the description above.

I've been given at least 3 mockups from the VDG mockup which feature using this
widget, clearly there's a demand for it.

It's a bit like QToolBox, except no-one uses it because QToolbox has a weird
way of only expanding one at a time, and looks a bit weird so no-one uses it.

Diffs (updated)
-

Diff: https://git.reviewboard.kde.org/r/125325/diff/

Testing
---

Made little test app (see screenshot)

Wrote QtDesigner plugin, and played with it there.

File Attachments

kcollapsiblegroupbox.png

https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/f9758e22-0043-4876-b462-364c3b2854dc__kcollapsiblegroupbox.png

Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125325: New widget KCollapsibleGroupBox

2015-10-20 Thread David Faure


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125325/#review87117
---


Almost there ;)


src/kcollapsiblegroupbox.h (line 47)


missing spaces around the '=' sign



src/kcollapsiblegroupbox.h (line 51)


showed -> shown. Wait, who's the native speaker again? :-P



src/kcollapsiblegroupbox.h (line 68)


I think you need two stars here for doxygen to pick this up.



src/kcollapsiblegroupbox.h (line 91)


I don't think doxygen will pick up one-line comments with this syntax.
Either make it 3 lines, or use the correct one-line syntax (which I think 
is ///! or ///<, not sure).



src/kcollapsiblegroupbox.h (line 99)


this method is normally public, don't hide it.
same for minimumSizeHint()



src/kcollapsiblegroupbox.h (line 115)


wrong comment (just remove it, imho)



src/kcollapsiblegroupbox.cpp (line 62)


matches to match? ;)



src/kcollapsiblegroupbox.cpp (line 193)


(a switch(event->type()) wouldn't hurt...)


- David Faure


On Oct. 19, 2015, 10:32 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125325/
> ---
> 
> (Updated Oct. 19, 2015, 10:32 p.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> A groupbox featuring a clickable header and arrow indicator that can be
> expanded and collapsed to reveal the box content
> 
> Widget features a close and collapse animation and works as expected in
> QtDesigner.
> 
> --
> Screenshot explains what I mean better than the description above.
> 
> I've been given at least 3 mockups from the VDG mockup which feature using 
> this widget, clearly there's a demand for it. 
> 
> It's a bit like QToolBox, except no-one uses it because QToolbox has a weird 
> way of only expanding one at a time, and looks a bit weird so no-one uses it.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt e03e9bbd6d73811873b0a465f86da269f4295138 
>   src/kcollapsiblegroupbox.h PRE-CREATION 
>   src/kcollapsiblegroupbox.cpp PRE-CREATION 
>   tests/CMakeLists.txt 180b0ef1f8900247da59112612ee87dd3164c8af 
>   tests/kcollapsiblegroupboxtest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125325/diff/
> 
> 
> Testing
> ---
> 
> Made little test app (see screenshot)
> 
> Wrote QtDesigner plugin, and played with it there.
> 
> 
> File Attachments
> 
> 
> kcollapsiblegroupbox.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/f9758e22-0043-4876-b462-364c3b2854dc__kcollapsiblegroupbox.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125325: New widget KCollapsibleGroupBox

2015-10-19 Thread David Edmundson

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125325/
---

(Updated Oct. 19, 2015, 10:32 p.m.)

Review request for KDE Frameworks and Christoph Feck.

Changes
---

oops, missed one change.

Repository: kwidgetsaddons

Description
---

A groupbox featuring a clickable header and arrow indicator that can be
expanded and collapsed to reveal the box content

Widget features a close and collapse animation and works as expected in
QtDesigner.

--
Screenshot explains what I mean better than the description above.

I've been given at least 3 mockups from the VDG mockup which feature using this
widget, clearly there's a demand for it.

It's a bit like QToolBox, except no-one uses it because QToolbox has a weird
way of only expanding one at a time, and looks a bit weird so no-one uses it.

Diffs (updated)
-

src/CMakeLists.txt e03e9bbd6d73811873b0a465f86da269f4295138
src/kcollapsiblegroupbox.h PRE-CREATION
src/kcollapsiblegroupbox.cpp PRE-CREATION
tests/CMakeLists.txt 180b0ef1f8900247da59112612ee87dd3164c8af
tests/kcollapsiblegroupboxtest.cpp PRE-CREATION

Diff: https://git.reviewboard.kde.org/r/125325/diff/

Testing
---

Made little test app (see screenshot)

Wrote QtDesigner plugin, and played with it there.

File Attachments

kcollapsiblegroupbox.png

https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/f9758e22-0043-4876-b462-364c3b2854dc__kcollapsiblegroupbox.png

Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125325: New widget KCollapsibleGroupBox

2015-10-19 Thread David Edmundson

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125325/
---

(Updated Oct. 19, 2015, 10:27 p.m.)

Review request for KDE Frameworks and Christoph Feck.

Repository: kwidgetsaddons

Description
---

A groupbox featuring a clickable header and arrow indicator that can be
expanded and collapsed to reveal the box content

Widget features a close and collapse animation and works as expected in
QtDesigner.

--
Screenshot explains what I mean better than the description above.

I've been given at least 3 mockups from the VDG mockup which feature using this
widget, clearly there's a demand for it.

It's a bit like QToolBox, except no-one uses it because QToolbox has a weird
way of only expanding one at a time, and looks a bit weird so no-one uses it.

Diffs (updated)
-

Diff: https://git.reviewboard.kde.org/r/125325/diff/

Testing
---

Made little test app (see screenshot)

Wrote QtDesigner plugin, and played with it there.

File Attachments

kcollapsiblegroupbox.png

https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/f9758e22-0043-4876-b462-364c3b2854dc__kcollapsiblegroupbox.png

Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125325: New widget KCollapsibleGroupBox

2015-10-10 Thread Christoph Feck


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125325/#review86639
---



src/CMakeLists.txt (line 12)


Please keep alphabetic order



src/kcollapsiblegroupbox.h (line 36)


"When expanded, the widget ..."



src/kcollapsiblegroupbox.h (line 44)


Since this property can be changed by the user, I expected a signal/NOTIFY 
method.



src/kcollapsiblegroupbox.h (line 51)


Typos -> "permanently shown"



src/kcollapsiblegroupbox.h (line 70)


Add ',' after "animations".



src/kcollapsiblegroupbox.cpp (line 43)


Is it really possible to give default values for members in the class 
declaration? If yes, it is a new C++11 feature that we can assume for 
frameworks?



src/kcollapsiblegroupbox.cpp (line 105)


d->isExpanded = expanded;

looks simpler to understand?



src/kcollapsiblegroupbox.cpp (line 145)


Space after "0,"


- Christoph Feck


On Oct. 4, 2015, 8:37 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125325/
> ---
> 
> (Updated Oct. 4, 2015, 8:37 p.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> A groupbox featuring a clickable header and arrow indicator that can be
> expanded and collapsed to reveal the box content
> 
> Widget features a close and collapse animation and works as expected in
> QtDesigner.
> 
> --
> Screenshot explains what I mean better than the description above.
> 
> I've been given at least 3 mockups from the VDG mockup which feature using 
> this widget, clearly there's a demand for it. 
> 
> It's a bit like QToolBox, except no-one uses it because QToolbox has a weird 
> way of only expanding one at a time, and looks a bit weird so no-one uses it.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt e03e9bbd6d73811873b0a465f86da269f4295138 
>   src/kcollapsiblegroupbox.h PRE-CREATION 
>   src/kcollapsiblegroupbox.cpp PRE-CREATION 
>   tests/CMakeLists.txt 180b0ef1f8900247da59112612ee87dd3164c8af 
>   tests/kcollapsiblegroupboxtest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125325/diff/
> 
> 
> Testing
> ---
> 
> Made little test app (see screenshot)
> 
> Wrote QtDesigner plugin, and played with it there.
> 
> 
> File Attachments
> 
> 
> kcollapsiblegroupbox.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/f9758e22-0043-4876-b462-364c3b2854dc__kcollapsiblegroupbox.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125325: New widget KCollapsibleGroupBox

2015-10-04 Thread David Edmundson

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125325/
---

(Updated Oct. 4, 2015, 8:37 p.m.)

Review request for KDE Frameworks and Christoph Feck.

Repository: kwidgetsaddons

Description
---

A groupbox featuring a clickable header and arrow indicator that can be
expanded and collapsed to reveal the box content

Widget features a close and collapse animation and works as expected in
QtDesigner.

--
Screenshot explains what I mean better than the description above.

I've been given at least 3 mockups from the VDG mockup which feature using this
widget, clearly there's a demand for it.

It's a bit like QToolBox, except no-one uses it because QToolbox has a weird
way of only expanding one at a time, and looks a bit weird so no-one uses it.

Diffs (updated)
-

Diff: https://git.reviewboard.kde.org/r/125325/diff/

Testing
---

Made little test app (see screenshot)

Wrote QtDesigner plugin, and played with it there.

File Attachments

kcollapsiblegroupbox.png

https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/f9758e22-0043-4876-b462-364c3b2854dc__kcollapsiblegroupbox.png

Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125325: New widget KCollapsibleGroupBox

2015-10-04 Thread David Edmundson



> On Oct. 3, 2015, 9:54 p.m., David Faure wrote:
> >

Thanks


> On Oct. 3, 2015, 9:54 p.m., David Faure wrote:
> > tests/kcollapsiblegroupboxtest.cpp, line 35
> > 
> >
> > just curious: why?

We don't know which apps will enable it, so it's best to test every widget as 
though some app might.

This widget doesn't use pixmaps, so it's pretty pointless for now, but it might 
in future and I want setting this to be a standard thing in all qwidget 
graphical tests.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125325/#review86315
---


On Oct. 3, 2015, 1:38 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125325/
> ---
> 
> (Updated Oct. 3, 2015, 1:38 p.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> A groupbox featuring a clickable header and arrow indicator that can be
> expanded and collapsed to reveal the box content
> 
> Widget features a close and collapse animation and works as expected in
> QtDesigner.
> 
> --
> Screenshot explains what I mean better than the description above.
> 
> I've been given at least 3 mockups from the VDG mockup which feature using 
> this widget, clearly there's a demand for it. 
> 
> It's a bit like QToolBox, except no-one uses it because QToolbox has a weird 
> way of only expanding one at a time, and looks a bit weird so no-one uses it.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt e03e9bbd6d73811873b0a465f86da269f4295138 
>   src/kcollapsiblegroupbox.h PRE-CREATION 
>   src/kcollapsiblegroupbox.cpp PRE-CREATION 
>   tests/CMakeLists.txt 180b0ef1f8900247da59112612ee87dd3164c8af 
>   tests/kcollapsiblegroupboxtest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125325/diff/
> 
> 
> Testing
> ---
> 
> Made little test app (see screenshot)
> 
> Wrote QtDesigner plugin, and played with it there.
> 
> 
> File Attachments
> 
> 
> kcollapsiblegroupbox.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/f9758e22-0043-4876-b462-364c3b2854dc__kcollapsiblegroupbox.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125325: New widget KCollapsibleGroupBox

2015-10-03 Thread David Faure


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125325/#review86315
---



src/kcollapsiblegroupbox.h (line 21)


K missing



src/kcollapsiblegroupbox.h (line 91)


virtual is better removed when using Q_DECL_OVERRIDE (at least I thought 
this was the consenssus)



src/kcollapsiblegroupbox.h (line 108)


add K or remove comment



src/kcollapsiblegroupbox.cpp (line 43)


remove space after 0



src/kcollapsiblegroupbox.cpp (line 46)


typo in recalculate



src/kcollapsiblegroupbox.cpp (line 47)


methods above members, for readability?



src/kcollapsiblegroupbox.cpp (line 277)


don't use range-for on QList, it triggers a detach.

-> use foreach



tests/kcollapsiblegroupboxtest.cpp (line 35)


just curious: why?


- David Faure


On Oct. 3, 2015, 1:38 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125325/
> ---
> 
> (Updated Oct. 3, 2015, 1:38 p.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> A groupbox featuring a clickable header and arrow indicator that can be
> expanded and collapsed to reveal the box content
> 
> Widget features a close and collapse animation and works as expected in
> QtDesigner.
> 
> --
> Screenshot explains what I mean better than the description above.
> 
> I've been given at least 3 mockups from the VDG mockup which feature using 
> this widget, clearly there's a demand for it. 
> 
> It's a bit like QToolBox, except no-one uses it because QToolbox has a weird 
> way of only expanding one at a time, and looks a bit weird so no-one uses it.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt e03e9bbd6d73811873b0a465f86da269f4295138 
>   src/kcollapsiblegroupbox.h PRE-CREATION 
>   src/kcollapsiblegroupbox.cpp PRE-CREATION 
>   tests/CMakeLists.txt 180b0ef1f8900247da59112612ee87dd3164c8af 
>   tests/kcollapsiblegroupboxtest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125325/diff/
> 
> 
> Testing
> ---
> 
> Made little test app (see screenshot)
> 
> Wrote QtDesigner plugin, and played with it there.
> 
> 
> File Attachments
> 
> 
> kcollapsiblegroupbox.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/f9758e22-0043-4876-b462-364c3b2854dc__kcollapsiblegroupbox.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125325: New widget KCollapsibleGroupBox

2015-10-03 Thread David Edmundson


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125325/
---

(Updated Oct. 3, 2015, 1:38 p.m.)


Review request for KDE Frameworks and Christoph Feck.


Changes
---

Add @since


Repository: kwidgetsaddons


Description
---

A groupbox featuring a clickable header and arrow indicator that can be
expanded and collapsed to reveal the box content

Widget features a close and collapse animation and works as expected in
QtDesigner.

--
Screenshot explains what I mean better than the description above.

I've been given at least 3 mockups from the VDG mockup which feature using this 
widget, clearly there's a demand for it. 

It's a bit like QToolBox, except no-one uses it because QToolbox has a weird 
way of only expanding one at a time, and looks a bit weird so no-one uses it.


Diffs (updated)
-

  src/CMakeLists.txt e03e9bbd6d73811873b0a465f86da269f4295138 
  src/kcollapsiblegroupbox.h PRE-CREATION 
  src/kcollapsiblegroupbox.cpp PRE-CREATION 
  tests/CMakeLists.txt 180b0ef1f8900247da59112612ee87dd3164c8af 
  tests/kcollapsiblegroupboxtest.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/125325/diff/


Testing
---

Made little test app (see screenshot)

Wrote QtDesigner plugin, and played with it there.


File Attachments


kcollapsiblegroupbox.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/f9758e22-0043-4876-b462-364c3b2854dc__kcollapsiblegroupbox.png


Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125325: New widget KCollapsibleGroupBox

2015-09-24 Thread David Edmundson



> On Sept. 24, 2015, 8:04 a.m., Hugo Pereira Da Costa wrote:
> > +1 on the idea.
> > Note that gtk has such a widget (which looks exactly like yours) since 
> > quite some time already
> 
> Hugo Pereira Da Costa wrote:
> Testing, there are some issues though. The fact for instance that 
> mouse-over and focus are deliberatly merged, and shown on the arrow only is 
> very confusing, at least in breeze, and also oxygen.
> 
> To me the header should be rendered more or less like a checkbox, with an 
> arrow in place of the check mark, but with the same mouse-over and focus 
> effects as checkboxes. For breeze (and oxygen@kf5), that would be underlined 
> text. But then this is naturally style dependent. One should investigate 
> further how one can better re-use existing style elements. I'll try to give 
> it a shot locally.

Made a version that acts more like Checkbox using CE_CheckboxLabel for drawing.
I had to make the sizehints behave like a checkbox so the minimum width now 
fits the text rather than eliding. 

Breeze gets the blue underline, oxygen and fusion don't get any change on 
focus. So I'm on the fence as to which was better


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125325/#review85862
---


On Sept. 24, 2015, 7:34 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125325/
> ---
> 
> (Updated Sept. 24, 2015, 7:34 p.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> A groupbox featuring a clickable header and arrow indicator that can be
> expanded and collapsed to reveal the box content
> 
> Widget features a close and collapse animation and works as expected in
> QtDesigner.
> 
> --
> Screenshot explains what I mean better than the description above.
> 
> I've been given at least 3 mockups from the VDG mockup which feature using 
> this widget, clearly there's a demand for it. 
> 
> It's a bit like QToolBox, except no-one uses it because QToolbox has a weird 
> way of only expanding one at a time, and looks a bit weird so no-one uses it.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt e03e9bbd6d73811873b0a465f86da269f4295138 
>   src/kcollapsiblegroupbox.h PRE-CREATION 
>   src/kcollapsiblegroupbox.cpp PRE-CREATION 
>   tests/CMakeLists.txt 180b0ef1f8900247da59112612ee87dd3164c8af 
>   tests/kcollapsiblegroupboxtest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125325/diff/
> 
> 
> Testing
> ---
> 
> Made little test app (see screenshot)
> 
> Wrote QtDesigner plugin, and played with it there.
> 
> 
> File Attachments
> 
> 
> kcollapsiblegroupbox.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/f9758e22-0043-4876-b462-364c3b2854dc__kcollapsiblegroupbox.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125325: New widget KCollapsibleGroupBox

2015-09-24 Thread David Edmundson

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125325/
---

(Updated Sept. 24, 2015, 7:34 p.m.)

Review request for KDE Frameworks and Christoph Feck.

Repository: kwidgetsaddons

Description
---

A groupbox featuring a clickable header and arrow indicator that can be
expanded and collapsed to reveal the box content

Widget features a close and collapse animation and works as expected in
QtDesigner.

--
Screenshot explains what I mean better than the description above.

I've been given at least 3 mockups from the VDG mockup which feature using this
widget, clearly there's a demand for it.

It's a bit like QToolBox, except no-one uses it because QToolbox has a weird
way of only expanding one at a time, and looks a bit weird so no-one uses it.

Diffs (updated)
-

Diff: https://git.reviewboard.kde.org/r/125325/diff/

Testing
---

Made little test app (see screenshot)

Wrote QtDesigner plugin, and played with it there.

File Attachments

kcollapsiblegroupbox.png

https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/f9758e22-0043-4876-b462-364c3b2854dc__kcollapsiblegroupbox.png

Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125325: New widget KCollapsibleGroupBox

2015-09-24 Thread Hugo Pereira Da Costa



> On Sept. 24, 2015, 8:04 a.m., Hugo Pereira Da Costa wrote:
> > +1 on the idea.
> > Note that gtk has such a widget (which looks exactly like yours) since 
> > quite some time already

Testing, there are some issues though. The fact for instance that mouse-over 
and focus are deliberatly merged, and shown on the arrow only is very 
confusing, at least in breeze, and also oxygen.

To me the header should be rendered more or less like a checkbox, with an arrow 
in place of the check mark, but with the same mouse-over and focus effects as 
checkboxes. For breeze (and oxygen@kf5), that would be underlined text. But 
then this is naturally style dependent. One should investigate further how one 
can better re-use existing style elements. I'll try to give it a shot locally.


- Hugo


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125325/#review85862
---


On Sept. 20, 2015, 3:55 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125325/
> ---
> 
> (Updated Sept. 20, 2015, 3:55 p.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> A groupbox featuring a clickable header and arrow indicator that can be
> expanded and collapsed to reveal the box content
> 
> Widget features a close and collapse animation and works as expected in
> QtDesigner.
> 
> --
> Screenshot explains what I mean better than the description above.
> 
> I've been given at least 3 mockups from the VDG mockup which feature using 
> this widget, clearly there's a demand for it. 
> 
> It's a bit like QToolBox, except no-one uses it because QToolbox has a weird 
> way of only expanding one at a time, and looks a bit weird so no-one uses it.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt e03e9bbd6d73811873b0a465f86da269f4295138 
>   src/kcollapsiblegroupbox.h PRE-CREATION 
>   src/kcollapsiblegroupbox.cpp PRE-CREATION 
>   tests/CMakeLists.txt 180b0ef1f8900247da59112612ee87dd3164c8af 
>   tests/kcollapsiblegroupboxtest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125325/diff/
> 
> 
> Testing
> ---
> 
> Made little test app (see screenshot)
> 
> Wrote QtDesigner plugin, and played with it there.
> 
> 
> File Attachments
> 
> 
> kcollapsiblegroupbox.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/f9758e22-0043-4876-b462-364c3b2854dc__kcollapsiblegroupbox.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125325: New widget KCollapsibleGroupBox

2015-09-24 Thread Hugo Pereira Da Costa


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125325/#review85862
---


+1 on the idea.
Note that gtk has such a widget (which looks exactly like yours) since quite 
some time already

- Hugo Pereira Da Costa


On Sept. 20, 2015, 3:55 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125325/
> ---
> 
> (Updated Sept. 20, 2015, 3:55 p.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> A groupbox featuring a clickable header and arrow indicator that can be
> expanded and collapsed to reveal the box content
> 
> Widget features a close and collapse animation and works as expected in
> QtDesigner.
> 
> --
> Screenshot explains what I mean better than the description above.
> 
> I've been given at least 3 mockups from the VDG mockup which feature using 
> this widget, clearly there's a demand for it. 
> 
> It's a bit like QToolBox, except no-one uses it because QToolbox has a weird 
> way of only expanding one at a time, and looks a bit weird so no-one uses it.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt e03e9bbd6d73811873b0a465f86da269f4295138 
>   src/kcollapsiblegroupbox.h PRE-CREATION 
>   src/kcollapsiblegroupbox.cpp PRE-CREATION 
>   tests/CMakeLists.txt 180b0ef1f8900247da59112612ee87dd3164c8af 
>   tests/kcollapsiblegroupboxtest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125325/diff/
> 
> 
> Testing
> ---
> 
> Made little test app (see screenshot)
> 
> Wrote QtDesigner plugin, and played with it there.
> 
> 
> File Attachments
> 
> 
> kcollapsiblegroupbox.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/f9758e22-0043-4876-b462-364c3b2854dc__kcollapsiblegroupbox.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125325: New widget KCollapsibleGroupBox

2015-09-20 Thread David Edmundson



> On Sept. 20, 2015, 2:08 p.m., Sune Vuorela wrote:
> > src/kcollapsiblegroupbox.h, line 34
> > 
> >
> > Does it handle 1000 items, or is it up to the user to ensure to limit 
> > it or add it in a scrollarea?
> > Should it be documented?

It's up to the user, that way it acts more like a normal GroupBox. 
I added a comment in the class description that hopefully makes that clearer.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125325/#review85688
---


On Sept. 20, 2015, 3:55 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125325/
> ---
> 
> (Updated Sept. 20, 2015, 3:55 p.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> A groupbox featuring a clickable header and arrow indicator that can be
> expanded and collapsed to reveal the box content
> 
> Widget features a close and collapse animation and works as expected in
> QtDesigner.
> 
> --
> Screenshot explains what I mean better than the description above.
> 
> I've been given at least 3 mockups from the VDG mockup which feature using 
> this widget, clearly there's a demand for it. 
> 
> It's a bit like QToolBox, except no-one uses it because QToolbox has a weird 
> way of only expanding one at a time, and looks a bit weird so no-one uses it.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt e03e9bbd6d73811873b0a465f86da269f4295138 
>   src/kcollapsiblegroupbox.h PRE-CREATION 
>   src/kcollapsiblegroupbox.cpp PRE-CREATION 
>   tests/CMakeLists.txt 180b0ef1f8900247da59112612ee87dd3164c8af 
>   tests/kcollapsiblegroupboxtest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125325/diff/
> 
> 
> Testing
> ---
> 
> Made little test app (see screenshot)
> 
> Wrote QtDesigner plugin, and played with it there.
> 
> 
> File Attachments
> 
> 
> kcollapsiblegroupbox.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/f9758e22-0043-4876-b462-364c3b2854dc__kcollapsiblegroupbox.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125325: New widget KCollapsibleGroupBox

2015-09-20 Thread David Edmundson

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125325/
---

(Updated Sept. 20, 2015, 3:55 p.m.)

Review request for KDE Frameworks and Christoph Feck.

Repository: kwidgetsaddons

Description
---

A groupbox featuring a clickable header and arrow indicator that can be
expanded and collapsed to reveal the box content

Widget features a close and collapse animation and works as expected in
QtDesigner.

--
Screenshot explains what I mean better than the description above.

I've been given at least 3 mockups from the VDG mockup which feature using this
widget, clearly there's a demand for it.

It's a bit like QToolBox, except no-one uses it because QToolbox has a weird
way of only expanding one at a time, and looks a bit weird so no-one uses it.

Diffs (updated)
-

Diff: https://git.reviewboard.kde.org/r/125325/diff/

Testing
---

Made little test app (see screenshot)

Wrote QtDesigner plugin, and played with it there.

File Attachments

kcollapsiblegroupbox.png

https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/f9758e22-0043-4876-b462-364c3b2854dc__kcollapsiblegroupbox.png

Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125325: New widget KCollapsibleGroupBox

2015-09-20 Thread Sune Vuorela


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125325/#review85688
---


I like the concept.


src/kcollapsiblegroupbox.h (line 4)


trailing whitespace



src/kcollapsiblegroupbox.h (line 6)


widgetaddons is lgpl, not gpl



src/kcollapsiblegroupbox.h (line 12)


whitespace



src/kcollapsiblegroupbox.h (line 17)


whitespace



src/kcollapsiblegroupbox.h (line 20)


whitespace



src/kcollapsiblegroupbox.h (line 34)


Does it handle 1000 items, or is it up to the user to ensure to limit it or 
add it in a scrollarea?
Should it be documented?



src/kcollapsiblegroupbox.h (line 65)


Missing words? Or too many?



src/kcollapsiblegroupbox.h (line 100)


This construct actually EXPORT's the private class as well. The easy way is 
to move the class outside of the public class as KCollapsibleGroupBoxPrivate. 
The harder way is to ... build the right NOT_EXPORT macro


- Sune Vuorela


On Sept. 20, 2015, 1:48 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125325/
> ---
> 
> (Updated Sept. 20, 2015, 1:48 p.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> A groupbox featuring a clickable header and arrow indicator that can be
> expanded and collapsed to reveal the box content
> 
> Widget features a close and collapse animation and works as expected in
> QtDesigner.
> 
> --
> Screenshot explains what I mean better than the description above.
> 
> I've been given at least 3 mockups from the VDG mockup which feature using 
> this widget, clearly there's a demand for it. 
> 
> It's a bit like QToolBox, except no-one uses it because QToolbox has a weird 
> way of only expanding one at a time, and looks a bit weird so no-one uses it.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt e03e9bbd6d73811873b0a465f86da269f4295138 
>   src/kcollapsiblegroupbox.h PRE-CREATION 
>   src/kcollapsiblegroupbox.cpp PRE-CREATION 
>   tests/CMakeLists.txt 180b0ef1f8900247da59112612ee87dd3164c8af 
>   tests/kcollapsiblegroupboxtest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125325/diff/
> 
> 
> Testing
> ---
> 
> Made little test app (see screenshot)
> 
> Wrote QtDesigner plugin, and played with it there.
> 
> 
> File Attachments
> 
> 
> kcollapsiblegroupbox.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/f9758e22-0043-4876-b462-364c3b2854dc__kcollapsiblegroupbox.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 125325: New widget KCollapsibleGroupBox

2015-09-20 Thread David Edmundson


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125325/
---

Review request for KDE Frameworks and Christoph Feck.


Repository: kwidgetsaddons


Description
---

A groupbox featuring a clickable header and arrow indicator that can be
expanded and collapsed to reveal the box content

Widget features a close and collapse animation and works as expected in
QtDesigner.

--
Screenshot explains what I mean better than the description above.

I've been given at least 3 mockups from the VDG mockup which feature using this 
widget, clearly there's a demand for it. 

It's a bit like QToolBox, except no-one uses it because QToolbox has a weird 
way of only expanding one at a time, and looks a bit weird so no-one uses it.


Diffs
-

  src/CMakeLists.txt e03e9bbd6d73811873b0a465f86da269f4295138 
  src/kcollapsiblegroupbox.h PRE-CREATION 
  src/kcollapsiblegroupbox.cpp PRE-CREATION 
  tests/CMakeLists.txt 180b0ef1f8900247da59112612ee87dd3164c8af 
  tests/kcollapsiblegroupboxtest.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/125325/diff/


Testing
---

Made little test app (see screenshot)

Wrote QtDesigner plugin, and played with it there.


File Attachments


kcollapsiblegroupbox.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/f9758e22-0043-4876-b462-364c3b2854dc__kcollapsiblegroupbox.png


Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125325: New widget KCollapsibleGroupBox

Re: Review Request 125325: New widget KCollapsibleGroupBox

Re: Review Request 125325: New widget KCollapsibleGroupBox

Re: Review Request 125325: New widget KCollapsibleGroupBox

Re: Review Request 125325: New widget KCollapsibleGroupBox

Re: Review Request 125325: New widget KCollapsibleGroupBox

Re: Review Request 125325: New widget KCollapsibleGroupBox

Re: Review Request 125325: New widget KCollapsibleGroupBox

Re: Review Request 125325: New widget KCollapsibleGroupBox

Re: Review Request 125325: New widget KCollapsibleGroupBox

Re: Review Request 125325: New widget KCollapsibleGroupBox

Re: Review Request 125325: New widget KCollapsibleGroupBox

Re: Review Request 125325: New widget KCollapsibleGroupBox

Re: Review Request 125325: New widget KCollapsibleGroupBox

Re: Review Request 125325: New widget KCollapsibleGroupBox

Re: Review Request 125325: New widget KCollapsibleGroupBox

Re: Review Request 125325: New widget KCollapsibleGroupBox

Re: Review Request 125325: New widget KCollapsibleGroupBox

Review Request 125325: New widget KCollapsibleGroupBox

19 matches

Site Navigation

Mail list logo

Footer information