Re: Review Request 125390: Fix build on Mac OS X
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125390/ --- (Updated Sept. 29, 2015, 1:10 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Alex Merry. Changes --- Submitted with commit 0f8592f27064ba92485928a0de074c58118414aa by Harald Fernengel to branch master. Repository: kdesignerplugin Description --- Qt 5.5 requires Qt5UiPlugin framework to be in the include path. On Linux this didn't break as all Qt headers are typically in the same prefix, but on Mac, the include hierarchy is quite different. Diffs - KF5DesignerPluginMacros.cmake 15db23db3c275c231487d8bafc8fb3f4df624905 Diff: https://git.reviewboard.kde.org/r/125390/diff/ Testing --- Thanks, Harald Fernengel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 125390: Fix build on Mac OS X
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125390/ --- Review request for KDE Frameworks and Alex Merry. Repository: kdesignerplugin Description --- Qt 5.5 requires Qt5UiPlugin framework to be in the include path. On Linux this didn't break as all Qt headers are typically in the same prefix, but on Mac, the include hierarchy is quite different. Diffs - KF5DesignerPluginMacros.cmake 15db23db3c275c231487d8bafc8fb3f4df624905 Diff: https://git.reviewboard.kde.org/r/125390/diff/ Testing --- Thanks, Harald Fernengel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125390: Fix build on Mac OS X
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125390/#review85933 --- Ship it! Ship It! - Alex Merry On Sept. 25, 2015, 11:08 a.m., Harald Fernengel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125390/ > --- > > (Updated Sept. 25, 2015, 11:08 a.m.) > > > Review request for KDE Frameworks and Alex Merry. > > > Repository: kdesignerplugin > > > Description > --- > > Qt 5.5 requires Qt5UiPlugin framework to be in the include path. > On Linux this didn't break as all Qt headers are typically in the > same prefix, but on Mac, the include hierarchy is quite different. > > > Diffs > - > > KF5DesignerPluginMacros.cmake 15db23db3c275c231487d8bafc8fb3f4df624905 > > Diff: https://git.reviewboard.kde.org/r/125390/diff/ > > > Testing > --- > > > Thanks, > > Harald Fernengel > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
