Re: Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125425/ --- (Updated Oct. 6, 2015, 8:30 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 4b24b70c93523c5bc56c90c04a5a666331e96a1b by Frank Reininghaus to branch master. Bugs: 350769 https://bugs.kde.org/show_bug.cgi?id=350769 Repository: kio Description --- This is a modified version of the file konqpopupmenuplugin.desktop in kde-baseapps (see https://quickgit.kde.org/?p=kde-baseapps.git&a=blob&h=94a680ac215b4638a0c7cdd2b20bc7830b9619f2&hb=35e8bc2992f48ffaff9007cfbf8faf3c856b18a3&f=lib%2Fkonq%2Fkonqpopupmenuplugin.desktop for the latest version). I modified the name to kioservicemenuplugin.desktop because the file has not been Konqueror-specific for quite some time. I also updated the 'Comment' accordingly and removed the outdated translations. I hope I did that right - any comments are welcome! Note: Just like https://git.reviewboard.kde.org/r/124983/ this should probably be pushed to master after the tagging for the next version because of the translations. On the one hand, the translation of this 'Comment' might not be that important because the it is not shown anywhere in the UI as far as I know (it is shown in the 'Type' column in Dolphin though when viewing the directory where this file is installed). But on the other hand, it might be better to resolve both context menu issues in the same KIO release. What do others think? Diffs - src/widgets/CMakeLists.txt 820cd34 src/widgets/konqpopupmenuplugin.desktop PRE-CREATION Diff: https://git.reviewboard.kde.org/r/125425/diff/ Testing --- Konsole service actions are shown in the context menu again. Thanks, Frank Reininghaus ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories
> On Okt. 3, 2015, 8:08 vorm., David Faure wrote: > > I just realized another problem with this approach: since the latest > > libkonq release installs konqpopupmenuplugin.desktop already, this patch > > will make the next KIO release conflict with that last libkonq release > > (which by definition cannot have a version check). Moving stuff between > > products is hard! > > > > So you were right, better install this under a different filename like in > > your v1 of the patch (just doublecheck that having two definitions of the > > same servicetype in two different files doesn't break things, but I don't > > think it does). And in the second step (later) we can reuse that filename > > to provide a different servicetypename and deprecate KonqPopupMenuPlugin. > > Sorry for not realizing this sooner. > > > > In any case, due to the issue with translations we wanted to commit this > > after today's release (but of course this delays the fix by one month). > > Unless Luigi is available this weekend to do the merging, but it's getting > > tight. > > Luigi Toscano wrote: > I would say that it's better to postpone for the next release (merge > immediately after the tag), so there is a bit more time to catch issues and > it's not risky for this release (too tight now, exactly). > > Hrvoje Senjan wrote: > > since the latest libkonq release installs konqpopupmenuplugin.desktop > already > > But that release is kdelibs4 based, so there shouldn't be any conflict > here... > > David Faure wrote: > Oh, is there really no release that installs konqpopupmenuplugin.desktop > into servicestypes5? I thought people said otherwise in bug reports, but I > didn't fully follow that (and looking again now I indeed don't see that > clearly said). > > If this was never released it's easier indeed, this patch can go in > (after the release) then. Yes, there is currently no KF5-based release of anything that installs this file. Service menus might work for some users though if distros package lib/konq (which is ported to KF5, but not released). I'll push this and the commit for the "Create New" menu issue tomorrow if there are no objections. Maybe I'll also send a mail to the kde-packager list, such that the packagers can decide if they want to backport them. This would prevent that users will have to wait until November (or even longer, if distros do not update the KF5 libs regularly) until they get a functional context menu again. - Frank --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125425/#review86276 --- On Okt. 3, 2015, 7:50 vorm., Frank Reininghaus wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125425/ > --- > > (Updated Okt. 3, 2015, 7:50 vorm.) > > > Review request for KDE Frameworks and David Faure. > > > Bugs: 350769 > https://bugs.kde.org/show_bug.cgi?id=350769 > > > Repository: kio > > > Description > --- > > This is a modified version of the file konqpopupmenuplugin.desktop in > kde-baseapps (see > https://quickgit.kde.org/?p=kde-baseapps.git&a=blob&h=94a680ac215b4638a0c7cdd2b20bc7830b9619f2&hb=35e8bc2992f48ffaff9007cfbf8faf3c856b18a3&f=lib%2Fkonq%2Fkonqpopupmenuplugin.desktop > for the latest version). > > I modified the name to kioservicemenuplugin.desktop because the file has not > been Konqueror-specific for quite some time. I also updated the 'Comment' > accordingly and removed the outdated translations. > > I hope I did that right - any comments are welcome! > > Note: Just like https://git.reviewboard.kde.org/r/124983/ this should > probably be pushed to master after the tagging for the next version because > of the translations. On the one hand, the translation of this 'Comment' might > not be that important because the it is not shown anywhere in the UI as far > as I know (it is shown in the 'Type' column in Dolphin though when viewing > the directory where this file is installed). But on the other hand, it might > be better to resolve both context menu issues in the same KIO release. What > do others think? > > > Diffs > - > > src/widgets/CMakeLists.txt 820cd34 > src/widgets/konqpopupmenuplugin.desktop PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/125425/diff/ > > > Testing > --- > > Konsole service actions are shown in the context menu again. > > > Thanks, > > Frank Reininghaus > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories
> On Oct. 3, 2015, 8:08 a.m., David Faure wrote: > > I just realized another problem with this approach: since the latest > > libkonq release installs konqpopupmenuplugin.desktop already, this patch > > will make the next KIO release conflict with that last libkonq release > > (which by definition cannot have a version check). Moving stuff between > > products is hard! > > > > So you were right, better install this under a different filename like in > > your v1 of the patch (just doublecheck that having two definitions of the > > same servicetype in two different files doesn't break things, but I don't > > think it does). And in the second step (later) we can reuse that filename > > to provide a different servicetypename and deprecate KonqPopupMenuPlugin. > > Sorry for not realizing this sooner. > > > > In any case, due to the issue with translations we wanted to commit this > > after today's release (but of course this delays the fix by one month). > > Unless Luigi is available this weekend to do the merging, but it's getting > > tight. > > Luigi Toscano wrote: > I would say that it's better to postpone for the next release (merge > immediately after the tag), so there is a bit more time to catch issues and > it's not risky for this release (too tight now, exactly). > > Hrvoje Senjan wrote: > > since the latest libkonq release installs konqpopupmenuplugin.desktop > already > > But that release is kdelibs4 based, so there shouldn't be any conflict > here... Oh, is there really no release that installs konqpopupmenuplugin.desktop into servicestypes5? I thought people said otherwise in bug reports, but I didn't fully follow that (and looking again now I indeed don't see that clearly said). If this was never released it's easier indeed, this patch can go in (after the release) then. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125425/#review86276 --- On Oct. 3, 2015, 7:50 a.m., Frank Reininghaus wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125425/ > --- > > (Updated Oct. 3, 2015, 7:50 a.m.) > > > Review request for KDE Frameworks and David Faure. > > > Bugs: 350769 > https://bugs.kde.org/show_bug.cgi?id=350769 > > > Repository: kio > > > Description > --- > > This is a modified version of the file konqpopupmenuplugin.desktop in > kde-baseapps (see > https://quickgit.kde.org/?p=kde-baseapps.git&a=blob&h=94a680ac215b4638a0c7cdd2b20bc7830b9619f2&hb=35e8bc2992f48ffaff9007cfbf8faf3c856b18a3&f=lib%2Fkonq%2Fkonqpopupmenuplugin.desktop > for the latest version). > > I modified the name to kioservicemenuplugin.desktop because the file has not > been Konqueror-specific for quite some time. I also updated the 'Comment' > accordingly and removed the outdated translations. > > I hope I did that right - any comments are welcome! > > Note: Just like https://git.reviewboard.kde.org/r/124983/ this should > probably be pushed to master after the tagging for the next version because > of the translations. On the one hand, the translation of this 'Comment' might > not be that important because the it is not shown anywhere in the UI as far > as I know (it is shown in the 'Type' column in Dolphin though when viewing > the directory where this file is installed). But on the other hand, it might > be better to resolve both context menu issues in the same KIO release. What > do others think? > > > Diffs > - > > src/widgets/CMakeLists.txt 820cd34 > src/widgets/konqpopupmenuplugin.desktop PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/125425/diff/ > > > Testing > --- > > Konsole service actions are shown in the context menu again. > > > Thanks, > > Frank Reininghaus > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories
> On Oct. 3, 2015, 10:08 a.m., David Faure wrote: > > I just realized another problem with this approach: since the latest > > libkonq release installs konqpopupmenuplugin.desktop already, this patch > > will make the next KIO release conflict with that last libkonq release > > (which by definition cannot have a version check). Moving stuff between > > products is hard! > > > > So you were right, better install this under a different filename like in > > your v1 of the patch (just doublecheck that having two definitions of the > > same servicetype in two different files doesn't break things, but I don't > > think it does). And in the second step (later) we can reuse that filename > > to provide a different servicetypename and deprecate KonqPopupMenuPlugin. > > Sorry for not realizing this sooner. > > > > In any case, due to the issue with translations we wanted to commit this > > after today's release (but of course this delays the fix by one month). > > Unless Luigi is available this weekend to do the merging, but it's getting > > tight. > > Luigi Toscano wrote: > I would say that it's better to postpone for the next release (merge > immediately after the tag), so there is a bit more time to catch issues and > it's not risky for this release (too tight now, exactly). > since the latest libkonq release installs konqpopupmenuplugin.desktop already But that release is kdelibs4 based, so there shouldn't be any conflict here... - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125425/#review86276 --- On Oct. 3, 2015, 9:50 a.m., Frank Reininghaus wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125425/ > --- > > (Updated Oct. 3, 2015, 9:50 a.m.) > > > Review request for KDE Frameworks and David Faure. > > > Bugs: 350769 > https://bugs.kde.org/show_bug.cgi?id=350769 > > > Repository: kio > > > Description > --- > > This is a modified version of the file konqpopupmenuplugin.desktop in > kde-baseapps (see > https://quickgit.kde.org/?p=kde-baseapps.git&a=blob&h=94a680ac215b4638a0c7cdd2b20bc7830b9619f2&hb=35e8bc2992f48ffaff9007cfbf8faf3c856b18a3&f=lib%2Fkonq%2Fkonqpopupmenuplugin.desktop > for the latest version). > > I modified the name to kioservicemenuplugin.desktop because the file has not > been Konqueror-specific for quite some time. I also updated the 'Comment' > accordingly and removed the outdated translations. > > I hope I did that right - any comments are welcome! > > Note: Just like https://git.reviewboard.kde.org/r/124983/ this should > probably be pushed to master after the tagging for the next version because > of the translations. On the one hand, the translation of this 'Comment' might > not be that important because the it is not shown anywhere in the UI as far > as I know (it is shown in the 'Type' column in Dolphin though when viewing > the directory where this file is installed). But on the other hand, it might > be better to resolve both context menu issues in the same KIO release. What > do others think? > > > Diffs > - > > src/widgets/CMakeLists.txt 820cd34 > src/widgets/konqpopupmenuplugin.desktop PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/125425/diff/ > > > Testing > --- > > Konsole service actions are shown in the context menu again. > > > Thanks, > > Frank Reininghaus > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories
> On Oct. 3, 2015, 10:08 a.m., David Faure wrote: > > I just realized another problem with this approach: since the latest > > libkonq release installs konqpopupmenuplugin.desktop already, this patch > > will make the next KIO release conflict with that last libkonq release > > (which by definition cannot have a version check). Moving stuff between > > products is hard! > > > > So you were right, better install this under a different filename like in > > your v1 of the patch (just doublecheck that having two definitions of the > > same servicetype in two different files doesn't break things, but I don't > > think it does). And in the second step (later) we can reuse that filename > > to provide a different servicetypename and deprecate KonqPopupMenuPlugin. > > Sorry for not realizing this sooner. > > > > In any case, due to the issue with translations we wanted to commit this > > after today's release (but of course this delays the fix by one month). > > Unless Luigi is available this weekend to do the merging, but it's getting > > tight. I would say that it's better to postpone for the next release (merge immediately after the tag), so there is a bit more time to catch issues and it's not risky for this release (too tight now, exactly). - Luigi --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125425/#review86276 --- On Oct. 3, 2015, 9:50 a.m., Frank Reininghaus wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125425/ > --- > > (Updated Oct. 3, 2015, 9:50 a.m.) > > > Review request for KDE Frameworks and David Faure. > > > Bugs: 350769 > https://bugs.kde.org/show_bug.cgi?id=350769 > > > Repository: kio > > > Description > --- > > This is a modified version of the file konqpopupmenuplugin.desktop in > kde-baseapps (see > https://quickgit.kde.org/?p=kde-baseapps.git&a=blob&h=94a680ac215b4638a0c7cdd2b20bc7830b9619f2&hb=35e8bc2992f48ffaff9007cfbf8faf3c856b18a3&f=lib%2Fkonq%2Fkonqpopupmenuplugin.desktop > for the latest version). > > I modified the name to kioservicemenuplugin.desktop because the file has not > been Konqueror-specific for quite some time. I also updated the 'Comment' > accordingly and removed the outdated translations. > > I hope I did that right - any comments are welcome! > > Note: Just like https://git.reviewboard.kde.org/r/124983/ this should > probably be pushed to master after the tagging for the next version because > of the translations. On the one hand, the translation of this 'Comment' might > not be that important because the it is not shown anywhere in the UI as far > as I know (it is shown in the 'Type' column in Dolphin though when viewing > the directory where this file is installed). But on the other hand, it might > be better to resolve both context menu issues in the same KIO release. What > do others think? > > > Diffs > - > > src/widgets/CMakeLists.txt 820cd34 > src/widgets/konqpopupmenuplugin.desktop PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/125425/diff/ > > > Testing > --- > > Konsole service actions are shown in the context menu again. > > > Thanks, > > Frank Reininghaus > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125425/#review86276 --- I just realized another problem with this approach: since the latest libkonq release installs konqpopupmenuplugin.desktop already, this patch will make the next KIO release conflict with that last libkonq release (which by definition cannot have a version check). Moving stuff between products is hard! So you were right, better install this under a different filename like in your v1 of the patch (just doublecheck that having two definitions of the same servicetype in two different files doesn't break things, but I don't think it does). And in the second step (later) we can reuse that filename to provide a different servicetypename and deprecate KonqPopupMenuPlugin. Sorry for not realizing this sooner. In any case, due to the issue with translations we wanted to commit this after today's release (but of course this delays the fix by one month). Unless Luigi is available this weekend to do the merging, but it's getting tight. - David Faure On Oct. 3, 2015, 7:50 a.m., Frank Reininghaus wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125425/ > --- > > (Updated Oct. 3, 2015, 7:50 a.m.) > > > Review request for KDE Frameworks and David Faure. > > > Bugs: 350769 > https://bugs.kde.org/show_bug.cgi?id=350769 > > > Repository: kio > > > Description > --- > > This is a modified version of the file konqpopupmenuplugin.desktop in > kde-baseapps (see > https://quickgit.kde.org/?p=kde-baseapps.git&a=blob&h=94a680ac215b4638a0c7cdd2b20bc7830b9619f2&hb=35e8bc2992f48ffaff9007cfbf8faf3c856b18a3&f=lib%2Fkonq%2Fkonqpopupmenuplugin.desktop > for the latest version). > > I modified the name to kioservicemenuplugin.desktop because the file has not > been Konqueror-specific for quite some time. I also updated the 'Comment' > accordingly and removed the outdated translations. > > I hope I did that right - any comments are welcome! > > Note: Just like https://git.reviewboard.kde.org/r/124983/ this should > probably be pushed to master after the tagging for the next version because > of the translations. On the one hand, the translation of this 'Comment' might > not be that important because the it is not shown anywhere in the UI as far > as I know (it is shown in the 'Type' column in Dolphin though when viewing > the directory where this file is installed). But on the other hand, it might > be better to resolve both context menu issues in the same KIO release. What > do others think? > > > Diffs > - > > src/widgets/CMakeLists.txt 820cd34 > src/widgets/konqpopupmenuplugin.desktop PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/125425/diff/ > > > Testing > --- > > Konsole service actions are shown in the context menu again. > > > Thanks, > > Frank Reininghaus > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125425/ --- (Updated Okt. 3, 2015, 7:50 vorm.) Review request for KDE Frameworks and David Faure. Changes --- I propose to do this in two steps: 1. Move konqpopupmenu.plugin from kde-baseapps to kio (this is what the current version of this review does). 2. Add a new KIOServiceMenuPlugin service type, make it work like KonqPopupMenu/Plugin, and log a warning if a plugin only implements the latter. I'm willing to also do step 2, but after I had a quick look at the code, I think that KFileItemActions::addServiceActionsTo needs some refactoring first. I currently don't have the time for that, but I think that the absence of service menu plugins should be fixed rather sooner than later, so I think that implementing step 1 first makes sense. If this is approved, then I will push it together with https://git.reviewboard.kde.org/r/124983/ to minimize the trouble for the translators and see how the installation of the files can be suppressed in lib/konq if the KIO version is high enough. Bugs: 350769 https://bugs.kde.org/show_bug.cgi?id=350769 Repository: kio Description --- This is a modified version of the file konqpopupmenuplugin.desktop in kde-baseapps (see https://quickgit.kde.org/?p=kde-baseapps.git&a=blob&h=94a680ac215b4638a0c7cdd2b20bc7830b9619f2&hb=35e8bc2992f48ffaff9007cfbf8faf3c856b18a3&f=lib%2Fkonq%2Fkonqpopupmenuplugin.desktop for the latest version). I modified the name to kioservicemenuplugin.desktop because the file has not been Konqueror-specific for quite some time. I also updated the 'Comment' accordingly and removed the outdated translations. I hope I did that right - any comments are welcome! Note: Just like https://git.reviewboard.kde.org/r/124983/ this should probably be pushed to master after the tagging for the next version because of the translations. On the one hand, the translation of this 'Comment' might not be that important because the it is not shown anywhere in the UI as far as I know (it is shown in the 'Type' column in Dolphin though when viewing the directory where this file is installed). But on the other hand, it might be better to resolve both context menu issues in the same KIO release. What do others think? Diffs (updated) - src/widgets/CMakeLists.txt 820cd34 src/widgets/konqpopupmenuplugin.desktop PRE-CREATION Diff: https://git.reviewboard.kde.org/r/125425/diff/ Testing --- Konsole service actions are shown in the context menu again. Thanks, Frank Reininghaus ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories
> On Sept. 28, 2015, 7:30 vorm., David Faure wrote: > > The filename not matching the servicetype name in it, is very confusing. > > > > How about deprecating KonqPopupMenu/Plugin, introducing a > > KIOServiceMenuPlugin servicetype, installing desktop files for both, > > querying for both and skipping the installation of > > konqpopupmenuplugin.desktop if the KIO version is > 5.15? > > Frank Reininghaus wrote: > If we change the ServiceType entry in the file, then every service menu > will have to be changed, right? Not only those that are installed by > applications and libraries that are hosted on git.kde.org (which we could at > least find and fix), but also service menus that are released on > kde-apps.org, or unreleased menus that users have written for themselves. I > thought that it's unrealistic that this happens for every single service > menu, that's why I thought that the KonqPopupMenu/Plugin type should be kept. > Or am I overlooking something? If not, then I'm happy to change the file name > - probably having a konqpopupmenuplugin.desktop in KIO is really less > confusing than the ServiceType/file name mismatch. > > David Faure wrote: > Yes this is why I was suggesting to install desktop files for both names. > Deprecating != removing. > > Make both servicetype names work, but issue a warning if a plugin only > implements KonqPopupMenu/Plugin and not KIOServiceMenuPlugin (both is ok, > it's a way to make it work for older versions of KF5). Only > KIOServiceMenuPlugin is ok of course. > > Anyway, that's more work, if you want to just rename the file and move on > I'm ok with that. > In any case, make sure to avoid the conflict between kio and libkonq > installing the same file, with a version check. Thanks David for the clarification! Yes, that makes a lot of sense. Sorry for the misunderstanding - I did not realize that you meant "skipping the installation of konqpopupmenuplugin.desktop *in kde-baseapps* if the KIO version is > 5.15". I'll update the patch soon. - Frank --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125425/#review86028 --- On Sept. 27, 2015, 6:18 nachm., Frank Reininghaus wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125425/ > --- > > (Updated Sept. 27, 2015, 6:18 nachm.) > > > Review request for KDE Frameworks and David Faure. > > > Bugs: 350769 > https://bugs.kde.org/show_bug.cgi?id=350769 > > > Repository: kio > > > Description > --- > > This is a modified version of the file konqpopupmenuplugin.desktop in > kde-baseapps (see > https://quickgit.kde.org/?p=kde-baseapps.git&a=blob&h=94a680ac215b4638a0c7cdd2b20bc7830b9619f2&hb=35e8bc2992f48ffaff9007cfbf8faf3c856b18a3&f=lib%2Fkonq%2Fkonqpopupmenuplugin.desktop > for the latest version). > > I modified the name to kioservicemenuplugin.desktop because the file has not > been Konqueror-specific for quite some time. I also updated the 'Comment' > accordingly and removed the outdated translations. > > I hope I did that right - any comments are welcome! > > Note: Just like https://git.reviewboard.kde.org/r/124983/ this should > probably be pushed to master after the tagging for the next version because > of the translations. On the one hand, the translation of this 'Comment' might > not be that important because the it is not shown anywhere in the UI as far > as I know (it is shown in the 'Type' column in Dolphin though when viewing > the directory where this file is installed). But on the other hand, it might > be better to resolve both context menu issues in the same KIO release. What > do others think? > > > Diffs > - > > src/widgets/CMakeLists.txt 820cd34 > src/widgets/kioservicemenuplugin.desktop PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/125425/diff/ > > > Testing > --- > > Konsole service actions are shown in the context menu again. > > > Thanks, > > Frank Reininghaus > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories
> On Sept. 28, 2015, 7:30 a.m., David Faure wrote: > > The filename not matching the servicetype name in it, is very confusing. > > > > How about deprecating KonqPopupMenu/Plugin, introducing a > > KIOServiceMenuPlugin servicetype, installing desktop files for both, > > querying for both and skipping the installation of > > konqpopupmenuplugin.desktop if the KIO version is > 5.15? > > Frank Reininghaus wrote: > If we change the ServiceType entry in the file, then every service menu > will have to be changed, right? Not only those that are installed by > applications and libraries that are hosted on git.kde.org (which we could at > least find and fix), but also service menus that are released on > kde-apps.org, or unreleased menus that users have written for themselves. I > thought that it's unrealistic that this happens for every single service > menu, that's why I thought that the KonqPopupMenu/Plugin type should be kept. > Or am I overlooking something? If not, then I'm happy to change the file name > - probably having a konqpopupmenuplugin.desktop in KIO is really less > confusing than the ServiceType/file name mismatch. Yes this is why I was suggesting to install desktop files for both names. Deprecating != removing. Make both servicetype names work, but issue a warning if a plugin only implements KonqPopupMenu/Plugin and not KIOServiceMenuPlugin (both is ok, it's a way to make it work for older versions of KF5). Only KIOServiceMenuPlugin is ok of course. Anyway, that's more work, if you want to just rename the file and move on I'm ok with that. In any case, make sure to avoid the conflict between kio and libkonq installing the same file, with a version check. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125425/#review86028 --- On Sept. 27, 2015, 6:18 p.m., Frank Reininghaus wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125425/ > --- > > (Updated Sept. 27, 2015, 6:18 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Bugs: 350769 > https://bugs.kde.org/show_bug.cgi?id=350769 > > > Repository: kio > > > Description > --- > > This is a modified version of the file konqpopupmenuplugin.desktop in > kde-baseapps (see > https://quickgit.kde.org/?p=kde-baseapps.git&a=blob&h=94a680ac215b4638a0c7cdd2b20bc7830b9619f2&hb=35e8bc2992f48ffaff9007cfbf8faf3c856b18a3&f=lib%2Fkonq%2Fkonqpopupmenuplugin.desktop > for the latest version). > > I modified the name to kioservicemenuplugin.desktop because the file has not > been Konqueror-specific for quite some time. I also updated the 'Comment' > accordingly and removed the outdated translations. > > I hope I did that right - any comments are welcome! > > Note: Just like https://git.reviewboard.kde.org/r/124983/ this should > probably be pushed to master after the tagging for the next version because > of the translations. On the one hand, the translation of this 'Comment' might > not be that important because the it is not shown anywhere in the UI as far > as I know (it is shown in the 'Type' column in Dolphin though when viewing > the directory where this file is installed). But on the other hand, it might > be better to resolve both context menu issues in the same KIO release. What > do others think? > > > Diffs > - > > src/widgets/CMakeLists.txt 820cd34 > src/widgets/kioservicemenuplugin.desktop PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/125425/diff/ > > > Testing > --- > > Konsole service actions are shown in the context menu again. > > > Thanks, > > Frank Reininghaus > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories
> On Sept. 28, 2015, 7:30 vorm., David Faure wrote: > > The filename not matching the servicetype name in it, is very confusing. > > > > How about deprecating KonqPopupMenu/Plugin, introducing a > > KIOServiceMenuPlugin servicetype, installing desktop files for both, > > querying for both and skipping the installation of > > konqpopupmenuplugin.desktop if the KIO version is > 5.15? If we change the ServiceType entry in the file, then every service menu will have to be changed, right? Not only those that are installed by applications and libraries that are hosted on git.kde.org (which we could at least find and fix), but also service menus that are released on kde-apps.org, or unreleased menus that users have written for themselves. I thought that it's unrealistic that this happens for every single service menu, that's why I thought that the KonqPopupMenu/Plugin type should be kept. Or am I overlooking something? If not, then I'm happy to change the file name - probably having a konqpopupmenuplugin.desktop in KIO is really less confusing than the ServiceType/file name mismatch. - Frank --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125425/#review86028 --- On Sept. 27, 2015, 6:18 nachm., Frank Reininghaus wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125425/ > --- > > (Updated Sept. 27, 2015, 6:18 nachm.) > > > Review request for KDE Frameworks and David Faure. > > > Bugs: 350769 > https://bugs.kde.org/show_bug.cgi?id=350769 > > > Repository: kio > > > Description > --- > > This is a modified version of the file konqpopupmenuplugin.desktop in > kde-baseapps (see > https://quickgit.kde.org/?p=kde-baseapps.git&a=blob&h=94a680ac215b4638a0c7cdd2b20bc7830b9619f2&hb=35e8bc2992f48ffaff9007cfbf8faf3c856b18a3&f=lib%2Fkonq%2Fkonqpopupmenuplugin.desktop > for the latest version). > > I modified the name to kioservicemenuplugin.desktop because the file has not > been Konqueror-specific for quite some time. I also updated the 'Comment' > accordingly and removed the outdated translations. > > I hope I did that right - any comments are welcome! > > Note: Just like https://git.reviewboard.kde.org/r/124983/ this should > probably be pushed to master after the tagging for the next version because > of the translations. On the one hand, the translation of this 'Comment' might > not be that important because the it is not shown anywhere in the UI as far > as I know (it is shown in the 'Type' column in Dolphin though when viewing > the directory where this file is installed). But on the other hand, it might > be better to resolve both context menu issues in the same KIO release. What > do others think? > > > Diffs > - > > src/widgets/CMakeLists.txt 820cd34 > src/widgets/kioservicemenuplugin.desktop PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/125425/diff/ > > > Testing > --- > > Konsole service actions are shown in the context menu again. > > > Thanks, > > Frank Reininghaus > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125425/#review86028 --- The filename not matching the servicetype name in it, is very confusing. How about deprecating KonqPopupMenu/Plugin, introducing a KIOServiceMenuPlugin servicetype, installing desktop files for both, querying for both and skipping the installation of konqpopupmenuplugin.desktop if the KIO version is > 5.15? - David Faure On Sept. 27, 2015, 6:18 p.m., Frank Reininghaus wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125425/ > --- > > (Updated Sept. 27, 2015, 6:18 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Bugs: 350769 > https://bugs.kde.org/show_bug.cgi?id=350769 > > > Repository: kio > > > Description > --- > > This is a modified version of the file konqpopupmenuplugin.desktop in > kde-baseapps (see > https://quickgit.kde.org/?p=kde-baseapps.git&a=blob&h=94a680ac215b4638a0c7cdd2b20bc7830b9619f2&hb=35e8bc2992f48ffaff9007cfbf8faf3c856b18a3&f=lib%2Fkonq%2Fkonqpopupmenuplugin.desktop > for the latest version). > > I modified the name to kioservicemenuplugin.desktop because the file has not > been Konqueror-specific for quite some time. I also updated the 'Comment' > accordingly and removed the outdated translations. > > I hope I did that right - any comments are welcome! > > Note: Just like https://git.reviewboard.kde.org/r/124983/ this should > probably be pushed to master after the tagging for the next version because > of the translations. On the one hand, the translation of this 'Comment' might > not be that important because the it is not shown anywhere in the UI as far > as I know (it is shown in the 'Type' column in Dolphin though when viewing > the directory where this file is installed). But on the other hand, it might > be better to resolve both context menu issues in the same KIO release. What > do others think? > > > Diffs > - > > src/widgets/CMakeLists.txt 820cd34 > src/widgets/kioservicemenuplugin.desktop PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/125425/diff/ > > > Testing > --- > > Konsole service actions are shown in the context menu again. > > > Thanks, > > Frank Reininghaus > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125425/ --- Review request for KDE Frameworks and David Faure. Bugs: 350769 https://bugs.kde.org/show_bug.cgi?id=350769 Repository: kio Description --- This is a modified version of the file konqpopupmenuplugin.desktop in kde-baseapps (see https://quickgit.kde.org/?p=kde-baseapps.git&a=blob&h=94a680ac215b4638a0c7cdd2b20bc7830b9619f2&hb=35e8bc2992f48ffaff9007cfbf8faf3c856b18a3&f=lib%2Fkonq%2Fkonqpopupmenuplugin.desktop for the latest version). I modified the name to kioservicemenuplugin.desktop because the file has not been Konqueror-specific for quite some time. I also updated the 'Comment' accordingly and removed the outdated translations. I hope I did that right - any comments are welcome! Note: Just like https://git.reviewboard.kde.org/r/124983/ this should probably be pushed to master after the tagging for the next version because of the translations. On the one hand, the translation of this 'Comment' might not be that important because the it is not shown anywhere in the UI as far as I know (it is shown in the 'Type' column in Dolphin though when viewing the directory where this file is installed). But on the other hand, it might be better to resolve both context menu issues in the same KIO release. What do others think? Diffs - src/widgets/CMakeLists.txt 820cd34 src/widgets/kioservicemenuplugin.desktop PRE-CREATION Diff: https://git.reviewboard.kde.org/r/125425/diff/ Testing --- Konsole service actions are shown in the context menu again. Thanks, Frank Reininghaus ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
