Re: Review Request 125815: Provide an alternative when khelpcenter is not available

2015-11-07 Thread Luigi Toscano 


> On Nov. 4, 2015, 1:43 a.m., Aleix Pol Gonzalez wrote:
> > Bump? Anyone with docs.kde.org knowledge around?
> 
> Ben Cooksley wrote:
> As long as the application name is being submitted in lower case, it 
> should work fine.
> 
> Examples: 
> https://docs.kde.org/index.php?branch=stable5&application=gwenview
> https://docs.kde.org/index.php?branch=stable5&application=konversation
> https://docs.kde.org/index.php?branch=stable5&application=dolphin
> 
> Luigi Toscano wrote:
> There are few exceptions for kioslaves and kcm modules:
> application=kioslave5/ftp for kioslaves (or kioslave/ftp for the kdelibs4 
> based version)
> application=kcontrol/powerdevil
> Not sure if they need to be handled there or those values are already 
> specified as applicationName()
> 
> For the record, all the source code is here:
> https://quickgit.kde.org/?p=websites%2Fdocs-kde-org.git&a=tree
> 
> Ralf Habacker wrote:
> What about language selection ? khelpcenter also covers to select the 
> language currently used in the KDE environment.
> 
> Aleix Pol Gonzalez wrote:
> I introduced it in the committed version. It will need some love in the 
> server-side though, since it needs to understand that "fr_FR" is "fr".
> We can do the cutting before the _ because there's some exceptions, for 
> example zh_CN.
> 
> Help there is welcome.

Server side for xy_XY: 
https://quickgit.kde.org/?p=websites%2Fdocs-kde-org.git&a=commit&h=60ef1e16faf3328362b17e1048d8bad01f168fef


- Luigi


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125815/#review87979
---


On Nov. 6, 2015, 5:48 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125815/
> ---
> 
> (Updated Nov. 6, 2015, 5:48 p.m.)
> 
> 
> Review request for KDE Frameworks, Christoph Cullmann and Luigi Toscano.
> 
> 
> Repository: kguiaddons
> 
> 
> Description
> ---
> 
> Tries to reach out to docs.kde.org when khelpcenter is not available.
> 
> 
> Diffs
> -
> 
>   src/util/urlhandler.cpp 5b46be2 
> 
> Diff: https://git.reviewboard.kde.org/r/125815/diff/
> 
> 
> Testing
> ---
> 
> I tried it with a couple of applications. For the main documentation just 
> works.
> 
> Needs figuring out for more complex cases, I'm unsure if applications are 
> opening the documentation in specific pages. In fact, I couldn't find the 
> documentation for docs.kde.org url scheme, and I just made up the `path` 
> part, although it seems to work.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125815: Provide an alternative when khelpcenter is not available

2015-11-06 Thread Nick Shaforostoff 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125815/#review88105
---



src/util/urlhandler.cpp (line 49)


there is no point in using QStringLiteral there as a deep copy is done 
anyways. using QLatin1String would take almost the same time, except that the 
.so binary would be smaller.

instead for QStandardPaths::findExecutable it does make sense to use 
QStringLiteral


- Nick Shaforostoff


On Nov. 6, 2015, 4:48 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125815/
> ---
> 
> (Updated Nov. 6, 2015, 4:48 p.m.)
> 
> 
> Review request for KDE Frameworks, Christoph Cullmann and Luigi Toscano.
> 
> 
> Repository: kguiaddons
> 
> 
> Description
> ---
> 
> Tries to reach out to docs.kde.org when khelpcenter is not available.
> 
> 
> Diffs
> -
> 
>   src/util/urlhandler.cpp 5b46be2 
> 
> Diff: https://git.reviewboard.kde.org/r/125815/diff/
> 
> 
> Testing
> ---
> 
> I tried it with a couple of applications. For the main documentation just 
> works.
> 
> Needs figuring out for more complex cases, I'm unsure if applications are 
> opening the documentation in specific pages. In fact, I couldn't find the 
> documentation for docs.kde.org url scheme, and I just made up the `path` 
> part, although it seems to work.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125815: Provide an alternative when khelpcenter is not available

2015-11-06 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125815/
---

(Updated Nov. 6, 2015, 4:48 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Christoph Cullmann and Luigi Toscano.


Changes
---

Submitted with commit c61b3a8acfd013e50219e62da68f300ab43acfaf by Aleix Pol to 
branch master.


Repository: kguiaddons


Description
---

Tries to reach out to docs.kde.org when khelpcenter is not available.


Diffs
-

  src/util/urlhandler.cpp 5b46be2 

Diff: https://git.reviewboard.kde.org/r/125815/diff/


Testing
---

I tried it with a couple of applications. For the main documentation just works.

Needs figuring out for more complex cases, I'm unsure if applications are 
opening the documentation in specific pages. In fact, I couldn't find the 
documentation for docs.kde.org url scheme, and I just made up the `path` part, 
although it seems to work.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125815: Provide an alternative when khelpcenter is not available

2015-11-06 Thread Aleix Pol Gonzalez 


> On Nov. 4, 2015, 1:43 a.m., Aleix Pol Gonzalez wrote:
> > Bump? Anyone with docs.kde.org knowledge around?
> 
> Ben Cooksley wrote:
> As long as the application name is being submitted in lower case, it 
> should work fine.
> 
> Examples: 
> https://docs.kde.org/index.php?branch=stable5&application=gwenview
> https://docs.kde.org/index.php?branch=stable5&application=konversation
> https://docs.kde.org/index.php?branch=stable5&application=dolphin
> 
> Luigi Toscano wrote:
> There are few exceptions for kioslaves and kcm modules:
> application=kioslave5/ftp for kioslaves (or kioslave/ftp for the kdelibs4 
> based version)
> application=kcontrol/powerdevil
> Not sure if they need to be handled there or those values are already 
> specified as applicationName()
> 
> For the record, all the source code is here:
> https://quickgit.kde.org/?p=websites%2Fdocs-kde-org.git&a=tree
> 
> Ralf Habacker wrote:
> What about language selection ? khelpcenter also covers to select the 
> language currently used in the KDE environment.

I introduced it in the committed version. It will need some love in the 
server-side though, since it needs to understand that "fr_FR" is "fr".
We can do the cutting before the _ because there's some exceptions, for example 
zh_CN.

Help there is welcome.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125815/#review87979
---


On Nov. 4, 2015, 6:55 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125815/
> ---
> 
> (Updated Nov. 4, 2015, 6:55 p.m.)
> 
> 
> Review request for KDE Frameworks, Christoph Cullmann and Luigi Toscano.
> 
> 
> Repository: kguiaddons
> 
> 
> Description
> ---
> 
> Tries to reach out to docs.kde.org when khelpcenter is not available.
> 
> 
> Diffs
> -
> 
>   src/util/urlhandler.cpp 5b46be2 
> 
> Diff: https://git.reviewboard.kde.org/r/125815/diff/
> 
> 
> Testing
> ---
> 
> I tried it with a couple of applications. For the main documentation just 
> works.
> 
> Needs figuring out for more complex cases, I'm unsure if applications are 
> opening the documentation in specific pages. In fact, I couldn't find the 
> documentation for docs.kde.org url scheme, and I just made up the `path` 
> part, although it seems to work.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125815: Provide an alternative when khelpcenter is not available

2015-11-04 Thread Ralf Habacker 


> On Nov. 4, 2015, 1:43 vorm., Aleix Pol Gonzalez wrote:
> > Bump? Anyone with docs.kde.org knowledge around?
> 
> Ben Cooksley wrote:
> As long as the application name is being submitted in lower case, it 
> should work fine.
> 
> Examples: 
> https://docs.kde.org/index.php?branch=stable5&application=gwenview
> https://docs.kde.org/index.php?branch=stable5&application=konversation
> https://docs.kde.org/index.php?branch=stable5&application=dolphin
> 
> Luigi Toscano wrote:
> There are few exceptions for kioslaves and kcm modules:
> application=kioslave5/ftp for kioslaves (or kioslave/ftp for the kdelibs4 
> based version)
> application=kcontrol/powerdevil
> Not sure if they need to be handled there or those values are already 
> specified as applicationName()
> 
> For the record, all the source code is here:
> https://quickgit.kde.org/?p=websites%2Fdocs-kde-org.git&a=tree

What about language selection ? khelpcenter also covers to select the language 
currently used in the KDE environment.


- Ralf


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125815/#review87979
---


On Nov. 4, 2015, 6:55 nachm., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125815/
> ---
> 
> (Updated Nov. 4, 2015, 6:55 nachm.)
> 
> 
> Review request for KDE Frameworks, Christoph Cullmann and Luigi Toscano.
> 
> 
> Repository: kguiaddons
> 
> 
> Description
> ---
> 
> Tries to reach out to docs.kde.org when khelpcenter is not available.
> 
> 
> Diffs
> -
> 
>   src/util/urlhandler.cpp 5b46be2 
> 
> Diff: https://git.reviewboard.kde.org/r/125815/diff/
> 
> 
> Testing
> ---
> 
> I tried it with a couple of applications. For the main documentation just 
> works.
> 
> Needs figuring out for more complex cases, I'm unsure if applications are 
> opening the documentation in specific pages. In fact, I couldn't find the 
> documentation for docs.kde.org url scheme, and I just made up the `path` 
> part, although it seems to work.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125815: Provide an alternative when khelpcenter is not available

2015-11-04 Thread Alex Merry 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125815/#review88019
---

Ship it!


As you noted, it's better than the current situation, so I say ship it.


src/util/urlhandler.cpp (line 29)


Unused include


- Alex Merry


On Nov. 4, 2015, 5:55 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125815/
> ---
> 
> (Updated Nov. 4, 2015, 5:55 p.m.)
> 
> 
> Review request for KDE Frameworks, Christoph Cullmann and Luigi Toscano.
> 
> 
> Repository: kguiaddons
> 
> 
> Description
> ---
> 
> Tries to reach out to docs.kde.org when khelpcenter is not available.
> 
> 
> Diffs
> -
> 
>   src/util/urlhandler.cpp 5b46be2 
> 
> Diff: https://git.reviewboard.kde.org/r/125815/diff/
> 
> 
> Testing
> ---
> 
> I tried it with a couple of applications. For the main documentation just 
> works.
> 
> Needs figuring out for more complex cases, I'm unsure if applications are 
> opening the documentation in specific pages. In fact, I couldn't find the 
> documentation for docs.kde.org url scheme, and I just made up the `path` 
> part, although it seems to work.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125815: Provide an alternative when khelpcenter is not available

2015-11-04 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125815/
---

(Updated Nov. 4, 2015, 6:55 p.m.)


Review request for KDE Frameworks, Christoph Cullmann and Luigi Toscano.


Changes
---

The apache redirections do something similar to my patch 
https://quickgit.kde.org/?p=websites%2Fdocs-kde-org.git&a=blob&h=ae03e951c8d7cb8dda070e1a9592ea0a15ecc0f9&f=apache-docs.kde.org.conf&o=plain.

I suggest to have it merged, as it will always work better than the current 
state which is just show an error.


Summary (updated)
-

Provide an alternative when khelpcenter is not available


Repository: kguiaddons


Description
---

Tries to reach out to docs.kde.org when khelpcenter is not available.


Diffs
-

  src/util/urlhandler.cpp 5b46be2 

Diff: https://git.reviewboard.kde.org/r/125815/diff/


Testing
---

I tried it with a couple of applications. For the main documentation just works.

Needs figuring out for more complex cases, I'm unsure if applications are 
opening the documentation in specific pages. In fact, I couldn't find the 
documentation for docs.kde.org url scheme, and I just made up the `path` part, 
although it seems to work.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel