Re: Review Request 125941: Add KCompressionDevice tests to KArchive

2015-11-25 Thread David Faure 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125941/#review88847
---

Ship it!


I would have used less member variables in the unittest, but ok nevermind, it's 
just a test.

Thanks for the test, let's have it in.


autotests/CMakeLists.txt (line 6)


This should probably be made optional, it's an unexpected dependency for 
KArchive.



autotests/kcompressiondevicetest.cpp (line 32)


not really needed for this QBuffer-based test, but ok, it's just a first 
step towards making QNetworkReply work, let's commit what works now.


- David Faure


On Nov. 25, 2015, 3:12 p.m., Romário Rios wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125941/
> ---
> 
> (Updated Nov. 25, 2015, 3:12 p.m.)
> 
> 
> Review request for KDE Frameworks, Aleix Pol Gonzalez and David Faure.
> 
> 
> Repository: karchive
> 
> 
> Description
> ---
> 
> I recently noticed that using KTar with KCompressionDevice and QNetworkReply 
> did not work, so I'm adding some tests to confirm that
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt 1b2e819 
>   autotests/kcompressiondevicetest.h PRE-CREATION 
>   autotests/kcompressiondevicetest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125941/diff/
> 
> 
> Testing
> ---
> 
> The tests run and show that KCompressionDevice works properly with QBuffer 
> when used with KTar
> 
> 
> Thanks,
> 
> Romário Rios
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125941: Add KCompressionDevice tests to KArchive

2015-11-25 Thread Romário Rios 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125941/
---

(Updated Nov. 25, 2015, 9:19 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Aleix Pol Gonzalez and David Faure.


Changes
---

Submitted with commit 31a735a3dfb75d9f345a326fe5dbfa3651647463 by Luiz Romário 
Santana Rios to branch master.


Repository: karchive


Description
---

I recently noticed that using KTar with KCompressionDevice and QNetworkReply 
did not work, so I'm adding some tests to confirm that


Diffs
-

  autotests/CMakeLists.txt 1b2e819 
  autotests/kcompressiondevicetest.h PRE-CREATION 
  autotests/kcompressiondevicetest.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/125941/diff/


Testing
---

The tests run and show that KCompressionDevice works properly with QBuffer when 
used with KTar


Thanks,

Romário Rios

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125941: Add KCompressionDevice tests to KArchive

2015-11-25 Thread Romário Rios 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125941/
---

(Updated Nov. 25, 2015, 9:16 p.m.)


Review request for KDE Frameworks, Aleix Pol Gonzalez and David Faure.


Changes
---

Make Qt5Network optional


Repository: karchive


Description
---

I recently noticed that using KTar with KCompressionDevice and QNetworkReply 
did not work, so I'm adding some tests to confirm that


Diffs (updated)
-

  autotests/CMakeLists.txt 1b2e819 
  autotests/kcompressiondevicetest.h PRE-CREATION 
  autotests/kcompressiondevicetest.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/125941/diff/


Testing
---

The tests run and show that KCompressionDevice works properly with QBuffer when 
used with KTar


Thanks,

Romário Rios

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125941: Add KCompressionDevice tests to KArchive

2015-11-25 Thread Romário Rios 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125941/
---

(Updated Nov. 25, 2015, 3:12 p.m.)


Review request for KDE Frameworks, Aleix Pol Gonzalez and David Faure.


Changes
---

Remove QNetworkReply tests without QBuffer for now


Repository: karchive


Description
---

I recently noticed that using KTar with KCompressionDevice and QNetworkReply 
did not work, so I'm adding some tests to confirm that


Diffs (updated)
-

  autotests/CMakeLists.txt 1b2e819 
  autotests/kcompressiondevicetest.h PRE-CREATION 
  autotests/kcompressiondevicetest.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/125941/diff/


Testing (updated)
---

The tests run and show that KCompressionDevice works properly with QBuffer when 
used with KTar


Thanks,

Romário Rios

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125941: Add KCompressionDevice tests to KArchive

2015-11-04 Thread Romário Rios 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125941/#review88018
---



autotests/kcompressiondevicetest.cpp (line 29)


I don't believe it can. It can do the opposite -- CompressionType by 
filename or mimetype --, but not this.


- Romário Rios


On Nov. 4, 2015, 2:08 a.m., Romário Rios wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125941/
> ---
> 
> (Updated Nov. 4, 2015, 2:08 a.m.)
> 
> 
> Review request for KDE Frameworks and Aleix Pol Gonzalez.
> 
> 
> Repository: karchive
> 
> 
> Description
> ---
> 
> I recently noticed that using KTar with KCompressionDevice and QNetworkReply 
> did not work, so I'm adding some tests to confirm that
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt 1b2e819 
>   autotests/kcompressiondevicetest.h PRE-CREATION 
>   autotests/kcompressiondevicetest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125941/diff/
> 
> 
> Testing
> ---
> 
> The tests run and show that KCompressionDevice isn't working as expected
> 
> 
> Thanks,
> 
> Romário Rios
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 125941: Add KCompressionDevice tests to KArchive

2015-11-03 Thread Romário Rios 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125941/
---

Review request for KDE Frameworks and Aleix Pol Gonzalez.


Repository: karchive


Description
---

I recently noticed that using KTar with KCompressionDevice and QNetworkReply 
did not work, so I'm adding some tests to confirm that


Diffs
-

  autotests/CMakeLists.txt 1b2e819 
  autotests/kcompressiondevicetest.h PRE-CREATION 
  autotests/kcompressiondevicetest.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/125941/diff/


Testing
---

The tests run and show that KCompressionDevice isn't working as expected


Thanks,

Romário Rios

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125941: Add KCompressionDevice tests to KArchive

2015-11-03 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125941/#review87980
---



autotests/kcompressiondevicetest.cpp (line 29)


Can't KArchive do that already?



autotests/kcompressiondevicetest.cpp (line 69)


Use QTemporaryDir.



autotests/kcompressiondevicetest.cpp (line 79)


You should compare to the file size, otherwise this all will have to be 
changed every time these files are modified.


Good first step!

- Aleix Pol Gonzalez


On Nov. 4, 2015, 3:08 a.m., Romário Rios wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125941/
> ---
> 
> (Updated Nov. 4, 2015, 3:08 a.m.)
> 
> 
> Review request for KDE Frameworks and Aleix Pol Gonzalez.
> 
> 
> Repository: karchive
> 
> 
> Description
> ---
> 
> I recently noticed that using KTar with KCompressionDevice and QNetworkReply 
> did not work, so I'm adding some tests to confirm that
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt 1b2e819 
>   autotests/kcompressiondevicetest.h PRE-CREATION 
>   autotests/kcompressiondevicetest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125941/diff/
> 
> 
> Testing
> ---
> 
> The tests run and show that KCompressionDevice isn't working as expected
> 
> 
> Thanks,
> 
> Romário Rios
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel