Re: Review Request 126149: [Icon widget] Bring back properties dialog
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126149/ --- (Updated Sept. 6, 2016, 8:55 nachm.) Status -- This change has been discarded. Review request for KDE Frameworks and Plasma. Bugs: 349177 https://bugs.kde.org/show_bug.cgi?id=349177 Repository: plasma-workspace Description --- This brings back the KPropertiesDialog to modify an icon's appearance. This has been requested at multiple occasions. This has been adapted from the Plasma 4 icon code. Diffs - applets/icon/package/contents/ui/main.qml 9286b94 applets/icon/plugin/icon_p.h dd7963c applets/icon/plugin/icon_p.cpp e086870 Diff: https://git.reviewboard.kde.org/r/126149/diff/ Testing --- Dropped a file from my home onto the desktop -> dialog from the actual file, allowing to rename it. The applet reflected the changes. Dropped an application from kickoff to the desktop -> dialog from a copy of the desktop file, allowing to change its icon and description. The applet reflected the changes. Thanks, Kai Uwe Broulik
Re: Review Request 126149: [Icon widget] Bring back properties dialog
> On Dec. 29, 2015, 6:07 p.m., Kai Uwe Broulik wrote: > > I completely screwed up my Kate desktop files :( Would it help if I set > > NoDisplay or Hidden on the desktop file copy so it's there for the icon > > widget but not shown in the Open With dialogs and so on? Or, if I copied > > the desktop file elsewhere (eg. not into the local share applications)? > > > > Also, I should probably delete the desktop file again if the widget is > > removed :) If you set NoDisplay or Hidden in ~/.local/share/applications/kate.desktop then this will fully hide kate from your K menu. That's a local override. Desktop files in the panel or on the desktop should probably be copies, yes (in other dirs than ~/.local/share/applications/) - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126149/#review90298 --- On Dec. 21, 2015, 11:31 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126149/ > --- > > (Updated Dec. 21, 2015, 11:31 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Bugs: 349177 > https://bugs.kde.org/show_bug.cgi?id=349177 > > > Repository: plasma-workspace > > > Description > --- > > This brings back the KPropertiesDialog to modify an icon's appearance. This > has been requested at multiple occasions. This has been adapted from the > Plasma 4 icon code. > > > Diffs > - > > applets/icon/package/contents/ui/main.qml 9286b94 > applets/icon/plugin/icon_p.h dd7963c > applets/icon/plugin/icon_p.cpp e086870 > > Diff: https://git.reviewboard.kde.org/r/126149/diff/ > > > Testing > --- > > Dropped a file from my home onto the desktop -> dialog from the actual file, > allowing to rename it. The applet reflected the changes. > > Dropped an application from kickoff to the desktop -> dialog from a copy of > the desktop file, allowing to change its icon and description. The applet > reflected the changes. > > > Thanks, > > Kai Uwe Broulik > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 126149: [Icon widget] Bring back properties dialog
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126149/#review90298 --- I completely screwed up my Kate desktop files :( Would it help if I set NoDisplay or Hidden on the desktop file copy so it's there for the icon widget but not shown in the Open With dialogs and so on? Or, if I copied the desktop file elsewhere (eg. not into the local share applications)? Also, I should probably delete the desktop file again if the widget is removed :) - Kai Uwe Broulik On Dez. 21, 2015, 11:31 nachm., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126149/ > --- > > (Updated Dez. 21, 2015, 11:31 nachm.) > > > Review request for KDE Frameworks and Plasma. > > > Bugs: 349177 > https://bugs.kde.org/show_bug.cgi?id=349177 > > > Repository: plasma-workspace > > > Description > --- > > This brings back the KPropertiesDialog to modify an icon's appearance. This > has been requested at multiple occasions. This has been adapted from the > Plasma 4 icon code. > > > Diffs > - > > applets/icon/package/contents/ui/main.qml 9286b94 > applets/icon/plugin/icon_p.h dd7963c > applets/icon/plugin/icon_p.cpp e086870 > > Diff: https://git.reviewboard.kde.org/r/126149/diff/ > > > Testing > --- > > Dropped a file from my home onto the desktop -> dialog from the actual file, > allowing to rename it. The applet reflected the changes. > > Dropped an application from kickoff to the desktop -> dialog from a copy of > the desktop file, allowing to change its icon and description. The applet > reflected the changes. > > > Thanks, > > Kai Uwe Broulik > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 126149: [Icon widget] Bring back properties dialog
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126149/ --- (Updated Dez. 21, 2015, 11:31 nachm.) Review request for KDE Frameworks and Plasma. Bugs: 349177 https://bugs.kde.org/show_bug.cgi?id=349177 Repository: plasma-workspace Description --- This brings back the KPropertiesDialog to modify an icon's appearance. This has been requested at multiple occasions. This has been adapted from the Plasma 4 icon code. Diffs - applets/icon/package/contents/ui/main.qml 9286b94 applets/icon/plugin/icon_p.h dd7963c applets/icon/plugin/icon_p.cpp e086870 Diff: https://git.reviewboard.kde.org/r/126149/diff/ Testing --- Dropped a file from my home onto the desktop -> dialog from the actual file, allowing to rename it. The applet reflected the changes. Dropped an application from kickoff to the desktop -> dialog from a copy of the desktop file, allowing to change its icon and description. The applet reflected the changes. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 126149: [Icon widget] Bring back properties dialog
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126149/ --- (Updated Nov. 26, 2015, 8:15 nachm.) Review request for KDE Frameworks and Plasma. Changes --- Adding Frameworks Does anyone of you have an idea how to prevent it from registering the copies as applications (see last comments)? Bugs: ? https://bugs.kde.org/show_bug.cgi?id=? Repository: plasma-workspace Description --- This brings back the KPropertiesDialog to modify an icon's appearance. This has been requested at multiple occasions. This has been adapted from the Plasma 4 icon code. Diffs - applets/icon/package/contents/ui/main.qml 9286b94 applets/icon/plugin/icon_p.h dd7963c applets/icon/plugin/icon_p.cpp e086870 Diff: https://git.reviewboard.kde.org/r/126149/diff/ Testing --- Dropped a file from my home onto the desktop -> dialog from the actual file, allowing to rename it. The applet reflected the changes. Dropped an application from kickoff to the desktop -> dialog from a copy of the desktop file, allowing to change its icon and description. The applet reflected the changes. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel