Re: Review Request 126196: Fix regression caused by RR 125527
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126196/ --- (Updated Nov. 30, 2015, 8:40 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Jarosław Staniek. Changes --- Submitted with commit 78d740aece90b676086412f977d4cd691791bd8f by Alex Richardson to branch master. Repository: kcoreaddons Description --- Make sure that applications using kcoreaddons_desktop_to_json() that depend on reading the MimeType property of the root object still work See https://git.reviewboard.kde.org/r/125527/ Diffs - src/lib/plugin/desktopfileparser.cpp eae91881bafc93b047b81a2b21634223dd5d89f4 Diff: https://git.reviewboard.kde.org/r/126196/diff/ Testing --- compiles, tests pass Thanks, Alex Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 126196: Fix regression caused by RR 125527
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126196/#review88920 --- Ship it! Brilliant fix. Thanks a lot, Alex! - Jarosław Staniek On Nov. 28, 2015, 11:25 p.m., Alex Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126196/ > --- > > (Updated Nov. 28, 2015, 11:25 p.m.) > > > Review request for KDE Frameworks and Jarosław Staniek. > > > Repository: kcoreaddons > > > Description > --- > > Make sure that applications using kcoreaddons_desktop_to_json() that > depend on reading the MimeType property of the root object still work > > See https://git.reviewboard.kde.org/r/125527/ > > > Diffs > - > > src/lib/plugin/desktopfileparser.cpp > eae91881bafc93b047b81a2b21634223dd5d89f4 > > Diff: https://git.reviewboard.kde.org/r/126196/diff/ > > > Testing > --- > > compiles, tests pass > > > Thanks, > > Alex Richardson > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 126196: Fix regression caused by RR 125527
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126196/ --- Review request for KDE Frameworks and Jarosław Staniek. Repository: kcoreaddons Description --- Make sure that applications using kcoreaddons_desktop_to_json() that depend on reading the MimeType property of the root object still work See https://git.reviewboard.kde.org/r/125527/ Diffs - src/lib/plugin/desktopfileparser.cpp eae91881bafc93b047b81a2b21634223dd5d89f4 Diff: https://git.reviewboard.kde.org/r/126196/diff/ Testing --- compiles, tests pass Thanks, Alex Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
