Re: Review Request 126199: Don't warn when SVG(Z) icons are provided with multiple sizes/levels of detail
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126199/ --- (Updated Nov. 30, 2015, 5:05 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Alex Merry. Changes --- Submitted with commit 18243570bcae0cf02a4a87eff2f1834500ae955d by Jaroslaw Staniek to branch master. Repository: extra-cmake-modules Description --- This change adds SVG(Z) extensions to the list of allowed icons for specific sizes. This technically works and is practiced, e.g. for some Breeze icons. Reasoning: Some SVG icons do not scale well down from 32 to 22 or up from 16 to 22. For such cases icons are typically specially crafted for 22 and 16, at least. Then there's no single icon that be marked as "sc". So warnings such as: CMake Warning at /ECMInstallIcons.cmake:272 (message): Fixed-size icon foo.svg is not PNG or MNG ... are misleading. Diffs - modules/ECMInstallIcons.cmake 549ebe1 Diff: https://git.reviewboard.kde.org/r/126199/diff/ Testing --- ECM no longer warns for projects that use .svg icons of multiple variants (e.g. kreport.git master) Thanks, Jarosław Staniek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 126199: Don't warn when SVG(Z) icons are provided with multiple sizes/levels of detail
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126199/#review88966 --- Ship it! Ship It! - Alex Merry On Nov. 29, 2015, 8:59 p.m., Jarosław Staniek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126199/ > --- > > (Updated Nov. 29, 2015, 8:59 p.m.) > > > Review request for KDE Frameworks and Alex Merry. > > > Repository: extra-cmake-modules > > > Description > --- > > This change adds SVG(Z) extensions to the list of allowed icons for specific > sizes. > > This technically works and is practiced, e.g. for some Breeze icons. > > Reasoning: > Some SVG icons do not scale well down from 32 to 22 or up from 16 to 22. > For such cases icons are typically specially crafted for 22 and 16, at least. > Then there's no single icon that be marked as "sc". > > So warnings such as: > > CMake Warning at /ECMInstallIcons.cmake:272 (message): > Fixed-size icon foo.svg is not PNG or MNG > > ... are misleading. > > > Diffs > - > > modules/ECMInstallIcons.cmake 549ebe1 > > Diff: https://git.reviewboard.kde.org/r/126199/diff/ > > > Testing > --- > > ECM no longer warns for projects that use .svg icons of multiple variants > (e.g. kreport.git master) > > > Thanks, > > Jarosław Staniek > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 126199: Don't warn when SVG(Z) icons are provided with multiple sizes/levels of detail
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126199/ --- Review request for KDE Frameworks and Alex Merry. Repository: extra-cmake-modules Description --- This change adds SVG(Z) extensions to the list of allowed icons for specific sizes. This technically works and is practiced, e.g. for some Breeze icons. Reasoning: Some SVG icons do not scale well down from 32 to 22 or up from 16 to 22. For such cases icons are typically specially crafted for 22 and 16, at least. Then there's no single icon that be marked as "sc". So warnings such as: CMake Warning at /ECMInstallIcons.cmake:272 (message): Fixed-size icon foo.svg is not PNG or MNG ... are misleading. Diffs - modules/ECMInstallIcons.cmake 549ebe1 Diff: https://git.reviewboard.kde.org/r/126199/diff/ Testing --- ECM no longer warns for projects that use .svg icons of multiple variants (e.g. kreport.git master) Thanks, Jarosław Staniek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
