Re: Review Request 126429: Fixed all Clazy warnings level 1 and level 2

[Artur Puzio]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126429/
---

(Updated Dec. 19, 2015, 4:56 p.m.)


Review request for KDE Frameworks and Aleix Pol Gonzalez.


Repository: karchive


Description
---

Fixed warning: Folder has dtor but not copy-ctor, copy-assignment 
[-Wclazy-rule-of-three], by adding Q_DISABLE_COPY(Folder)
Fixed warning: Reserve candidate [-Wclazy-reserve-candidates], by 
precalculateing QVector size.
Fixed warning: unused variable [-Wunused-const-variable], by commenting unused 
variables


Diffs
-

  src/k7zip.cpp 7b5e6a3 

Diff: https://git.reviewboard.kde.org/r/126429/diff/


Testing
---

Automated tests pass.


Thanks,

Artur Puzio

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126429: Fixed all Clazy warnings level 1 and level 2

[Artur Puzio]

> On Gru 19, 2015, 4:55 po południu, Aleix Pol Gonzalez wrote:
> > In general I don't like commented code. Why keep it?
> > David, do you think we should keep it?
> > 
> > Artur, have you made sure the tests still pass? It doesn't say so in the 
> > testing field.

Sorry I have forgotten to submit Testing Done fild.


- Artur


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126429/#review89746
---


On Gru 19, 2015, 4:56 po południu, Artur Puzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126429/
> ---
> 
> (Updated Gru 19, 2015, 4:56 po południu)
> 
> 
> Review request for KDE Frameworks and Aleix Pol Gonzalez.
> 
> 
> Repository: karchive
> 
> 
> Description
> ---
> 
> Fixed warning: Folder has dtor but not copy-ctor, copy-assignment 
> [-Wclazy-rule-of-three], by adding Q_DISABLE_COPY(Folder)
> Fixed warning: Reserve candidate [-Wclazy-reserve-candidates], by 
> precalculateing QVector size.
> Fixed warning: unused variable [-Wunused-const-variable], by commenting 
> unused variables
> 
> 
> Diffs
> -
> 
>   src/k7zip.cpp 7b5e6a3 
> 
> Diff: https://git.reviewboard.kde.org/r/126429/diff/
> 
> 
> Testing
> ---
> 
> Automated tests pass.
> 
> 
> Thanks,
> 
> Artur Puzio
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126429: Fixed all Clazy warnings level 1 and level 2

[Artur Puzio]

> On Gru 19, 2015, 4:55 po południu, Aleix Pol Gonzalez wrote:
> > In general I don't like commented code. Why keep it?
> > David, do you think we should keep it?
> > 
> > Artur, have you made sure the tests still pass? It doesn't say so in the 
> > testing field.
> 
> Artur Puzio wrote:
> Sorry I have forgotten to submit Testing Done fild.

Actually it looks like I have succesfully written "Automated tests pass" in 
Testing Done field.


- Artur


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126429/#review89746
---


On Gru 19, 2015, 4:56 po południu, Artur Puzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126429/
> ---
> 
> (Updated Gru 19, 2015, 4:56 po południu)
> 
> 
> Review request for KDE Frameworks and Aleix Pol Gonzalez.
> 
> 
> Repository: karchive
> 
> 
> Description
> ---
> 
> Fixed warning: Folder has dtor but not copy-ctor, copy-assignment 
> [-Wclazy-rule-of-three], by adding Q_DISABLE_COPY(Folder)
> Fixed warning: Reserve candidate [-Wclazy-reserve-candidates], by 
> precalculateing QVector size.
> Fixed warning: unused variable [-Wunused-const-variable], by commenting 
> unused variables
> 
> 
> Diffs
> -
> 
>   src/k7zip.cpp 7b5e6a3 
> 
> Diff: https://git.reviewboard.kde.org/r/126429/diff/
> 
> 
> Testing
> ---
> 
> Automated tests pass.
> 
> 
> Thanks,
> 
> Artur Puzio
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126429: Fixed all Clazy warnings level 1 and level 2

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126429/#review89995
---



src/k7zip.cpp (line 118)


Why do we keep all this code?



src/k7zip.cpp (line 2029)


I wouldn't get this all in. Is that suggested by 
`-Wclazy-reserve-candidates`?


- Aleix Pol Gonzalez


On Dec. 19, 2015, 4:56 p.m., Artur Puzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126429/
> ---
> 
> (Updated Dec. 19, 2015, 4:56 p.m.)
> 
> 
> Review request for KDE Frameworks and Aleix Pol Gonzalez.
> 
> 
> Repository: karchive
> 
> 
> Description
> ---
> 
> Fixed warning: Folder has dtor but not copy-ctor, copy-assignment 
> [-Wclazy-rule-of-three], by adding Q_DISABLE_COPY(Folder)
> Fixed warning: Reserve candidate [-Wclazy-reserve-candidates], by 
> precalculateing QVector size.
> Fixed warning: unused variable [-Wunused-const-variable], by commenting 
> unused variables
> 
> 
> Diffs
> -
> 
>   src/k7zip.cpp 7b5e6a3 
> 
> Diff: https://git.reviewboard.kde.org/r/126429/diff/
> 
> 
> Testing
> ---
> 
> Automated tests pass.
> 
> 
> Thanks,
> 
> Artur Puzio
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126429: Fixed all Clazy warnings level 1 and level 2

[Artur Puzio]

> On Gru 23, 2015, 3:49 po południu, Aleix Pol Gonzalez wrote:
> > src/k7zip.cpp, line 2029
> > 
> >
> > I wouldn't get this all in. Is that suggested by 
> > `-Wclazy-reserve-candidates`?

Yes this is suggested by `-Wclazy-reserve-candidates`.


- Artur


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126429/#review89995
---


On Gru 23, 2015, 3:49 po południu, Artur Puzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126429/
> ---
> 
> (Updated Gru 23, 2015, 3:49 po południu)
> 
> 
> Review request for KDE Frameworks, Aleix Pol Gonzalez and Sergio Martins.
> 
> 
> Repository: karchive
> 
> 
> Description
> ---
> 
> Fixed warning: Folder has dtor but not copy-ctor, copy-assignment 
> [-Wclazy-rule-of-three], by adding Q_DISABLE_COPY(Folder)
> Fixed warning: Reserve candidate [-Wclazy-reserve-candidates], by 
> precalculateing QVector size.
> Fixed warning: unused variable [-Wunused-const-variable], by commenting 
> unused variables
> 
> 
> Diffs
> -
> 
>   src/k7zip.cpp 7b5e6a3 
> 
> Diff: https://git.reviewboard.kde.org/r/126429/diff/
> 
> 
> Testing
> ---
> 
> Automated tests pass.
> 
> 
> Thanks,
> 
> Artur Puzio
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126429: Fixed all Clazy warnings level 1 and level 2

[Artur Puzio]

> On Gru 23, 2015, 3:49 po południu, Aleix Pol Gonzalez wrote:
> > src/k7zip.cpp, line 118
> > 
> >
> > Why do we keep all this code?

Personally I would keep it, becouse I think its related to some not implemented 
features.


- Artur


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126429/#review89995
---


On Gru 23, 2015, 3:49 po południu, Artur Puzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126429/
> ---
> 
> (Updated Gru 23, 2015, 3:49 po południu)
> 
> 
> Review request for KDE Frameworks, Aleix Pol Gonzalez and Sergio Martins.
> 
> 
> Repository: karchive
> 
> 
> Description
> ---
> 
> Fixed warning: Folder has dtor but not copy-ctor, copy-assignment 
> [-Wclazy-rule-of-three], by adding Q_DISABLE_COPY(Folder)
> Fixed warning: Reserve candidate [-Wclazy-reserve-candidates], by 
> precalculateing QVector size.
> Fixed warning: unused variable [-Wunused-const-variable], by commenting 
> unused variables
> 
> 
> Diffs
> -
> 
>   src/k7zip.cpp 7b5e6a3 
> 
> Diff: https://git.reviewboard.kde.org/r/126429/diff/
> 
> 
> Testing
> ---
> 
> Automated tests pass.
> 
> 
> Thanks,
> 
> Artur Puzio
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126429: Fixed all Clazy warnings level 1 and level 2

[Sergio Martins]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126429/#review90023
---


- Sergio Martins


On Dec. 23, 2015, 2:49 p.m., Artur Puzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126429/
> ---
> 
> (Updated Dec. 23, 2015, 2:49 p.m.)
> 
> 
> Review request for KDE Frameworks, Aleix Pol Gonzalez and Sergio Martins.
> 
> 
> Repository: karchive
> 
> 
> Description
> ---
> 
> Fixed warning: Folder has dtor but not copy-ctor, copy-assignment 
> [-Wclazy-rule-of-three], by adding Q_DISABLE_COPY(Folder)
> Fixed warning: Reserve candidate [-Wclazy-reserve-candidates], by 
> precalculateing QVector size.
> Fixed warning: unused variable [-Wunused-const-variable], by commenting 
> unused variables
> 
> 
> Diffs
> -
> 
>   src/k7zip.cpp 7b5e6a3 
> 
> Diff: https://git.reviewboard.kde.org/r/126429/diff/
> 
> 
> Testing
> ---
> 
> Automated tests pass.
> 
> 
> Thanks,
> 
> Artur Puzio
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126429: Fixed all Clazy warnings level 1 and level 2

[Sergio Martins]

> On Dec. 23, 2015, 2:49 p.m., Aleix Pol Gonzalez wrote:
> > src/k7zip.cpp, line 2029
> > 
> >
> > I wouldn't get this all in. Is that suggested by 
> > `-Wclazy-reserve-candidates`?
> 
> Artur Puzio wrote:
> Yes this is suggested by `-Wclazy-reserve-candidates`.

I think this one is not worth it, as it makes the code more complex.
Also note that QVector already has a growth strategy, so it's not terrible.


- Sergio


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126429/#review89995
---


On Dec. 23, 2015, 2:49 p.m., Artur Puzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126429/
> ---
> 
> (Updated Dec. 23, 2015, 2:49 p.m.)
> 
> 
> Review request for KDE Frameworks, Aleix Pol Gonzalez and Sergio Martins.
> 
> 
> Repository: karchive
> 
> 
> Description
> ---
> 
> Fixed warning: Folder has dtor but not copy-ctor, copy-assignment 
> [-Wclazy-rule-of-three], by adding Q_DISABLE_COPY(Folder)
> Fixed warning: Reserve candidate [-Wclazy-reserve-candidates], by 
> precalculateing QVector size.
> Fixed warning: unused variable [-Wunused-const-variable], by commenting 
> unused variables
> 
> 
> Diffs
> -
> 
>   src/k7zip.cpp 7b5e6a3 
> 
> Diff: https://git.reviewboard.kde.org/r/126429/diff/
> 
> 
> Testing
> ---
> 
> Automated tests pass.
> 
> 
> Thanks,
> 
> Artur Puzio
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126429: Fixed all Clazy warnings level 1 and level 2

[Artur Puzio]

> On Gru 23, 2015, 3:49 po południu, Aleix Pol Gonzalez wrote:
> > src/k7zip.cpp, line 2029
> > 
> >
> > I wouldn't get this all in. Is that suggested by 
> > `-Wclazy-reserve-candidates`?
> 
> Artur Puzio wrote:
> Yes this is suggested by `-Wclazy-reserve-candidates`.
> 
> Sergio Martins wrote:
> I think this one is not worth it, as it makes the code more complex.
> Also note that QVector already has a growth strategy, so it's not 
> terrible.

It for sure makes the code run faster and be more memory efficient, but if you 
want I can remove this.


- Artur


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126429/#review89995
---


On Gru 23, 2015, 3:49 po południu, Artur Puzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126429/
> ---
> 
> (Updated Gru 23, 2015, 3:49 po południu)
> 
> 
> Review request for KDE Frameworks, Aleix Pol Gonzalez and Sergio Martins.
> 
> 
> Repository: karchive
> 
> 
> Description
> ---
> 
> Fixed warning: Folder has dtor but not copy-ctor, copy-assignment 
> [-Wclazy-rule-of-three], by adding Q_DISABLE_COPY(Folder)
> Fixed warning: Reserve candidate [-Wclazy-reserve-candidates], by 
> precalculateing QVector size.
> Fixed warning: unused variable [-Wunused-const-variable], by commenting 
> unused variables
> 
> 
> Diffs
> -
> 
>   src/k7zip.cpp 7b5e6a3 
> 
> Diff: https://git.reviewboard.kde.org/r/126429/diff/
> 
> 
> Testing
> ---
> 
> Automated tests pass.
> 
> 
> Thanks,
> 
> Artur Puzio
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126429: Fixed all Clazy warnings level 1 and level 2

[Aleix Pol Gonzalez]

> On Dec. 23, 2015, 3:49 p.m., Aleix Pol Gonzalez wrote:
> > src/k7zip.cpp, line 2029
> > 
> >
> > I wouldn't get this all in. Is that suggested by 
> > `-Wclazy-reserve-candidates`?
> 
> Artur Puzio wrote:
> Yes this is suggested by `-Wclazy-reserve-candidates`.
> 
> Sergio Martins wrote:
> I think this one is not worth it, as it makes the code more complex.
> Also note that QVector already has a growth strategy, so it's not 
> terrible.
> 
> Artur Puzio wrote:
> It for sure makes the code run faster and be more memory efficient, but 
> if you want I can remove this.

Yes, please. Remove it.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126429/#review89995
---


On Dec. 23, 2015, 3:49 p.m., Artur Puzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126429/
> ---
> 
> (Updated Dec. 23, 2015, 3:49 p.m.)
> 
> 
> Review request for KDE Frameworks, Aleix Pol Gonzalez and Sergio Martins.
> 
> 
> Repository: karchive
> 
> 
> Description
> ---
> 
> Fixed warning: Folder has dtor but not copy-ctor, copy-assignment 
> [-Wclazy-rule-of-three], by adding Q_DISABLE_COPY(Folder)
> Fixed warning: Reserve candidate [-Wclazy-reserve-candidates], by 
> precalculateing QVector size.
> Fixed warning: unused variable [-Wunused-const-variable], by commenting 
> unused variables
> 
> 
> Diffs
> -
> 
>   src/k7zip.cpp 7b5e6a3 
> 
> Diff: https://git.reviewboard.kde.org/r/126429/diff/
> 
> 
> Testing
> ---
> 
> Automated tests pass.
> 
> 
> Thanks,
> 
> Artur Puzio
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126429: Fixed all Clazy warnings level 1 and level 2

[Artur Puzio]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126429/
---

(Updated Gru 23, 2015, 8:50 po południu)


Review request for KDE Frameworks, Aleix Pol Gonzalez and Sergio Martins.


Changes
---

Removed -Wclazy-reserve-candidates fix


Repository: karchive


Description (updated)
---

Fixed warning: Folder has dtor but not copy-ctor, copy-assignment 
[-Wclazy-rule-of-three], by adding Q_DISABLE_COPY(Folder)
Fixed warning: unused variable [-Wunused-const-variable], by commenting unused 
variables


Diffs (updated)
-

  src/k7zip.cpp 7b5e6a3 

Diff: https://git.reviewboard.kde.org/r/126429/diff/


Testing
---

Automated tests pass.


Thanks,

Artur Puzio

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126429: Fixed all Clazy warnings level 1 and level 2

[Artur Puzio]

> On Gru 23, 2015, 3:49 po południu, Aleix Pol Gonzalez wrote:
> > src/k7zip.cpp, line 2029
> > 
> >
> > I wouldn't get this all in. Is that suggested by 
> > `-Wclazy-reserve-candidates`?
> 
> Artur Puzio wrote:
> Yes this is suggested by `-Wclazy-reserve-candidates`.
> 
> Sergio Martins wrote:
> I think this one is not worth it, as it makes the code more complex.
> Also note that QVector already has a growth strategy, so it's not 
> terrible.
> 
> Artur Puzio wrote:
> It for sure makes the code run faster and be more memory efficient, but 
> if you want I can remove this.
> 
> Aleix Pol Gonzalez wrote:
> Yes, please. Remove it.

Removed


- Artur


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126429/#review89995
---


On Gru 23, 2015, 8:50 po południu, Artur Puzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126429/
> ---
> 
> (Updated Gru 23, 2015, 8:50 po południu)
> 
> 
> Review request for KDE Frameworks, Aleix Pol Gonzalez and Sergio Martins.
> 
> 
> Repository: karchive
> 
> 
> Description
> ---
> 
> Fixed warning: Folder has dtor but not copy-ctor, copy-assignment 
> [-Wclazy-rule-of-three], by adding Q_DISABLE_COPY(Folder)
> Fixed warning: unused variable [-Wunused-const-variable], by commenting 
> unused variables
> 
> 
> Diffs
> -
> 
>   src/k7zip.cpp 7b5e6a3 
> 
> Diff: https://git.reviewboard.kde.org/r/126429/diff/
> 
> 
> Testing
> ---
> 
> Automated tests pass.
> 
> 
> Thanks,
> 
> Artur Puzio
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126429: Fixed all Clazy warnings level 1 and level 2

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126429/#review90401
---

Ship it!


Ship It!

- David Faure


On Dec. 23, 2015, 7:50 p.m., Artur Puzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126429/
> ---
> 
> (Updated Dec. 23, 2015, 7:50 p.m.)
> 
> 
> Review request for KDE Frameworks, Aleix Pol Gonzalez and Sergio Martins.
> 
> 
> Repository: karchive
> 
> 
> Description
> ---
> 
> Fixed warning: Folder has dtor but not copy-ctor, copy-assignment 
> [-Wclazy-rule-of-three], by adding Q_DISABLE_COPY(Folder)
> Fixed warning: unused variable [-Wunused-const-variable], by commenting 
> unused variables
> 
> 
> Diffs
> -
> 
>   src/k7zip.cpp 7b5e6a3 
> 
> Diff: https://git.reviewboard.kde.org/r/126429/diff/
> 
> 
> Testing
> ---
> 
> Automated tests pass.
> 
> 
> Thanks,
> 
> Artur Puzio
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126429: Fixed all Clazy warnings level 1 and level 2

[Artur Puzio]

> On Sty 1, 2016, 6:05 po południu, David Faure wrote:
> > Ship It!

Hey, this RR stil waits for commiting.


- Artur


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126429/#review90401
---


On Gru 23, 2015, 8:50 po południu, Artur Puzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126429/
> ---
> 
> (Updated Gru 23, 2015, 8:50 po południu)
> 
> 
> Review request for KDE Frameworks, Aleix Pol Gonzalez and Sergio Martins.
> 
> 
> Repository: karchive
> 
> 
> Description
> ---
> 
> Fixed warning: Folder has dtor but not copy-ctor, copy-assignment 
> [-Wclazy-rule-of-three], by adding Q_DISABLE_COPY(Folder)
> Fixed warning: unused variable [-Wunused-const-variable], by commenting 
> unused variables
> 
> 
> Diffs
> -
> 
>   src/k7zip.cpp 7b5e6a3 
> 
> Diff: https://git.reviewboard.kde.org/r/126429/diff/
> 
> 
> Testing
> ---
> 
> Automated tests pass.
> 
> 
> Thanks,
> 
> Artur Puzio
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126429: Fixed all Clazy warnings level 1 and level 2

[Artur Puzio]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126429/
---

(Updated Jan. 9, 2016, 10:51 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Aleix Pol Gonzalez and Sergio Martins.


Changes
---

Submitted with commit 8d8a20f3d066e886dfbd63c739cf0dd5a50d58a5 by Lamarque V. 
Souza on behalf of Artur Puzio to branch master.


Repository: karchive


Description
---

Fixed warning: Folder has dtor but not copy-ctor, copy-assignment 
[-Wclazy-rule-of-three], by adding Q_DISABLE_COPY(Folder)
Fixed warning: unused variable [-Wunused-const-variable], by commenting unused 
variables


Diffs
-

  src/k7zip.cpp 7b5e6a3 

Diff: https://git.reviewboard.kde.org/r/126429/diff/


Testing
---

Automated tests pass.


Thanks,

Artur Puzio

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel