Re: Review Request 126587: Add option to build with gcov support
> On Jan. 2, 2016, 3:57 a.m., Aleix Pol Gonzalez wrote: > > Well, then it's implemented by `ECMCoverageOption.cmake` in ECM, and > > included by `KDECompilerSettings.cmake`. If anything, the proper fix would > > be to remove this kind of code from elsewhere. Indeed. - Dāvis --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126587/#review90426 --- On Dec. 31, 2015, 11:13 p.m., Dāvis Mosāns wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126587/ > --- > > (Updated Dec. 31, 2015, 11:13 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kjsembed > > > Description > --- > > Add option to build with gcov support > > > Diffs > - > > CMakeLists.txt 916970287c070c07a60f8dbcd5f0758ac602038e > > Diff: https://git.reviewboard.kde.org/r/126587/diff/ > > > Testing > --- > > Compiles > > > Thanks, > > Dāvis Mosāns > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 126587: Add option to build with gcov support
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126587/ --- (Updated Jan. 4, 2016, 10:21 p.m.) Status -- This change has been discarded. Review request for KDE Frameworks. Repository: kjsembed Description --- Add option to build with gcov support Diffs - CMakeLists.txt 916970287c070c07a60f8dbcd5f0758ac602038e Diff: https://git.reviewboard.kde.org/r/126587/diff/ Testing --- Compiles Thanks, Dāvis Mosāns ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 126587: Add option to build with gcov support
> On Jan. 2, 2016, 12:56 a.m., Aleix Pol Gonzalez wrote: > > That's provided by ecm, isn't it? > > Dāvis Mosāns wrote: > I don't know... I based this on KWin > https://quickgit.kde.org/?p=kwin.git=blob=master=CMakeLists.txt#l249 the check in KWin predates the one in ecm and as Aleix says: it should be removed from KWin. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126587/#review90423 --- On Dec. 31, 2015, 10:13 p.m., Dāvis Mosāns wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126587/ > --- > > (Updated Dec. 31, 2015, 10:13 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kjsembed > > > Description > --- > > Add option to build with gcov support > > > Diffs > - > > CMakeLists.txt 916970287c070c07a60f8dbcd5f0758ac602038e > > Diff: https://git.reviewboard.kde.org/r/126587/diff/ > > > Testing > --- > > Compiles > > > Thanks, > > Dāvis Mosāns > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 126587: Add option to build with gcov support
> On Jan. 2, 2016, 1:56 a.m., Aleix Pol Gonzalez wrote: > > That's provided by ecm, isn't it? I don't know... I based this on KWin https://quickgit.kde.org/?p=kwin.git=blob=master=CMakeLists.txt#l249 - Dāvis --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126587/#review90423 --- On Dec. 31, 2015, 11:13 p.m., Dāvis Mosāns wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126587/ > --- > > (Updated Dec. 31, 2015, 11:13 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kjsembed > > > Description > --- > > Add option to build with gcov support > > > Diffs > - > > CMakeLists.txt 916970287c070c07a60f8dbcd5f0758ac602038e > > Diff: https://git.reviewboard.kde.org/r/126587/diff/ > > > Testing > --- > > Compiles > > > Thanks, > > Dāvis Mosāns > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 126587: Add option to build with gcov support
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126587/#review90426 --- Well, then it's implemented by `ECMCoverageOption.cmake` in ECM, and included by `KDECompilerSettings.cmake`. If anything, the proper fix would be to remove this kind of code from elsewhere. - Aleix Pol Gonzalez On Dec. 31, 2015, 10:13 p.m., Dāvis Mosāns wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126587/ > --- > > (Updated Dec. 31, 2015, 10:13 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kjsembed > > > Description > --- > > Add option to build with gcov support > > > Diffs > - > > CMakeLists.txt 916970287c070c07a60f8dbcd5f0758ac602038e > > Diff: https://git.reviewboard.kde.org/r/126587/diff/ > > > Testing > --- > > Compiles > > > Thanks, > > Dāvis Mosāns > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 126587: Add option to build with gcov support
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126587/#review90423 --- That's provided by ecm, isn't it? - Aleix Pol Gonzalez On Dec. 31, 2015, 10:13 p.m., Dāvis Mosāns wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126587/ > --- > > (Updated Dec. 31, 2015, 10:13 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kjsembed > > > Description > --- > > Add option to build with gcov support > > > Diffs > - > > CMakeLists.txt 916970287c070c07a60f8dbcd5f0758ac602038e > > Diff: https://git.reviewboard.kde.org/r/126587/diff/ > > > Testing > --- > > Compiles > > > Thanks, > > Dāvis Mosāns > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 126587: Add option to build with gcov support
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126587/ --- Review request for KDE Frameworks. Repository: kjsembed Description --- Add option to build with gcov support Diffs - CMakeLists.txt 916970287c070c07a60f8dbcd5f0758ac602038e Diff: https://git.reviewboard.kde.org/r/126587/diff/ Testing --- Compiles Thanks, Dāvis Mosāns ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
