Re: Review Request 127093: Drop KDocTools requirement

2016-07-04 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127093/
---

(Updated July 4, 2016, 3:32 p.m.)


Status
--

This change has been discarded.


Review request for KDE Frameworks and Alex Merry.


Repository: kdesignerplugin


Description
---

Like in many other frameworks.


Diffs
-

  CMakeLists.txt bbec850 

Diff: https://git.reviewboard.kde.org/r/127093/diff/


Testing
---

Builds with and without kdoctools.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127093: Drop KDocTools requirement

2016-02-20 Thread David Faure 


> On Feb. 18, 2016, 11:37 p.m., Albert Astals Cid wrote:
> > Why is suddenty documentation less important than the rest? Do you even get 
> > a hint saying you must install kdoctools to get documetnation or it 
> > silently skips it?

Documentation is very important. However there are use cases for compiling 
without documentation if it helps reducing dependencies: e.g. compiling for an 
embedded device. The developers read the docs installed by their desktop 
packages, not the docs installed onto the embedded device.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127093/#review92543
---


On Feb. 18, 2016, 10:34 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127093/
> ---
> 
> (Updated Feb. 18, 2016, 10:34 p.m.)
> 
> 
> Review request for KDE Frameworks and Alex Merry.
> 
> 
> Repository: kdesignerplugin
> 
> 
> Description
> ---
> 
> Like in many other frameworks.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt bbec850 
> 
> Diff: https://git.reviewboard.kde.org/r/127093/diff/
> 
> 
> Testing
> ---
> 
> Builds with and without kdoctools.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127093: Drop KDocTools requirement

2016-02-19 Thread Alex Merry 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127093/#review92570
---




CMakeLists.txt (line 32)


You should set the package properties to say what it is needed for (and 
maybe make it RECOMMENDED?). See KF5Completion below.


- Alex Merry


On Feb. 18, 2016, 10:34 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127093/
> ---
> 
> (Updated Feb. 18, 2016, 10:34 p.m.)
> 
> 
> Review request for KDE Frameworks and Alex Merry.
> 
> 
> Repository: kdesignerplugin
> 
> 
> Description
> ---
> 
> Like in many other frameworks.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt bbec850 
> 
> Diff: https://git.reviewboard.kde.org/r/127093/diff/
> 
> 
> Testing
> ---
> 
> Builds with and without kdoctools.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127093: Drop KDocTools requirement

2016-02-18 Thread Albert Astals Cid 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127093/#review92543
---



Why is suddenty documentation less important than the rest? Do you even get a 
hint saying you must install kdoctools to get documetnation or it silently 
skips it?

- Albert Astals Cid


On Feb. 18, 2016, 10:34 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127093/
> ---
> 
> (Updated Feb. 18, 2016, 10:34 p.m.)
> 
> 
> Review request for KDE Frameworks and Alex Merry.
> 
> 
> Repository: kdesignerplugin
> 
> 
> Description
> ---
> 
> Like in many other frameworks.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt bbec850 
> 
> Diff: https://git.reviewboard.kde.org/r/127093/diff/
> 
> 
> Testing
> ---
> 
> Builds with and without kdoctools.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127093: Drop KDocTools requirement

2016-02-18 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127093/
---

Review request for KDE Frameworks and Alex Merry.


Repository: kdesignerplugin


Description
---

Like in many other frameworks.


Diffs
-

  CMakeLists.txt bbec850 

Diff: https://git.reviewboard.kde.org/r/127093/diff/


Testing
---

Builds with and without kdoctools.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel