Re: Review Request 127145: KLinkItemSelectionModel: Don't store model locally

2016-10-20 Thread Stephen Kelly

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127145/
---

(Updated Oct. 20, 2016, 12:28 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kitemmodels


Description
---

The model can be changed after the constructor is run as of Qt 5.5.

At this point, the KLinkItemSelectionModel would still break if that is
attempted, so a unit test comes later.


Diffs
-

  src/klinkitemselectionmodel.cpp 1b676e87128d83586b62f94f9652b25111e766a5 

Diff: https://git.reviewboard.kde.org/r/127145/diff/


Testing
---


Thanks,

Stephen  Kelly



Re: Review Request 127145: KLinkItemSelectionModel: Don't store model locally

2016-02-24 Thread Stephen Kelly


> On Feb. 24, 2016, 12:36 a.m., Aleix Pol Gonzalez wrote:
> > Ship It!
> 
> Aleix Pol Gonzalez wrote:
> Eh.. wait, we still support Qt 5.3, will that be a problem?

Hi Aleix,

Good catch! It's not a problem in this commit, but following commits would not 
compile with Qt 5.3 because of a connect() to a method that doesn't exist yet, 
and because of unit tests calling setModel on the QItemSelectionModel.

I wrapped those things in ifdefs and tested successfully with Qt 5.3. I pushed 
the result to my branch again on github.

Thanks,


- Stephen


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127145/#review92693
---


On Feb. 22, 2016, 4:30 p.m., Stephen  Kelly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127145/
> ---
> 
> (Updated Feb. 22, 2016, 4:30 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kitemmodels
> 
> 
> Description
> ---
> 
> The model can be changed after the constructor is run as of Qt 5.5.
> 
> At this point, the KLinkItemSelectionModel would still break if that is
> attempted, so a unit test comes later.
> 
> 
> Diffs
> -
> 
>   src/klinkitemselectionmodel.cpp 1b676e87128d83586b62f94f9652b25111e766a5 
> 
> Diff: https://git.reviewboard.kde.org/r/127145/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Stephen  Kelly
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 127145: KLinkItemSelectionModel: Don't store model locally

2016-02-23 Thread Aleix Pol Gonzalez


> On Feb. 24, 2016, 1:36 a.m., Aleix Pol Gonzalez wrote:
> > Ship It!

Eh.. wait, we still support Qt 5.3, will that be a problem?


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127145/#review92693
---


On Feb. 22, 2016, 5:30 p.m., Stephen  Kelly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127145/
> ---
> 
> (Updated Feb. 22, 2016, 5:30 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kitemmodels
> 
> 
> Description
> ---
> 
> The model can be changed after the constructor is run as of Qt 5.5.
> 
> At this point, the KLinkItemSelectionModel would still break if that is
> attempted, so a unit test comes later.
> 
> 
> Diffs
> -
> 
>   src/klinkitemselectionmodel.cpp 1b676e87128d83586b62f94f9652b25111e766a5 
> 
> Diff: https://git.reviewboard.kde.org/r/127145/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Stephen  Kelly
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 127145: KLinkItemSelectionModel: Don't store model locally

2016-02-23 Thread Aleix Pol Gonzalez

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127145/#review92693
---


Ship it!




Ship It!

- Aleix Pol Gonzalez


On Feb. 22, 2016, 5:30 p.m., Stephen  Kelly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127145/
> ---
> 
> (Updated Feb. 22, 2016, 5:30 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kitemmodels
> 
> 
> Description
> ---
> 
> The model can be changed after the constructor is run as of Qt 5.5.
> 
> At this point, the KLinkItemSelectionModel would still break if that is
> attempted, so a unit test comes later.
> 
> 
> Diffs
> -
> 
>   src/klinkitemselectionmodel.cpp 1b676e87128d83586b62f94f9652b25111e766a5 
> 
> Diff: https://git.reviewboard.kde.org/r/127145/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Stephen  Kelly
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 127145: KLinkItemSelectionModel: Don't store model locally

2016-02-22 Thread Stephen Kelly

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127145/
---

(Updated Feb. 22, 2016, 4:30 p.m.)


Review request for KDE Frameworks.


Repository: kitemmodels


Description
---

The model can be changed after the constructor is run as of Qt 5.5.

At this point, the KLinkItemSelectionModel would still break if that is
attempted, so a unit test comes later.


Diffs (updated)
-

  src/klinkitemselectionmodel.cpp 1b676e87128d83586b62f94f9652b25111e766a5 

Diff: https://git.reviewboard.kde.org/r/127145/diff/


Testing
---


Thanks,

Stephen  Kelly

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Review Request 127145: KLinkItemSelectionModel: Don't store model locally

2016-02-22 Thread Stephen Kelly

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127145/
---

Review request for KDE Frameworks.


Repository: kitemmodels


Description
---

The model can be changed after the constructor is run as of Qt 5.5.

At this point, the KLinkItemSelectionModel would still break if that is
attempted, so a unit test comes later.


Diffs
-

  src/klinkitemselectionmodel.cpp 1b676e87128d83586b62f94f9652b25111e766a5 

Diff: https://git.reviewboard.kde.org/r/127145/diff/


Testing
---


Thanks,

Stephen  Kelly

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel