Re: Review Request 127148: KLinkItemSelectionModel: Add new default constructor.

2016-10-20 Thread Stephen Kelly 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127148/
---

(Updated Oct. 20, 2016, 12:28 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kitemmodels


Description
---

Make it possible to construct this in QML


Diffs
-

  src/klinkitemselectionmodel.h c871121fa9a791b6030f5ff3a104d8d3bdcbe79d 
  src/klinkitemselectionmodel.cpp 1b676e87128d83586b62f94f9652b25111e766a5 

Diff: https://git.reviewboard.kde.org/r/127148/diff/


Testing
---


Thanks,

Stephen  Kelly

Re: Review Request 127148: KLinkItemSelectionModel: Add new default constructor.

2016-02-23 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127148/#review92696
---


Ship it!




Ship It!

- Aleix Pol Gonzalez


On Feb. 22, 2016, 5:31 p.m., Stephen  Kelly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127148/
> ---
> 
> (Updated Feb. 22, 2016, 5:31 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kitemmodels
> 
> 
> Description
> ---
> 
> Make it possible to construct this in QML
> 
> 
> Diffs
> -
> 
>   src/klinkitemselectionmodel.h c871121fa9a791b6030f5ff3a104d8d3bdcbe79d 
>   src/klinkitemselectionmodel.cpp 1b676e87128d83586b62f94f9652b25111e766a5 
> 
> Diff: https://git.reviewboard.kde.org/r/127148/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Stephen  Kelly
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127148: KLinkItemSelectionModel: Add new default constructor.

2016-02-22 Thread Stephen Kelly 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127148/
---

(Updated Feb. 22, 2016, 4:31 p.m.)


Review request for KDE Frameworks.


Repository: kitemmodels


Description
---

Make it possible to construct this in QML


Diffs (updated)
-

  src/klinkitemselectionmodel.h c871121fa9a791b6030f5ff3a104d8d3bdcbe79d 
  src/klinkitemselectionmodel.cpp 1b676e87128d83586b62f94f9652b25111e766a5 

Diff: https://git.reviewboard.kde.org/r/127148/diff/


Testing
---


Thanks,

Stephen  Kelly

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127148: KLinkItemSelectionModel: Add new default constructor.

2016-02-22 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127148/#review92639
---




src/klinkitemselectionmodel.h (line 108)


explicit? Also, Q_NULLPTR



src/klinkitemselectionmodel.cpp (line 95)


We cannot use nullptr in Frameworks, use Q_NULLPTR


- Kai Uwe Broulik


On Feb. 22, 2016, 3:34 nachm., Stephen  Kelly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127148/
> ---
> 
> (Updated Feb. 22, 2016, 3:34 nachm.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kitemmodels
> 
> 
> Description
> ---
> 
> Make it possible to construct this in QML
> 
> 
> Diffs
> -
> 
>   src/klinkitemselectionmodel.h c871121fa9a791b6030f5ff3a104d8d3bdcbe79d 
>   src/klinkitemselectionmodel.cpp 1b676e87128d83586b62f94f9652b25111e766a5 
> 
> Diff: https://git.reviewboard.kde.org/r/127148/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Stephen  Kelly
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127148: KLinkItemSelectionModel: Add new default constructor.

2016-02-22 Thread Stephen Kelly 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127148/
---

Review request for KDE Frameworks.


Repository: kitemmodels


Description
---

Make it possible to construct this in QML


Diffs
-

  src/klinkitemselectionmodel.h c871121fa9a791b6030f5ff3a104d8d3bdcbe79d 
  src/klinkitemselectionmodel.cpp 1b676e87128d83586b62f94f9652b25111e766a5 

Diff: https://git.reviewboard.kde.org/r/127148/diff/


Testing
---


Thanks,

Stephen  Kelly

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel