Re: Review Request 127164: Add actionType to the declarative plugin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127164/ --- (Updated Feb. 24, 2016, 6:08 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and KDEPIM. Changes --- Submitted with commit 28843fa2d256dd213ee636eaa552bf892586576e by Martin Klapetek to branch master. Repository: kpeople Description --- The KPeople::ActionType is just a namespaced enum, so here's a wrapper that makes it usable from QML Diffs - src/declarative/peopleqmlplugin.cpp 1e0516a Diff: https://git.reviewboard.kde.org/r/127164/diff/ Testing --- Works all good. Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127164: Add actionType to the declarative plugin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127164/#review92704 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 24, 2016, 12:29 a.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127164/ > --- > > (Updated Feb. 24, 2016, 12:29 a.m.) > > > Review request for KDE Frameworks and KDEPIM. > > > Repository: kpeople > > > Description > --- > > The KPeople::ActionType is just a namespaced enum, so here's a wrapper > that makes it usable from QML > > > Diffs > - > > src/declarative/peopleqmlplugin.cpp 1e0516a > > Diff: https://git.reviewboard.kde.org/r/127164/diff/ > > > Testing > --- > > Works all good. > > > Thanks, > > Martin Klapetek > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127164: Add actionType to the declarative plugin
> On Feb. 24, 2016, 1:47 a.m., Aleix Pol Gonzalez wrote: > > What does it look like on the code? > > > > `ActionTypeWrapper.TextChatAction` might be awkward. KPeople.ActionType.TextChatAction - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127164/#review92701 --- On Feb. 24, 2016, 12:29 a.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127164/ > --- > > (Updated Feb. 24, 2016, 12:29 a.m.) > > > Review request for KDE Frameworks and KDEPIM. > > > Repository: kpeople > > > Description > --- > > The KPeople::ActionType is just a namespaced enum, so here's a wrapper > that makes it usable from QML > > > Diffs > - > > src/declarative/peopleqmlplugin.cpp 1e0516a > > Diff: https://git.reviewboard.kde.org/r/127164/diff/ > > > Testing > --- > > Works all good. > > > Thanks, > > Martin Klapetek > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127164: Add actionType to the declarative plugin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127164/#review92701 --- What does it look like on the code? `ActionTypeWrapper.TextChatAction` might be awkward. - Aleix Pol Gonzalez On Feb. 24, 2016, 12:29 a.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127164/ > --- > > (Updated Feb. 24, 2016, 12:29 a.m.) > > > Review request for KDE Frameworks and KDEPIM. > > > Repository: kpeople > > > Description > --- > > The KPeople::ActionType is just a namespaced enum, so here's a wrapper > that makes it usable from QML > > > Diffs > - > > src/declarative/peopleqmlplugin.cpp 1e0516a > > Diff: https://git.reviewboard.kde.org/r/127164/diff/ > > > Testing > --- > > Works all good. > > > Thanks, > > Martin Klapetek > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 127164: Add actionType to the declarative plugin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127164/ --- Review request for KDE Frameworks and KDEPIM. Repository: kpeople Description --- The KPeople::ActionType is just a namespaced enum, so here's a wrapper that makes it usable from QML Diffs - src/declarative/peopleqmlplugin.cpp 1e0516a Diff: https://git.reviewboard.kde.org/r/127164/diff/ Testing --- Works all good. Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
