Review Request 127177: Compilation fixes for MSVC (2013)

2016-02-25 Thread Thomas Friedrichsmeier 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127177/
---

Review request for KDE Frameworks and kdewin.


Repository: ki18n


Description
---

Fix compilation on Windows with MSVC.

a) MSVC accepts declspec at global scope, only.
b) QStringLiteral does not work with concatenated literals in MSVC (see 
http://blog.qt.io/blog/2014/06/13/qt-weekly-13-qstringliteral/). Since the 
occurences seem to be mostly for debugging, going through QString::fromLatin1() 
in these cases should not hurt much.


Diffs
-

  src/kcatalog.cpp 083443d 
  src/ktranscript.cpp 72c3755 

Diff: https://git.reviewboard.kde.org/r/127177/diff/


Testing
---

Now builds with MSVC 2013.

No other compilers and no other platforms tested for this patch.


Thanks,

Thomas Friedrichsmeier

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127177: Compilation fixes for MSVC (2013)

2016-02-26 Thread Kevin Funk 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127177/#review92805
---


Fix it, then Ship it!





src/kcatalog.cpp (line 46)


Remove indentation. Same below.


- Kevin Funk


On Feb. 25, 2016, 5:16 p.m., Thomas Friedrichsmeier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127177/
> ---
> 
> (Updated Feb. 25, 2016, 5:16 p.m.)
> 
> 
> Review request for KDE Frameworks and kdewin.
> 
> 
> Repository: ki18n
> 
> 
> Description
> ---
> 
> Fix compilation on Windows with MSVC.
> 
> a) MSVC accepts declspec at global scope, only.
> b) QStringLiteral does not work with concatenated literals in MSVC (see 
> http://blog.qt.io/blog/2014/06/13/qt-weekly-13-qstringliteral/). Since the 
> occurences seem to be mostly for debugging, going through 
> QString::fromLatin1() in these cases should not hurt much.
> 
> 
> Diffs
> -
> 
>   src/kcatalog.cpp 083443d 
>   src/ktranscript.cpp 72c3755 
> 
> Diff: https://git.reviewboard.kde.org/r/127177/diff/
> 
> 
> Testing
> ---
> 
> Now builds with MSVC 2013.
> 
> No other compilers and no other platforms tested for this patch.
> 
> 
> Thanks,
> 
> Thomas Friedrichsmeier
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127177: Compilation fixes for MSVC (2013)

2016-02-26 Thread Thomas Friedrichsmeier 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127177/
---

(Updated Feb. 26, 2016, 2:14 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and kdewin.


Changes
---

Submitted with commit 1c2aa25fb179fe3350bee166f2d8e69404d0cc7f by Thomas 
Friedrichsmeier to branch master.


Repository: ki18n


Description
---

Fix compilation on Windows with MSVC.

a) MSVC accepts declspec at global scope, only.
b) QStringLiteral does not work with concatenated literals in MSVC (see 
http://blog.qt.io/blog/2014/06/13/qt-weekly-13-qstringliteral/). Since the 
occurences seem to be mostly for debugging, going through QString::fromLatin1() 
in these cases should not hurt much.


Diffs
-

  src/kcatalog.cpp 083443d 
  src/ktranscript.cpp 72c3755 

Diff: https://git.reviewboard.kde.org/r/127177/diff/


Testing
---

Now builds with MSVC 2013.

No other compilers and no other platforms tested for this patch.


Thanks,

Thomas Friedrichsmeier

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel