Re: Review Request 127209: Fix some issues found by Coverity

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127209/
---

(Updated March 22, 2016, 2:50 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit 9ae6d765b37135bbfe3a8b936e5a88b8a435e424 by Aleix Pol to 
branch master.


Repository: kcoreaddons


Description
---

Mostly initializing values and using printf() correctly.


Diffs
-

  src/lib/io/kdirwatch.cpp f2fd3b8 
  src/lib/io/kprocess.cpp 07430f7 
  src/lib/io/kprocess_p.h 70fe91f 
  src/lib/kaboutdata.cpp a220977 
  src/lib/randomness/krandom.cpp bdbdec6 
  src/lib/util/kformatprivate.cpp 3d98007 

Diff: https://git.reviewboard.kde.org/r/127209/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127209: Fix some issues found by Coverity

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127209/
---

(Updated March 3, 2016, 12:16 p.m.)


Review request for KDE Frameworks.


Repository: kcoreaddons


Description
---

Mostly initializing values and using printf() correctly.


Diffs (updated)
-

  src/lib/io/kdirwatch.cpp f2fd3b8 
  src/lib/io/kprocess.cpp 07430f7 
  src/lib/io/kprocess_p.h 70fe91f 
  src/lib/kaboutdata.cpp a220977 
  src/lib/randomness/krandom.cpp bdbdec6 
  src/lib/util/kformatprivate.cpp 3d98007 

Diff: https://git.reviewboard.kde.org/r/127209/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127209: Fix some issues found by Coverity

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127209/#review92968
---




src/lib/io/kdirwatch.cpp (line 181)


mSn needs to be in #if HAVE_SYS_INOTIFY_H



src/lib/io/kprocess_p.h (line 33)


Yes, pass q as parameter, this is how it's usually done.


- David Faure


On Feb. 29, 2016, 1:29 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127209/
> ---
> 
> (Updated Feb. 29, 2016, 1:29 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Mostly initializing values and using printf() correctly.
> 
> 
> Diffs
> -
> 
>   src/lib/io/kdirwatch.cpp f2fd3b8 
>   src/lib/io/kprocess_p.h 70fe91f 
>   src/lib/kaboutdata.cpp a220977 
>   src/lib/randomness/krandom.cpp bdbdec6 
>   src/lib/util/kformatprivate.cpp 3d98007 
> 
> Diff: https://git.reviewboard.kde.org/r/127209/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127209: Fix some issues found by Coverity

[Aleix Pol Gonzalez]

> On Feb. 29, 2016, 4:30 p.m., Kai Uwe Broulik wrote:
> > src/lib/io/kprocess_p.h, line 33
> > 
> >
> > Why not have a constructor that takes the q ptr?
> > 
> > The only code that uses it does:
> > 
> > d_ptr(new KProcessPrivate)
> > d_ptr->q_ptr = this;

Yes... I've been pondering doing this everywhere. In fact we have many of 
those. If there's consensus that we want this, I can do the changes.

Also probably having q_ptr to nullptr for a brief instance doesn't help a lot 
either.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127209/#review92912
---


On Feb. 29, 2016, 2:29 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127209/
> ---
> 
> (Updated Feb. 29, 2016, 2:29 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Mostly initializing values and using printf() correctly.
> 
> 
> Diffs
> -
> 
>   src/lib/io/kdirwatch.cpp f2fd3b8 
>   src/lib/io/kprocess_p.h 70fe91f 
>   src/lib/kaboutdata.cpp a220977 
>   src/lib/randomness/krandom.cpp bdbdec6 
>   src/lib/util/kformatprivate.cpp 3d98007 
> 
> Diff: https://git.reviewboard.kde.org/r/127209/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127209: Fix some issues found by Coverity

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127209/#review92912
---




src/lib/io/kprocess_p.h (line 33)


Why not have a constructor that takes the q ptr?

The only code that uses it does:

d_ptr(new KProcessPrivate)
d_ptr->q_ptr = this;


- Kai Uwe Broulik


On Feb. 29, 2016, 1:29 nachm., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127209/
> ---
> 
> (Updated Feb. 29, 2016, 1:29 nachm.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Mostly initializing values and using printf() correctly.
> 
> 
> Diffs
> -
> 
>   src/lib/io/kdirwatch.cpp f2fd3b8 
>   src/lib/io/kprocess_p.h 70fe91f 
>   src/lib/kaboutdata.cpp a220977 
>   src/lib/randomness/krandom.cpp bdbdec6 
>   src/lib/util/kformatprivate.cpp 3d98007 
> 
> Diff: https://git.reviewboard.kde.org/r/127209/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127209: Fix some issues found by Coverity

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127209/
---

(Updated Feb. 29, 2016, 2:29 p.m.)


Review request for KDE Frameworks.


Repository: kcoreaddons


Description
---

Mostly initializing values and using printf() correctly.


Diffs (updated)
-

  src/lib/io/kdirwatch.cpp f2fd3b8 
  src/lib/io/kprocess_p.h 70fe91f 
  src/lib/kaboutdata.cpp a220977 
  src/lib/randomness/krandom.cpp bdbdec6 
  src/lib/util/kformatprivate.cpp 3d98007 

Diff: https://git.reviewboard.kde.org/r/127209/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127209: Fix some issues found by Coverity

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127209/#review92881
---



You lost the changes to the other files, in the diff. (missing --amend?)

- David Faure


On Feb. 29, 2016, 12:13 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127209/
> ---
> 
> (Updated Feb. 29, 2016, 12:13 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Mostly initializing values and using printf() correctly.
> 
> 
> Diffs
> -
> 
>   src/lib/kaboutdata.cpp a220977 
> 
> Diff: https://git.reviewboard.kde.org/r/127209/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127209: Fix some issues found by Coverity

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127209/
---

(Updated Feb. 29, 2016, 1:13 a.m.)


Review request for KDE Frameworks.


Changes
---

Address issue as pointed out by Lamarque.


Repository: kcoreaddons


Description
---

Mostly initializing values and using printf() correctly.


Diffs (updated)
-

  src/lib/kaboutdata.cpp a220977 

Diff: https://git.reviewboard.kde.org/r/127209/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127209: Fix some issues found by Coverity

[Lamarque Souza]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127209/#review92862
---




src/lib/kaboutdata.cpp (line 993)


I think you must change the second "%s" to "%1" here, otherwise the value 
returned by qAppName() will be added to the string created by 
QCoreApplication::translate().



src/lib/kaboutdata.cpp (line 1006)


Same here.


- Lamarque Souza


On Feb. 28, 2016, 7:46 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127209/
> ---
> 
> (Updated Feb. 28, 2016, 7:46 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Mostly initializing values and using printf() correctly.
> 
> 
> Diffs
> -
> 
>   src/lib/io/kdirwatch.cpp f2fd3b8 
>   src/lib/io/kprocess_p.h 70fe91f 
>   src/lib/kaboutdata.cpp a220977 
>   src/lib/randomness/krandom.cpp bdbdec6 
>   src/lib/util/kformatprivate.cpp 3d98007 
> 
> Diff: https://git.reviewboard.kde.org/r/127209/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127209: Fix some issues found by Coverity

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127209/
---

Review request for KDE Frameworks.


Repository: kcoreaddons


Description
---

Mostly initializing values and using printf() correctly.


Diffs
-

  src/lib/io/kdirwatch.cpp f2fd3b8 
  src/lib/io/kprocess_p.h 70fe91f 
  src/lib/kaboutdata.cpp a220977 
  src/lib/randomness/krandom.cpp bdbdec6 
  src/lib/util/kformatprivate.cpp 3d98007 

Diff: https://git.reviewboard.kde.org/r/127209/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel