Review Request 127418: Set text on QCheckbox widget rather than using a separate label
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127418/ --- Review request for KDE Frameworks. Repository: kio Description --- This fixes (amongst other focus bugs) the label having the right enabled effect if the permissions are not editable. CCBUG: 245580 Diffs - src/widgets/kpropertiesdialog.cpp 59e189fb79e8033d8f8983b19aa914767dac52f6 Diff: https://git.reviewboard.kde.org/r/127418/diff/ Testing --- Opened kpropertiesdialog on a folder and a file Faked being a file system without ACL (by adding && false) into line 2128 so that we see the full grid of options Opened kpropertiesdialog on a folder and a file Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127418: Set text on QCheckbox widget rather than using a separate label
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127418/ --- (Updated March 18, 2016, 2:51 a.m.) Review request for KDE Frameworks. Bugs: 245580 https://bugs.kde.org/show_bug.cgi?id=245580 Repository: kio Description --- This fixes (amongst other focus bugs) the label having the right enabled effect if the permissions are not editable. CCBUG: 245580 Diffs - src/widgets/kpropertiesdialog.cpp 59e189fb79e8033d8f8983b19aa914767dac52f6 Diff: https://git.reviewboard.kde.org/r/127418/diff/ Testing --- Opened kpropertiesdialog on a folder and a file Faked being a file system without ACL (by adding && false) into line 2128 so that we see the full grid of options Opened kpropertiesdialog on a folder and a file Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127418: Set text on QCheckbox widget rather than using a separate label
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127418/#review93685 --- Ship it! Ship It! - Sebastian Kügler On March 18, 2016, 1:51 a.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127418/ > --- > > (Updated March 18, 2016, 1:51 a.m.) > > > Review request for KDE Frameworks. > > > Bugs: 245580 > https://bugs.kde.org/show_bug.cgi?id=245580 > > > Repository: kio > > > Description > --- > > This fixes (amongst other focus bugs) the label having the right > enabled effect if the permissions are not editable. > > CCBUG: 245580 > > > Diffs > - > > src/widgets/kpropertiesdialog.cpp 59e189fb79e8033d8f8983b19aa914767dac52f6 > > Diff: https://git.reviewboard.kde.org/r/127418/diff/ > > > Testing > --- > > Opened kpropertiesdialog on a folder and a file > > Faked being a file system without ACL (by adding && false) into line 2128 so > that we see the full grid of options > > Opened kpropertiesdialog on a folder and a file > > > Thanks, > > David Edmundson > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127418: Set text on QCheckbox widget rather than using a separate label
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127418/ --- (Updated April 7, 2016, 11:44 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 36d80144ab9acf078deb0379e6aff3a912f5d3da by David Edmundson to branch master. Bugs: 245580 https://bugs.kde.org/show_bug.cgi?id=245580 Repository: kio Description --- This fixes (amongst other focus bugs) the label having the right enabled effect if the permissions are not editable. CCBUG: 245580 Diffs - src/widgets/kpropertiesdialog.cpp 59e189fb79e8033d8f8983b19aa914767dac52f6 Diff: https://git.reviewboard.kde.org/r/127418/diff/ Testing --- Opened kpropertiesdialog on a folder and a file Faked being a file system without ACL (by adding && false) into line 2128 so that we see the full grid of options Opened kpropertiesdialog on a folder and a file Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
