Re: Review Request 127754: Use kbuildsycoca5 executable that was just built, not the one from the system
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127754/ --- (Updated apr 27, 2016, 12:47 p.m.) Status -- This change has been discarded. Review request for KDE Frameworks. Repository: kservice Description --- This test was using QStandardPaths::findExecutable to find buildsycoca5. So the test was testing with the wrong buildsycoca5. I've added a function findFile() that looks for buildsycoca5 in the build directory. Diffs - autotests/ksycoca_xdgdirstest.cpp f879959 Diff: https://git.reviewboard.kde.org/r/127754/diff/ Testing --- I ran the unit tests. Some now pass for me, but on my system still some are failing. Thanks, Jos van den Oever ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127754: Use kbuildsycoca5 executable that was just built, not the one from the system
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127754/#review94903 --- Please see this approach: https://git.reviewboard.kde.org/r/127757/ - Aleix Pol Gonzalez On April 27, 2016, 10:33 a.m., Jos van den Oever wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127754/ > --- > > (Updated April 27, 2016, 10:33 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kservice > > > Description > --- > > This test was using QStandardPaths::findExecutable to find buildsycoca5. So > the test was testing with the wrong buildsycoca5. > > I've added a function findFile() that looks for buildsycoca5 in the build > directory. > > > Diffs > - > > autotests/ksycoca_xdgdirstest.cpp f879959 > > Diff: https://git.reviewboard.kde.org/r/127754/diff/ > > > Testing > --- > > I ran the unit tests. Some now pass for me, but on my system still some are > failing. > > > Thanks, > > Jos van den Oever > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 127754: Use kbuildsycoca5 executable that was just built, not the one from the system
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127754/ --- Review request for KDE Frameworks. Repository: kservice Description --- This test was using QStandardPaths::findExecutable to find buildsycoca5. So the test was testing with the wrong buildsycoca5. I've added a function findFile() that looks for buildsycoca5 in the build directory. Diffs - autotests/ksycoca_xdgdirstest.cpp f879959 Diff: https://git.reviewboard.kde.org/r/127754/diff/ Testing --- I ran the unit tests. Some now pass for me, but on my system still some are failing. Thanks, Jos van den Oever ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
