Re: Review Request 127850: Let Plasma::Corona load the layout on all cases.

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127850/
---

(Updated June 7, 2016, 1:23 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Plasma and David Rosca.


Changes
---

Submitted with commit 9575b8c009d5500126cc0edb1a384ab39fd0a641 by Aleix Pol to 
branch master.


Bugs: 60777
http://bugs.kde.org/show_bug.cgi?id=60777


Repository: plasma-framework


Description
---

Iteration of: https://git.reviewboard.kde.org/r/127848/

We either load the existing layout or we load a default one.

With this, it could be removed from ShellCorona.


Diffs
-

  src/plasma/corona.h d8f829a 
  src/plasma/corona.cpp 1784516 

Diff: https://git.reviewboard.kde.org/r/127850/diff/


Testing
---

Tests pass.
PlasmaShell prints completed once both with and without configuration.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127850: Let Plasma::Corona load the layout on all cases.

[Marco Martin]

> On June 5, 2016, 2:59 p.m., Anthony Fieroni wrote:
> > Ping?

the issues have not been adressed


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127850/#review96206
---


On May 11, 2016, 11:20 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127850/
> ---
> 
> (Updated May 11, 2016, 11:20 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and David Rosca.
> 
> 
> Bugs: 60777
> http://bugs.kde.org/show_bug.cgi?id=60777
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Iteration of: https://git.reviewboard.kde.org/r/127848/
> 
> We either load the existing layout or we load a default one.
> 
> With this, it could be removed from ShellCorona.
> 
> 
> Diffs
> -
> 
>   src/plasma/corona.h d8f829a 
>   src/plasma/corona.cpp 1784516 
> 
> Diff: https://git.reviewboard.kde.org/r/127850/diff/
> 
> 
> Testing
> ---
> 
> Tests pass.
> PlasmaShell prints completed once both with and without configuration.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127850: Let Plasma::Corona load the layout on all cases.

[Anthony Fieroni]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127850/#review96206
---



Ping?

- Anthony Fieroni


On Май 12, 2016, 2:20 преди обяд, Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127850/
> ---
> 
> (Updated Май 12, 2016, 2:20 преди обяд)
> 
> 
> Review request for KDE Frameworks, Plasma and David Rosca.
> 
> 
> Bugs: 60777
> http://bugs.kde.org/show_bug.cgi?id=60777
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Iteration of: https://git.reviewboard.kde.org/r/127848/
> 
> We either load the existing layout or we load a default one.
> 
> With this, it could be removed from ShellCorona.
> 
> 
> Diffs
> -
> 
>   src/plasma/corona.h d8f829a 
>   src/plasma/corona.cpp 1784516 
> 
> Diff: https://git.reviewboard.kde.org/r/127850/diff/
> 
> 
> Testing
> ---
> 
> Tests pass.
> PlasmaShell prints completed once both with and without configuration.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127850: Let Plasma::Corona load the layout on all cases.

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127850/#review95419
---


Fix it, then Ship it!




logic is fine, but should not add public symbols for this completely internal 
function


src/plasma/corona.h (line 363)


move in dpointer



src/plasma/corona.h (line 364)


no private functions in exported classes, ever

this should be just a lambda, is used exactly once in a single connect


- Marco Martin


On May 11, 2016, 11:20 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127850/
> ---
> 
> (Updated May 11, 2016, 11:20 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and David Rosca.
> 
> 
> Bugs: 60777
> http://bugs.kde.org/show_bug.cgi?id=60777
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Iteration of: https://git.reviewboard.kde.org/r/127848/
> 
> We either load the existing layout or we load a default one.
> 
> With this, it could be removed from ShellCorona.
> 
> 
> Diffs
> -
> 
>   src/plasma/corona.h d8f829a 
>   src/plasma/corona.cpp 1784516 
> 
> Diff: https://git.reviewboard.kde.org/r/127850/diff/
> 
> 
> Testing
> ---
> 
> Tests pass.
> PlasmaShell prints completed once both with and without configuration.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127850: Let Plasma::Corona load the layout on all cases.

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127850/
---

(Updated May 12, 2016, 1:20 a.m.)


Review request for KDE Frameworks, Plasma and David Rosca.


Changes
---

Looked into the issue again, we shouldn't be notifying the startup completed 
only because the script finished. This re-uses the same code for both cases and 
fixes Plasma 5.5 and 5.6 without touching them.


Bugs: 60777
http://bugs.kde.org/show_bug.cgi?id=60777


Repository: plasma-framework


Description
---

Iteration of: https://git.reviewboard.kde.org/r/127848/

We either load the existing layout or we load a default one.

With this, it could be removed from ShellCorona.


Diffs (updated)
-

  src/plasma/corona.h d8f829a 
  src/plasma/corona.cpp 1784516 

Diff: https://git.reviewboard.kde.org/r/127850/diff/


Testing
---

Tests pass.
PlasmaShell prints completed once both with and without configuration.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127850: Let Plasma::Corona load the layout on all cases.

[David Rosca]

> On May 6, 2016, 4:08 p.m., David Rosca wrote:
> > It will also need 
> > https://quickgit.kde.org/?p=plasma-workspace.git=commit=1b6231f2e3f1de8cb5ea2540f0b8f425f6ae43a3
> >  in Plasma/5.6
> 
> Aleix Pol Gonzalez wrote:
> No, it's already called by `ShellCorona::loadDefaultLayout()`.
> 
> David Rosca wrote:
> Yes, this is inside ShellCorona::loadDefaultLayout(). In Plasma/5.6 the 
> loadDefaultLayout does not emit startupCompleted (because the above commit is 
> only in master) and indeed, this patch does not fix it for me with 
> plasma-workspace 5.6.
> 
> Aleix Pol Gonzalez wrote:
> So should I commit this as is and backport the commit below to 5.6?

+1 from me, but it will still be broken with Plasma 5.5. Do we care about it?


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127850/#review95241
---


On May 6, 2016, 3:56 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127850/
> ---
> 
> (Updated May 6, 2016, 3:56 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and David Rosca.
> 
> 
> Bugs: 60777
> http://bugs.kde.org/show_bug.cgi?id=60777
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Iteration of: https://git.reviewboard.kde.org/r/127848/
> 
> We either load the existing layout or we load a default one.
> 
> With this, it could be removed from ShellCorona.
> 
> 
> Diffs
> -
> 
>   src/plasma/corona.cpp 1784516 
> 
> Diff: https://git.reviewboard.kde.org/r/127850/diff/
> 
> 
> Testing
> ---
> 
> Tests pass.
> PlasmaShell prints completed once both with and without configuration.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127850: Let Plasma::Corona load the layout on all cases.

[Aleix Pol Gonzalez]

> On May 6, 2016, 6:08 p.m., David Rosca wrote:
> > It will also need 
> > https://quickgit.kde.org/?p=plasma-workspace.git=commit=1b6231f2e3f1de8cb5ea2540f0b8f425f6ae43a3
> >  in Plasma/5.6
> 
> Aleix Pol Gonzalez wrote:
> No, it's already called by `ShellCorona::loadDefaultLayout()`.
> 
> David Rosca wrote:
> Yes, this is inside ShellCorona::loadDefaultLayout(). In Plasma/5.6 the 
> loadDefaultLayout does not emit startupCompleted (because the above commit is 
> only in master) and indeed, this patch does not fix it for me with 
> plasma-workspace 5.6.

So should I commit this as is and backport the commit below to 5.6?


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127850/#review95241
---


On May 6, 2016, 5:56 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127850/
> ---
> 
> (Updated May 6, 2016, 5:56 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and David Rosca.
> 
> 
> Bugs: 60777
> http://bugs.kde.org/show_bug.cgi?id=60777
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Iteration of: https://git.reviewboard.kde.org/r/127848/
> 
> We either load the existing layout or we load a default one.
> 
> With this, it could be removed from ShellCorona.
> 
> 
> Diffs
> -
> 
>   src/plasma/corona.cpp 1784516 
> 
> Diff: https://git.reviewboard.kde.org/r/127850/diff/
> 
> 
> Testing
> ---
> 
> Tests pass.
> PlasmaShell prints completed once both with and without configuration.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127850: Let Plasma::Corona load the layout on all cases.

[David Rosca]

> On May 6, 2016, 4:08 p.m., David Rosca wrote:
> > It will also need 
> > https://quickgit.kde.org/?p=plasma-workspace.git=commit=1b6231f2e3f1de8cb5ea2540f0b8f425f6ae43a3
> >  in Plasma/5.6
> 
> Aleix Pol Gonzalez wrote:
> No, it's already called by `ShellCorona::loadDefaultLayout()`.

Yes, this is inside ShellCorona::loadDefaultLayout(). In Plasma/5.6 the 
loadDefaultLayout does not emit startupCompleted (because the above commit is 
only in master) and indeed, this patch does not fix it for me with 
plasma-workspace 5.6.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127850/#review95241
---


On May 6, 2016, 3:56 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127850/
> ---
> 
> (Updated May 6, 2016, 3:56 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and David Rosca.
> 
> 
> Bugs: 60777
> http://bugs.kde.org/show_bug.cgi?id=60777
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Iteration of: https://git.reviewboard.kde.org/r/127848/
> 
> We either load the existing layout or we load a default one.
> 
> With this, it could be removed from ShellCorona.
> 
> 
> Diffs
> -
> 
>   src/plasma/corona.cpp 1784516 
> 
> Diff: https://git.reviewboard.kde.org/r/127850/diff/
> 
> 
> Testing
> ---
> 
> Tests pass.
> PlasmaShell prints completed once both with and without configuration.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127850: Let Plasma::Corona load the layout on all cases.

[Aleix Pol Gonzalez]

> On May 6, 2016, 6:08 p.m., David Rosca wrote:
> > It will also need 
> > https://quickgit.kde.org/?p=plasma-workspace.git=commit=1b6231f2e3f1de8cb5ea2540f0b8f425f6ae43a3
> >  in Plasma/5.6

No, it's already called by `ShellCorona::loadDefaultLayout()`.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127850/#review95241
---


On May 6, 2016, 5:56 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127850/
> ---
> 
> (Updated May 6, 2016, 5:56 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and David Rosca.
> 
> 
> Bugs: 60777
> http://bugs.kde.org/show_bug.cgi?id=60777
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Iteration of: https://git.reviewboard.kde.org/r/127848/
> 
> We either load the existing layout or we load a default one.
> 
> With this, it could be removed from ShellCorona.
> 
> 
> Diffs
> -
> 
>   src/plasma/corona.cpp 1784516 
> 
> Diff: https://git.reviewboard.kde.org/r/127850/diff/
> 
> 
> Testing
> ---
> 
> Tests pass.
> PlasmaShell prints completed once both with and without configuration.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127850: Let Plasma::Corona load the layout on all cases.

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127850/#review95241
---



It will also need 
https://quickgit.kde.org/?p=plasma-workspace.git=commit=1b6231f2e3f1de8cb5ea2540f0b8f425f6ae43a3
 in Plasma/5.6

- David Rosca


On May 6, 2016, 3:56 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127850/
> ---
> 
> (Updated May 6, 2016, 3:56 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and David Rosca.
> 
> 
> Bugs: 60777
> http://bugs.kde.org/show_bug.cgi?id=60777
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Iteration of: https://git.reviewboard.kde.org/r/127848/
> 
> We either load the existing layout or we load a default one.
> 
> With this, it could be removed from ShellCorona.
> 
> 
> Diffs
> -
> 
>   src/plasma/corona.cpp 1784516 
> 
> Diff: https://git.reviewboard.kde.org/r/127850/diff/
> 
> 
> Testing
> ---
> 
> Tests pass.
> PlasmaShell prints completed once both with and without configuration.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127850: Let Plasma::Corona load the layout on all cases.

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127850/#review95240
---




src/plasma/corona.cpp (line 181)


Braces pls


- Kai Uwe Broulik


On Mai 6, 2016, 3:56 nachm., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127850/
> ---
> 
> (Updated Mai 6, 2016, 3:56 nachm.)
> 
> 
> Review request for KDE Frameworks, Plasma and David Rosca.
> 
> 
> Bugs: 60777
> http://bugs.kde.org/show_bug.cgi?id=60777
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Iteration of: https://git.reviewboard.kde.org/r/127848/
> 
> We either load the existing layout or we load a default one.
> 
> With this, it could be removed from ShellCorona.
> 
> 
> Diffs
> -
> 
>   src/plasma/corona.cpp 1784516 
> 
> Diff: https://git.reviewboard.kde.org/r/127850/diff/
> 
> 
> Testing
> ---
> 
> Tests pass.
> PlasmaShell prints completed once both with and without configuration.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127850: Let Plasma::Corona load the layout on all cases.

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127850/#review95239
---




src/plasma/corona.cpp (line 181)


braces also with one line


- David Rosca


On May 6, 2016, 3:56 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127850/
> ---
> 
> (Updated May 6, 2016, 3:56 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and David Rosca.
> 
> 
> Bugs: 60777
> http://bugs.kde.org/show_bug.cgi?id=60777
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Iteration of: https://git.reviewboard.kde.org/r/127848/
> 
> We either load the existing layout or we load a default one.
> 
> With this, it could be removed from ShellCorona.
> 
> 
> Diffs
> -
> 
>   src/plasma/corona.cpp 1784516 
> 
> Diff: https://git.reviewboard.kde.org/r/127850/diff/
> 
> 
> Testing
> ---
> 
> Tests pass.
> PlasmaShell prints completed once both with and without configuration.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127850: Let Plasma::Corona load the layout on all cases.

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127850/
---

Review request for KDE Frameworks, Plasma and David Rosca.


Bugs: 60777
http://bugs.kde.org/show_bug.cgi?id=60777


Repository: plasma-framework


Description
---

Iteration of: https://git.reviewboard.kde.org/r/127848/

We either load the existing layout or we load a default one.

With this, it could be removed from ShellCorona.


Diffs
-

  src/plasma/corona.cpp 1784516 

Diff: https://git.reviewboard.kde.org/r/127850/diff/


Testing
---

Tests pass.
PlasmaShell prints completed once both with and without configuration.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel