Re: Review Request 127888: use selected icon effect for current KPageView page

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127888/
---

(Updated May 13, 2016, 11:48 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit cac7427d8a09973560a097cf4ba1307c66a50345 by Marco Martin 
to branch master.


Repository: kwidgetsaddons


Description
---

in case icons of KPageView are monochromatic, recolor them of the 
highlightedtext color as the other patches on the breeze style and kio


Diffs
-

  src/kpageview_p.cpp 650a7b3 

Diff: https://git.reviewboard.kde.org/r/127888/diff/


Testing
---


File Attachments


dadel3.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/05/10/72741885-021d-448f-892e-1590b95ef8c0__dadel3.png


Thanks,

Marco Martin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127888: use selected icon effect for current KPageView page

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127888/#review95381
---


Ship it!




- David Edmundson


On May 10, 2016, 3:12 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127888/
> ---
> 
> (Updated May 10, 2016, 3:12 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> in case icons of KPageView are monochromatic, recolor them of the 
> highlightedtext color as the other patches on the breeze style and kio
> 
> 
> Diffs
> -
> 
>   src/kpageview_p.cpp 650a7b3 
> 
> Diff: https://git.reviewboard.kde.org/r/127888/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> dadel3.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/05/10/72741885-021d-448f-892e-1590b95ef8c0__dadel3.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127888: use selected icon effect for current KPageView page

[Marco Martin]

> On May 10, 2016, 3:17 p.m., Emmanuel Pescosta wrote:
> > src/kpageview_p.cpp, line 402
> > 
> >
> > option.state & (QStyle::State_Selected | QStyle::State_Active) maybe?

doesn't work, if state is QStyle::State_Active, (QStyle::State_Active & 
(QStyle::State_Selected | QStyle::State_Active)) is QStyle::State_Active, not 
QStyle::State_None


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127888/#review95354
---


On May 10, 2016, 3:12 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127888/
> ---
> 
> (Updated May 10, 2016, 3:12 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> in case icons of KPageView are monochromatic, recolor them of the 
> highlightedtext color as the other patches on the breeze style and kio
> 
> 
> Diffs
> -
> 
>   src/kpageview_p.cpp 650a7b3 
> 
> Diff: https://git.reviewboard.kde.org/r/127888/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> dadel3.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/05/10/72741885-021d-448f-892e-1590b95ef8c0__dadel3.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel