Re: Review Request 128904: Avoid creating a KPluginInfo from a KPluginMetaData instance

2016-09-14 Thread David Edmundson

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128904/
---

(Updated Sept. 14, 2016, 2:40 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit 820baec72e22055e9c91de231d7457527776fe4a by David 
Edmundson to branch master.


Repository: plasma-framework


Description
---

It's not needed, gives a (very) tiny performance boost and is a bit cleaner.


Diffs
-

  src/plasma/pluginloader.cpp b8f82dc53dd63eabcd99ef259bc4936df47d6d73 

Diff: https://git.reviewboard.kde.org/r/128904/diff/


Testing
---


Thanks,

David Edmundson



Re: Review Request 128904: Avoid creating a KPluginInfo from a KPluginMetaData instance

2016-09-14 Thread Marco Martin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128904/#review99163
---


Ship it!




Ship It!

- Marco Martin


On Sept. 14, 2016, 1:02 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128904/
> ---
> 
> (Updated Sept. 14, 2016, 1:02 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> It's not needed, gives a (very) tiny performance boost and is a bit cleaner.
> 
> 
> Diffs
> -
> 
>   src/plasma/pluginloader.cpp b8f82dc53dd63eabcd99ef259bc4936df47d6d73 
> 
> Diff: https://git.reviewboard.kde.org/r/128904/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>



Re: Review Request 128904: Avoid creating a KPluginInfo from a KPluginMetaData instance

2016-09-13 Thread Sune Vuorela

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128904/#review99158
---


Ship it!




Ship It!

- Sune Vuorela


On Sept. 14, 2016, 1:02 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128904/
> ---
> 
> (Updated Sept. 14, 2016, 1:02 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> It's not needed, gives a (very) tiny performance boost and is a bit cleaner.
> 
> 
> Diffs
> -
> 
>   src/plasma/pluginloader.cpp b8f82dc53dd63eabcd99ef259bc4936df47d6d73 
> 
> Diff: https://git.reviewboard.kde.org/r/128904/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>



Review Request 128904: Avoid creating a KPluginInfo from a KPluginMetaData instance

2016-09-13 Thread David Edmundson

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128904/
---

Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

It's not needed, gives a (very) tiny performance boost and is a bit cleaner.


Diffs
-

  src/plasma/pluginloader.cpp b8f82dc53dd63eabcd99ef259bc4936df47d6d73 

Diff: https://git.reviewboard.kde.org/r/128904/diff/


Testing
---


Thanks,

David Edmundson