Re: Review Request 129133: Silent warning of unused variable in lamda function

2016-11-09 Thread Nilesh Kokane 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129133/
---

(Updated Nov. 9, 2016, 10:35 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Valentin Rusu.


Changes
---

Submitted with commit da8cb1c530ad07028d886cc07a4310d89c79dfbd by Albert Astals 
Cid on behalf of Nilesh Kokane to branch master.


Repository: kwallet


Description
---

^^


Diffs
-

  src/runtime/kwalletd/migrationwizard.cpp cdd2a92 

Diff: https://git.reviewboard.kde.org/r/129133/diff/


Testing
---

Done


Thanks,

Nilesh Kokane

Re: Review Request 129133: Silent warning of unused variable in lamda function

2016-11-09 Thread David Faure 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129133/#review100750
---


Ship it!




Remember to update the commit message ;-)

- David Faure


On Nov. 9, 2016, 2 p.m., Nilesh Kokane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129133/
> ---
> 
> (Updated Nov. 9, 2016, 2 p.m.)
> 
> 
> Review request for KDE Frameworks and Valentin Rusu.
> 
> 
> Repository: kwallet
> 
> 
> Description
> ---
> 
> ^^
> 
> 
> Diffs
> -
> 
>   src/runtime/kwalletd/migrationwizard.cpp cdd2a92 
> 
> Diff: https://git.reviewboard.kde.org/r/129133/diff/
> 
> 
> Testing
> ---
> 
> Done
> 
> 
> Thanks,
> 
> Nilesh Kokane
> 
>

Re: Review Request 129133: Silent warning of unused variable in lamda function

2016-11-09 Thread Nilesh Kokane 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129133/
---

(Updated Nov. 9, 2016, 2 p.m.)


Review request for KDE Frameworks and Valentin Rusu.


Repository: kwallet


Description
---

^^


Diffs (updated)
-

  src/runtime/kwalletd/migrationwizard.cpp cdd2a92 

Diff: https://git.reviewboard.kde.org/r/129133/diff/


Testing
---

Done


Thanks,

Nilesh Kokane

Re: Review Request 129133: Silent warning of unused variable in lamda function

2016-11-06 Thread David Faure 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129133/#review100628
---




src/runtime/kwalletd/migrationwizard.cpp (line 37)


OK, but isn't this a case where a lambda is just overkill? Just forward the 
signal:

connect(_ui._optionNo, ::toggled, this, 
::completeChanged);


- David Faure


On Oct. 9, 2016, 4:04 p.m., Nilesh Kokane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129133/
> ---
> 
> (Updated Oct. 9, 2016, 4:04 p.m.)
> 
> 
> Review request for KDE Frameworks and Valentin Rusu.
> 
> 
> Repository: kwallet
> 
> 
> Description
> ---
> 
> ^^
> 
> 
> Diffs
> -
> 
>   src/runtime/kwalletd/migrationwizard.cpp cdd2a92 
> 
> Diff: https://git.reviewboard.kde.org/r/129133/diff/
> 
> 
> Testing
> ---
> 
> Done
> 
> 
> Thanks,
> 
> Nilesh Kokane
> 
>

Re: Review Request 129133: Silent warning of unused variable in lamda function

2016-10-09 Thread Nilesh Kokane 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129133/
---

(Updated Oct. 9, 2016, 4:04 p.m.)


Review request for KDE Frameworks and Valentin Rusu.


Repository: kwallet


Description
---

^^


Diffs (updated)
-

  src/runtime/kwalletd/migrationwizard.cpp cdd2a92 

Diff: https://git.reviewboard.kde.org/r/129133/diff/


Testing
---

Done


Thanks,

Nilesh Kokane

Re: Review Request 129133: Silent warning of unused variable in lamda function

2016-10-09 Thread Albert Astals Cid 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129133/#review99879
---



Can't you just remove the argument from the lambda?

- Albert Astals Cid


On Oct. 9, 2016, 12:01 p.m., Nilesh Kokane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129133/
> ---
> 
> (Updated Oct. 9, 2016, 12:01 p.m.)
> 
> 
> Review request for KDE Frameworks and Valentin Rusu.
> 
> 
> Repository: kwallet
> 
> 
> Description
> ---
> 
> ^^
> 
> 
> Diffs
> -
> 
>   src/runtime/kwalletd/migrationwizard.cpp cdd2a92 
> 
> Diff: https://git.reviewboard.kde.org/r/129133/diff/
> 
> 
> Testing
> ---
> 
> Done
> 
> 
> Thanks,
> 
> Nilesh Kokane
> 
>

Review Request 129133: Silent warning of unused variable in lamda function

2016-10-09 Thread Nilesh Kokane 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129133/
---

Review request for KDE Frameworks and Valentin Rusu.


Repository: kwallet


Description
---

^^


Diffs
-

  src/runtime/kwalletd/migrationwizard.cpp cdd2a92 

Diff: https://git.reviewboard.kde.org/r/129133/diff/


Testing
---

Done


Thanks,

Nilesh Kokane