Re: Review Request 129253: Support non integer scale factors in kiconengine
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129253/ --- (Updated Oct. 25, 2016, 8:55 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Christoph Feck. Changes --- Submitted with commit c203e366c400bab750e0b0f3d640f7fa85c35065 by David Edmundson to branch master. Repository: kiconthemes Description --- Support non integer scale factors in kiconengine Diffs - src/kiconengine.cpp c31829e82237a7432e3b7c6b1cf85cc3b2bc3ebe Diff: https://git.reviewboard.kde.org/r/129253/diff/ Testing --- Ran system settings with QT_SCALE_FACTOR=2.3 didn't look blurry on mouseover Thanks, David Edmundson
Re: Review Request 129253: Support non integer scale factors in kiconengine
> On Oct. 24, 2016, 4:49 p.m., Jarosław Staniek wrote: > > > didn't look blurry on mouseover > > > > Did you test particular theme or can we assume lines are sharp regardless > > of theme? > > > > (for the record, when I removed 24x24 icons I got blurry icons for default > > Windows style on Windows as 24px is a standard for toolbars) > > Christoph Feck wrote: > Native Windows applications do not scale the icon size if you increase > the global scaling in the Control Panel? We know this fix will always give as sharp or sharper images than it does currently, regardless of theme. Your issue is something unrelated. Qt originally had DPRs being floats everywhere except QPaintEngine::devicePixelRatio which was some sort of oversight; but not one that mattered because the backends enforced integer scaling anyway. At 5.6 they changed that in the backend, but for API reasons had to introduce a new method QPaintDevice::devicePixelRatioF. Without this fix, the client code can end up trying to paint an icon of DPR 2 into a pixmap of DPR 2.3 and that will involve some an extra scaling operation that shouldn't exist. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129253/#review100239 --- On Oct. 24, 2016, 3:06 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129253/ > --- > > (Updated Oct. 24, 2016, 3:06 p.m.) > > > Review request for KDE Frameworks and Christoph Feck. > > > Repository: kiconthemes > > > Description > --- > > Support non integer scale factors in kiconengine > > > Diffs > - > > src/kiconengine.cpp c31829e82237a7432e3b7c6b1cf85cc3b2bc3ebe > > Diff: https://git.reviewboard.kde.org/r/129253/diff/ > > > Testing > --- > > Ran system settings with QT_SCALE_FACTOR=2.3 > didn't look blurry on mouseover > > > Thanks, > > David Edmundson > >
Re: Review Request 129253: Support non integer scale factors in kiconengine
> On Oct. 24, 2016, 6:49 p.m., Jarosław Staniek wrote: > > > didn't look blurry on mouseover > > > > Did you test particular theme or can we assume lines are sharp regardless > > of theme? > > > > (for the record, when I removed 24x24 icons I got blurry icons for default > > Windows style on Windows as 24px is a standard for toolbars) Native Windows applications do not scale the icon size if you increase the global scaling in the Control Panel? - Christoph --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129253/#review100239 --- On Oct. 24, 2016, 5:06 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129253/ > --- > > (Updated Oct. 24, 2016, 5:06 p.m.) > > > Review request for KDE Frameworks and Christoph Feck. > > > Repository: kiconthemes > > > Description > --- > > Support non integer scale factors in kiconengine > > > Diffs > - > > src/kiconengine.cpp c31829e82237a7432e3b7c6b1cf85cc3b2bc3ebe > > Diff: https://git.reviewboard.kde.org/r/129253/diff/ > > > Testing > --- > > Ran system settings with QT_SCALE_FACTOR=2.3 > didn't look blurry on mouseover > > > Thanks, > > David Edmundson > >
Re: Review Request 129253: Support non integer scale factors in kiconengine
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129253/#review100240 --- Ship it! - Christoph Feck On Oct. 24, 2016, 5:06 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129253/ > --- > > (Updated Oct. 24, 2016, 5:06 p.m.) > > > Review request for KDE Frameworks and Christoph Feck. > > > Repository: kiconthemes > > > Description > --- > > Support non integer scale factors in kiconengine > > > Diffs > - > > src/kiconengine.cpp c31829e82237a7432e3b7c6b1cf85cc3b2bc3ebe > > Diff: https://git.reviewboard.kde.org/r/129253/diff/ > > > Testing > --- > > Ran system settings with QT_SCALE_FACTOR=2.3 > didn't look blurry on mouseover > > > Thanks, > > David Edmundson > >
Re: Review Request 129253: Support non integer scale factors in kiconengine
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129253/#review100239 --- > didn't look blurry on mouseover Did you test particular theme or can we assume lines are sharp regardless of theme? (for the record, when I removed 24x24 icons I got blurry icons for default Windows style on Windows as 24px is a standard for toolbars) - Jarosław Staniek On Oct. 24, 2016, 5:06 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129253/ > --- > > (Updated Oct. 24, 2016, 5:06 p.m.) > > > Review request for KDE Frameworks and Christoph Feck. > > > Repository: kiconthemes > > > Description > --- > > Support non integer scale factors in kiconengine > > > Diffs > - > > src/kiconengine.cpp c31829e82237a7432e3b7c6b1cf85cc3b2bc3ebe > > Diff: https://git.reviewboard.kde.org/r/129253/diff/ > > > Testing > --- > > Ran system settings with QT_SCALE_FACTOR=2.3 > didn't look blurry on mouseover > > > Thanks, > > David Edmundson > >
Review Request 129253: Support non integer scale factors in kiconengine
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129253/ --- Review request for KDE Frameworks and Christoph Feck. Repository: kiconthemes Description --- Support non integer scale factors in kiconengine Diffs - src/kiconengine.cpp c31829e82237a7432e3b7c6b1cf85cc3b2bc3ebe Diff: https://git.reviewboard.kde.org/r/129253/diff/ Testing --- Ran system settings with QT_SCALE_FACTOR=2.3 didn't look blurry on mouseover Thanks, David Edmundson
